n8n 2.30.4 → 2.31.0

package/dist/modules/instance-ai/instance-ai.service.js

@@ -189,55 +189,6 @@ function getAbortReason(signal) {
 }
 const MAX_CONCURRENT_BACKGROUND_TASKS_PER_THREAD = 5;
 const TITLE_REFINE_HISTORY_LIMIT = 50;
-function stringifyForContextValue(value) {
-    if (typeof value === 'string')
-        return value;
-    try {
-        return JSON.stringify(value);
-    }
-    catch {
-        return String(value);
-    }
-}
-const PLANNED_TASK_CONTEXT_VALUE_LIMIT = 1_500;
-function truncateContextValue(value) {
-    if (value.length <= PLANNED_TASK_CONTEXT_VALUE_LIMIT)
-        return value;
-    return `${value.slice(0, PLANNED_TASK_CONTEXT_VALUE_LIMIT)}...`;
-}
-function buildPlannedTaskConversationContext(task, graph) {
-    if (!graph)
-        return undefined;
-    const parts = [
-        `Approved plan task: ${task.title}`,
-        `Task id: ${task.id}`,
-        `Task kind: ${task.kind}`,
-        `Plan run id: ${graph.planRunId}`,
-    ];
-    if (task.workflowId) {
-        parts.push(`Target workflow id: ${task.workflowId}`);
-    }
-    const dependencies = graph.tasks.filter((candidate) => task.deps.includes(candidate.id));
-    if (dependencies.length > 0) {
-        parts.push('Completed dependency context:');
-        for (const dependency of dependencies) {
-            const dependencyParts = [
-                `- ${dependency.id} (${dependency.kind}, ${dependency.status}): ${dependency.title}`,
-            ];
-            if (dependency.result) {
-                dependencyParts.push(`result=${truncateContextValue(dependency.result)}`);
-            }
-            if (dependency.error) {
-                dependencyParts.push(`error=${truncateContextValue(dependency.error)}`);
-            }
-            if (dependency.outcome) {
-                dependencyParts.push(`outcome=${truncateContextValue(stringifyForContextValue(dependency.outcome))}`);
-            }
-            parts.push(dependencyParts.join(' '));
-        }
-    }
-    return parts.join('\n');
-}
 function toConfirmationData(request) {
     switch (request.kind) {
         case 'approval':
@@ -1319,8 +1270,8 @@ let InstanceAiService = class InstanceAiService {
         if (nodeDefDirs.length > 0) {
             (0, workflow_sdk_1.setSchemaBaseDirs)(nodeDefDirs);
         }
-        const baseRuntimeSkills = (0, instance_ai_1.loadInstanceAiRuntimeSkillSource)();
-        let runtimeSkills = baseRuntimeSkills;
+        const allRuntimeSkills = (0, instance_ai_1.loadInstanceAiRuntimeSkillSource)();
+        let runtimeSkills = allRuntimeSkills;
         let runtimeWorkspace;
         let workspaceRoot;
         const sandboxStatus = this.settingsService.getSandboxStatus();
@@ -1358,7 +1309,7 @@ let InstanceAiService = class InstanceAiService {
                     ensureWorkspace: async () => await scopeWorkspaceForAgent((await getSandboxEntry())?.workspace),
                 });
                 runtimeSkills = (0, instance_ai_1.createLazyWorkspaceRuntimeSkillSource)({
-                    source: baseRuntimeSkills,
+                    source: allRuntimeSkills,
                     workspace: runtimeSkillWorkspace,
                     logger: this.logger,
                 });
@@ -1380,7 +1331,6 @@ let InstanceAiService = class InstanceAiService {
             orchestratorAgentId: (0, instance_ai_1.orchestratorAgentId)(runId),
             modelId,
             checkpointStore: this.checkpointStore,
-            subAgentMaxSteps: this.instanceAiConfig.subAgentMaxSteps,
             eventBus: this.eventBus,
             logger: this.logger,
             outputRedaction: (0, output_redaction_config_1.resolveOutputRedaction)(this.instanceAiConfig),
@@ -1393,7 +1343,7 @@ let InstanceAiService = class InstanceAiService {
             timeZone: this.defaultTimeZone,
             localMcpServer: context.localMcpServer,
             runtimeSkills,
-            runtimeSkillCatalog: baseRuntimeSkills,
+            runtimeSkillCatalog: allRuntimeSkills,
             oauth2CallbackUrl: this.oauth2CallbackUrl,
             webhookBaseUrl: this.webhookBaseUrl,
             formBaseUrl: this.formBaseUrl,
@@ -1447,46 +1397,23 @@ let InstanceAiService = class InstanceAiService {
             orchestrationContext,
         };
     }
-    async dispatchPlannedTask(task, context, graph) {
-        const taskContext = this.createPlannedTaskContext(task.kind, context);
-        const conversationContext = buildPlannedTaskConversationContext(task, graph);
-        let started = null;
-        if (task.kind === 'delegate') {
-            started = await (0, instance_ai_1.startDetachedDelegateTask)(taskContext, {
-                title: task.title,
-                spec: task.spec,
-                tools: task.tools ?? [],
-                plannedTaskId: task.id,
-                conversationContext,
-            });
-        }
-        if (!started?.taskId) {
-            await context.plannedTaskService?.markFailed(context.threadId, task.id, {
-                error: started?.result || `Failed to start planned task "${task.title}"`,
+    async dispatchPlannedTask(task, context, _graph) {
+        if (task.kind === 'build-workflow' || task.kind === 'checkpoint') {
+            this.logger.warn('dispatchPlannedTask called for a runtime planned-task kind', {
+                threadId: context.threadId,
+                taskId: task.id,
+                kind: task.kind,
             });
             return;
         }
-        await context.plannedTaskService?.markRunning(context.threadId, task.id, {
-            agentId: started.agentId,
-            backgroundTaskId: started.taskId,
+        await context.plannedTaskService?.markFailed(context.threadId, task.id, {
+            error: `Planned task kind "${task.kind}" is no longer supported`,
         });
         const nextGraph = await context.plannedTaskService?.getGraph(context.threadId);
         if (nextGraph) {
             await this.syncPlannedTasksToUi(context.threadId, nextGraph);
         }
     }
-    createPlannedTaskContext(kind, context) {
-        if (!context.domainContext)
-            return context;
-        const taskDomainContext = (0, instance_ai_1.applyPlannedTaskPermissions)(context.domainContext, kind);
-        if (taskDomainContext === context.domainContext)
-            return context;
-        return {
-            ...context,
-            domainContext: taskDomainContext,
-            domainTools: (0, instance_ai_1.createAllTools)(taskDomainContext),
-        };
-    }
     collectWorkflowIds(value, workflowIds) {
         if (value === null || value === undefined || typeof value !== 'object')
             return;
@@ -2366,6 +2293,16 @@ let InstanceAiService = class InstanceAiService {
                 workSummary: result.workSummary,
                 usage: result.usage,
                 errorReason: userFacingErrorMessage,
+                ...(result.status === 'errored'
+                    ? {
+                        errorInfo: {
+                            errorMessage: result.error
+                                ? getErrorMessage(result.error)
+                                : 'Instance AI stream errored',
+                            errorSource: 'stream',
+                        },
+                    }
+                    : {}),
             });
             await this.creditService.claimRunUsage(user, threadId, result.agentRunId || runId, result.usage?.usage ?? [], result.status);
             if (result.status === 'completed') {
@@ -2448,16 +2385,7 @@ let InstanceAiService = class InstanceAiService {
                 metadata: this.tracing.buildMessageTraceMetadata(threadId, runId, { status: 'error' }),
             };
             const archivedWorkflowIds = await this.temporaryWorkflowService.reapForRun(threadId, user, aiCreatedWorkflowIds, this.backgroundTasks.getRunningTasks(threadId).length);
-            this.eventBus.publish(threadId, {
-                type: 'run-finish',
-                runId,
-                agentId: (0, instance_ai_1.orchestratorAgentId)(runId),
-                payload: {
-                    status: 'error',
-                    reason: userFacingErrorMessage,
-                    ...(archivedWorkflowIds.length > 0 ? { archivedWorkflowIds } : {}),
-                },
-            });
+            this.publishRunFinish(threadId, runId, 'errored', userFacingErrorMessage, archivedWorkflowIds, user.id, { errorMessage, errorSource: 'exception' });
             if (activeSnapshotStorage) {
                 await this.saveAgentTreeSnapshot(threadId, runId, activeSnapshotStorage);
             }
@@ -3100,6 +3028,16 @@ let InstanceAiService = class InstanceAiService {
                 workSummary: result.workSummary,
                 usage: result.usage,
                 errorReason: userFacingErrorMessage,
+                ...(result.status === 'errored'
+                    ? {
+                        errorInfo: {
+                            errorMessage: result.error
+                                ? getErrorMessage(result.error)
+                                : 'Instance AI resumed stream errored',
+                            errorSource: 'stream',
+                        },
+                    }
+                    : {}),
             });
             await this.creditService.claimRunUsage(opts.user, opts.threadId, result.agentRunId || opts.runId, result.usage?.usage ?? [], result.status);
             if (result.status === 'completed') {
@@ -3179,16 +3117,7 @@ let InstanceAiService = class InstanceAiService {
                 }),
             };
             const archivedWorkflowIds = await this.temporaryWorkflowService.reapForRun(opts.threadId, opts.user, undefined, this.backgroundTasks.getRunningTasks(opts.threadId).length);
-            this.eventBus.publish(opts.threadId, {
-                type: 'run-finish',
-                runId: opts.runId,
-                agentId: (0, instance_ai_1.orchestratorAgentId)(opts.runId),
-                payload: {
-                    status: 'error',
-                    reason: userFacingErrorMessage,
-                    ...(archivedWorkflowIds.length > 0 ? { archivedWorkflowIds } : {}),
-                },
-            });
+            this.publishRunFinish(opts.threadId, opts.runId, 'errored', userFacingErrorMessage, archivedWorkflowIds, opts.user.id, { errorMessage, errorSource: 'exception' });
             await this.saveAgentTreeSnapshot(opts.threadId, opts.runId, opts.snapshotStorage);
         }
         finally {
@@ -3477,7 +3406,7 @@ let InstanceAiService = class InstanceAiService {
         });
         void this.suspendedThreads.dropPendingConfirmation(suspended.requestId);
     }
-    publishRunFinish(threadId, runId, status, reason, archivedWorkflowIds, userId) {
+    publishRunFinish(threadId, runId, status, reason, archivedWorkflowIds, userId, errorInfo) {
         const effectiveStatus = status === 'errored' ? 'error' : status;
         const hasArchived = archivedWorkflowIds && archivedWorkflowIds.length > 0;
         this.eventBus.publish(threadId, {
@@ -3500,9 +3429,18 @@ let InstanceAiService = class InstanceAiService {
             status: effectiveStatus,
             ...(userId ? { user_id: userId } : {}),
         });
+        if (status === 'errored') {
+            this.telemetry.track('Builder generation errored', {
+                thread_id: threadId,
+                run_id: runId,
+                error_message: errorInfo?.errorMessage ?? reason ?? 'unknown',
+                ...(errorInfo?.errorSource ? { error_source: errorInfo.errorSource } : {}),
+                ...(userId ? { user_id: userId } : {}),
+            });
+        }
     }
     async finalizeRun(threadId, runId, status, snapshotStorage, options) {
-        this.publishRunFinish(threadId, runId, status, options?.errorReason, options?.archivedWorkflowIds, options?.userId);
+        this.publishRunFinish(threadId, runId, status, options?.errorReason, options?.archivedWorkflowIds, options?.userId, options?.errorInfo);
         this.emitRunMetrics(threadId, status, options);
         await this.saveAgentTreeSnapshot(threadId, runId, snapshotStorage);
         if (status === 'completed' && options?.userId && options?.modelId) {