n8n-nodes-smartcontact 1.0.1 → 1.0.2

package/README.md

@@ -19,5 +19,5 @@ version: bump `version`, then, with a short-lived granular publish token from Da
     npm run build
     npm publish --access public --userconfig <scratch npmrc>
 
-n8n verification (n8n Cloud) needs publishing from GitHub Actions with provenance: see docs/guides/D2-n8n.md.
+n8n verification (n8n Cloud) needs publishing from GitHub Actions with provenance: see docs/BACKLOG.md #84 (needs a SmartContact GitHub account from Dave, then Claude does the rest).
 Self-hosted n8n users install it from Settings › Community Nodes as `n8n-nodes-smartcontact`.

package/dist/credentials/SmartContactApi.credentials.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SmartContactApi = void 0;
+const urls_1 = require("../nodes/SmartContact/urls");
 class SmartContactApi {
     name = 'smartContactApi';
     displayName = 'SmartContact API';
@@ -16,17 +17,18 @@ class SmartContactApi {
             description: 'In SmartContact: Settings › API keys & agents › add a key of kind "Integration". Its role decides what n8n can read and change.',
         },
         {
-            displayName: 'API URL',
+            displayName: 'Environment',
             name: 'baseUrl',
-            type: 'string',
-            default: 'https://app.smartcontact.online/v1',
-            description: 'Leave as it is unless SmartContact support gives you another address',
+            type: 'options',
+            default: urls_1.API_URL,
+            options: urls_1.API_URLS.map((value) => ({ name: value === urls_1.API_URL ? 'Production' : value.includes('-dev.') ? 'Development' : 'Test', value })),
+            description: 'Leave on Production unless you are testing with SmartContact',
         },
     ];
     authenticate = {
         type: 'generic',
         properties: { headers: { Authorization: '=Bearer {{$credentials.apiKey}}' } },
     };
-    test = { request: { baseURL: '={{$credentials.baseUrl}}', url: '/me' } };
+    test = { request: { baseURL: urls_1.BASE_URL_EXPRESSION, url: '/me' } };
 }
 exports.SmartContactApi = SmartContactApi;

package/dist/nodes/SmartContact/SmartContact.node.js

@@ -1,6 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SmartContact = void 0;
+// SmartContact actions for n8n: create, get, find and update companies, contacts, deals, tasks and notes.
+// Declarative style: each operation maps straight to one call on the public API (/v1/openapi.json).
+const urls_1 = require("./urls");
 const show = (resource, operation) => ({ show: { resource: [resource], ...(operation ? { operation } : {}) } });
 const idField = (resource, name, operations) => ({
     displayName: `${name} ID`,
@@ -110,7 +113,7 @@ class SmartContact {
         inputs: ['main'],
         outputs: ['main'],
         credentials: [{ name: 'smartContactApi', required: true }],
-        requestDefaults: { baseURL: '={{$credentials.baseUrl}}', headers: { Accept: 'application/json', 'Content-Type': 'application/json' } },
+        requestDefaults: { baseURL: urls_1.BASE_URL_EXPRESSION, headers: { Accept: 'application/json', 'Content-Type': 'application/json' } },
         properties: [
             {
                 displayName: 'Resource',

package/dist/nodes/SmartContact/SmartContactTrigger.node.js

@@ -3,8 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SmartContactTrigger = void 0;
 // Instant SmartContact trigger for n8n. Activating the workflow subscribes this node's webhook URL to the chosen events
 // (POST /v1/webhooks, which returns a signing secret); deactivating removes it. Each delivery is checked against that
-// secret, then the record is fetched from api_url so the workflow gets the full company, contact, deal or task.
+// secret, then the record is fetched by its type and id so the workflow gets the full company, contact, deal or task.
 const signature_1 = require("./signature");
+const urls_1 = require("./urls");
 const EVENTS = [
     ['company.created', 'Company added'],
     ['company.updated', 'Company changed'],
@@ -60,7 +61,7 @@ class SmartContactTrigger {
                 const data = this.getWorkflowStaticData('node');
                 if (!data.webhookId)
                     return false;
-                const { baseUrl } = (await this.getCredentials('smartContactApi'));
+                const baseUrl = (0, urls_1.safeBaseUrl)((await this.getCredentials('smartContactApi')).baseUrl);
                 const list = (await this.helpers.httpRequestWithAuthentication.call(this, 'smartContactApi', { method: 'GET', url: `${baseUrl}/webhooks`, json: true }));
                 if (list.data.some((w) => w.id === data.webhookId && w.status === 'active'))
                     return true;
@@ -69,7 +70,7 @@ class SmartContactTrigger {
                 return false;
             },
             async create() {
-                const { baseUrl } = (await this.getCredentials('smartContactApi'));
+                const baseUrl = (0, urls_1.safeBaseUrl)((await this.getCredentials('smartContactApi')).baseUrl);
                 const created = (await this.helpers.httpRequestWithAuthentication.call(this, 'smartContactApi', {
                     method: 'POST',
                     url: `${baseUrl}/webhooks`,
@@ -84,7 +85,7 @@ class SmartContactTrigger {
             async delete() {
                 const data = this.getWorkflowStaticData('node');
                 if (data.webhookId) {
-                    const { baseUrl } = (await this.getCredentials('smartContactApi'));
+                    const baseUrl = (0, urls_1.safeBaseUrl)((await this.getCredentials('smartContactApi')).baseUrl);
                     try {
                         await this.helpers.httpRequestWithAuthentication.call(this, 'smartContactApi', { method: 'DELETE', url: `${baseUrl}/webhooks/${data.webhookId}` });
                     }
@@ -108,10 +109,11 @@ class SmartContactTrigger {
         }
         const event = req.body;
         let record;
-        const { baseUrl } = (await this.getCredentials('smartContactApi'));
-        if (this.getNodeParameter('fetch') && event.api_url && String(event.api_url).startsWith(`${baseUrl}/`)) {
+        const baseUrl = (0, urls_1.safeBaseUrl)((await this.getCredentials('smartContactApi')).baseUrl);
+        const url = this.getNodeParameter('fetch') ? (0, urls_1.recordUrl)(baseUrl, event.type, event.data?.id) : null;
+        if (url) {
             try {
-                record = (await this.helpers.httpRequestWithAuthentication.call(this, 'smartContactApi', { method: 'GET', url: String(event.api_url), json: true }));
+                record = (await this.helpers.httpRequestWithAuthentication.call(this, 'smartContactApi', { method: 'GET', url, json: true, disableFollowRedirect: true }));
             }
             catch {
                 record = undefined; // e.g. deleted since; the event still goes through

package/dist/nodes/SmartContact/urls.js

@@ -0,0 +1,20 @@
+"use strict";
+// Where the API key may be sent. Kept apart from the node so it can be tested without n8n installed.
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.BASE_URL_EXPRESSION = exports.safeBaseUrl = exports.API_URLS = exports.API_URL = void 0;
+exports.recordUrl = recordUrl;
+exports.API_URL = 'https://app.smartcontact.online/v1';
+exports.API_URLS = [exports.API_URL, 'https://app-dev.smartcontact.online/v1', 'https://app-test.smartcontact.online/v1'];
+/** The credential's API URL if it is one of ours; anything else (a value saved by an older version) falls back to production. */
+const safeBaseUrl = (url) => (exports.API_URLS.includes(String(url)) ? String(url) : exports.API_URL);
+exports.safeBaseUrl = safeBaseUrl;
+/** The same check as safeBaseUrl, as an n8n expression for declarative requests and the credential test. */
+exports.BASE_URL_EXPRESSION = `={{ ${JSON.stringify(exports.API_URLS)}.includes($credentials.baseUrl) ? $credentials.baseUrl : ${JSON.stringify(exports.API_URL)} }}`;
+const PATHS = { company: 'companies', contact: 'contacts', deal: 'deals', task: 'tasks', meeting: 'meetings', activity: 'activities', quote: 'quotes' };
+/** Builds the record's address from the event's type and id. A URL in the payload is never followed. Erased records can't be fetched. */
+function recordUrl(baseUrl, type, id) {
+    if (typeof type !== 'string' || typeof id !== 'string' || !id || type.endsWith('.erased'))
+        return null;
+    const path = Object.prototype.hasOwnProperty.call(PATHS, type.split('.')[0]) ? PATHS[type.split('.')[0]] : undefined;
+    return path ? `${(0, exports.safeBaseUrl)(baseUrl)}/${path}/${encodeURIComponent(id)}` : null;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-smartcontact",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "SmartContact CRM nodes for n8n: instant triggers from SmartContact webhooks, and actions on companies, contacts, deals, tasks and notes",
   "keywords": ["n8n-community-node-package", "smartcontact", "crm"],
   "license": "MIT",