n8n-nodes-prestashop8 1.2.2 → 1.2.4

package/dist/nodes/PrestaShop8/PrestaShop8.node.js

@@ -28,31 +28,18 @@ const n8n_workflow_1 = require("n8n-workflow");
 const PrestaShop8_node_description_1 = require("./PrestaShop8.node.description");
 const types_1 = require("./types");
 const utils_1 = require("./utils");
-// Helper function to build headers based on raw mode (backward compatibility)
-function buildHeaders(rawMode) {
-    const headers = {};
-    if (rawMode) {
-        // En mode Raw, demandons explicitement le XML
-        headers['Output-Format'] = 'XML';
-    }
-    else {
-        headers['Output-Format'] = 'JSON';
-    }
-    return headers;
-}
+const fieldMappings_1 = require("./fieldMappings");
 /**
- * Build common HTTP request options
+ * Build HTTP request options with appropriate headers (consolidated)
  */
 function buildHttpOptions(method, url, credentials, rawMode, timeout, body) {
     const headers = {};
-    // Only add Content-Type for requests with body (POST, PATCH, PUT)
-    if (body && (method === 'POST' || method === 'PATCH' || method === 'PUT')) {
+    // Add Content-Type for requests with body (POST, PATCH, PUT)
+    if (body && ['POST', 'PATCH', 'PUT'].includes(method)) {
         headers['Content-Type'] = 'application/xml';
     }
-    // Add Output-Format for non-raw mode
-    if (!rawMode) {
-        headers['Output-Format'] = 'JSON';
-    }
+    // Add Output-Format header based on mode
+    headers['Output-Format'] = rawMode ? 'XML' : 'JSON';
     return {
         method,
         url,
@@ -108,35 +95,7 @@ async function executeHttpRequest(helpers, options, credentials, rawMode, operat
  */
 function collectRequiredFields(executeFunctions, resource, itemIndex) {
     const fieldsToCreate = [];
-    const fieldMappings = {
-        products: {
-            productName: 'name-1',
-            productPrice: 'price',
-            productCategoryId: 'id_category_default'
-        },
-        categories: {
-            categoryName: 'name-1',
-            categoryParentId: 'id_parent'
-        },
-        customers: {
-            customerFirstname: 'firstname',
-            customerLastname: 'lastname',
-            customerEmail: 'email'
-        },
-        addresses: {
-            addressFirstname: 'firstname',
-            addressLastname: 'lastname',
-            addressAddress1: 'address1',
-            addressCity: 'city',
-            addressCountryId: 'id_country',
-            addressCustomerId: 'id_customer'
-        },
-        manufacturers: {
-            manufacturerName: 'name',
-            manufacturerActive: 'active'
-        }
-    };
-    const mappings = fieldMappings[resource];
+    const mappings = (0, fieldMappings_1.getFieldMappingsForResource)(resource);
     if (mappings) {
         for (const [inputName, fieldName] of Object.entries(mappings)) {
             const value = executeFunctions.getNodeParameter(inputName, itemIndex, '');
@@ -339,7 +298,7 @@ class PrestaShop8 {
                                         username: credentials.apiKey,
                                         password: ''
                                     },
-                                    headers: buildHeaders(rawMode),
+                                    headers: buildHttpOptions('GET', requestUrl, credentials, rawMode, timeout || 30000).headers,
                                     timeout: timeout || 30000,
                                     transformResponse: [(data) => data],
                                     validateStatus: neverError ? () => true : undefined // Accept all status codes if neverError is true
@@ -347,7 +306,7 @@ class PrestaShop8 {
                                 requestDebugInfo = captureRequestDebugInfo({
                                     method: 'GET',
                                     url: requestUrl,
-                                    headers: buildHeaders(rawMode),
+                                    headers: buildHttpOptions('GET', requestUrl, credentials, rawMode, timeout || 30000).headers,
                                     timeout: timeout
                                 }, credentials, rawMode, operation, resource);
                                 requestHeaders = requestDebugInfo.headers;
@@ -693,7 +652,7 @@ class PrestaShop8 {
                                         username: credentials.apiKey,
                                         password: ''
                                     },
-                                    headers: buildHeaders(rawMode),
+                                    headers: buildHttpOptions('GET', requestUrl, credentials, rawMode, timeout || 30000).headers,
                                     timeout: timeout || 30000,
                                     transformResponse: [(data) => data],
                                     validateStatus: neverError ? () => true : undefined // Accept all status codes if neverError is true
@@ -701,7 +660,7 @@ class PrestaShop8 {
                                 requestDebugInfo = captureRequestDebugInfo({
                                     method: 'GET',
                                     url: requestUrl,
-                                    headers: buildHeaders(rawMode),
+                                    headers: buildHttpOptions('GET', requestUrl, credentials, rawMode, timeout || 30000).headers,
                                     timeout: timeout
                                 }, credentials, rawMode, operation, resource);
                                 requestHeaders = requestDebugInfo.headers;

package/dist/nodes/PrestaShop8/fieldMappings.d.ts

@@ -0,0 +1,28 @@
+/**
+ * Centralized field mappings for PrestaShop resources
+ * Eliminates duplication between node and utils files
+ */
+export interface FieldMapping {
+    [inputName: string]: string;
+}
+export interface ResourceFieldMappings {
+    [resource: string]: FieldMapping;
+}
+/**
+ * Input field name to PrestaShop field name mappings for CREATE operations
+ */
+export declare const CREATE_FIELD_MAPPINGS: ResourceFieldMappings;
+/**
+ * CamelCase to PrestaShop field name mappings for UPDATE operations
+ */
+export declare const CAMELCASE_TO_PRESTASHOP_MAPPINGS: {
+    [key: string]: string;
+};
+/**
+ * Convert camelCase field name to PrestaShop format
+ */
+export declare function convertFromCamelCase(fieldName: string): string;
+/**
+ * Get field mappings for a specific resource
+ */
+export declare function getFieldMappingsForResource(resource: string): FieldMapping | null;

package/dist/nodes/PrestaShop8/fieldMappings.js

@@ -0,0 +1,76 @@
+"use strict";
+/**
+ * Centralized field mappings for PrestaShop resources
+ * Eliminates duplication between node and utils files
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.getFieldMappingsForResource = exports.convertFromCamelCase = exports.CAMELCASE_TO_PRESTASHOP_MAPPINGS = exports.CREATE_FIELD_MAPPINGS = void 0;
+/**
+ * Input field name to PrestaShop field name mappings for CREATE operations
+ */
+exports.CREATE_FIELD_MAPPINGS = {
+    products: {
+        productName: 'name-1',
+        productPrice: 'price',
+        productCategoryId: 'id_category_default'
+    },
+    categories: {
+        categoryName: 'name-1',
+        categoryParentId: 'id_parent'
+    },
+    customers: {
+        customerFirstname: 'firstname',
+        customerLastname: 'lastname',
+        customerEmail: 'email'
+    },
+    addresses: {
+        addressFirstname: 'firstname',
+        addressLastname: 'lastname',
+        addressAddress1: 'address1',
+        addressCity: 'city',
+        addressCountryId: 'id_country',
+        addressCustomerId: 'id_customer'
+    },
+    manufacturers: {
+        manufacturerName: 'name',
+        manufacturerActive: 'active'
+    }
+};
+/**
+ * CamelCase to PrestaShop field name mappings for UPDATE operations
+ */
+exports.CAMELCASE_TO_PRESTASHOP_MAPPINGS = {
+    'manufacturerId': 'id_manufacturer',
+    'categoryId': 'id_category',
+    'supplierId': 'id_supplier',
+    'customerId': 'id_customer',
+    'addressId': 'id_address',
+    'countryId': 'id_country',
+    'stateId': 'id_state',
+    'zoneId': 'id_zone',
+    'currencyId': 'id_currency',
+    'languageId': 'id_language',
+    'groupId': 'id_group',
+};
+/**
+ * Convert camelCase field name to PrestaShop format
+ */
+function convertFromCamelCase(fieldName) {
+    // Check specific mappings first
+    if (exports.CAMELCASE_TO_PRESTASHOP_MAPPINGS[fieldName]) {
+        return exports.CAMELCASE_TO_PRESTASHOP_MAPPINGS[fieldName];
+    }
+    // Generic camelCase to snake_case conversion
+    return fieldName
+        .replace(/([A-Z])/g, '_$1')
+        .toLowerCase()
+        .replace(/^_/, ''); // Remove leading underscore
+}
+exports.convertFromCamelCase = convertFromCamelCase;
+/**
+ * Get field mappings for a specific resource
+ */
+function getFieldMappingsForResource(resource) {
+    return exports.CREATE_FIELD_MAPPINGS[resource] || null;
+}
+exports.getFieldMappingsForResource = getFieldMappingsForResource;

package/dist/nodes/PrestaShop8/utils.d.ts

@@ -41,7 +41,7 @@ export declare function buildCreateXml(resource: string, fields: Array<{
 /**
  * Builds PrestaShop XML for Update operations using key-value pairs
  */
-export declare function buildUpdateXml(resource: string, id: string, fields: Array<{
+export declare function buildUpdateXml(resource: string, id: string | number, fields: Array<{
     name: string;
     value: string;
 }>): string;

package/dist/nodes/PrestaShop8/utils.js

@@ -26,6 +26,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.validateDataForResource = exports.validateFieldsForCreate = exports.REQUIRED_FIELDS_BY_RESOURCE = exports.buildUpdateXml = exports.buildCreateXml = exports.buildUrlWithFilters = exports.parseXmlToJson = exports.buildPrestashopXml = exports.simplifyPrestashopResponse = exports.processResponseForMode = exports.processDisplayParameter = exports.processSortParameter = exports.extractPrestashopError = void 0;
 const xml2js = __importStar(require("xml2js"));
 const js2xmlparser = __importStar(require("js2xmlparser"));
+const fieldMappings_1 = require("./fieldMappings");
 /**
  * Clean error message by removing PHP warnings and debug info
  */
@@ -67,10 +68,8 @@ function extractPrestashopError(error) {
     // If it's an axios error with response
     if (error.response && error.response.data) {
         const data = error.response.data;
-        // Debug logging for complex error structures
-        if (typeof data === 'object' && data !== null) {
-            console.log('PrestaShop Error Structure:', JSON.stringify(data, null, 2));
-        }
+        // Debug logging for complex error structures (only in debug mode)
+        // Note: Removed console.log to prevent production log pollution
         // Try to parse XML error response
         if (typeof data === 'string' && data.includes('<error>')) {
             const errorMatch = data.match(/<error><!\[CDATA\[(.+?)\]\]><\/error>/);
@@ -342,7 +341,7 @@ function convertSimplifiedToPrestaShop(data, resource) {
     const converted = {};
     const associations = {};
     for (const [key, value] of Object.entries(data)) {
-        const prestashopKey = convertFromCamelCase(key);
+        const prestashopKey = (0, fieldMappings_1.convertFromCamelCase)(key);
         // Detect associations (arrays of IDs)
         if (Array.isArray(value) && value.every(v => typeof v === 'number' || typeof v === 'string')) {
             associations[prestashopKey] = {
@@ -359,38 +358,7 @@ function convertSimplifiedToPrestaShop(data, resource) {
     }
     return converted;
 }
-/**
- * Converts camelCase to snake_case with PrestaShop prefixes
- */
-function convertFromCamelCase(fieldName) {
-    // Map certain special fields
-    const fieldMappings = {
-        'manufacturerId': 'id_manufacturer',
-        'categoryId': 'id_category',
-        'supplierId': 'id_supplier',
-        'customerId': 'id_customer',
-        'orderId': 'id_order',
-        'productId': 'id_product',
-        'carrierId': 'id_carrier',
-        'currencyId': 'id_currency',
-        'languageId': 'id_language',
-        'shopId': 'id_shop',
-        'taxId': 'id_tax',
-        'zoneId': 'id_zone',
-        'countryId': 'id_country',
-        'stateId': 'id_state',
-        'addressId': 'id_address',
-        'groupId': 'id_group',
-    };
-    if (fieldMappings[fieldName]) {
-        return fieldMappings[fieldName];
-    }
-    // Generic camelCase to snake_case conversion
-    return fieldName
-        .replace(/([A-Z])/g, '_$1')
-        .toLowerCase()
-        .replace(/^_/, '');
-}
+// convertFromCamelCase function moved to fieldMappings.ts for centralization
 /**
  * Obtient tous les champs string pour CDATA
  */
@@ -459,7 +427,9 @@ exports.buildUrlWithFilters = buildUrlWithFilters;
  * Escapes XML special characters
  */
 function escapeXml(unsafe) {
-    return unsafe.replace(/[<>&'"]/g, function (c) {
+    // Convert to string if not already
+    const str = unsafe !== null && unsafe !== undefined ? String(unsafe) : '';
+    return str.replace(/[<>&'"]/g, function (c) {
         switch (c) {
             case '<': return '&lt;';
             case '>': return '&gt;';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-prestashop8",
-  "version": "1.2.2",
+  "version": "1.2.4",
   "description": "Nœud n8n personnalisé pour PrestaShop 8 avec support CRUD complet et conversion XML/JSON automatique",
   "keywords": [
     "n8n-community-node-package",