n8n-nodes-onedrive-business 1.1.5 → 1.1.8

package/dist/nodes/OneDriveBusiness.node.js

@@ -253,8 +253,8 @@ class OneDriveBusiness {
                     },
                     default: '',
                     required: true,
-                    placeholder: '/Documents/file.pdf',
-                    description: 'Destination path in OneDrive (including filename)',
+                    placeholder: '/Documents/NewFolder/{{ $binary.data.fileName }}',
+                    description: 'Full path of the file to save (e.g. /Documents/report.pdf). Tip: Use Expression to keep original name: /Path/To/Folder/{{ $binary.data.fileName }}',
                 },
                 {
                     displayName: 'Binary Property',

package/dist/utils/helpers.d.ts

@@ -31,6 +31,10 @@ export declare function resolveSubscriptionResource(location: DriveLocation): st
  * - Encodes special characters
  */
 export declare function sanitizePath(path: string): string;
+/**
+ * Validate Microsoft Graph item ID format
+ */
+export declare function isValidItemId(itemId: string): boolean;
 /**
  * Build the full item path for OneDrive API
  *
@@ -68,10 +72,6 @@ export declare function parseRetryAfter(retryAfterHeader?: string): number;
  * Used for clientState in webhook subscriptions
  */
 export declare function generateSecureRandomString(length?: number): string;
-/**
- * Validate Microsoft Graph item ID format
- */
-export declare function isValidItemId(itemId: string): boolean;
 /**
  * Check if an item is a file (vs folder)
  */

package/dist/utils/helpers.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.parseGraphError = exports.cleanupProcessedVersions = exports.buildVersionKey = exports.getMimeType = exports.isFolder = exports.isFile = exports.isValidItemId = exports.generateSecureRandomString = exports.parseRetryAfter = exports.sleep = exports.calculateBackoffDelay = exports.formatBytes = exports.getFileExtension = exports.buildItemPath = exports.sanitizePath = exports.resolveSubscriptionResource = exports.resolveDrivePath = void 0;
+exports.parseGraphError = exports.cleanupProcessedVersions = exports.buildVersionKey = exports.getMimeType = exports.isFolder = exports.isFile = exports.generateSecureRandomString = exports.parseRetryAfter = exports.sleep = exports.calculateBackoffDelay = exports.formatBytes = exports.getFileExtension = exports.buildItemPath = exports.isValidItemId = exports.sanitizePath = exports.resolveSubscriptionResource = exports.resolveDrivePath = void 0;
 /**
  * Helper Functions for OneDrive Business Node
  *
@@ -64,6 +64,22 @@ function sanitizePath(path) {
     return encodedParts.join('/');
 }
 exports.sanitizePath = sanitizePath;
+/**
+ * Validate Microsoft Graph item ID format
+ */
+function isValidItemId(itemId) {
+    if (!itemId || typeof itemId !== 'string') {
+        return false;
+    }
+    // Graph item IDs are base64-encoded strings but can vary.
+    // Use a heuristic: if it contains slash or colon, it's definitely a path.
+    // If it's a long string without path separators, treat as ID.
+    if (itemId.includes('/') || itemId.includes(':')) {
+        return false;
+    }
+    return true;
+}
+exports.isValidItemId = isValidItemId;
 /**
  * Build the full item path for OneDrive API
  *
@@ -76,7 +92,14 @@ function buildItemPath(drivePath, itemPath, itemId) {
         return `${drivePath}/items/${itemId}`;
     }
     if (itemPath) {
-        const sanitized = sanitizePath(itemPath);
+        // Strip out duplicated drive root prefixes to fix "itemNotFound" errors
+        // Matches: /drive/root:, drive/root:, /drives/{id}/root:, drives/{id}/root:
+        let cleanPath = itemPath.replace(/^(\/)?(drive|drives\/[^\/]+)\/root:/i, '');
+        // Also remove any leading slash if present after replacement
+        if (cleanPath.startsWith('/')) {
+            cleanPath = cleanPath.substring(1);
+        }
+        const sanitized = sanitizePath(cleanPath);
         if (sanitized) {
             return `${drivePath}/root:/${sanitized}`;
         }
@@ -163,18 +186,6 @@ function generateSecureRandomString(length = 32) {
     return result;
 }
 exports.generateSecureRandomString = generateSecureRandomString;
-/**
- * Validate Microsoft Graph item ID format
- */
-function isValidItemId(itemId) {
-    if (!itemId || typeof itemId !== 'string') {
-        return false;
-    }
-    // Graph item IDs are typically base64-encoded strings
-    // They should not contain spaces or special characters except !, _, -, and =
-    return /^[A-Za-z0-9!_\-=]+$/.test(itemId);
-}
-exports.isValidItemId = isValidItemId;
 /**
  * Check if an item is a file (vs folder)
  */

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "n8n-nodes-onedrive-business",
-    "version": "1.1.5",
+    "version": "1.1.8",
     "description": "n8n custom node for OneDrive Business with robust deduplication and webhook triggers",
     "keywords": [
         "n8n",