n8n-nodes-onedrive-business 1.1.0 → 1.1.2

package/dist/nodes/OneDriveBusinessTrigger.node.js

@@ -239,18 +239,26 @@ class OneDriveBusinessTrigger {
                     await stateStore.initialize(tenantId, driveId, driveLocation.userId, driveLocation.siteId);
                     // Create webhook handler
                     const webhookHandler = new WebhookHandler_1.WebhookHandler(graphClient, stateStore, subscriptionResource);
-                    // Create subscription
-                    const subscription = await webhookHandler.createOrRenewSubscription(webhookUrl);
-                    // Store subscription ID in workflow static data
-                    const webhookData = this.getWorkflowStaticData('node');
-                    webhookData.subscriptionId = subscription.id;
-                    // Store instances for webhook handling
+                    // Store instances for webhook handling BEFORE creating subscription
+                    // This is critical because Microsoft verifies the webhook during creation
                     OneDriveBusinessTrigger.instances.set(nodeId, {
                         stateStore,
                         webhookHandler,
                     });
-                    console.log(`OneDrive Business Trigger activated for node ${nodeId}`);
-                    return true;
+                    try {
+                        // Create subscription
+                        const subscription = await webhookHandler.createOrRenewSubscription(webhookUrl);
+                        // Store subscription ID in workflow static data
+                        const webhookData = this.getWorkflowStaticData('node');
+                        webhookData.subscriptionId = subscription.id;
+                        console.log(`OneDrive Business Trigger activated for node ${nodeId}`);
+                        return true;
+                    }
+                    catch (error) {
+                        // Cleanup if subscription fails
+                        OneDriveBusinessTrigger.instances.delete(nodeId);
+                        throw error;
+                    }
                 },
                 async delete() {
                     const webhookData = this.getWorkflowStaticData('node');

package/dist/nodes/onedrive.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64"><path d="M41.8 17H41c-7.3 0-13.4 5.3-14.7 12.3-.6-.1-1.2-.2-1.8-.2-6.5 0-11.9 4.6-13.2 10.8C5 40.8 0 46.1 0 52.5c0 6.4 5.2 11.5 11.5 11.5h31.9c11.4 0 20.6-9.2 20.6-20.6 0-10.4-7.7-19-17.7-20.3-1.1-9.9-9.5-17.6-19.5-17.6z" fill="#0078D4"/></svg>

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "n8n-nodes-onedrive-business",
-    "version": "1.1.0",
+    "version": "1.1.2",
     "description": "n8n custom node for OneDrive Business with robust deduplication and webhook triggers",
     "keywords": [
         "n8n",
@@ -23,7 +23,7 @@
     "main": "index.js",
     "scripts": {
         "build": "tsc && npm run copy-icons",
-        "copy-icons": "copyfiles -u 1 \"nodes/**/*.{png,svg}\" dist/",
+        "copy-icons": "copyfiles \"nodes/**/*.{png,svg}\" dist/",
         "dev": "tsc --watch",
         "format": "prettier nodes --write",
         "lint": "tslint -p tsconfig.json -c tslint.json",