n8n-nodes-mautic-advanced 0.1.9 → 0.2.0

package/dist/nodes/MauticAdvanced/CompanyDescription.js

@@ -510,10 +510,9 @@ exports.companyFields = [
         },
         typeOptions: {
             minValue: 1,
-            maxValue: 30,
         },
         default: 30,
-        description: 'Max number of results to return',
+        description: 'Max number of results to return. If you request more than 30 records, the node will automatically use pagination to fetch up to the requested number.',
     },
     {
         displayName: 'Simplify',

package/dist/nodes/MauticAdvanced/ContactDescription.js

@@ -1295,10 +1295,9 @@ exports.contactFields = [
         },
         typeOptions: {
             minValue: 1,
-            maxValue: 30,
         },
         default: 30,
-        description: 'Max number of results to return',
+        description: 'Max number of results to return. If you request more than 30 records, the node will automatically use pagination to fetch up to the requested number.',
     },
     /* -------------------------------------------------------------------------- */
     /*                               contact:delete                               */

package/dist/nodes/MauticAdvanced/GenericFunctions.js

@@ -43,54 +43,26 @@ exports.mauticApiRequest = mauticApiRequest;
  * Make an API request to paginated mautic endpoint
  * and return all results
  */
-async function mauticApiRequestAllItems(propertyName, method, endpoint, body = {}, query = {}) {
+async function mauticApiRequestAllItems(propertyName, method, endpoint, body = {}, query = {}, maxResults) {
     const returnData = [];
     let responseData;
     query.limit = 30;
     query.start = 0;
-    let page = 0;
+    // Removed unused 'page' variable
     do {
         responseData = await mauticApiRequest.call(this, method, endpoint, body, query);
         const values = Object.values(responseData[propertyName]);
-        // Log per-page
-        const pageIds = values.map(v => {
-            if (typeof v === 'object' && v !== null) {
-                const obj = v;
-                return obj.id ?? (obj.fields && obj.fields.id);
-            }
-            return undefined;
-        });
-        console.log(`[DEBUG] Page ${page} (start=${query.start}, limit=${query.limit}): IDs =`, pageIds);
-        returnData.push.apply(returnData, values);
-        query.start += query.limit;
-        page++;
-    } while (responseData.total !== undefined &&
-        returnData.length - parseInt(responseData.total, 10) < 0);
-    // Log all IDs before deduplication
-    const allIds = returnData.map(item => {
-        if (typeof item === 'object' && item !== null) {
-            const obj = item;
-            return obj.id ?? (obj.fields && obj.fields.id);
+        if (maxResults !== undefined && returnData.length + values.length > maxResults) {
+            const needed = maxResults - returnData.length;
+            returnData.push(...values.slice(0, needed));
+            break;
         }
-        return undefined;
-    });
-    console.log('[DEBUG] All IDs before deduplication:', allIds);
-    // Log duplicates
-    const filteredIds = allIds.filter(id => typeof id === 'string' || typeof id === 'number');
-    const idCounts = filteredIds.reduce((acc, id) => {
-        const key = String(id);
-        acc[key] = (acc[key] || 0) + 1;
-        return acc;
-    }, {});
-    const duplicates = Object.entries(idCounts).filter(([_, count]) => count > 1);
-    if (duplicates.length > 0) {
-        console.log('[DEBUG] Duplicate IDs found:', duplicates);
-    }
-    else {
-        console.log('[DEBUG] No duplicate IDs found.');
-    }
-    // Log summary
-    console.log(`[DEBUG] Total records fetched: ${returnData.length}`);
+        else {
+            returnData.push(...values);
+        }
+        query.start += query.limit;
+    } while ((responseData.total !== undefined && returnData.length - parseInt(responseData.total, 10) < 0) &&
+        (maxResults === undefined || returnData.length < maxResults));
     return returnData;
 }
 exports.mauticApiRequestAllItems = mauticApiRequestAllItems;

package/dist/nodes/MauticAdvanced/MauticAdvanced.node.js

@@ -803,23 +803,26 @@ class MauticAdvanced {
                         const options = this.getNodeParameter('options', i);
                         qs = Object.assign(qs, options);
                         if (qs.orderBy) {
-                            // For some reason does camelCase get used in the returned data
-                            // but snake_case here. So convert it automatically to not confuse
-                            // the users.
                             qs.orderBy = (0, change_case_1.snakeCase)(qs.orderBy);
                         }
                         if (returnAll) {
                             responseData = await GenericFunctions_1.mauticApiRequestAllItems.call(this, 'contacts', 'GET', '/contacts', {}, qs);
                         }
                         else {
-                            qs.limit = this.getNodeParameter('limit', i);
-                            qs.start = 0;
-                            responseData = await GenericFunctions_1.mauticApiRequest.call(this, 'GET', '/contacts', {}, qs);
-                            if (responseData.errors) {
-                                throw new n8n_workflow_1.NodeApiError(this.getNode(), responseData);
+                            const limit = this.getNodeParameter('limit', i);
+                            if (limit > 30) {
+                                responseData = await GenericFunctions_1.mauticApiRequestAllItems.call(this, 'contacts', 'GET', '/contacts', {}, qs, limit);
+                            }
+                            else {
+                                qs.limit = limit;
+                                qs.start = 0;
+                                responseData = await GenericFunctions_1.mauticApiRequest.call(this, 'GET', '/contacts', {}, qs);
+                                if (responseData.errors) {
+                                    throw new n8n_workflow_1.NodeApiError(this.getNode(), responseData);
+                                }
+                                responseData = responseData.contacts;
+                                responseData = Object.values(responseData);
                             }
-                            responseData = responseData.contacts;
-                            responseData = Object.values(responseData);
                         }
                         if (options.rawData === false) {
                             //@ts-ignore
@@ -832,8 +835,6 @@ class MauticAdvanced {
                         const contactId = this.getNodeParameter('contactId', i);
                         try {
                             responseData = await GenericFunctions_1.mauticApiRequest.call(this, 'DELETE', `/contacts/${contactId}/delete`);
-                            // Debug: log raw response from mauticApiRequest
-                            console.log('[DEBUG] mauticApiRequest response for contact delete:', JSON.stringify(responseData, null, 2));
                             // Mautic API may return 200 with no 'contact' property or empty body on successful delete
                             if (responseData && responseData.contact !== undefined) {
                                 responseData = [responseData.contact];
@@ -844,8 +845,6 @@ class MauticAdvanced {
                             }
                         }
                         catch (error) {
-                            // Debug: log error object
-                            console.log('[DEBUG] Error caught in contact delete operation:', JSON.stringify(error, Object.getOwnPropertyNames(error), 2));
                             // If the error is a 404 (not found), treat as successful delete (idempotent)
                             if (error instanceof n8n_workflow_1.NodeApiError && error.httpCode === '404') {
                                 responseData = [{ success: true, message: 'Contact already deleted or not found.' }];
@@ -854,8 +853,6 @@ class MauticAdvanced {
                                 throw error;
                             }
                         }
-                        // Debug: log final responseData before returning
-                        console.log('[DEBUG] Final responseData to return from contact delete:', JSON.stringify(responseData, null, 2));
                         if (options.rawData === false) {
                             responseData = responseData.map((item) => item.fields?.all ?? item);
                         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-mautic-advanced",
-  "version": "0.1.9",
+  "version": "0.2.0",
   "description": "Enhanced n8n node for Mautic with comprehensive API coverage including tags, campaigns, categories, and advanced contact management",
   "keywords": [
     "n8n",