n8n-nodes-kafka-batch-consumer 1.0.9 → 1.0.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-kafka-batch-consumer",
-  "version": "1.0.9",
+  "version": "1.0.11",
   "description": "N8N node for consuming Kafka messages in batches",
   "main": "dist/index.js",
   "scripts": {

package/src/nodes/KafkaBatchConsumer/KafkaBatchConsumer.node.test.ts

@@ -292,23 +292,25 @@ describe('KafkaBatchConsumer', () => {
       });
     });
 
-    it('should handle SSL with rejectUnauthorized false', async () => {
+    /**
+     * Test plaintext connection (no SSL)
+     * When ssl is false or undefined, no SSL configuration should be added
+     */
+    it('should handle plaintext connection without SSL', async () => {
       mockExecuteFunctions.getCredentials.mockResolvedValue({
         brokers: 'localhost:9092',
         clientId: 'test-client',
-        ssl: false,
+        ssl: false, // Explicitly disable SSL
       });
 
-      mockConsumer.run.mockImplementation(async () => Promise.resolve());
+      mockConsumer.run.mockImplementation(async () => new Promise(() => {}));
 
       await kafkaBatchConsumer.execute.call(mockExecuteFunctions);
 
+      // Should NOT include ssl config when ssl: false
       expect(Kafka).toHaveBeenCalledWith({
         clientId: 'test-client',
         brokers: ['localhost:9092'],
-        ssl: {
-          rejectUnauthorized: false,
-        },
       });
     });
 

package/src/nodes/KafkaBatchConsumer/KafkaBatchConsumer.node.ts

@@ -151,6 +151,15 @@ export class KafkaBatchConsumer implements INodeType {
         ['localhost:9092'],
     };
 
+    // Debug: log credentials to understand SSL configuration
+    console.log('🔍 Kafka Credentials Debug:', {
+      ssl: credentials.ssl,
+      hasCa: !!credentials.ca,
+      hasCert: !!credentials.cert,
+      hasKey: !!credentials.key,
+      sslType: typeof credentials.ssl,
+    });
+
     // Map N8N credential fields to KafkaJS authentication format
     // Add SASL authentication if provided
     if (credentials.authentication) {
@@ -162,9 +171,10 @@ export class KafkaBatchConsumer implements INodeType {
     }
 
     // Add SSL/TLS configuration for encrypted connections
-    if (credentials.ssl !== undefined) {
+    // Only enable SSL if explicitly set to true or if SSL certificates are provided
+    if (credentials.ssl === true || credentials.ca || credentials.cert || credentials.key) {
       kafkaConfig.ssl = {
-        rejectUnauthorized: credentials.ssl, // Validate server certificates
+        rejectUnauthorized: credentials.ssl !== false, // Default to true if SSL is enabled
       };
 
       // Add optional SSL certificates for mutual TLS authentication