n8n-nodes-commercetools 1.0.14 → 1.0.16

package/LICENSE.md

@@ -1,19 +1,19 @@
-Copyright 2025 jjtech-digital
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of
-this software and associated documentation files (the "Software"), to deal in
-the Software without restriction, including without limitation the rights to
-use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
-of the Software, and to permit persons to whom the Software is furnished to do
-so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+Copyright 2025 jjtech-digital
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -269,16 +269,18 @@ A hash of `{ events, hasAWS, hasGCP }` is stored in workflow static data. When `
 When `awsAccessKeyId` and `awsSecretAccessKey` are present in the credential, the node automatically provisions:
 
 - SQS queue (14-day retention, long polling)
-- Lambda function (Node.js) with `WEBHOOK_URL` env var
+- Lambda function (Node.js 22.x) with `WEBHOOK_URL` env var
 - IAM role with SQS receive/delete and CloudWatch Logs policies
 - Event source mapping (SQS → Lambda, batch size 10)
 
 The Lambda forwards each SQS message to the n8n webhook URL as a POST request. All resources are deleted when the trigger is deactivated or its configuration changes.
 
+Uses **AWS SDK for JavaScript v3** (`@aws-sdk/client-sqs`, `@aws-sdk/client-lambda`, `@aws-sdk/client-iam`, `@aws-sdk/client-sts`, `@aws-sdk/client-cloudwatch-logs`).
+
 **Requirements:**
 
 - Publicly reachable n8n webhook URL
-- AWS credentials with permissions for: SQS, Lambda, IAM, CloudWatch Logs
+- AWS credentials with permissions for: SQS, Lambda, IAM, STS, CloudWatch Logs
 
 > ⚠️ AWS costs may apply.
 
@@ -356,7 +358,7 @@ npm run dev
 # Regenerate operations from the latest Postman collection + rebuild event registry
 npm run generate
 
-# Build
+# Build (cross-platform — also copies lambda handlers to dist/ via scripts/copyLambda.js)
 npm run build
 
 # Build and watch
@@ -365,6 +367,9 @@ npm run build:watch
 # Lint
 npm run lint
 npm run lint:fix
+
+# Run tests
+npm test
 ```
 
 ### Code generation pipeline
@@ -372,7 +377,13 @@ npm run lint:fix
 ```
 scripts/generate.ts                       (entry point: npm run generate)
 │
-├── parseCollection.ts
+├── parseCollection.ts                    (thin orchestrator)
+│     ├── collection/postmanTypes.ts      PostmanItem, PostmanCollection interfaces
+│     ├── collection/types.ts             BodyField, ParsedOperation interfaces
+│     ├── collection/helpers.ts           slugify, formatLabel, isLocalizedObject
+│     ├── collection/fieldExtractors.ts   extractFields, extractActionBodyFields
+│     ├── collection/findFolder.ts        findFolder (module-level cache — PERF-5)
+│     └── collection/walkItems.ts         walkItems (top-level exported function)
 │     Downloads Postman collection.json → ParsedOperation[]
 │     Detects per operation:
 │       isSearch        POST .../search
@@ -384,7 +395,13 @@ scripts/generate.ts                       (entry point: npm run generate)
 │       bodyFields      extracted from Postman body.raw JSON
 │       actionBodyFields fields from inside actions[0]
 │
-├── generateProperties.ts
+├── generateProperties.ts                 (thin orchestrator — PERF-4: Map index built once)
+│     ├── properties/helpers.ts           Constants + shared property builders
+│     ├── properties/resourceAndOperation.ts  Resource + Operation dropdowns
+│     ├── properties/idFields.ts          ID / Key / Container / path param fields
+│     ├── properties/versionAndActions.ts Actions (JSON) + Actions (UI) fixedCollection
+│     ├── properties/bodyFields.ts        Create / Misc-POST / Search body fields
+│     └── properties/imageAndQuery.ts     Image upload fields + query-param Filters
 │     ParsedOperation[] → INodeProperties[]
 │     Emits in order:
 │       1.  Resource dropdown
@@ -408,7 +425,11 @@ scripts/generate.ts                       (entry point: npm run generate)
 │     Extracts: *MessagePayload type literals,
 │               MessageSubscriptionResourceTypeId values,
 │               ChangeSubscriptionResourceTypeId values
-│     │     Filters to allowedResources: [product, customer, cart, order, business-unit, category, channel, associate-role, inventory-entry, review, shopping-list, type, payment, quote, quote-request, staged-quote, approval-rule, approval-flow, standalone-price, store, product-tailoring, customer-group, product-selection]
+│     Filters to allowedResources: [product, customer, cart, order, business-unit,
+│       category, channel, associate-role, inventory-entry, review, shopping-list,
+│       type, payment, quote, quote-request, staged-quote, approval-rule,
+│       approval-flow, standalone-price, store, product-tailoring,
+│       customer-group, product-selection]
 │     → nodes/Commercetools/generated/ctp-event-registry.json
 │
 └── generateSubscriptionProperties.ts
@@ -421,6 +442,37 @@ scripts/generate.ts                       (entry point: npm run generate)
 
 Generated files are committed to the repository. The built node works without running `generate` unless the Postman collection or SDK has changed.
 
+### Node source layout
+
+```
+nodes/Commercetools/
+├── Commercetools.node.ts           Thin action-node orchestrator (~175 lines)
+├── CommercetoolsTrigger.node.ts    Webhook trigger — receives and routes events
+├── generated/                      Auto-generated (do not edit manually)
+│   ├── properties.ts
+│   ├── operations.json
+│   ├── ctp-event-registry.json
+│   └── subscription.properties.ts
+├── lambda/
+│   ├── awsHandler.js               Lambda: SQS → n8n webhook forwarder
+│   └── gcpHandler.js               Cloud Function: Pub/Sub → n8n webhook forwarder
+└── utils/
+    ├── urlBuilder.utils.ts         URL construction + path-param substitution
+    ├── bodyBuilder.utils.ts        Request body assembly for all operation types
+    ├── imageUpload.utils.ts        SSRF-guarded image download + CT binary POST
+    ├── subscription.utils.ts       Subscription CRUD + body building + event routing
+    ├── webhookMethods.utils.ts     Webhook lifecycle: checkExists / create / delete
+    ├── cloudVerification.utils.ts  AWS + GCP infrastructure existence checks
+    ├── awsInfra.utils.ts           AWS SQS / Lambda / IAM provisioning (SDK v3)
+    ├── awsDelete.utils.ts          AWS infrastructure teardown (SDK v3)
+    ├── gcpInfra.utils.ts           GCP Pub/Sub / Cloud Functions provisioning
+    └── gcpDelete.utils.ts          GCP infrastructure teardown
+
+scripts/
+├── copyLambda.js                   Cross-platform postbuild: copies lambda/*.js → dist/
+└── ...
+```
+
 ---
 
 ## Auto-Update Pipeline
@@ -450,6 +502,13 @@ New API endpoints and fields appear in the node automatically without manual dev
 | Business Unit Search: `Search Not Ready`                   | Business Unit Search must be activated on your project — call `PUT /{projectKey}/business-units/search/indexing-status` with `{ "activated": true }` then wait for indexing to complete |
 | GCP: private key / PEM errors                              | Use the **Service Account JSON** field; paste the entire `.json` key file, not individual fields              |
 | GCP: deploy timeout on first activation                    | GCP API enablement takes time on cold projects — retry after a minute                                         |
+| GCP: `gcpRegion` missing error on activation               | Open the credential and select a GCP Region — the field is required for Cloud Functions deployment            |
+| AWS: wrong queue ARN in GovCloud / China regions           | ARN is fetched from `GetQueueAttributes` (not constructed manually)                                           |
+| AWS: `credentials are invalid` or `permissions denied`     | Verify the IAM user has SQS, Lambda, IAM, STS, and CloudWatch Logs permissions                               |
+| Build: `The syntax of the command is incorrect` on Windows | Ensure you are on v1.0.15+ — the postbuild script is now cross-platform (`scripts/copyLambda.js`)            |
+| Trigger: malformed webhook payload crashes execution        | Update to v1.0.14 — invalid JSON payloads are now silently dropped instead of crashing the context           |
+| Subscription: `subscriptionId is empty` error              | The subscription ID was not persisted in static data — deactivate and reactivate the workflow                 |
+| Update operation: zero value (`0`) silently dropped        | Update to v1.0.14 — `quantity: 0` and `centAmount: 0` are now sent correctly                                 |
 | Node not visible in n8n                                    | Run `npm install` then `npm run dev`                                                                          |
 | Trigger: `"A message with the name 'PaymentMethodCreated' is unknown for the TypeId 'payment'"` | CT Subscriptions API does not support `payment-method` as a resourceTypeId. Use CT API Extensions or a schedule-based polling trigger instead. |
 
@@ -459,14 +518,10 @@ New API endpoints and fields appear in the node automatically without manual dev
 
 | Version | Changes                                                                                                                     |
 | ------- | ----------------------------------------------------------------------------------------------------------------------------|
-| v1.0.13 | Added Standalone Prices, Stores, Product Tailoring, Customer Groups, Product Selections, Cart Discounts, and Discount Codes |
-| v1.0.12 | Added Approval Rules, Approval Flows, and Associate Endpoints                                                               |
-| v1.0.11 | Added Quotes, Quote Requests, Staged Quotes, Messages, and API Extensions                                                   |
-| v1.0.10 | Added Claude AI agents and skills for automated development assistance                                                      |
-                                                                      
-
-
-
+| v1.0.16 | Readme Update                                                                                                   |  
+| v1.0.15 | Migrated AWS infrastructure to SDK v3 (`@aws-sdk/client-*`); cross-platform postbuild script (`scripts/copyLambda.js`) fixes Windows build; lambda handlers now correctly copied to `dist/`; CI workflow adds test step and npm cache; ESLint allows `console.warn`/`console.error` for infrastructure logging |
+| v1.0.14 | Added Product Discounts, Product Types, Product Projections, Tax Categories, Attribute Groups, API Clients, Recurring Orders, Recurrence Policies, Discount Groups, and In-Store Endpoints |
+| v1.0.13 | Added Standalone Prices, Stores, Product Tailoring, Customer Groups, Product Selections, Cart Discounts, and Discount Codes |                              
 ---
 
 ## License

package/dist/icons/github.dark.svg

@@ -1,3 +1,3 @@
-<svg width="40" height="40" viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
-<path fill-rule="evenodd" clip-rule="evenodd" d="M20.0165 0C8.94791 0 0 9.01388 0 20.1653C0 29.0792 5.73324 36.6246 13.6868 39.2952C14.6812 39.496 15.0454 38.8613 15.0454 38.3274C15.0454 37.8599 15.0126 36.2575 15.0126 34.5879C9.4445 35.79 8.28498 32.1841 8.28498 32.1841C7.39015 29.847 6.06429 29.2463 6.06429 29.2463C4.24185 28.011 6.19704 28.011 6.19704 28.011C8.21861 28.1446 9.27938 30.081 9.27938 30.081C11.0686 33.1522 13.9518 32.2844 15.1118 31.7502C15.2773 30.4481 15.8079 29.5467 16.3713 29.046C11.9303 28.5785 7.25781 26.8425 7.25781 19.0967C7.25781 16.8932 8.05267 15.0905 9.31216 13.6884C9.11344 13.1877 8.41732 11.1174 9.51128 8.34644C9.51128 8.34644 11.2014 7.81217 15.0122 10.4164C16.6438 9.97495 18.3263 9.7504 20.0165 9.74851C21.7067 9.74851 23.4295 9.98246 25.0205 10.4164C28.8317 7.81217 30.5218 8.34644 30.5218 8.34644C31.6158 11.1174 30.9192 13.1877 30.7205 13.6884C32.0132 15.0905 32.7753 16.8932 32.7753 19.0967C32.7753 26.8425 28.1028 28.5449 23.6287 29.046C24.358 29.6802 24.9873 30.882 24.9873 32.7851C24.9873 35.4893 24.9545 37.6596 24.9545 38.327C24.9545 38.8613 25.3192 39.496 26.3132 39.2956C34.2667 36.6242 39.9999 29.0792 39.9999 20.1653C40.0327 9.01388 31.052 0 20.0165 0Z" fill="white"/>
-</svg>
+<svg width="40" height="40" viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M20.0165 0C8.94791 0 0 9.01388 0 20.1653C0 29.0792 5.73324 36.6246 13.6868 39.2952C14.6812 39.496 15.0454 38.8613 15.0454 38.3274C15.0454 37.8599 15.0126 36.2575 15.0126 34.5879C9.4445 35.79 8.28498 32.1841 8.28498 32.1841C7.39015 29.847 6.06429 29.2463 6.06429 29.2463C4.24185 28.011 6.19704 28.011 6.19704 28.011C8.21861 28.1446 9.27938 30.081 9.27938 30.081C11.0686 33.1522 13.9518 32.2844 15.1118 31.7502C15.2773 30.4481 15.8079 29.5467 16.3713 29.046C11.9303 28.5785 7.25781 26.8425 7.25781 19.0967C7.25781 16.8932 8.05267 15.0905 9.31216 13.6884C9.11344 13.1877 8.41732 11.1174 9.51128 8.34644C9.51128 8.34644 11.2014 7.81217 15.0122 10.4164C16.6438 9.97495 18.3263 9.7504 20.0165 9.74851C21.7067 9.74851 23.4295 9.98246 25.0205 10.4164C28.8317 7.81217 30.5218 8.34644 30.5218 8.34644C31.6158 11.1174 30.9192 13.1877 30.7205 13.6884C32.0132 15.0905 32.7753 16.8932 32.7753 19.0967C32.7753 26.8425 28.1028 28.5449 23.6287 29.046C24.358 29.6802 24.9873 30.882 24.9873 32.7851C24.9873 35.4893 24.9545 37.6596 24.9545 38.327C24.9545 38.8613 25.3192 39.496 26.3132 39.2956C34.2667 36.6242 39.9999 29.0792 39.9999 20.1653C40.0327 9.01388 31.052 0 20.0165 0Z" fill="white"/>
+</svg>

package/dist/icons/github.svg

@@ -1,3 +1,3 @@
-<svg width="40" height="40" viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
-<path fill-rule="evenodd" clip-rule="evenodd" d="M20.0165 0C8.94791 0 0 9.01388 0 20.1653C0 29.0792 5.73324 36.6246 13.6868 39.2952C14.6812 39.496 15.0454 38.8613 15.0454 38.3274C15.0454 37.8599 15.0126 36.2575 15.0126 34.5879C9.4445 35.79 8.28498 32.1841 8.28498 32.1841C7.39015 29.847 6.06429 29.2463 6.06429 29.2463C4.24185 28.011 6.19704 28.011 6.19704 28.011C8.21861 28.1446 9.27938 30.081 9.27938 30.081C11.0686 33.1522 13.9518 32.2844 15.1118 31.7502C15.2773 30.4481 15.8079 29.5467 16.3713 29.046C11.9303 28.5785 7.25781 26.8425 7.25781 19.0967C7.25781 16.8932 8.05267 15.0905 9.31216 13.6884C9.11344 13.1877 8.41732 11.1174 9.51128 8.34644C9.51128 8.34644 11.2014 7.81217 15.0122 10.4164C16.6438 9.97495 18.3263 9.7504 20.0165 9.74851C21.7067 9.74851 23.4295 9.98246 25.0205 10.4164C28.8317 7.81217 30.5218 8.34644 30.5218 8.34644C31.6158 11.1174 30.9192 13.1877 30.7205 13.6884C32.0132 15.0905 32.7753 16.8932 32.7753 19.0967C32.7753 26.8425 28.1028 28.5449 23.6287 29.046C24.358 29.6802 24.9873 30.882 24.9873 32.7851C24.9873 35.4893 24.9545 37.6596 24.9545 38.327C24.9545 38.8613 25.3192 39.496 26.3132 39.2956C34.2667 36.6242 39.9999 29.0792 39.9999 20.1653C40.0327 9.01388 31.052 0 20.0165 0Z" fill="#24292F"/>
-</svg>
+<svg width="40" height="40" viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M20.0165 0C8.94791 0 0 9.01388 0 20.1653C0 29.0792 5.73324 36.6246 13.6868 39.2952C14.6812 39.496 15.0454 38.8613 15.0454 38.3274C15.0454 37.8599 15.0126 36.2575 15.0126 34.5879C9.4445 35.79 8.28498 32.1841 8.28498 32.1841C7.39015 29.847 6.06429 29.2463 6.06429 29.2463C4.24185 28.011 6.19704 28.011 6.19704 28.011C8.21861 28.1446 9.27938 30.081 9.27938 30.081C11.0686 33.1522 13.9518 32.2844 15.1118 31.7502C15.2773 30.4481 15.8079 29.5467 16.3713 29.046C11.9303 28.5785 7.25781 26.8425 7.25781 19.0967C7.25781 16.8932 8.05267 15.0905 9.31216 13.6884C9.11344 13.1877 8.41732 11.1174 9.51128 8.34644C9.51128 8.34644 11.2014 7.81217 15.0122 10.4164C16.6438 9.97495 18.3263 9.7504 20.0165 9.74851C21.7067 9.74851 23.4295 9.98246 25.0205 10.4164C28.8317 7.81217 30.5218 8.34644 30.5218 8.34644C31.6158 11.1174 30.9192 13.1877 30.7205 13.6884C32.0132 15.0905 32.7753 16.8932 32.7753 19.0967C32.7753 26.8425 28.1028 28.5449 23.6287 29.046C24.358 29.6802 24.9873 30.882 24.9873 32.7851C24.9873 35.4893 24.9545 37.6596 24.9545 38.327C24.9545 38.8613 25.3192 39.496 26.3132 39.2956C34.2667 36.6242 39.9999 29.0792 39.9999 20.1653C40.0327 9.01388 31.052 0 20.0165 0Z" fill="#24292F"/>
+</svg>