n8n-nodes-binary-to-url 0.2.1 → 0.2.3

package/dist/drivers/MemoryStorage.d.ts

@@ -66,7 +66,7 @@ export declare class MemoryStorage {
      * Format: {timestamp}-{16-char-hex}
      */
     static generateFileKey(): string;
-    static upload(workflowId: string, data: Buffer, contentType: string, ttl?: number): Promise<{
+    static upload(workflowId: string, data: Buffer, contentType: string, fileName: string, ttl?: number): Promise<{
         fileKey: string;
         contentType: string;
     }>;
@@ -74,6 +74,7 @@ export declare class MemoryStorage {
     static download(workflowId: string, fileKey: string): Promise<{
         data: Buffer;
         contentType: string;
+        fileName: string;
     } | null>;
     static delete(workflowId: string, fileKey: string): Promise<boolean>;
     static cleanupWorkflowExpired(workflowId: string): void;

package/dist/drivers/MemoryStorage.js

@@ -148,7 +148,7 @@ class MemoryStorage {
     static generateFileKey() {
         return (0, crypto_1.randomUUID)();
     }
-    static async upload(workflowId, data, contentType, ttl) {
+    static async upload(workflowId, data, contentType, fileName, ttl) {
         // Wait for any existing upload for this workflow to complete
         const existingLock = this.uploadLocks.get(workflowId);
         if (existingLock) {
@@ -165,7 +165,7 @@ class MemoryStorage {
         // Create new lock for this upload
         const lockPromise = (async () => {
             try {
-                return await this.uploadInternal(workflowId, data, contentType, ttl);
+                return await this.uploadInternal(workflowId, data, contentType, fileName, ttl);
             }
             finally {
                 // Release lock
@@ -175,7 +175,7 @@ class MemoryStorage {
         this.uploadLocks.set(workflowId, lockPromise);
         return lockPromise;
     }
-    static async uploadInternal(workflowId, data, contentType, ttl) {
+    static async uploadInternal(workflowId, data, contentType, fileName, ttl) {
         const fileKey = this.generateFileKey();
         const now = Date.now();
         const expiresAt = now + (ttl || this.DEFAULT_TTL);
@@ -184,6 +184,7 @@ class MemoryStorage {
         const file = {
             data,
             contentType,
+            fileName,
             uploadedAt: now,
             expiresAt,
         };
@@ -235,6 +236,7 @@ class MemoryStorage {
         return {
             data: file.data,
             contentType: file.contentType,
+            fileName: file.fileName,
         };
     }
     static async delete(workflowId, fileKey) {

package/dist/nodes/BinaryToUrl/BinaryToUrl.node.js

@@ -90,9 +90,10 @@ class BinaryToUrl {
             }
             // Return binary file directly
             const isDownload = constants_js_1.DOWNLOAD_MIME_TYPES.includes(result.contentType);
-            const disposition = isDownload
+            const dispositionType = isDownload
                 ? constants_js_1.HTTP_HEADERS.DISPOSITION_ATTACHMENT
                 : constants_js_1.HTTP_HEADERS.DISPOSITION_INLINE;
+            const disposition = `${dispositionType}; filename="${result.fileName}"`;
             // Get origin from headers for CORS
             const headers = this.getHeaderData();
             const origin = headers?.origin;
@@ -213,8 +214,24 @@ async function handleUpload(context, items) {
             const binaryData = context.helpers.assertBinaryData(i, binaryPropertyName);
             buffer = await context.helpers.getBinaryDataBuffer(i, binaryPropertyName);
             contentType = binaryData.mimeType || 'application/octet-stream';
-            const ext = item.json?.fileExtension;
-            fileExtension = typeof ext === 'string' ? ext : (contentType.split('/')[1] || '');
+            // Auto-detect file extension:
+            // 1. From original filename in binary data
+            // 2. From MIME type
+            if (binaryData.fileName && typeof binaryData.fileName === 'string') {
+                const lastDot = binaryData.fileName.lastIndexOf('.');
+                if (lastDot > 0 && lastDot < binaryData.fileName.length - 1) {
+                    fileExtension = binaryData.fileName.slice(lastDot + 1);
+                    debugLog(context.logger, `Extracted extension from filename ${binaryData.fileName}: ${fileExtension}`);
+                }
+                else {
+                    fileExtension = contentType.split('/')[1] || '';
+                    debugLog(context.logger, `No extension in filename, using MIME type: ${fileExtension}`);
+                }
+            }
+            else {
+                fileExtension = contentType.split('/')[1] || '';
+                debugLog(context.logger, `No filename available, using MIME type: ${fileExtension}`);
+            }
             debugLog(context.logger, `Got binary data from property: size=${buffer.length}, mimeType=${contentType}, extension=${fileExtension}`);
         }
         catch {
@@ -226,8 +243,24 @@ async function handleUpload(context, items) {
                     const stream = await context.helpers.getBinaryStream(fileId);
                     buffer = await context.helpers.binaryToBuffer(stream);
                     contentType = String(item.json?.mimeType || 'application/octet-stream');
-                    const ext = item.json?.fileExtension;
-                    fileExtension = typeof ext === 'string' ? ext : (contentType.split('/')[1] || '');
+                    // Auto-detect file extension:
+                    // 1. From original filename in item data
+                    // 2. From MIME type
+                    if (item.json?.fileName && typeof item.json.fileName === 'string') {
+                        const lastDot = item.json.fileName.lastIndexOf('.');
+                        if (lastDot > 0 && lastDot < item.json.fileName.length - 1) {
+                            fileExtension = item.json.fileName.slice(lastDot + 1);
+                            debugLog(context.logger, `Extracted extension from filename ${item.json.fileName}: ${fileExtension}`);
+                        }
+                        else {
+                            fileExtension = contentType.split('/')[1] || '';
+                            debugLog(context.logger, `No extension in filename, using MIME type: ${fileExtension}`);
+                        }
+                    }
+                    else {
+                        fileExtension = contentType.split('/')[1] || '';
+                        debugLog(context.logger, `No filename available, using MIME type: ${fileExtension}`);
+                    }
                     debugLog(context.logger, `File fetched via getBinaryStream: size=${buffer.length}, mimeType=${contentType}, extension=${fileExtension}`);
                 }
                 catch (streamError) {
@@ -248,11 +281,12 @@ async function handleUpload(context, items) {
         if (fileSize > constants_js_1.CACHE_LIMITS.MAX_FILE_SIZE) {
             throw new n8n_workflow_1.NodeOperationError(context.getNode(), `File size exceeds maximum limit of ${constants_js_1.CACHE_LIMITS.MAX_FILE_SIZE / 1024 / 1024}MB`);
         }
-        // Upload to memory storage
-        const result = await MemoryStorage_js_1.MemoryStorage.upload(workflowId, buffer, contentType, ttlMs);
-        const proxyUrl = `${webhookUrlBase}?fileKey=${result.fileKey}`;
         // Generate random filename with extension
         const randomFileName = fileExtension ? `${(0, crypto_1.randomUUID)()}.${fileExtension}` : (0, crypto_1.randomUUID)();
+        debugLog(context.logger, `Generated random filename: ${randomFileName}`);
+        // Upload to memory storage
+        const result = await MemoryStorage_js_1.MemoryStorage.upload(workflowId, buffer, contentType, randomFileName, ttlMs);
+        const proxyUrl = `${webhookUrlBase}?fileKey=${result.fileKey}`;
         debugLog(context.logger, `File uploaded: fileKey=${result.fileKey}, fileName=${randomFileName}`);
         returnData.push({
             json: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-binary-to-url",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "description": "n8n community node for creating temporary URLs for binary files within workflow execution",
   "keywords": [
     "n8n-community-node-package",