n8n-nodes-binary-to-url 0.1.38 → 0.2.2

package/dist/drivers/MemoryStorage.d.ts

@@ -9,11 +9,8 @@ interface StorageStats {
 export declare class MemoryStorage {
     private static workflowCaches;
     private static readonly DEFAULT_TTL;
-    private static readonly MAX_CACHE_SIZE;
-    private static readonly GLOBAL_MAX_CACHE_SIZE;
     private static globalCacheSize;
     private static nextGlobalExpirationTime?;
-    private static cleanupInterval?;
     private static readonly MAX_DELETE_PER_CLEANUP;
     private static readonly MIN_FILES_TO_KEEP;
     private static readonly VALIDATION_THRESHOLD;
@@ -48,17 +45,11 @@ export declare class MemoryStorage {
      * @returns The removed entry, or undefined if index is invalid
      */
     private static heapRemove;
-    /**
-     * Get the root element of the heap without removing it
-     * @returns The oldest file entry, or undefined if heap is empty
-     */
-    private static heapPeek;
     /**
      * Remove and return the root element of the heap
      * @returns The oldest file entry, or undefined if heap is empty
      */
     private static heapPop;
-    private static heapContains;
     private static heapGetIndex;
     private static removeFromExpirationQueue;
     private static uploadLocks;

package/dist/drivers/MemoryStorage.js

@@ -86,13 +86,6 @@ class MemoryStorage {
         }
         return entry;
     }
-    /**
-     * Get the root element of the heap without removing it
-     * @returns The oldest file entry, or undefined if heap is empty
-     */
-    static heapPeek() {
-        return this.globalUploadQueue[0];
-    }
     /**
      * Remove and return the root element of the heap
      * @returns The oldest file entry, or undefined if heap is empty
@@ -100,10 +93,6 @@ class MemoryStorage {
     static heapPop() {
         return this.heapRemove(0);
     }
-    static heapContains(workflowId, fileKey) {
-        const key = this.UPLOAD_QUEUE_INDEX_KEY(workflowId, fileKey);
-        return this.globalUploadQueueIndex.has(key);
-    }
     static heapGetIndex(workflowId, fileKey) {
         const key = this.UPLOAD_QUEUE_INDEX_KEY(workflowId, fileKey);
         return this.globalUploadQueueIndex.get(key);
@@ -169,6 +158,8 @@ class MemoryStorage {
             catch (error) {
                 this.warn(`Upload lock failed for workflow ${workflowId}: ${error}`);
                 this.uploadLocks.delete(workflowId);
+                // Re-throw to ensure caller is aware of the failure
+                throw error;
             }
         }
         // Create new lock for this upload
@@ -264,9 +255,8 @@ class MemoryStorage {
             // Remove from expiration queue with proper index update
             this.removeFromExpirationQueue(workflowCache, fileKey);
             if (workflowCache.cache.size === 0) {
-                workflowCache.nextExpirationTime = undefined;
-                workflowCache.expirationQueue = [];
-                workflowCache.queueIndex.clear();
+                // Clean up empty workflow cache to prevent memory leaks
+                this.workflowCaches.delete(workflowId);
             }
             else {
                 workflowCache.nextExpirationTime = workflowCache.expirationQueue[0]?.expiresAt;
@@ -323,7 +313,8 @@ class MemoryStorage {
             }
         }
         if (workflowCache.cache.size === 0) {
-            workflowCache.nextExpirationTime = undefined;
+            // Clean up empty workflow cache to prevent memory leaks
+            this.workflowCaches.delete(workflowId);
         }
         else {
             workflowCache.nextExpirationTime = workflowCache.expirationQueue[0]?.expiresAt;
@@ -588,8 +579,6 @@ class MemoryStorage {
 exports.MemoryStorage = MemoryStorage;
 MemoryStorage.workflowCaches = new Map();
 MemoryStorage.DEFAULT_TTL = constants_js_1.TTL.DEFAULT_MS;
-MemoryStorage.MAX_CACHE_SIZE = constants_js_1.CACHE_LIMITS.MAX_CACHE_SIZE;
-MemoryStorage.GLOBAL_MAX_CACHE_SIZE = constants_js_1.CACHE_LIMITS.GLOBAL_MAX_CACHE_SIZE;
 MemoryStorage.globalCacheSize = 0;
 MemoryStorage.MAX_DELETE_PER_CLEANUP = constants_js_1.CLEANUP.MAX_DELETE_PER_CLEANUP;
 MemoryStorage.MIN_FILES_TO_KEEP = constants_js_1.CLEANUP.MIN_FILES_TO_KEEP;

package/dist/nodes/BinaryToUrl/BinaryToUrl.node.js

@@ -5,10 +5,14 @@ const n8n_workflow_1 = require("n8n-workflow");
 const crypto_1 = require("crypto");
 const MemoryStorage_js_1 = require("../../drivers/MemoryStorage.js");
 const constants_js_1 = require("../../config/constants.js");
-// Enable debug logging via environment variable
-const DEBUG_ENABLED = process.env.BINARY_TO_URL_DEBUG === 'true';
+/**
+ * Debug logging helper function
+ * @param logger - n8n logger instance
+ * @param message - Log message
+ * @param args - Additional arguments to log
+ */
 function debugLog(logger, message, ...args) {
-    if (DEBUG_ENABLED && logger) {
+    if (logger) {
         const formattedMessage = args.length > 0
             ? `[BinaryToUrl] ${message} ${args.map(String).join(' ')}`
             : `[BinaryToUrl] ${message}`;
@@ -29,6 +33,7 @@ class BinaryToUrl {
             },
             inputs: ['main'],
             outputs: ['main'],
+            usableAsTool: true,
             webhooks: [
                 {
                     name: 'default',
@@ -208,11 +213,27 @@ async function handleUpload(context, items) {
             const binaryData = context.helpers.assertBinaryData(i, binaryPropertyName);
             buffer = await context.helpers.getBinaryDataBuffer(i, binaryPropertyName);
             contentType = binaryData.mimeType || 'application/octet-stream';
-            const ext = item.json?.fileExtension;
-            fileExtension = typeof ext === 'string' ? ext : (contentType.split('/')[1] || '');
+            // Auto-detect file extension:
+            // 1. From original filename in binary data
+            // 2. From MIME type
+            if (binaryData.fileName && typeof binaryData.fileName === 'string') {
+                const lastDot = binaryData.fileName.lastIndexOf('.');
+                if (lastDot > 0 && lastDot < binaryData.fileName.length - 1) {
+                    fileExtension = binaryData.fileName.slice(lastDot + 1);
+                    debugLog(context.logger, `Extracted extension from filename ${binaryData.fileName}: ${fileExtension}`);
+                }
+                else {
+                    fileExtension = contentType.split('/')[1] || '';
+                    debugLog(context.logger, `No extension in filename, using MIME type: ${fileExtension}`);
+                }
+            }
+            else {
+                fileExtension = contentType.split('/')[1] || '';
+                debugLog(context.logger, `No filename available, using MIME type: ${fileExtension}`);
+            }
             debugLog(context.logger, `Got binary data from property: size=${buffer.length}, mimeType=${contentType}, extension=${fileExtension}`);
         }
-        catch (error) {
+        catch {
             // If no binary data in property, try to get file ID from JSON
             if (item.json && typeof item.json === 'object' && 'id' in item.json && typeof item.json.id === 'string') {
                 const fileId = item.json.id;
@@ -221,8 +242,24 @@ async function handleUpload(context, items) {
                     const stream = await context.helpers.getBinaryStream(fileId);
                     buffer = await context.helpers.binaryToBuffer(stream);
                     contentType = String(item.json?.mimeType || 'application/octet-stream');
-                    const ext = item.json?.fileExtension;
-                    fileExtension = typeof ext === 'string' ? ext : (contentType.split('/')[1] || '');
+                    // Auto-detect file extension:
+                    // 1. From original filename in item data
+                    // 2. From MIME type
+                    if (item.json?.fileName && typeof item.json.fileName === 'string') {
+                        const lastDot = item.json.fileName.lastIndexOf('.');
+                        if (lastDot > 0 && lastDot < item.json.fileName.length - 1) {
+                            fileExtension = item.json.fileName.slice(lastDot + 1);
+                            debugLog(context.logger, `Extracted extension from filename ${item.json.fileName}: ${fileExtension}`);
+                        }
+                        else {
+                            fileExtension = contentType.split('/')[1] || '';
+                            debugLog(context.logger, `No extension in filename, using MIME type: ${fileExtension}`);
+                        }
+                    }
+                    else {
+                        fileExtension = contentType.split('/')[1] || '';
+                        debugLog(context.logger, `No filename available, using MIME type: ${fileExtension}`);
+                    }
                     debugLog(context.logger, `File fetched via getBinaryStream: size=${buffer.length}, mimeType=${contentType}, extension=${fileExtension}`);
                 }
                 catch (streamError) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-binary-to-url",
-  "version": "0.1.38",
+  "version": "0.2.2",
   "description": "n8n community node for creating temporary URLs for binary files within workflow execution",
   "keywords": [
     "n8n-community-node-package",