n8n-nodes-binary-to-url 0.1.2 → 0.1.7

package/README.md

@@ -70,7 +70,7 @@ sudo systemctl restart n8n
 ```json
 {
   "fileKey": "1736567890123-abc123def456",
-  "proxyUrl": "https://your-n8n.com/webhook/123/file/1736567890123-abc123def456",
+  "proxyUrl": "https://your-n8n.com/webhook/webhook-id/file?fileKey=1736567890123-abc123def456",
   "contentType": "image/jpeg",
   "fileSize": 245678
 }

package/dist/index.d.ts

@@ -0,0 +1,2 @@
+import { BinaryToUrl } from './nodes/BinaryToUrl/BinaryToUrl.node';
+export declare const nodeClasses: (typeof BinaryToUrl)[];

package/dist/index.js

@@ -0,0 +1,5 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.nodeClasses = void 0;
+const BinaryToUrl_node_1 = require("./nodes/BinaryToUrl/BinaryToUrl.node");
+exports.nodeClasses = [BinaryToUrl_node_1.BinaryToUrl];

package/dist/nodes/BinaryToUrl/BinaryToUrl.node.d.ts

@@ -1,6 +1,18 @@
-import { INodeType, INodeTypeDescription, IExecuteFunctions, IWebhookFunctions, IWebhookResponseData, INodeExecutionData } from 'n8n-workflow';
+import { INodeType, INodeTypeDescription, IExecuteFunctions, IWebhookFunctions, IWebhookResponseData, INodeExecutionData, IHookFunctions } from 'n8n-workflow';
+interface IHookFunctionsExtended extends IHookFunctions {
+    addWebhookToDatabase?(webhookUrl: string, httpMethod: string, path: string, restartWebhook?: boolean): Promise<void>;
+    removeWebhookFromDatabase?(webhookUrl: string, httpMethod: string, path: string): Promise<void>;
+}
 export declare class BinaryToUrl implements INodeType {
     description: INodeTypeDescription;
+    webhookMethods: {
+        default: {
+            checkExists(this: IHookFunctions): Promise<boolean>;
+            create(this: IHookFunctionsExtended): Promise<boolean>;
+            delete(this: IHookFunctionsExtended): Promise<boolean>;
+        };
+    };
     execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]>;
     webhook(this: IWebhookFunctions): Promise<IWebhookResponseData>;
 }
+export {};

package/dist/nodes/BinaryToUrl/BinaryToUrl.node.js

@@ -42,7 +42,7 @@ class BinaryToUrl {
             group: ['transform'],
             version: 1,
             subtitle: '={{$parameter["operation"]}}',
-            description: 'Create temporary URLs for binary files within a workflow execution',
+            description: 'Store binary files in memory and retrieve them by key',
             defaults: {
                 name: 'Binary to URL',
             },
@@ -53,7 +53,7 @@ class BinaryToUrl {
                     name: 'default',
                     httpMethod: 'GET',
                     responseMode: 'onReceived',
-                    path: 'file/:fileKey',
+                    path: 'file',
                     isFullPath: false,
                 },
             ],
@@ -67,7 +67,7 @@ class BinaryToUrl {
                         {
                             name: 'Upload',
                             value: 'upload',
-                            description: 'Create temporary URL for binary file',
+                            description: 'Store binary file in memory',
                             action: 'Upload file',
                         },
                         {
@@ -92,7 +92,7 @@ class BinaryToUrl {
                     description: 'Name of binary property containing the file to upload',
                 },
                 {
-                    displayName: 'URL Expiration Time (Seconds)',
+                    displayName: 'TTL (Seconds)',
                     name: 'ttl',
                     type: 'number',
                     displayOptions: {
@@ -101,8 +101,7 @@ class BinaryToUrl {
                         },
                     },
                     default: 600,
-                    description: 'How long the URL remains valid (default: 600 seconds = 10 minutes)',
-                    hint: 'This is for temporary use within a workflow. For short-term sharing, use 300-3600 seconds. For workflow-internal use, 60-600 seconds is recommended.',
+                    description: 'How long the file remains valid in memory (default: 600 seconds)',
                 },
                 {
                     displayName: 'File Key',
@@ -114,11 +113,41 @@ class BinaryToUrl {
                         },
                     },
                     default: '',
-                    description: 'Key of the file to delete from memory',
+                    description: 'Key of the file to delete',
                 },
             ],
             usableAsTool: true,
         };
+        this.webhookMethods = {
+            default: {
+                async checkExists() {
+                    const webhookUrl = this.getNodeWebhookUrl('default');
+                    return !!webhookUrl;
+                },
+                async create() {
+                    const webhookUrl = this.getNodeWebhookUrl('default');
+                    if (!webhookUrl) {
+                        throw new n8n_workflow_1.NodeOperationError(this.getNode(), 'Failed to get webhook URL');
+                    }
+                    // Try to register webhook in n8n's database if the method exists
+                    if (this.addWebhookToDatabase) {
+                        await this.addWebhookToDatabase(webhookUrl, 'GET', 'file', true);
+                    }
+                    return true;
+                },
+                async delete() {
+                    const webhookUrl = this.getNodeWebhookUrl('default');
+                    if (!webhookUrl) {
+                        return true;
+                    }
+                    // Try to unregister webhook if the method exists
+                    if (this.removeWebhookFromDatabase) {
+                        await this.removeWebhookFromDatabase(webhookUrl, 'GET', 'file');
+                    }
+                    return true;
+                },
+            },
+        };
     }
     async execute() {
         const items = this.getInputData();
@@ -132,8 +161,8 @@ class BinaryToUrl {
         throw new n8n_workflow_1.NodeOperationError(this.getNode(), `Unknown operation: ${operation}`);
     }
     async webhook() {
-        const req = this.getRequestObject();
-        const fileKey = req.params.fileKey;
+        const query = this.getQueryData();
+        const fileKey = query.fileKey;
         const workflow = this.getWorkflow();
         const workflowId = workflow.id;
         if (!fileKey) {
@@ -211,10 +240,17 @@ async function handleUpload(context, items) {
     }
     const workflow = context.getWorkflow();
     const workflowId = workflow.id;
+    const node = context.getNode();
     const baseUrl = context.getInstanceBaseUrl();
-    // Remove trailing slash and ensure clean URL
-    const cleanBaseUrl = baseUrl.replace(/\/+$/, '');
-    const webhookUrl = `${cleanBaseUrl}/webhook/${workflowId}/file/:fileKey`;
+    // Use n8n's getNodeWebhookUrl helper to build the correct webhook URL
+    // The webhook path is 'file' with fileKey as query parameter
+    const webhookUrlBase = (0, n8n_workflow_1.getNodeWebhookUrl)(baseUrl, workflowId, node, 'file', false);
+    // Validate that the webhook URL was generated successfully
+    if (!webhookUrlBase) {
+        throw new n8n_workflow_1.NodeOperationError(context.getNode(), 'Failed to generate webhook URL. Please check your n8n configuration.');
+    }
+    // URL template with query parameter
+    const webhookUrlTemplate = `${webhookUrlBase}?fileKey=:fileKey`;
     const returnData = [];
     for (const item of items) {
         const binaryData = item.binary?.[binaryPropertyName];
@@ -245,7 +281,7 @@ async function handleUpload(context, items) {
             throw new n8n_workflow_1.NodeOperationError(context.getNode(), `File size exceeds maximum limit of ${MAX_FILE_SIZE / 1024 / 1024}MB`);
         }
         const result = await MemoryStorage_js_1.MemoryStorage.upload(workflowId, buffer, contentType, ttl * 1000);
-        const proxyUrl = webhookUrl.replace(':fileKey', result.fileKey);
+        const proxyUrl = webhookUrlTemplate.replace(':fileKey', result.fileKey);
         context.logger.info(`File uploaded: ${result.fileKey}, size: ${fileSize}, contentType: ${contentType}, TTL: ${ttl}s`);
         returnData.push({
             json: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-binary-to-url",
-  "version": "0.1.2",
+  "version": "0.1.7",
   "description": "n8n community node for creating temporary URLs for binary files within workflow execution",
   "keywords": [
     "n8n-community-node-package",
@@ -53,7 +53,11 @@
     "typescript": "5.9.2"
   },
   "peerDependencies": {
-    "n8n-workflow": "*"
+    "n8n-workflow": ">=1.0.0"
+  },
+  "engines": {
+    "node": ">=18.10.0",
+    "n8n": ">=2.0.0"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"