n8n-nodes-binary-to-url 0.0.7 → 0.0.9

package/dist/credentials/S3Api.credentials.d.ts

@@ -1,4 +1,4 @@
-import type { Icon, ICredentialType, INodeProperties } from 'n8n-workflow';
+import type { ICredentialType, INodeProperties, Icon } from 'n8n-workflow';
 export declare class S3Api implements ICredentialType {
     name: string;
     displayName: string;

package/dist/credentials/S3Api.credentials.js

@@ -4,43 +4,50 @@ exports.S3Api = void 0;
 class S3Api {
     constructor() {
         this.name = 's3Api';
-        this.displayName = 'S3 API';
+        this.displayName = 'S3';
         this.icon = 'file:../icons/BinaryToUrl.svg';
         this.documentationUrl = 'https://docs.aws.amazon.com/AmazonS3/latest/userguide/AccessCredentials.html';
         this.properties = [
             {
-                displayName: 'Access Key ID',
-                name: 'accessKeyId',
-                type: 'string',
-                typeOptions: { password: true },
-                default: '',
-            },
-            {
-                displayName: 'Secret Access Key',
-                name: 'secretAccessKey',
+                displayName: 'S3 Endpoint',
+                name: 'endpoint',
                 type: 'string',
-                typeOptions: { password: true },
                 default: '',
+                description: 'S3-compatible service endpoint (e.g., https://s3.amazonaws.com, https://minio.example.com)',
             },
             {
                 displayName: 'Region',
                 name: 'region',
                 type: 'string',
                 default: 'us-east-1',
-                description: 'AWS region (e.g., us-east-1, eu-west-1)',
+                description: 'AWS region or custom region for S3-compatible service',
             },
             {
-                displayName: 'S3 Endpoint',
-                name: 's3Api',
+                displayName: 'Access Key ID',
+                name: 'accessKeyId',
+                type: 'string',
+                default: '',
+            },
+            {
+                displayName: 'Secret Access Key',
+                name: 'secretAccessKey',
                 type: 'string',
                 default: '',
-                placeholder: 'https://s3.amazonaws.com',
-                description: 'S3-compatible service endpoint (required for MinIO, DigitalOcean Spaces, Wasabi, etc.). Leave empty for AWS S3.',
+                typeOptions: {
+                    password: true,
+                },
+            },
+            {
+                displayName: 'Force Path Style',
+                name: 'forcePathStyle',
+                type: 'boolean',
+                default: false,
+                description: 'Use path-style addressing (required for MinIO, DigitalOcean Spaces, etc.)',
             },
         ];
         this.test = {
             request: {
-                baseURL: '={{$credentials.s3Api}}',
+                baseURL: '={{$credentials.endpoint}}',
                 url: '=/',
                 method: 'GET',
             },

package/dist/drivers/index.js

@@ -17,20 +17,23 @@ async function createStorageDriver(context, bucket) {
     const creds = credentials;
     const accessKeyId = creds.accessKeyId || '';
     const secretAccessKey = creds.secretAccessKey || '';
-    const credentialEndpoint = creds.s3Api;
+    const credentialEndpoint = creds.endpoint;
     const credentialRegion = creds.region;
-    // Use credential endpoint if node parameter is empty
+    // Convert forcePathStyle from credential (could be string or boolean)
+    const credentialForcePathStyle = String(creds.forcePathStyle) === 'true';
+    // Use credential values if node parameters are empty
     const finalEndpoint = endpoint || credentialEndpoint;
-    // Use credential region if node parameter is empty
     const finalRegion = region || credentialRegion || 'us-east-1';
+    // Use boolean OR to combine forcePathStyle from node and credential
+    const finalForcePathStyle = forcePathStyle || credentialForcePathStyle || false;
     if (!accessKeyId || !secretAccessKey) {
         throw new Error('Invalid credentials. Missing access key or secret key.');
     }
     // Auto-determine if path style should be forced
-    let shouldForcePathStyle = forcePathStyle;
+    let shouldForcePathStyle = finalForcePathStyle;
     // Force path style by default if custom endpoint is provided
     // This is needed for MinIO, Wasabi, DigitalOcean Spaces, Alibaba OSS, Tencent COS, etc.
-    if (finalEndpoint && finalEndpoint !== '') {
+    if (finalEndpoint && finalEndpoint !== '' && !finalForcePathStyle) {
         shouldForcePathStyle = true;
     }
     const config = {

package/dist/nodes/BinaryToUrl/BinaryToUrl.node.js

@@ -254,7 +254,12 @@ class BinaryToUrl {
 exports.BinaryToUrl = BinaryToUrl;
 async function handleUpload(context, items, storage) {
     const binaryPropertyName = context.getNodeParameter('binaryPropertyName', 0);
-    const webhookBaseUrl = buildWebhookUrl(context, 'default', 'file');
+    // Build webhook URL using n8n's instance base URL and workflow ID
+    // Format: {baseUrl}/webhook/{workflowId}/file/:fileKey
+    const baseUrl = context.getInstanceBaseUrl();
+    const workflow = context.getWorkflow();
+    const workflowId = workflow.id;
+    const webhookUrl = `${baseUrl}/webhook/${workflowId}/file/:fileKey`;
     const returnData = [];
     for (const item of items) {
         const binaryData = item.binary?.[binaryPropertyName];
@@ -272,7 +277,8 @@ async function handleUpload(context, items, storage) {
             throw new n8n_workflow_1.NodeOperationError(context.getNode(), `File size exceeds maximum limit of ${MAX_FILE_SIZE / 1024 / 1024}MB`);
         }
         const result = await storage.uploadStream(buffer, contentType);
-        const proxyUrl = `${webhookBaseUrl}/${result.fileKey}`;
+        // Replace the :fileKey placeholder with the actual file key
+        const proxyUrl = webhookUrl.replace(':fileKey', result.fileKey);
         returnData.push({
             json: {
                 fileKey: result.fileKey,
@@ -302,14 +308,6 @@ async function handleDelete(context, items, storage) {
     }
     return [returnData];
 }
-function buildWebhookUrl(context, webhookName, path) {
-    const baseUrl = context.getInstanceBaseUrl();
-    const node = context.getNode();
-    const workflow = context.getWorkflow();
-    const workflowId = workflow.id;
-    const nodeName = encodeURIComponent(node.name.toLowerCase());
-    return `${baseUrl}/webhook/${workflowId}/${nodeName}/${path}`;
-}
 function isValidFileKey(fileKey) {
     if (!fileKey || typeof fileKey !== 'string') {
         return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "n8n-nodes-binary-to-url",
-  "version": "0.0.7",
+  "version": "0.0.9",
   "description": "n8n community node for binary file to public URL bridge with S3 storage",
   "keywords": [
     "n8n-community-node-package",