mysql2 3.19.2-canary.f4ce16ab → 3.20.0

package/lib/auth_plugins/caching_sha2_password.js

@@ -36,6 +36,7 @@ function encrypt(password, scramble, key) {
   return crypto.publicEncrypt(
     {
       key,
+      oaepHash: 'sha1',
       padding: crypto.constants.RSA_PKCS1_OAEP_PADDING,
     },
     stage1

package/lib/auth_plugins/sha256_password.js

@@ -13,7 +13,13 @@ const STATE_FINAL = -1;
 
 function encrypt(password, scramble, key) {
   const stage1 = xorRotating(Buffer.from(`${password}\0`, 'utf8'), scramble);
-  return crypto.publicEncrypt(key, stage1);
+  return crypto.publicEncrypt(
+    {
+      key,
+      oaepHash: 'sha1',
+    },
+    stage1
+  );
 }
 
 module.exports =

package/lib/base/pool.js

@@ -62,7 +62,10 @@ class BasePool extends EventEmitter {
       if (this._freeConnections.length > 0) {
         connection = this._freeConnections.pop();
         this.emit('acquire', connection);
-        return process.nextTick(() => cb(null, connection));
+        return process.nextTick(() => {
+          connection._released = false;
+          cb(null, connection);
+        });
       }
       if (
         this.config.connectionLimit === 0 ||
@@ -126,7 +129,10 @@ class BasePool extends EventEmitter {
       }
     } else if (this._connectionQueue.length) {
       cb = this._connectionQueue.shift();
-      process.nextTick(cb.bind(null, null, connection));
+      process.nextTick(() => {
+        connection._released = false;
+        cb(null, connection);
+      });
     } else {
       this._freeConnections.push(connection);
       this.emit('release', connection);

package/lib/pool_connection.js

@@ -6,6 +6,7 @@ class PoolConnection extends Connection {
   constructor(pool, options) {
     super(options);
     this._pool = pool;
+    this._released = false;
     this.lastActiveTime = Date.now();
     this.once('end', () => {
       this._removeFromPool();
@@ -16,9 +17,13 @@ class PoolConnection extends Connection {
   }
 
   release() {
+    if (this._released) {
+      return;
+    }
     if (!this._pool || this._pool._closed) {
       return;
     }
+    this._released = true;
     this.lastActiveTime = Date.now();
     this._pool.releaseConnection(this);
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mysql2",
-  "version": "3.19.2-canary.f4ce16ab",
+  "version": "3.20.0",
   "description": "fast mysql driver. Implements core protocol, prepared statements, ssl and compression in native JS",
   "main": "index.js",
   "typings": "typings/mysql/index",