myrlin-workbook 0.9.29 → 0.9.30

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "myrlin-workbook",
-  "version": "0.9.29",
+  "version": "0.9.30",
   "description": "Browser-based project manager for Claude Code sessions - session discovery, multi-terminal, cost tracking, docs, and kanban board",
   "main": "src/index.js",
   "bin": {

package/scripts/postinstall.js

@@ -1,37 +1,77 @@
-#!/usr/bin/env node
-/**
- * Postinstall script: fix node-pty spawn-helper permissions on macOS/Linux.
- * The prebuilt spawn-helper binary ships without execute permission (644),
- * causing posix_spawnp failures. This sets it to 755.
- * See: https://github.com/therealarthur/myrlin-workbook/issues/4
- */
-'use strict';
-
-if (process.platform === 'win32') {
-  process.exit(0);
-}
-
-const { execSync } = require('child_process');
-const path = require('path');
-const fs = require('fs');
-
-const prebuildsDir = path.join(__dirname, '..', 'node_modules', 'node-pty', 'prebuilds');
-
-if (!fs.existsSync(prebuildsDir)) {
-  process.exit(0);
-}
-
-try {
-  // Find all spawn-helper binaries across platform dirs and chmod +x them
-  const dirs = fs.readdirSync(prebuildsDir, { withFileTypes: true })
-    .filter(d => d.isDirectory());
-
-  for (const dir of dirs) {
-    const helper = path.join(prebuildsDir, dir.name, 'spawn-helper');
-    if (fs.existsSync(helper)) {
-      execSync(`chmod +x "${helper}"`, { stdio: 'ignore' });
-    }
-  }
-} catch (_) {
-  // Non-fatal: if chmod fails, user can still manually fix
-}
+#!/usr/bin/env node
+/**
+ * Postinstall script: fix node-pty spawn-helper permissions on macOS/Linux.
+ *
+ * The prebuilt spawn-helper binary in node-pty's package ships without
+ * execute permission (mode 644 instead of 755), causing posix_spawnp to
+ * fail with "posix_spawnp failed" on first PTY spawn.
+ *
+ * This is a known node-pty packaging issue. We work around it here by
+ * locating node-pty (wherever npm/npx hoisted it), finding all prebuilt
+ * spawn-helper binaries across platform dirs, and setting them to 755.
+ *
+ * See: https://github.com/therealarthur/myrlin-workbook/issues/4
+ */
+'use strict';
+
+if (process.platform === 'win32') {
+  process.exit(0);
+}
+
+const path = require('path');
+const fs = require('fs');
+
+/**
+ * Locate node-pty's package directory using require.resolve.
+ * Works regardless of where npm/npx/yarn placed it (hoisted, nested,
+ * pnp-virtual, etc.). Returns null if node-pty isn't installed.
+ */
+function findNodePtyDir() {
+  try {
+    const ptyMain = require.resolve('node-pty', { paths: [path.join(__dirname, '..')] });
+    let dir = path.dirname(ptyMain);
+    // Walk up until we find package.json with "name": "node-pty"
+    for (let i = 0; i < 8; i++) {
+      const pkg = path.join(dir, 'package.json');
+      if (fs.existsSync(pkg)) {
+        try {
+          const json = JSON.parse(fs.readFileSync(pkg, 'utf8'));
+          if (json && json.name === 'node-pty') return dir;
+        } catch (_) {}
+      }
+      const parent = path.dirname(dir);
+      if (parent === dir) break;
+      dir = parent;
+    }
+  } catch (_) {}
+  return null;
+}
+
+const ptyDir = findNodePtyDir();
+if (!ptyDir) {
+  // node-pty not installed yet (rare during postinstall); skip silently.
+  process.exit(0);
+}
+
+const prebuildsDir = path.join(ptyDir, 'prebuilds');
+if (!fs.existsSync(prebuildsDir)) {
+  process.exit(0);
+}
+
+try {
+  const platforms = fs.readdirSync(prebuildsDir, { withFileTypes: true })
+    .filter(d => d.isDirectory());
+
+  for (const platform of platforms) {
+    const helper = path.join(prebuildsDir, platform.name, 'spawn-helper');
+    if (fs.existsSync(helper)) {
+      try {
+        fs.chmodSync(helper, 0o755);
+      } catch (_) {
+        // Non-fatal: runtime fix will catch this on first PTY spawn
+      }
+    }
+  }
+} catch (_) {
+  // Non-fatal
+}

package/src/web/pty-manager.js

@@ -11,10 +11,52 @@
  *   - Scrollback is capped at ~100KB total characters
  */
 
-const pty = require('node-pty');
 const fs = require('fs');
 const os = require('os');
 const path = require('path');
+
+// Ensure node-pty's prebuilt spawn-helper is executable BEFORE requiring node-pty.
+// node-pty's prebuild ships with mode 644 instead of 755, causing posix_spawnp
+// to fail on macOS/Linux. The postinstall script handles this in normal installs
+// but doesn't run with --ignore-scripts or in some npx caches. This runtime
+// fallback covers those cases. See: https://github.com/therealarthur/myrlin-workbook/issues/4
+if (process.platform !== 'win32') {
+  try {
+    const ptyMain = require.resolve('node-pty');
+    let dir = path.dirname(ptyMain);
+    for (let i = 0; i < 8; i++) {
+      const pkg = path.join(dir, 'package.json');
+      if (fs.existsSync(pkg)) {
+        try {
+          const json = JSON.parse(fs.readFileSync(pkg, 'utf8'));
+          if (json && json.name === 'node-pty') break;
+        } catch (_) {}
+      }
+      const parent = path.dirname(dir);
+      if (parent === dir) { dir = null; break; }
+      dir = parent;
+    }
+    if (dir) {
+      const prebuildsDir = path.join(dir, 'prebuilds');
+      if (fs.existsSync(prebuildsDir)) {
+        for (const p of fs.readdirSync(prebuildsDir)) {
+          const helper = path.join(prebuildsDir, p, 'spawn-helper');
+          if (fs.existsSync(helper)) {
+            try {
+              const stat = fs.statSync(helper);
+              // Only chmod if not already executable, avoids unnecessary syscalls
+              if ((stat.mode & 0o111) === 0) fs.chmodSync(helper, 0o755);
+            } catch (_) {}
+          }
+        }
+      }
+    }
+  } catch (_) {
+    // node-pty not yet resolvable; require() below will throw with a clearer error
+  }
+}
+
+const pty = require('node-pty');
 const { getStore } = require('../state/store');
 
 /**