mvcc-api 1.2.2 → 1.2.3

package/dist/cjs/index.cjs

@@ -84,6 +84,19 @@ var MVCCTransaction = class {
   isRoot() {
     return !this.parent;
   }
+  /**
+   * Checks if any ancestor transaction has already been committed.
+   * A nested transaction cannot commit if its parent or any higher ancestor is committed.
+   * @returns True if at least one ancestor is committed, false otherwise.
+   */
+  hasCommittedAncestor() {
+    let current = this.parent;
+    while (current) {
+      if (current.committed) return true;
+      current = current.parent;
+    }
+    return false;
+  }
   // --- Internal buffer manipulation helpers ---
   _bufferCreate(key, value) {
     this.localVersion++;
@@ -106,12 +119,7 @@ var MVCCTransaction = class {
     this.createdKeys.delete(key);
     this.keyVersions.set(key, this.localVersion);
   }
-  /**
-   * Rolls back the transaction.
-   * Clears all buffers and marks the transaction as finished.
-   * @returns The result object with success, created, updated, and deleted keys.
-   */
-  rollback() {
+  _getResultEntries() {
     const created = [];
     const updated = [];
     for (const [key, data] of this.writeBuffer.entries()) {
@@ -129,6 +137,15 @@ var MVCCTransaction = class {
         deleted.push({ key, data });
       }
     }
+    return { created, updated, deleted };
+  }
+  /**
+   * Rolls back the transaction.
+   * Clears all buffers and marks the transaction as finished.
+   * @returns The result object with success, created, updated, and deleted keys.
+   */
+  rollback() {
+    const { created, updated, deleted } = this._getResultEntries();
     this.writeBuffer.clear();
     this.deleteBuffer.clear();
     this.createdKeys.clear();
@@ -223,30 +240,17 @@ var SyncMVCCTransaction = class _SyncMVCCTransaction extends MVCCTransaction {
     }
   }
   commit() {
+    const { created, updated, deleted } = this._getResultEntries();
     if (this.committed) {
-      return { success: false, error: "Transaction already committed", created: [], updated: [], deleted: [] };
-    }
-    const created = [];
-    const updated = [];
-    for (const [key, data] of this.writeBuffer.entries()) {
-      if (this.createdKeys.has(key)) {
-        created.push({ key, data });
-      } else {
-        updated.push({ key, data });
-      }
+      return { success: false, error: "Transaction already committed", created, updated, deleted };
     }
-    const deleted = [];
-    for (const key of this.deleteBuffer) {
-      if (!this.originallyExisted.has(key)) continue;
-      const data = this.deletedValues.get(key);
-      if (data !== void 0) {
-        deleted.push({ key, data });
-      }
+    if (this.hasCommittedAncestor()) {
+      return { success: false, error: "Ancestor transaction already committed", created, updated, deleted };
     }
     if (this.parent) {
       const error = this.parent._merge(this);
       if (error) {
-        return { success: false, error, created: [], updated: [], deleted: [] };
+        return { success: false, error, created, updated, deleted };
       }
       this.committed = true;
     } else {
@@ -776,30 +780,17 @@ var AsyncMVCCTransaction = class _AsyncMVCCTransaction extends MVCCTransaction {
   }
   async commit() {
     return this.writeLock(async () => {
+      const { created, updated, deleted } = this._getResultEntries();
       if (this.committed) {
-        return { success: false, error: "Transaction already committed", created: [], updated: [], deleted: [] };
-      }
-      const created = [];
-      const updated = [];
-      for (const [key, data] of this.writeBuffer.entries()) {
-        if (this.createdKeys.has(key)) {
-          created.push({ key, data });
-        } else {
-          updated.push({ key, data });
-        }
+        return { success: false, error: "Transaction already committed", created, updated, deleted };
       }
-      const deleted = [];
-      for (const key of this.deleteBuffer) {
-        if (!this.originallyExisted.has(key)) continue;
-        const data = this.deletedValues.get(key);
-        if (data !== void 0) {
-          deleted.push({ key, data });
-        }
+      if (this.hasCommittedAncestor()) {
+        return { success: false, error: "Ancestor transaction already committed", created, updated, deleted };
       }
       if (this.parent) {
         const error = await this.parent._merge(this);
         if (error) {
-          return { success: false, error, created: [], updated: [], deleted: [] };
+          return { success: false, error, created, updated, deleted };
         }
         this.committed = true;
       } else {

package/dist/esm/index.mjs

@@ -55,6 +55,19 @@ var MVCCTransaction = class {
   isRoot() {
     return !this.parent;
   }
+  /**
+   * Checks if any ancestor transaction has already been committed.
+   * A nested transaction cannot commit if its parent or any higher ancestor is committed.
+   * @returns True if at least one ancestor is committed, false otherwise.
+   */
+  hasCommittedAncestor() {
+    let current = this.parent;
+    while (current) {
+      if (current.committed) return true;
+      current = current.parent;
+    }
+    return false;
+  }
   // --- Internal buffer manipulation helpers ---
   _bufferCreate(key, value) {
     this.localVersion++;
@@ -77,12 +90,7 @@ var MVCCTransaction = class {
     this.createdKeys.delete(key);
     this.keyVersions.set(key, this.localVersion);
   }
-  /**
-   * Rolls back the transaction.
-   * Clears all buffers and marks the transaction as finished.
-   * @returns The result object with success, created, updated, and deleted keys.
-   */
-  rollback() {
+  _getResultEntries() {
     const created = [];
     const updated = [];
     for (const [key, data] of this.writeBuffer.entries()) {
@@ -100,6 +108,15 @@ var MVCCTransaction = class {
         deleted.push({ key, data });
       }
     }
+    return { created, updated, deleted };
+  }
+  /**
+   * Rolls back the transaction.
+   * Clears all buffers and marks the transaction as finished.
+   * @returns The result object with success, created, updated, and deleted keys.
+   */
+  rollback() {
+    const { created, updated, deleted } = this._getResultEntries();
     this.writeBuffer.clear();
     this.deleteBuffer.clear();
     this.createdKeys.clear();
@@ -194,30 +211,17 @@ var SyncMVCCTransaction = class _SyncMVCCTransaction extends MVCCTransaction {
     }
   }
   commit() {
+    const { created, updated, deleted } = this._getResultEntries();
     if (this.committed) {
-      return { success: false, error: "Transaction already committed", created: [], updated: [], deleted: [] };
-    }
-    const created = [];
-    const updated = [];
-    for (const [key, data] of this.writeBuffer.entries()) {
-      if (this.createdKeys.has(key)) {
-        created.push({ key, data });
-      } else {
-        updated.push({ key, data });
-      }
+      return { success: false, error: "Transaction already committed", created, updated, deleted };
     }
-    const deleted = [];
-    for (const key of this.deleteBuffer) {
-      if (!this.originallyExisted.has(key)) continue;
-      const data = this.deletedValues.get(key);
-      if (data !== void 0) {
-        deleted.push({ key, data });
-      }
+    if (this.hasCommittedAncestor()) {
+      return { success: false, error: "Ancestor transaction already committed", created, updated, deleted };
     }
     if (this.parent) {
       const error = this.parent._merge(this);
       if (error) {
-        return { success: false, error, created: [], updated: [], deleted: [] };
+        return { success: false, error, created, updated, deleted };
       }
       this.committed = true;
     } else {
@@ -747,30 +751,17 @@ var AsyncMVCCTransaction = class _AsyncMVCCTransaction extends MVCCTransaction {
   }
   async commit() {
     return this.writeLock(async () => {
+      const { created, updated, deleted } = this._getResultEntries();
       if (this.committed) {
-        return { success: false, error: "Transaction already committed", created: [], updated: [], deleted: [] };
-      }
-      const created = [];
-      const updated = [];
-      for (const [key, data] of this.writeBuffer.entries()) {
-        if (this.createdKeys.has(key)) {
-          created.push({ key, data });
-        } else {
-          updated.push({ key, data });
-        }
+        return { success: false, error: "Transaction already committed", created, updated, deleted };
       }
-      const deleted = [];
-      for (const key of this.deleteBuffer) {
-        if (!this.originallyExisted.has(key)) continue;
-        const data = this.deletedValues.get(key);
-        if (data !== void 0) {
-          deleted.push({ key, data });
-        }
+      if (this.hasCommittedAncestor()) {
+        return { success: false, error: "Ancestor transaction already committed", created, updated, deleted };
       }
       if (this.parent) {
         const error = await this.parent._merge(this);
         if (error) {
-          return { success: false, error, created: [], updated: [], deleted: [] };
+          return { success: false, error, created, updated, deleted };
         }
         this.committed = true;
       } else {

package/dist/types/core/base/Transaction.d.ts

@@ -1,4 +1,4 @@
-import type { Deferred, TransactionResult } from '../../types';
+import type { Deferred, TransactionResult, TransactionEntry } from '../../types';
 import type { MVCCStrategy } from './Strategy';
 /**
  * MVCC Transaction abstract class.
@@ -34,6 +34,12 @@ export declare abstract class MVCCTransaction<S extends MVCCStrategy<K, T>, K, T
     protected activeTransactions: Set<MVCCTransaction<S, K, T>>;
     constructor(strategy?: S, parent?: MVCCTransaction<S, K, T>, snapshotVersion?: number);
     isRoot(): boolean;
+    /**
+     * Checks if any ancestor transaction has already been committed.
+     * A nested transaction cannot commit if its parent or any higher ancestor is committed.
+     * @returns True if at least one ancestor is committed, false otherwise.
+     */
+    hasCommittedAncestor(): boolean;
     /**
      * Schedules a creation (insert) of a key-value pair.
      * Throws if the key already exists.
@@ -60,6 +66,11 @@ export declare abstract class MVCCTransaction<S extends MVCCStrategy<K, T>, K, T
     protected _bufferCreate(key: K, value: T): void;
     protected _bufferWrite(key: K, value: T): void;
     protected _bufferDelete(key: K): void;
+    protected _getResultEntries(): {
+        created: TransactionEntry<K, T>[];
+        updated: TransactionEntry<K, T>[];
+        deleted: TransactionEntry<K, T>[];
+    };
     /**
      * Rolls back the transaction.
      * Clears all buffers and marks the transaction as finished.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mvcc-api",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Multiversion Concurrency Control (MVCC) API for TypeScript",
   "license": "MIT",
   "author": "izure <admin@izure.org>",