musubi-sdd 5.0.0 → 5.6.1

package/src/agents/agentic/code-reviewer.js

@@ -17,7 +17,7 @@ const SEVERITY = {
   INFO: 'info',
   WARNING: 'warning',
   ERROR: 'error',
-  CRITICAL: 'critical'
+  CRITICAL: 'critical',
 };
 
 /**
@@ -32,7 +32,7 @@ const CATEGORY = {
   MAINTAINABILITY: 'maintainability',
   BEST_PRACTICE: 'best-practice',
   ERROR_HANDLING: 'error-handling',
-  DOCUMENTATION: 'documentation'
+  DOCUMENTATION: 'documentation',
 };
 
 /**
@@ -78,7 +78,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.BEST_PRACTICE,
       severity: SEVERITY.WARNING,
       message: 'Use const or let instead of var',
-      suggestion: 'Replace var with const or let'
+      suggestion: 'Replace var with const or let',
     },
     {
       id: 'js-console-log',
@@ -86,7 +86,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.BEST_PRACTICE,
       severity: SEVERITY.INFO,
       message: 'Console statements should be removed in production',
-      suggestion: 'Remove or replace with proper logging'
+      suggestion: 'Remove or replace with proper logging',
     },
     {
       id: 'js-eval',
@@ -94,7 +94,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.SECURITY,
       severity: SEVERITY.CRITICAL,
       message: 'eval() is dangerous and should be avoided',
-      suggestion: 'Use safer alternatives to eval()'
+      suggestion: 'Use safer alternatives to eval()',
     },
     {
       id: 'js-todo',
@@ -102,7 +102,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.MAINTAINABILITY,
       severity: SEVERITY.INFO,
       message: 'TODO comment found',
-      suggestion: 'Complete or track the TODO item'
+      suggestion: 'Complete or track the TODO item',
     },
     {
       id: 'js-empty-catch',
@@ -110,7 +110,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.ERROR_HANDLING,
       severity: SEVERITY.ERROR,
       message: 'Empty catch block swallows errors',
-      suggestion: 'Handle or log the caught error'
+      suggestion: 'Handle or log the caught error',
     },
     {
       id: 'js-magic-number',
@@ -118,7 +118,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.MAINTAINABILITY,
       severity: SEVERITY.INFO,
       message: 'Magic number should be extracted to a named constant',
-      suggestion: 'Define a constant with a descriptive name'
+      suggestion: 'Define a constant with a descriptive name',
     },
     {
       id: 'js-long-function',
@@ -127,7 +127,7 @@ const DEFAULT_RULES = {
       severity: SEVERITY.WARNING,
       message: 'Function may be too long',
       checkLength: true,
-      maxLength: 50
+      maxLength: 50,
     },
     {
       id: 'js-no-strict',
@@ -136,10 +136,10 @@ const DEFAULT_RULES = {
       category: CATEGORY.BEST_PRACTICE,
       severity: SEVERITY.WARNING,
       message: 'Consider adding "use strict"',
-      condition: (code) => !code.includes("'use strict'") && !code.includes('"use strict"')
-    }
+      condition: code => !code.includes("'use strict'") && !code.includes('"use strict"'),
+    },
   ],
-  
+
   python: [
     {
       id: 'py-except-bare',
@@ -147,7 +147,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.ERROR_HANDLING,
       severity: SEVERITY.WARNING,
       message: 'Bare except catches all exceptions',
-      suggestion: 'Specify the exception type to catch'
+      suggestion: 'Specify the exception type to catch',
     },
     {
       id: 'py-print',
@@ -155,7 +155,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.BEST_PRACTICE,
       severity: SEVERITY.INFO,
       message: 'Print statements should use logging in production',
-      suggestion: 'Use logging module instead'
+      suggestion: 'Use logging module instead',
     },
     {
       id: 'py-todo',
@@ -163,7 +163,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.MAINTAINABILITY,
       severity: SEVERITY.INFO,
       message: 'TODO comment found',
-      suggestion: 'Complete or track the TODO item'
+      suggestion: 'Complete or track the TODO item',
     },
     {
       id: 'py-global',
@@ -171,10 +171,10 @@ const DEFAULT_RULES = {
       category: CATEGORY.BEST_PRACTICE,
       severity: SEVERITY.WARNING,
       message: 'Global variables should be avoided',
-      suggestion: 'Consider using class or function parameters'
-    }
+      suggestion: 'Consider using class or function parameters',
+    },
   ],
-  
+
   common: [
     {
       id: 'common-fixme',
@@ -182,7 +182,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.MAINTAINABILITY,
       severity: SEVERITY.WARNING,
       message: 'FIXME comment found - needs attention',
-      suggestion: 'Address the FIXME issue'
+      suggestion: 'Address the FIXME issue',
     },
     {
       id: 'common-hack',
@@ -190,7 +190,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.MAINTAINABILITY,
       severity: SEVERITY.WARNING,
       message: 'HACK comment found - technical debt',
-      suggestion: 'Refactor the hack'
+      suggestion: 'Refactor the hack',
     },
     {
       id: 'common-password',
@@ -198,7 +198,7 @@ const DEFAULT_RULES = {
       category: CATEGORY.SECURITY,
       severity: SEVERITY.CRITICAL,
       message: 'Hardcoded password detected',
-      suggestion: 'Use environment variables or secure vault'
+      suggestion: 'Use environment variables or secure vault',
     },
     {
       id: 'common-api-key',
@@ -206,9 +206,9 @@ const DEFAULT_RULES = {
       category: CATEGORY.SECURITY,
       severity: SEVERITY.CRITICAL,
       message: 'Hardcoded API key detected',
-      suggestion: 'Use environment variables'
-    }
-  ]
+      suggestion: 'Use environment variables',
+    },
+  ],
 };
 
 /**
@@ -222,24 +222,24 @@ class CodeReviewer extends EventEmitter {
    */
   constructor(options = {}) {
     super();
-    
+
     this.rules = this.mergeRules(DEFAULT_RULES, options.rules || {});
     this.enabledCategories = options.enabledCategories || Object.values(CATEGORY);
     this.minScore = options.minScore ?? 70;
     this.strictMode = options.strictMode ?? false;
-    
+
     // State
     this.reviews = new Map();
     this.reviewCounter = 0;
   }
-  
+
   /**
    * Merge custom rules with defaults
    * @private
    */
   mergeRules(defaults, custom) {
     const merged = { ...defaults };
-    
+
     for (const [lang, rules] of Object.entries(custom)) {
       if (merged[lang]) {
         merged[lang] = [...merged[lang], ...rules];
@@ -247,10 +247,10 @@ class CodeReviewer extends EventEmitter {
         merged[lang] = rules;
       }
     }
-    
+
     return merged;
   }
-  
+
   /**
    * Review code
    * @param {string} code - Code to review
@@ -261,34 +261,31 @@ class CodeReviewer extends EventEmitter {
     const id = this.generateId();
     const language = options.language || this.detectLanguage(code, options.filePath);
     const filePath = options.filePath || 'unknown';
-    
+
     this.emit('review:start', { id, filePath, language });
-    
+
     const issues = [];
-    
+
     // Get applicable rules
-    const rules = [
-      ...(this.rules[language] || []),
-      ...(this.rules.common || [])
-    ];
-    
+    const rules = [...(this.rules[language] || []), ...(this.rules.common || [])];
+
     // Apply each rule
     for (const rule of rules) {
       // Check if category is enabled
       if (!this.enabledCategories.includes(rule.category)) continue;
-      
+
       // Apply rule
       const ruleIssues = this.applyRule(rule, code, language);
       issues.push(...ruleIssues);
     }
-    
+
     // Run additional checks
     const structuralIssues = this.checkStructure(code, language);
     issues.push(...structuralIssues);
-    
+
     // Calculate score
     const score = this.calculateScore(issues);
-    
+
     // Create result
     const result = {
       id,
@@ -297,24 +294,24 @@ class CodeReviewer extends EventEmitter {
       issues,
       score,
       summary: this.createSummary(issues, score),
-      timestamp: Date.now()
+      timestamp: Date.now(),
     };
-    
+
     // Store review
     this.reviews.set(id, result);
-    
+
     this.emit('review:complete', { result });
-    
+
     return result;
   }
-  
+
   /**
    * Apply a single rule
    * @private
    */
-  applyRule(rule, code, language) {
+  applyRule(rule, code, _language) {
     const issues = [];
-    
+
     // Handle condition-based rules
     if (rule.condition) {
       if (rule.condition(code)) {
@@ -322,33 +319,33 @@ class CodeReviewer extends EventEmitter {
       }
       return issues;
     }
-    
+
     // Handle pattern-based rules
     if (!rule.pattern) return issues;
-    
-    const lines = code.split('\n');
+
+    const _lines = code.split('\n');
     let match;
-    
+
     // Reset regex
     rule.pattern.lastIndex = 0;
-    
+
     while ((match = rule.pattern.exec(code)) !== null) {
       const line = this.getLineNumber(code, match.index);
       const column = match.index - this.getLineStart(code, line);
-      
+
       // Skip if checking length and within limit
       if (rule.checkLength) {
         const funcEnd = this.findFunctionEnd(code, match.index);
         const funcLines = code.substring(match.index, funcEnd).split('\n').length;
         if (funcLines <= rule.maxLength) continue;
       }
-      
+
       issues.push(this.createIssue(rule, line, column, match[0]));
     }
-    
+
     return issues;
   }
-  
+
   /**
    * Create an issue object
    * @private
@@ -363,10 +360,10 @@ class CodeReviewer extends EventEmitter {
       column,
       code,
       suggestion: rule.suggestion,
-      rule: rule.id
+      rule: rule.id,
     };
   }
-  
+
   /**
    * Check code structure
    * @private
@@ -374,7 +371,7 @@ class CodeReviewer extends EventEmitter {
   checkStructure(code, language) {
     const issues = [];
     const lines = code.split('\n');
-    
+
     // Check line length
     lines.forEach((line, index) => {
       if (line.length > 120) {
@@ -384,11 +381,11 @@ class CodeReviewer extends EventEmitter {
           category: CATEGORY.STYLE,
           message: `Line exceeds 120 characters (${line.length})`,
           line: index + 1,
-          suggestion: 'Break long lines for better readability'
+          suggestion: 'Break long lines for better readability',
         });
       }
     });
-    
+
     // Check for missing documentation
     if (language === 'javascript' || language === 'typescript') {
       if (!code.includes('/**') && !code.includes('//')) {
@@ -397,11 +394,11 @@ class CodeReviewer extends EventEmitter {
           severity: SEVERITY.INFO,
           category: CATEGORY.DOCUMENTATION,
           message: 'Code lacks documentation comments',
-          suggestion: 'Add JSDoc comments to functions and classes'
+          suggestion: 'Add JSDoc comments to functions and classes',
         });
       }
     }
-    
+
     // Check nesting depth
     const maxNesting = this.checkNestingDepth(code);
     if (maxNesting > 4) {
@@ -410,13 +407,13 @@ class CodeReviewer extends EventEmitter {
         severity: SEVERITY.WARNING,
         category: CATEGORY.MAINTAINABILITY,
         message: `Deep nesting detected (depth: ${maxNesting})`,
-        suggestion: 'Consider extracting nested code into separate functions'
+        suggestion: 'Consider extracting nested code into separate functions',
       });
     }
-    
+
     return issues;
   }
-  
+
   /**
    * Check nesting depth
    * @private
@@ -424,7 +421,7 @@ class CodeReviewer extends EventEmitter {
   checkNestingDepth(code) {
     let maxDepth = 0;
     let currentDepth = 0;
-    
+
     for (const char of code) {
       if (char === '{') {
         currentDepth++;
@@ -433,31 +430,31 @@ class CodeReviewer extends EventEmitter {
         currentDepth = Math.max(0, currentDepth - 1);
       }
     }
-    
+
     return maxDepth;
   }
-  
+
   /**
    * Calculate review score
    * @private
    */
   calculateScore(issues) {
     let score = 100;
-    
+
     const penalties = {
       [SEVERITY.INFO]: 1,
       [SEVERITY.WARNING]: 3,
       [SEVERITY.ERROR]: 10,
-      [SEVERITY.CRITICAL]: 25
+      [SEVERITY.CRITICAL]: 25,
     };
-    
+
     for (const issue of issues) {
       score -= penalties[issue.severity] || 0;
     }
-    
+
     return Math.max(0, score);
   }
-  
+
   /**
    * Create review summary
    * @private
@@ -465,34 +462,34 @@ class CodeReviewer extends EventEmitter {
   createSummary(issues, score) {
     const bySeverity = {};
     const byCategory = {};
-    
+
     for (const issue of issues) {
       bySeverity[issue.severity] = (bySeverity[issue.severity] || 0) + 1;
       byCategory[issue.category] = (byCategory[issue.category] || 0) + 1;
     }
-    
+
     return {
       totalIssues: issues.length,
       bySeverity,
       byCategory,
       score,
       passed: score >= this.minScore,
-      recommendation: this.getRecommendation(score, issues)
+      recommendation: this.getRecommendation(score, issues),
     };
   }
-  
+
   /**
    * Get recommendation based on score
    * @private
    */
-  getRecommendation(score, issues) {
+  getRecommendation(score, _issues) {
     if (score >= 90) return 'Excellent! Code quality is high.';
     if (score >= 80) return 'Good. Minor improvements recommended.';
     if (score >= 70) return 'Acceptable. Several issues should be addressed.';
     if (score >= 50) return 'Needs work. Significant improvements required.';
     return 'Critical issues detected. Immediate attention required.';
   }
-  
+
   /**
    * Get line number from position
    * @private
@@ -500,7 +497,7 @@ class CodeReviewer extends EventEmitter {
   getLineNumber(code, position) {
     return code.substring(0, position).split('\n').length;
   }
-  
+
   /**
    * Get line start position
    * @private
@@ -513,7 +510,7 @@ class CodeReviewer extends EventEmitter {
     }
     return start;
   }
-  
+
   /**
    * Find function end position
    * @private
@@ -521,7 +518,7 @@ class CodeReviewer extends EventEmitter {
   findFunctionEnd(code, start) {
     let depth = 0;
     let inFunction = false;
-    
+
     for (let i = start; i < code.length; i++) {
       if (code[i] === '{') {
         depth++;
@@ -533,10 +530,10 @@ class CodeReviewer extends EventEmitter {
         }
       }
     }
-    
+
     return code.length;
   }
-  
+
   /**
    * Detect language
    * @private
@@ -549,19 +546,19 @@ class CodeReviewer extends EventEmitter {
         '.ts': 'typescript',
         '.py': 'python',
         '.jsx': 'javascript',
-        '.tsx': 'typescript'
+        '.tsx': 'typescript',
       };
       return langMap[ext] || 'javascript';
     }
-    
+
     // Detect from content
-    if (code.includes('def ') || code.includes('import ') && !code.includes('from \'')) {
+    if (code.includes('def ') || (code.includes('import ') && !code.includes("from '"))) {
       return 'python';
     }
-    
+
     return 'javascript';
   }
-  
+
   /**
    * Generate unique ID
    * @private
@@ -569,7 +566,7 @@ class CodeReviewer extends EventEmitter {
   generateId() {
     return `review-${Date.now().toString(36)}-${Math.random().toString(36).substr(2, 6)}`;
   }
-  
+
   /**
    * Get review by ID
    * @param {string} reviewId - Review identifier
@@ -578,7 +575,7 @@ class CodeReviewer extends EventEmitter {
   getReview(reviewId) {
     return this.reviews.get(reviewId) || null;
   }
-  
+
   /**
    * Get all reviews
    * @returns {ReviewResult[]}
@@ -586,7 +583,7 @@ class CodeReviewer extends EventEmitter {
   getAllReviews() {
     return Array.from(this.reviews.values());
   }
-  
+
   /**
    * Get statistics
    * @returns {Object}
@@ -594,16 +591,16 @@ class CodeReviewer extends EventEmitter {
   getStats() {
     const reviews = this.getAllReviews();
     const scores = reviews.map(r => r.score);
-    
+
     return {
       totalReviews: reviews.length,
       averageScore: scores.length > 0 ? scores.reduce((a, b) => a + b, 0) / scores.length : 0,
       passed: reviews.filter(r => r.summary.passed).length,
       failed: reviews.filter(r => !r.summary.passed).length,
-      totalIssues: reviews.reduce((sum, r) => sum + r.issues.length, 0)
+      totalIssues: reviews.reduce((sum, r) => sum + r.issues.length, 0),
     };
   }
-  
+
   /**
    * Add custom rule
    * @param {string} language - Language
@@ -615,14 +612,14 @@ class CodeReviewer extends EventEmitter {
     }
     this.rules[language].push(rule);
   }
-  
+
   /**
    * Clear reviews
    */
   clearReviews() {
     this.reviews.clear();
   }
-  
+
   /**
    * Export review to markdown
    * @param {string} reviewId - Review identifier
@@ -631,30 +628,30 @@ class CodeReviewer extends EventEmitter {
   exportToMarkdown(reviewId) {
     const review = this.getReview(reviewId);
     if (!review) return '';
-    
+
     let md = `# Code Review Report\n\n`;
     md += `**File:** ${review.filePath}\n`;
     md += `**Language:** ${review.language}\n`;
     md += `**Score:** ${review.score}/100 ${review.summary.passed ? '✅' : '❌'}\n\n`;
-    
+
     md += `## Summary\n\n`;
     md += `${review.summary.recommendation}\n\n`;
     md += `- Total Issues: ${review.issues.length}\n`;
     for (const [severity, count] of Object.entries(review.summary.bySeverity)) {
       md += `- ${severity}: ${count}\n`;
     }
-    
+
     if (review.issues.length > 0) {
       md += `\n## Issues\n\n`;
-      
+
       for (const issue of review.issues) {
         const icon = {
           [SEVERITY.INFO]: 'ℹ️',
           [SEVERITY.WARNING]: '⚠️',
           [SEVERITY.ERROR]: '❌',
-          [SEVERITY.CRITICAL]: '🚨'
+          [SEVERITY.CRITICAL]: '🚨',
         }[issue.severity];
-        
+
         md += `### ${icon} ${issue.message}\n\n`;
         md += `- **Severity:** ${issue.severity}\n`;
         md += `- **Category:** ${issue.category}\n`;
@@ -663,7 +660,7 @@ class CodeReviewer extends EventEmitter {
         md += `\n`;
       }
     }
-    
+
     return md;
   }
 }
@@ -694,5 +691,5 @@ module.exports = {
   reviewCode,
   SEVERITY,
   CATEGORY,
-  DEFAULT_RULES
+  DEFAULT_RULES,
 };

package/src/agents/agentic/index.js

@@ -12,7 +12,7 @@ const {
   generateCode,
   GEN_MODE,
   LANGUAGE,
-  TEMPLATES
+  TEMPLATES,
 } = require('./code-generator');
 
 const {
@@ -21,7 +21,7 @@ const {
   reviewCode,
   SEVERITY,
   CATEGORY,
-  DEFAULT_RULES
+  DEFAULT_RULES,
 } = require('./code-reviewer');
 
 module.exports = {
@@ -32,12 +32,12 @@ module.exports = {
   GEN_MODE,
   LANGUAGE,
   TEMPLATES,
-  
+
   // Code Reviewer
   CodeReviewer,
   createCodeReviewer,
   reviewCode,
   SEVERITY,
   CATEGORY,
-  DEFAULT_RULES
+  DEFAULT_RULES,
 };