mustard-claude 3.1.28 → 3.1.29

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mustard-claude",
-  "version": "3.1.28",
+  "version": "3.1.29",
   "description": "Framework-agnostic CLI for Claude Code project setup",
   "type": "module",
   "bin": {

package/templates/hooks/__tests__/hooks.test.js

@@ -1814,21 +1814,19 @@ describe("knowledge-extract prescriptions", () => {
     }];
 
     const patterns = extractPatternsFromStates(states);
-    // retries > 2 triggers the high-retry entry
-    const retryEntry = patterns.find(p => p.name === "high-retry-login-feature");
-    assert.ok(retryEntry, "Expected high-retry entry");
+    // retries > 2 triggers the high-hook-retry entry
+    const retryEntry = patterns.find(p => p.name === "high-hook-retry-login-feature");
+    assert.ok(retryEntry, "Expected high-hook-retry entry");
     assert.ok(retryEntry.prescription, "Expected prescription field");
     assert.ok(
       /delegate investigation via Task\(general-purpose\)/.test(retryEntry.prescription),
       "Prescription should instruct delegation via Task(general-purpose)"
     );
     assert.ok(retryEntry.tags.includes("prescriptive"), "Tags should include 'prescriptive'");
-    // Back-compat: original tags preserved
-    assert.ok(retryEntry.tags.includes("retry"));
+    assert.ok(retryEntry.tags.includes("hook-retry"));
     assert.ok(retryEntry.tags.includes("pipeline"));
     assert.ok(retryEntry.tags.includes("lesson"));
-    // Back-compat: description still present
-    assert.ok(retryEntry.description.includes("4 retries"));
+    assert.ok(retryEntry.description.includes("4 hook-level retries"));
   });
 
   it("should emit fragmentation prescription when apiCalls > 50 AND retries > 3", () => {
@@ -1843,7 +1841,7 @@ describe("knowledge-extract prescriptions", () => {
     }];
 
     const patterns = extractPatternsFromStates(states);
-    // apiCalls > 50 triggers heavy-pipeline; retries > 2 also triggers high-retry.
+    // apiCalls > 50 triggers heavy-pipeline; retries > 2 also triggers high-hook-retry.
     const heavyEntry = patterns.find(p => p.name === "heavy-pipeline-big-refactor");
     assert.ok(heavyEntry, "Expected heavy-pipeline entry");
     assert.ok(heavyEntry.prescription, "Expected prescription field");
@@ -1858,7 +1856,7 @@ describe("knowledge-extract prescriptions", () => {
   });
 
   it("should emit reactive-iteration prescription when Edit > 15 and Write < 3", () => {
-    // Edit=20 > 15, Write=1 < 3, retries=3 to trigger the high-retry entry
+    // Edit=20 > 15, Write=1 < 3, retries=3 to trigger the high-hook-retry entry
     // (needs retries > 2 OR apiCalls > 50 to produce any entry at all).
     // Pick retries=3 and small Bash/Agent to avoid L0-violation heuristic dominance
     // but note: the heuristic checks order — L0 fires first if bash+edit>3*agent AND retries>2.
@@ -1873,8 +1871,8 @@ describe("knowledge-extract prescriptions", () => {
     }];
 
     const patterns = extractPatternsFromStates(states);
-    const retryEntry = patterns.find(p => p.name === "high-retry-tweak-hell");
-    assert.ok(retryEntry, "Expected high-retry entry");
+    const retryEntry = patterns.find(p => p.name === "high-hook-retry-tweak-hell");
+    assert.ok(retryEntry, "Expected high-hook-retry entry");
     assert.ok(retryEntry.prescription, "Expected prescription field");
     assert.ok(
       /investigate with Read\+Grep BEFORE editing/.test(retryEntry.prescription),
@@ -1884,7 +1882,7 @@ describe("knowledge-extract prescriptions", () => {
   });
 
   it("should NOT add prescription or prescriptive tag when no heuristic matches", () => {
-    // retries=3 to trigger high-retry entry, but balanced tools so none of the
+    // retries=3 to trigger high-hook-retry entry, but balanced tools so none of the
     // heuristics fire (edit<=15, apiCalls<=50, bash+edit not >3*agent).
     const states = [{
       specName: "mild-case",
@@ -1896,13 +1894,12 @@ describe("knowledge-extract prescriptions", () => {
     }];
 
     const patterns = extractPatternsFromStates(states);
-    const retryEntry = patterns.find(p => p.name === "high-retry-mild-case");
-    assert.ok(retryEntry, "Expected high-retry entry");
+    const retryEntry = patterns.find(p => p.name === "high-hook-retry-mild-case");
+    assert.ok(retryEntry, "Expected high-hook-retry entry");
     assert.equal(retryEntry.prescription, undefined, "No prescription when no heuristic matches");
     assert.ok(!retryEntry.tags.includes("prescriptive"),
       "'prescriptive' tag must NOT be added when no prescription");
-    // Original schema preserved
-    assert.ok(retryEntry.tags.includes("retry"));
+    assert.ok(retryEntry.tags.includes("hook-retry"));
     assert.ok(retryEntry.description);
     assert.equal(retryEntry.source, "session-knowledge");
   });

package/templates/hooks/_lib/knowledge-extract.js

@@ -82,15 +82,17 @@ function extractPatternsFromStates(stateObjects) {
     var label = state.specName || state._file || 'unknown';
     var prescription = derivePrescription(metrics);
 
-    // High retry count → lesson
+    // High hook-retry count → lesson. Counts hook/sandbox events, not agent
+    // redispatches — a clean Pass@1 pipeline can still accumulate dozens.
     if (metrics.retries && metrics.retries > 2) {
       var retryEntry = {
         type: 'convention',
-        name: 'high-retry-' + label,
-        description: 'Pipeline required ' + metrics.retries + ' retries. Tool breakdown: ' +
+        name: 'high-hook-retry-' + label,
+        description: 'Pipeline triggered ' + metrics.retries + ' hook-level retries ' +
+          '(sandbox/stash-pop/re-prompts — not agent redispatches). Tool breakdown: ' +
           JSON.stringify(metrics.toolBreakdown || {}),
         source: 'session-knowledge',
-        tags: ['retry', 'pipeline', 'lesson'],
+        tags: ['hook-retry', 'pipeline', 'lesson'],
       };
       if (prescription) {
         retryEntry.prescription = prescription;

package/templates/scripts/metrics-collect.js

@@ -33,7 +33,7 @@ function main() {
   const statesDir = path.join(claudeDir, '.pipeline-states');
   const activeSpecDir = path.join(claudeDir, 'spec', 'active');
   if (fs.existsSync(statesDir)) {
-    const files = fs.readdirSync(statesDir).filter(f => f.endsWith('.json'));
+    const files = fs.readdirSync(statesDir).filter(f => f.endsWith('.json') && !f.endsWith('.metrics.json'));
     const activeBuckets = [];
     const orphanedBuckets = [];
     for (const f of files) {
@@ -49,7 +49,7 @@ function main() {
         lines.push(`## ${isOrphaned ? 'Orphaned' : 'Active'}: ${name}`);
         lines.push(`- Duration: ${duration}`);
         lines.push(`- API calls: ${m.apiCalls || 0}`);
-        lines.push(`- Retries: ${m.retries || 0}`);
+        lines.push(`- Hook retries: ${m.retries || 0}`);
         if (m.toolBreakdown && Object.keys(m.toolBreakdown).length > 0) {
           lines.push('- Tool breakdown:');
           for (const [tool, count] of Object.entries(m.toolBreakdown).sort((a, b) => b[1] - a[1])) {
@@ -102,7 +102,7 @@ function main() {
           parts.push(`### ${name}`);
           parts.push(`- Duration: ${duration}`);
           parts.push(`- API calls: ${m.apiCalls || 0}`);
-          parts.push(`- Retries: ${m.retries || 0}`);
+          parts.push(`- Hook retries: ${m.retries || 0}`);
           if (m.rtkSavings) {
             parts.push(`- RTK savings: ${m.rtkSavings.pct}% (${Math.round((m.rtkSavings.saved || 0) / 1000)}k tokens)`);
           }
@@ -119,7 +119,7 @@ function main() {
         parts.push('## Averages (last ' + count + ' pipelines)');
         parts.push(`- Avg duration: ${formatMs(Math.round(totalDurationMs / count))}`);
         parts.push(`- Avg API calls: ${Math.round(totalCalls / count)}`);
-        parts.push(`- Avg retries: ${Math.round(totalRetries / count)}`);
+        parts.push(`- Avg hook retries: ${Math.round(totalRetries / count)}`);
         parts.push('');
       }
 
@@ -184,8 +184,9 @@ function main() {
         var pass1Pct = Math.round((pass1Count / totalPipelines) * 100);
         var avgRetries = (totalRetrySum / totalPipelines).toFixed(1);
         parts.push('## Pass@1 Metrics');
-        parts.push('- Pass@1: ' + pass1Pct + '% (' + pass1Count + '/' + totalPipelines + ' completed without retries)');
-        parts.push('- Avg retries per pipeline: ' + avgRetries);
+        parts.push('- Pass@1 (hook-level): ' + pass1Pct + '% (' + pass1Count + '/' + totalPipelines + ' completed with zero hook retries)');
+        parts.push('- Avg hook retries per pipeline: ' + avgRetries);
+        parts.push('- Note: counts hook/sandbox events, not agent redispatches. True agent-level Pass@1 not yet tracked.');
         parts.push('');
       }
     }