musora-content-services 2.135.3 → 2.136.1

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [2.136.1](https://github.com/railroadmedia/musora-content-services/compare/v2.136.0...v2.136.1) (2026-02-19)
+
+## [2.136.0](https://github.com/railroadmedia/musora-content-services/compare/v2.135.3...v2.136.0) (2026-02-19)
+
+
+### Features
+
+* melon configurable purge grace period ([#816](https://github.com/railroadmedia/musora-content-services/issues/816)) ([f87eb21](https://github.com/railroadmedia/musora-content-services/commit/f87eb21a3cc9eac28f146b0793b4bf7136bd8d0c))
+
+
+### Bug Fixes
+
+* allows strategies to ask for pull only instead of pull+push ([#817](https://github.com/railroadmedia/musora-content-services/issues/817)) ([c8aa114](https://github.com/railroadmedia/musora-content-services/commit/c8aa1147f218de9ff9d55d1929049de977bdaaeb))
+
 ### [2.135.3](https://github.com/railroadmedia/musora-content-services/compare/v2.135.2...v2.135.3) (2026-02-19)
 
 ### [2.135.2](https://github.com/railroadmedia/musora-content-services/compare/v2.135.1...v2.135.2) (2026-02-19)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "musora-content-services",
-  "version": "2.135.3",
+  "version": "2.136.1",
   "description": "A package for Musoras content services ",
   "main": "src/index.js",
   "type": "module",

package/src/services/sanity.js

@@ -1496,13 +1496,13 @@ export async function fetchSanity(
     if (result.result) {
       let results = isList ? result.result : result.result[0]
       if (!results) {
-        throw new Error('No results found')
+        return null
       }
       results = processNeedAccess ? await needsAccessDecorator(results, userPermissions) : results
       results = processPageType ? pageTypeDecorator(results) : results
       return customPostProcess ? customPostProcess(results) : results
     } else {
-      throw new Error('No results found')
+      return null
     }
   } catch (error) {
     console.error('fetchSanity: Fetch error:', { error, query })
@@ -1656,7 +1656,7 @@ export async function fetchMetadata(brand, type, options = {}) {
 export async function fetchChatAndLiveEnvent(brand, forcedId = null) {
   const liveEvent =
     forcedId !== null ? await fetchByRailContentIds([forcedId]) : [await fetchLiveEvent(brand)]
-  if (liveEvent.length === 0 || (liveEvent.length === 1 && liveEvent[0] === undefined)) {
+  if (liveEvent.length === 0 || (liveEvent.length === 1 && !liveEvent[0])) {
     return null
   }
   let url = `/content/live-chat?brand=${brand}`

package/src/services/sync/manager.ts

@@ -158,8 +158,10 @@ export default class SyncManager {
       strategies.forEach((strategy) => {
         models.forEach((model) => {
           const store = this.storesRegistry[model.table]
-          strategy.onTrigger(store, (reason) => {
-            store.requestSync(reason)
+          strategy.onTrigger(store, {
+            callback: (reason) => store.requestSync(reason),
+            requestSync: (reason) => store.requestSync(reason),
+            requestPull: (reason) => store.requestPull(reason),
           })
         })
         strategy.start()

package/src/services/sync/store/index.ts

@@ -30,12 +30,12 @@ export type SyncStoreConfig<TModel extends BaseModel = BaseModel> = {
   comparator?: TModel extends BaseModel ? SyncResolverComparator<TModel> : SyncResolverComparator
   pull: SyncPull
   push: SyncPush
+  purgeGracePeriod?: EpochMs
 }
 
 export default class SyncStore<TModel extends BaseModel = BaseModel> {
   static readonly PULL_THROTTLE_INTERVAL = 2_000
   static readonly PUSH_THROTTLE_INTERVAL = 1_000
-  static readonly DELETED_RECORD_GRACE_PERIOD = 60_000 // 60s
   static readonly CLEANUP_INTERVAL = 60_000 * 60 // 1hr
 
   readonly telemetry: SyncTelemetry
@@ -58,6 +58,7 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
   private pushThrottleState: ThrottleState<SyncPushResponse>
   private pushCoalescer = new PushCoalescer()
 
+  private purgeGracePeriod: EpochMs
   private pushBlockingState: BlockingState = { enabled: false }
 
   private emitter = new EventEmitter<SyncStoreEvents<TModel>>()
@@ -66,7 +67,7 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
   private lastFetchTokenKey: string
 
   constructor(
-    { model, comparator, pull, push }: SyncStoreConfig<TModel>,
+    { model, comparator, pull, push, purgeGracePeriod }: SyncStoreConfig<TModel>,
     userScope: SyncUserScope,
     context: SyncContext,
     db: Database,
@@ -90,6 +91,8 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
     this.pushThrottleState = createThrottleState(SyncStore.PUSH_THROTTLE_INTERVAL)
     this.pullThrottleState = createThrottleState(SyncStore.PULL_THROTTLE_INTERVAL)
 
+    this.purgeGracePeriod = purgeGracePeriod ?? (0 as EpochMs)
+
     this.puller = pull
     this.pusher = push
     this.lastFetchTokenKey = `last_fetch_token:${this.model.table}`
@@ -141,6 +144,21 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
     }, { table: this.model.table, reason })
   }
 
+  /**
+   * Request a retrying pull - does not return
+   */
+  async requestPull(reason: string) {
+    inBoundary(ctx => {
+      this.telemetry.trace(
+        { name: `sync:${this.model.table}`, op: 'pull-request', attributes: { ...ctx, ...this.context.session.toJSON() } },
+        async span => await this.pullRecordsWithRetry(span)
+      )
+    }, { table: this.model.table, reason })
+  }
+
+  /**
+   * Request a retrying push - does not return
+   */
   async requestPush(reason: string) {
     inBoundary(ctx => {
       this.telemetry.trace(
@@ -525,6 +543,9 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
     )()
   }
 
+  // TODO - slight annoying bug that occurs with purge grace period
+  // since we send ALL unsynced records, any that are dirty deleted
+  // will keep on getting sent multiple times for as long as the grace period is active
   public async pushUnsyncedWithRetry(span?: Span, cause?: string | Record<string, string>) {
     const records = await this.queryMaybeDeletedRecords(Q.where('_status', Q.notEq('synced')))
 
@@ -907,7 +928,7 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
         const record = existingRecordsMap.get(id)
         if (!record) return true // If no record found, safe to destroy
 
-        const gracePeriodAgo = Date.now() - SyncStore.DELETED_RECORD_GRACE_PERIOD
+        const gracePeriodAgo = Date.now() - this.purgeGracePeriod
         return record.updated_at < gracePeriodAgo
       })
       .map((id) => {
@@ -999,7 +1020,7 @@ export default class SyncStore<TModel extends BaseModel = BaseModel> {
    * (after a server push), but instead every hour or so)
   */
   private async cleanupOldDeletedRecords(writer: WriterInterface) {
-    const gracePeriodAgo = Date.now() - SyncStore.DELETED_RECORD_GRACE_PERIOD
+    const gracePeriodAgo = Date.now() - this.purgeGracePeriod
 
     const oldDeletedRecords = await writer.callReader(() => this.queryMaybeDeletedRecords(
       Q.where('_status', 'deleted'),

package/src/services/sync/store-configs.ts

@@ -3,6 +3,7 @@ import { ContentLike, ContentProgress, Practice, UserAwardProgress, PracticeDayN
 import { handlePull, handlePush, makeFetchRequest } from "./fetch"
 
 import type BaseModel from "./models/Base"
+import { EpochMs } from "./index"
 
 // keeps type-safety in each entry
 const c = <TModel extends BaseModel>(config: SyncStoreConfig<TModel>) => config
@@ -32,12 +33,14 @@ export default function createStoresFromConfig() {
       model: Practice,
       pull: handlePull(makeFetchRequest('/api/user/practices/v1')),
       push: handlePush(makeFetchRequest('/api/user/practices/v1', { method: 'POST' })),
+      purgeGracePeriod: 12_000 as EpochMs // delete undo toast duration is 10s
     }),
 
     c({
       model: PracticeDayNote,
       pull: handlePull(makeFetchRequest('/api/user/practices/v1/notes')),
       push: handlePush(makeFetchRequest('/api/user/practices/v1/notes', { method: 'POST' })),
+      purgeGracePeriod: 12_000 as EpochMs // delete undo toast duration is 10s
     }),
 
     c({

package/src/services/sync/strategies/base.ts

@@ -2,8 +2,18 @@ import { SyncStrategy } from "./index";
 import SyncContext from "../context";
 import SyncStore from "../store";
 
+type SyncCallback = (reason: string) => void
+
+type SyncCallbacks = {
+  callback: SyncCallback
+  requestSync: SyncCallback
+  requestPull: SyncCallback
+}
+
+type RegistryEntry = SyncCallbacks & { store: SyncStore }
+
 export default abstract class BaseSyncStrategy implements SyncStrategy {
-  protected registry: { callback: (reason: string) => void, store: SyncStore }[] = []
+  protected registry: RegistryEntry[] = []
   abstract start(): void
   abstract stop(): void
 
@@ -14,8 +24,8 @@ export default abstract class BaseSyncStrategy implements SyncStrategy {
     this.registry = []
   }
 
-  onTrigger(store: SyncStore, callback: (reason: string) => void): this {
-    this.registry.push({ callback, store })
+  onTrigger(store: SyncStore, callbacks: SyncCallbacks): this {
+    this.registry.push({ ...callbacks, store })
     return this
   }
 }

package/src/services/sync/strategies/index.ts

@@ -1,12 +1,14 @@
 import SyncStore from "../store";
+import type { SyncCallbacks } from './base'
 
 export interface SyncStrategy {
   start(): void
   stop(): void
 
-  onTrigger(store: SyncStore, callback: (reason: string) => void): this
+  onTrigger(store: SyncStore, callbacks: SyncCallbacks): this
 }
 
 export { default as BaseStrategy } from './base'
 export { default as InitialStrategy } from './initial'
 export { default as PollingStrategy } from './polling'
+export type { SyncCallbacks } from './base'

package/.claude/settings.local.json

@@ -1,9 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(rg:*)",
-      "Bash(npm run lint:*)"
-    ],
-    "deny": []
-  }
-}