musora-content-services 2.124.1 → 2.125.0

package/.claude/settings.local.json

@@ -1,9 +1,8 @@
 {
   "permissions": {
     "allow": [
-      "Bash(rg:*)",
-      "Bash(npm run lint:*)"
-    ],
-    "deny": []
+      "Bash(grep:*)",
+      "Bash(find:*)"
+    ]
   }
 }

package/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [2.125.0](https://github.com/railroadmedia/musora-content-services/compare/v2.122.7...v2.125.0) (2026-01-29)
+
+
+### Features
+
+* **BEH-1505:** new award templates ([#740](https://github.com/railroadmedia/musora-content-services/issues/740)) ([e11f5f0](https://github.com/railroadmedia/musora-content-services/commit/e11f5f0db218132409b1d228a4c0a20500f73922))
+* better user impersonation ([#731](https://github.com/railroadmedia/musora-content-services/issues/731)) ([768022d](https://github.com/railroadmedia/musora-content-services/commit/768022df839b2c2e206d02985c82075b0d4de008))
+* **T3PS-1537:** Playbass Recommendations V2 ([#744](https://github.com/railroadmedia/musora-content-services/issues/744)) ([b88ffbd](https://github.com/railroadmedia/musora-content-services/commit/b88ffbd85a9982371e108d9f23190a9217cf29d0))
+* **TP-1080:** ignore resume time until past 10s window ([#749](https://github.com/railroadmedia/musora-content-services/issues/749)) ([c22f4c2](https://github.com/railroadmedia/musora-content-services/commit/c22f4c201ec60dbf9475eebbcee199dfea967bbf))
+
+
+### Bug Fixes
+
+* **auth:** import ([2686f30](https://github.com/railroadmedia/musora-content-services/commit/2686f3004bef54ab548ec87a2665ff918c385421))
+* **auth:** use http client for auth functions ([#751](https://github.com/railroadmedia/musora-content-services/issues/751)) ([6958adc](https://github.com/railroadmedia/musora-content-services/commit/6958adc87689a7dd433a8c66ccaff60317e6e962))
+* makes methodIntroComplete function send formatted date matching getDailySession ([#725](https://github.com/railroadmedia/musora-content-services/issues/725)) ([6ac47a0](https://github.com/railroadmedia/musora-content-services/commit/6ac47a04dfa2ea4a0d355409b4be8fa743af1b48))
+* resets trickled/bubbled records that are set to 0% in progress ([#746](https://github.com/railroadmedia/musora-content-services/issues/746)) ([056949b](https://github.com/railroadmedia/musora-content-services/commit/056949bc65b61aceb39e14fd5a485ef283817108))
+* **T3PS-1715:** lp lesson practices and activity mapping ([#732](https://github.com/railroadmedia/musora-content-services/issues/732)) ([922e455](https://github.com/railroadmedia/musora-content-services/commit/922e4558b720b17533b3923fd08939ef69afa4f2))
+* use jump-to-post url for notifications/reporting system ([91ff74f](https://github.com/railroadmedia/musora-content-services/commit/91ff74f227c350589f9558a60a76575abb71b0e2))
+
 ### [2.124.1](https://github.com/railroadmedia/musora-content-services/compare/v2.124.0...v2.124.1) (2026-01-29)
 
 

package/TECHNICAL_DEBT.md

@@ -0,0 +1,482 @@
+# 📊 Technical Debt Report - musora-content-services
+
+**Generated:** 2025-12-29
+**Package Version:** 2.107.4
+**Total Issues Found:** 31
+
+---
+
+## 🔴 Critical Priority (3 issues)
+
+### 1. Missing TypeScript Configuration
+**Impact:** High - Type safety not enforced
+**Files Affected:** All 75 `.ts` files
+**Issue:** No `tsconfig.json` found, TypeScript compiler not configured
+
+**Action Required:**
+- Add `tsconfig.json` with proper settings
+- Add `typescript` to devDependencies
+- Configure IDE/editor support
+
+---
+
+### 2. Permissions V2 Filter Generation Not Implemented
+**File:** `src/services/permissions/PermissionsV2Adapter.ts:78`
+**Impact:** High - Core feature incomplete
+
+```typescript
+/**
+ * TODO: Implement v2 filter generation
+ *
+ * V2 Logic:
+ * - When showMembershipRestrictedContent is true:
+ *   * Show content restricted by Plus Membership
+ *   * This supports the membership upgrade modal
+ * - When showOnlyOwnedContent is true:
+ *   * Shows only purchased/owned content
+ */
+```
+
+**Action Required:**
+- Implement v2 GROQ filter generation
+- Add tests for membership upgrade modal scenarios
+- Document filter behavior
+
+---
+
+### 3. WatermelonDB Bug Workaround
+**File:** `src/services/sync/store/index.ts:255`
+**Issue:** Critical workaround for WatermelonDB prepareUpdate() bug
+
+```typescript
+// Workaround for WatermelonDB bug: prepareUpdate() doesn't commit field changes
+```
+
+**Action Required:**
+- Monitor WatermelonDB releases for fix
+- Create test to validate when workaround can be removed
+- Document workaround in README
+
+---
+
+## 🟡 High Priority (8 issues)
+
+### 4. Content Progress - Missing Parent Hierarchy
+**File:** `src/services/contentProgress.js:99`
+
+```javascript
+//TODO add parent hierarchy upwards as well
+// data structure is the same but instead of child{} we use parent{}
+```
+
+**Impact:** Navigation logic incomplete for upward traversal
+
+---
+
+### 5. Pack Navigation Logic Incomplete
+**File:** `src/services/contentProgress.js:173`
+
+```javascript
+// TODO: packs have an extra situation where we need to jump to
+// the next course if all lessons in the last engaged course are completed
+```
+
+**Impact:** Poor UX - users stuck when completing pack courses
+
+---
+
+### 6. Progress Data Structure Limitation
+**File:** `src/services/contentProgress.js:263`
+
+```javascript
+// todo: warning: this doesnt work with having 2 items with same
+// contentId but different collection, because of the response
+// structure here with contentId as key
+```
+
+**Impact:** Data collision bug for duplicate content IDs across collections
+**Risk:** Data loss or incorrect progress tracking
+
+---
+
+### 7. Content Metadata Not in WatermelonDB
+**File:** `src/services/contentProgress.js:378`
+
+```javascript
+// TODO: eventually put content metadata into watermelon so we can
+// always have brand info in progress records and avoid all this
+```
+
+**Impact:** Performance - Additional API calls needed, null-ish brand handling complexity
+
+---
+
+### 8. Playlist Progress Tracking Migration Pending
+**File:** `src/services/userActivity.js:1017`
+
+```javascript
+// todo post v2: refactor this once we migrate playlist
+// progress tracking to new system
+```
+
+**Impact:** Technical debt blocking v2 completion
+
+---
+
+### 9. Deprecated Method Card
+**File:** `src/services/userActivity.js:1369`
+
+```javascript
+//todo remove method card
+```
+
+**Impact:** Code cleanup needed
+
+---
+
+### 10. Tiered-Course Content Type Not Implemented
+**File:** `src/contentTypeConfig.js:221`
+
+```javascript
+'tiered-course', // TODO: new content type
+```
+
+**Impact:** New content type defined but not fully implemented
+**Risk:** Runtime errors if content type is used
+
+---
+
+### 11. Show Types Require Clarification
+**File:** `src/contentTypeConfig.js:230`
+
+```javascript
+// TODO these require clearing the information with Chris,
+// they weren't part of the old system, but are part of
+// the migration document as SHOWS
+```
+
+**Impact:** Unclear content type classification blocking migration
+
+---
+
+## 🟢 Medium Priority (5 issues)
+
+### 12-13. Content Aggregator Performance
+**Files:**
+- `src/services/contentAggregator.js:65`
+- `src/services/contentAggregator.js:159`
+
+```javascript
+// todo: merge addProgressData with addResumeTimeSeconds
+// to one watermelon call
+```
+
+**Impact:** Performance - Two database calls instead of one
+
+---
+
+### 14. Bulk Update Event Emitting Missing
+**File:** `src/services/sync/repositories/content-progress.ts:198`
+
+```typescript
+//todo add event emitting for bulk updates?
+```
+
+**Impact:** UI updates may not reflect bulk changes
+
+---
+
+### 15. Backwards Compatibility Code (Temporary)
+**Files:**
+- `src/services/content.js:357`
+- `src/services/content.js:380`
+
+```javascript
+// TODO: Remove content after FE/MA updates the
+// existing code to use items
+```
+
+**Impact:** Technical debt - duplicate `content` and `items` fields
+**Action:** Coordinate with FE/MA teams for migration
+
+---
+
+### 16. Progress Slicing Missing
+**File:** `src/services/userActivity.js:1003`
+
+```javascript
+// TODO slice progress to a reasonable number, say 100
+```
+
+**Impact:** Performance - Unbounded array growth
+
+---
+
+## 🔵 Low Priority (6 issues)
+
+### 17. Deprecated Code - Maintained for Compatibility
+**File:** `src/services/userActivity.js:1229`
+
+```javascript
+// TODO depreciated, maintained to avoid breaking changes
+```
+
+**Impact:** Low - Functioning but marked for removal
+
+---
+
+### 18. Sanity Import - Instructor Calendars
+**File:** `src/services/sanity.js:1179`
+
+```javascript
+// TODO import instructor calendars to Sanity
+```
+
+**Impact:** Data migration pending
+
+---
+
+### 19. Legacy Methods Still in Use
+**File:** `src/services/content.js:446-457`
+
+```javascript
+/**
+ * Fetches legacy methods for a given brand by permission.
+ */
+export async function getLegacyMethods(brand) {
+```
+
+**Impact:** Legacy code path still active
+
+---
+
+### 20. RailcontentConfig Deprecated
+**File:** `src/services/types.js:14`
+
+```javascript
+/**
+ * @deprecated use `config.session` and `config.baseUrl` instead.
+ * Will be removed in future versions.
+ */
+```
+
+**Status:** Documented deprecation, replacement path clear
+
+---
+
+### 21. Sync Manager Database Init Risk
+**File:** `src/services/sync/manager.ts:63`
+
+```typescript
+// todo - can cause undefined??
+this.database = this.telemetry.trace({ name: 'db:init' },
+  () => inBoundary(initDatabase))
+```
+
+**Impact:** Potential undefined database object
+
+---
+
+### 22. Store Construction Hack
+**File:** `src/services/sync/store/index.ts:658`
+
+```typescript
+// NOTE: constructing models in this way is a bit of a hack,
+```
+
+**Impact:** Code quality - Non-standard model construction
+
+---
+
+## ⚠️ Security & Performance (5 issues)
+
+### 23. NPM Security Vulnerabilities
+**Count:** 5 vulnerabilities (1 low, 4 moderate)
+
+**Details:**
+1. **@babel/helpers** - RegExp complexity (CVE Score: 6.2)
+   - Range: <7.26.10
+   - Severity: Moderate
+   - Fix: `npm audit fix`
+
+2. **@babel/runtime** - RegExp complexity (CVE Score: 6.2)
+   - Range: <7.26.10
+   - Severity: Moderate
+   - Affects: @nozbe/watermelondb
+
+3. **@nozbe/watermelondb** - Via @babel/runtime
+   - Current: 0.28.1-0
+   - Fix requires major version downgrade to 0.25.5
+
+4. **brace-expansion** - ReDoS vulnerability
+   - Severity: Low
+
+**Action Required:**
+```bash
+npm audit fix  # For non-breaking changes
+# Evaluate WatermelonDB downgrade impact
+```
+
+---
+
+### 24. Console.log Statements
+**Count:** 263 statements across 30 files
+
+**Risk:** Potential sensitive data leakage in production
+
+**Examples:**
+- `src/services/imageSRCVerify.js:61,110` - WARNING messages
+- Multiple debug logs throughout codebase
+
+**Action Required:**
+- Replace with Sentry logging
+- Add logging levels (debug, info, warn, error)
+- Remove console.logs from production builds
+
+---
+
+### 25. TypeScript 'any' Usage
+**Count:** 60 occurrences across 23 files
+
+**Impact:** Reduces type safety benefits
+
+**Action Required:**
+- Audit each usage
+- Replace with proper types
+- Enable `noImplicitAny` in tsconfig.json
+
+---
+
+### 26. Process.env Usage in Mobile Context
+**Files:**
+- `src/filterBuilder.js:38` (commented out)
+- `src/services/imageSRCVerify.js:60,109`
+
+```javascript
+if (process.env.NODE_ENV !== 'production') {
+  console.warn(`WARNING: ...`)
+}
+```
+
+**Risk:** `process.env` not available in React Native without configuration
+
+**Current Impact:** Low - Only used for warnings
+
+**Action Required:**
+- Use react-native-config for mobile builds
+- Document environment variable strategy
+
+---
+
+### 27. Critical Award Query Warning
+**File:** `src/services/awards/award-query.js:42`
+
+```javascript
+// CRITICAL: Pass collection context when inside a learning path!
+```
+
+**Impact:** Data integrity - Awards may be calculated incorrectly without collection context
+
+**Action Required:**
+- Add runtime validation
+- Throw error if collection missing in learning path context
+- Add test coverage
+
+---
+
+## 📈 Code Quality Issues
+
+### 28. Large Monolithic Files
+
+**sanity.js:** 2,109 lines
+- Multiple responsibilities: queries, filters, metadata
+- **Recommendation:** Split into:
+  - `sanity/queries.js`
+  - `sanity/filters.js`
+  - `sanity/metadata.js`
+
+**userActivity.js:** 1,454 lines
+- Diverse functionality: practices, progress, statistics
+- **Recommendation:** Split by domain:
+  - `user/practices.js`
+  - `user/progress-rows.js`
+  - `user/statistics.js`
+
+---
+
+### 29. Mixed JS/TS Codebase
+- 42 `.js` files
+- 75 `.ts` files
+- Extensive cross-imports
+
+**Recommendation:** Gradual migration to TypeScript
+
+---
+
+### 30. Inconsistent Export Patterns
+- Only 10 files use `excludeFromGeneratedIndex`
+- Permissions directory manually excluded in generator script
+- No clear guidelines documented
+
+---
+
+### 31. Test Coverage Unknown
+- 33 test files exist
+- Coverage reporting enabled
+- No recent coverage report available
+
+**Action Required:**
+```bash
+npm test -- --coverage
+```
+
+---
+
+## 📋 Summary by Priority
+
+| Priority | Count | Requires Action |
+|----------|-------|-----------------|
+| 🔴 Critical | 3 | Immediate |
+| 🟡 High | 8 | Next Sprint |
+| 🟢 Medium | 5 | Next Quarter |
+| 🔵 Low | 6 | Backlog |
+| ⚠️ Security | 5 | Review & Plan |
+| **TOTAL** | **31** | |
+
+---
+
+## 🎯 Recommended Action Plan
+
+### Sprint 1 (Immediate)
+1. Add `tsconfig.json` and configure TypeScript
+2. Run `npm audit fix` for security vulnerabilities
+3. Document critical award query collection requirement
+
+### Sprint 2-3 (Next 2 weeks)
+4. Implement Permissions V2 filter generation
+5. Fix content progress data structure collision bug (contentProgress.js:263)
+6. Complete pack navigation logic
+
+### Month 1
+7. Migrate playlist progress tracking to v2 system
+8. Refactor large files (sanity.js, userActivity.js)
+9. Replace console.log with Sentry logging
+
+### Quarter 1
+10. Complete content metadata WatermelonDB migration
+11. Remove backwards compatibility code (coordinate with FE/MA)
+12. Reduce TypeScript 'any' usage
+13. Achieve 80%+ test coverage
+
+---
+
+## 📝 Notes
+
+This report was generated by analyzing:
+- All TODO, FIXME, HACK, XXX comments
+- Security vulnerabilities via npm audit
+- Code quality metrics (file sizes, console.logs, TypeScript any usage)
+- Deprecated code patterns
+- Critical warnings in comments
+
+**Last Updated:** 2025-12-29

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "musora-content-services",
-  "version": "2.124.1",
+  "version": "2.125.0",
   "description": "A package for Musoras content services ",
   "main": "src/index.js",
   "type": "module",

package/src/contentTypeConfig.js

@@ -52,7 +52,7 @@ export const DEFAULT_FIELDS = [
   "'image': thumbnail.asset->url",
   "'thumbnail': thumbnail.asset->url",
   'difficulty',
-  difficultyStringField(),
+  'difficulty_string',
   'published_on',
   "'type': _type",
   "'length_in_seconds' : coalesce(length_in_seconds, soundslice[0].soundslice_length_in_second)",
@@ -760,10 +760,6 @@ export function artistOrInstructorNameAsArray(key = 'artists') {
   return `'${key}': select(artist->name != null => [artist->name], instructor[]->name)`
 }
 
-export function difficultyStringField(key = 'difficulty_string') {
-  return `'${key}': select(difficulty_string == 'Novice' => 'Introductory', difficulty_string)`
-}
-
 export async function getFieldsForContentTypeWithFilteredChildren(
   contentType,
   asQueryString = true
@@ -829,9 +825,6 @@ const filterHandlers = {
   style: (value) => `"${value}" in genre[]->name`,
 
   difficulty: (value) => {
-    if (value === 'Introductory') {
-      return `(difficulty_string == "Novice" || difficulty_string == "Introductory")`
-    }
     return `difficulty_string == "${value}"`
   },