musora-content-services 1.0.207 → 1.0.209

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.0.209](https://github.com/railroadmedia/musora-content-services/compare/v1.0.208...v1.0.209) (2024-12-02)
+
+### [1.0.208](https://github.com/railroadmedia/musora-content-services/compare/v1.0.207...v1.0.208) (2024-12-02)
+
 ### [1.0.207](https://github.com/railroadmedia/musora-content-services/compare/v1.0.198...v1.0.207) (2024-12-02)
 
 ### [1.0.206](https://github.com/railroadmedia/musora-content-services/compare/v1.0.205...v1.0.206) (2024-12-01)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "musora-content-services",
-  "version": "1.0.207",
+  "version": "1.0.209",
   "description": "A package for Musoras content services ",
   "main": "src/index.js",
   "scripts": {

package/src/filterBuilder.js

@@ -61,10 +61,12 @@ export class FilterBuilder {
         if (this.availableContentStatuses.length === 0) {
             if (this.userData.isAdmin) {
                 this.availableContentStatuses = [this.STATUS_DRAFT, this.STATUS_SCHEDULED, this.STATUS_PUBLISHED, this.STATUS_ARCHIVED, this.STATUS_UNLISTED];
+                this.getFutureScheduledContentsOnly = true;
             } else if(this.isSingle){
                 this.availableContentStatuses = [this.STATUS_SCHEDULED, this.STATUS_PUBLISHED, this.STATUS_UNLISTED, this.STATUS_ARCHIVED];
             } else{
                 this.availableContentStatuses = [this.STATUS_SCHEDULED, this.STATUS_PUBLISHED];
+                this.getFutureScheduledContentsOnly = true;
             }
         }
 
@@ -74,8 +76,8 @@ export class FilterBuilder {
             this.pullFutureContent = true;
             const now = new Date().toISOString();
             let statuses = [...this.availableContentStatuses];
-            statuses.splice(statuses.indexOf(this.STATUS_SCHEDULED));
-            this._andWhere(`(status in ${arrayToStringRepresentation(statuses)} || (status == '${this.STATUS_SCHEDULED}' && published_on >= '${now}'))`)
+            statuses.splice(statuses.indexOf(this.STATUS_SCHEDULED), 1);
+            this._andWhere(`(status in ${arrayToStringRepresentation(statuses)} || (status == '${this.STATUS_SCHEDULED}' && defined(published_on) && published_on >= '${now}'))`)
 
         } else {
             this._andWhere(`status in ${arrayToStringRepresentation(this.availableContentStatuses)}`);
@@ -86,8 +88,7 @@ export class FilterBuilder {
     _applyPermissions() {
         if (this.bypassPermissions || this.userData.isAdmin) return this;
         const requiredPermissions = this._getUserPermissions();
-        if (requiredPermissions.length === 0) return this;
-        this._andWhere(`references(*[_type == 'permission' && railcontent_id in ${arrayToRawRepresentation(requiredPermissions)}]._id)`);
+        this._andWhere(`(!defined(permission) || references(*[_type == 'permission' && railcontent_id in ${arrayToRawRepresentation(requiredPermissions)}]._id))`);
         return this;
     }
 
@@ -146,4 +147,4 @@ export function arrayToStringRepresentation(arr) {
 
 export function arrayToRawRepresentation(arr) {
     return '[' + arr.map(item => `${item}`).join(',') + ']';
-}
+}

package/src/services/sanity.js

@@ -1160,7 +1160,7 @@ export async function fetchLessonContent(railContentId) {
  * @returns {Promise<Array<Object>|null>} - The fetched related lessons data or null if not found.
  */
 export async function fetchRelatedLessons(railContentId, brand) {
-    const query = `*[railcontent_id == ${railContentId} && brand == "${brand}" && references(*[_type=='permission']._id)]{
+    const query = `*[railcontent_id == ${railContentId} && brand == "${brand}" && (!defined(permission) || references(*[_type=='permission']._id))]{
    _type, parent_type, railcontent_id,
     "related_lessons" : array::unique([
       ...(*[references(^._id)][0].child[]->{_id, "id":railcontent_id, published_on, "instructor": instructor[0]->name, title, "thumbnail_url":thumbnail.asset->url, length_in_seconds, web_url_path, "type": _type, difficulty, difficulty_string, railcontent_id, artist->,"permission_id": permission[]->railcontent_id,_type}),

package/test/sanityQueryService.test.js

@@ -683,16 +683,16 @@ describe('Filter Builder', function () {
         let finalFilter = await builder.buildFilter(filter);
         let clauses = spliceFilterForAnds(finalFilter);
         expect(clauses[0].phrase).toBe(filter);
-        expect(clauses[1].field).toBe('status');
-        expect(clauses[2].field).toBe('published_on');
+        expect(clauses[1].field).toBe('(status');
+        expect(clauses[3].field).toBe('published_on');
 
         builder = new FilterBuilder('', {bypassPermissions: true});
         finalFilter = await builder.buildFilter(filter);
         clauses = spliceFilterForAnds(finalFilter);
-        expect(clauses[0].field).toBe('status');
+        expect(clauses[0].field).toBe('(status');
         expect(clauses[0].operator).toBe('in');
-        expect(clauses[1].field).toBe('published_on');
-        expect(clauses[1].operator).toBe('<=');
+        expect(clauses[2].field).toBe('published_on');
+        expect(clauses[2].operator).toBe('>=');
     });
 
     test('withOnlyFilterAvailableStatuses', async () => {
@@ -720,7 +720,7 @@ describe('Filter Builder', function () {
         expect(clauses[1].field).toBe('(status'); // extra ( because it's a multi part filter
         expect(clauses[1].operator).toBe('in');
         // getFutureScheduledContentsOnly doesn't make a filter that's splicable, so we match on the more static string
-        const expected = "['published','unlisted'] || (status == 'scheduled' && published_on >=";
+        const expected = "['published','unlisted'] || (status == 'scheduled' && defined(published_on) && published_on >=";
         const isMatch = finalFilter.includes(expected);
         expect(isMatch).toBeTruthy();
     });
@@ -747,7 +747,8 @@ describe('Filter Builder', function () {
         const filter = 'railcontent_id = 111'
         const builder = new FilterBuilder(filter,
             {
-                bypassPermissions: true
+                bypassPermissions: true,
+                pullFutureContent: false
             });
         const finalFilter = await builder.buildFilter();
         const expected = "references(*[_type == 'permission' && railcontent_id in [78,91,92]]._id)"
@@ -755,8 +756,8 @@ describe('Filter Builder', function () {
         expect(isMatch).toBeFalsy();
         const clauses = spliceFilterForAnds(finalFilter);
         expect(clauses[0].field).toBe('railcontent_id');
-        expect(clauses[1].field).toBe('status');
-        expect(clauses[2].field).toBe('published_on');
+        expect(clauses[1].field).toBe('(status');
+        expect(clauses[3].field).toBe('published_on');
 
     });
 
@@ -773,13 +774,10 @@ describe('Filter Builder', function () {
         let finalFilter = await builder.buildFilter();
         let clauses = spliceFilterForAnds(finalFilter);
         expect(clauses[0].phrase).toBe(filter);
-        expect(clauses[1].field).toBe('status');
+        expect(clauses[1].field).toBe('(status');
         expect(clauses[1].operator).toBe('in');
-        expect(clauses[2].field).toBe('published_on');
-        expect(clauses[2].operator).toBe('<=');
-        const restrictionDate = new Date(clauses[2].condition)
-        const now = new Date();
-        expect(now.getTime()).toBeLessThan(restrictionDate.getTime());
+        expect(clauses[2].phrase).toBe('defined(published_on)');
+        expect(clauses[3].field).toBe('published_on');
 
         builder = new FilterBuilder(filter,
             {
@@ -789,8 +787,8 @@ describe('Filter Builder', function () {
         finalFilter = await builder.buildFilter();
         clauses = spliceFilterForAnds(finalFilter);
         expect(clauses[0].phrase).toBe(filter);
-        expect(clauses[2].field).toBe('published_on');
-        expect(clauses[2].operator).toBe('>=');
+        expect(clauses[3].field).toBe('published_on');
+        expect(clauses[3].operator).toBe('>=');
     });
 
     function spliceFilterForAnds(filter) {