musicbrainz-api 0.25.0 → 0.25.1

package/lib/coverartarchive-api.js

@@ -2,7 +2,7 @@
 import { HttpClient } from "./http-client.js";
 export class CoverArtArchiveApi {
     constructor() {
-        this.httpClient = new HttpClient({ baseUrl: 'https://coverartarchive.org', userAgent: 'Node.js musicbrains-api', timeout: 20000, followRedirects: false });
+        this.httpClient = new HttpClient({ baseUrl: 'https://coverartarchive.org', userAgent: 'Node.js musicbrains-api', timeout: 2000, followRedirects: false });
     }
     async getJson(path) {
         const response = await this.httpClient.get(path, {

package/lib/http-client-node.js

@@ -13,7 +13,7 @@ export class HttpClientNode extends HttpClient {
         return Promise.resolve(undefined);
     }
     getCookies() {
-        return this.cookieJar.getCookieString(this.options.baseUrl); // Get cookies for the request
+        return this.cookieJar.getCookieString(this.httpOptions.baseUrl); // Get cookies for the request
     }
 }
 //# sourceMappingURL=http-client-node.js.map

package/lib/http-client.d.ts

@@ -10,6 +10,9 @@ export type MultiQueryFormData = {
 };
 export interface IHttpClientOptions {
     baseUrl: string;
+    /**
+     * Retry time-out, default 500 ms
+     */
     timeout: number;
     userAgent: string;
     followRedirects?: boolean;
@@ -22,13 +25,15 @@ export interface IFetchOptions {
     followRedirects?: boolean;
 }
 export declare class HttpClient {
-    protected options: IHttpClientOptions;
-    constructor(options: IHttpClientOptions);
+    protected httpOptions: IHttpClientOptions;
+    constructor(httpOptions: IHttpClientOptions);
     get(path: string, options?: IFetchOptions): Promise<Response>;
     post(path: string, options?: IFetchOptions): Promise<Response>;
     postForm(path: string, formData: HttpFormData, options?: IFetchOptions): Promise<Response>;
     postJson(path: string, json: Object, options?: IFetchOptions): Promise<Response>;
     private _fetch;
-    protected registerCookies(response: Response): Promise<Cookie | undefined>;
+    private _buildUrl;
+    private _delay;
+    protected registerCookies(_response: Response): Promise<Cookie | undefined>;
     getCookies(): Promise<string | null>;
 }

package/lib/http-client.js

@@ -1,6 +1,8 @@
+import Debug from "debug";
+const debug = Debug('musicbrainz-api-node');
 export class HttpClient {
-    constructor(options) {
-        this.options = options;
+    constructor(httpOptions) {
+        this.httpOptions = httpOptions;
     }
     get(path, options) {
         return this._fetch('get', path, options);
@@ -12,7 +14,6 @@ export class HttpClient {
         const encodedFormData = new URLSearchParams(formData).toString();
         return this._fetch('post', path, { ...options, body: encodedFormData, headers: { 'Content-Type': 'application/x-www-form-urlencoded' } });
     }
-    // biome-ignore lint/complexity/noBannedTypes:
     postJson(path, json, options) {
         const encodedJson = JSON.stringify(json);
         return this._fetch('post', path, { ...options, body: encodedJson, headers: { 'Content-Type': 'application/json.' } });
@@ -20,34 +21,58 @@ export class HttpClient {
     async _fetch(method, path, options) {
         if (!options)
             options = {};
-        let url = path.startsWith('/') ? `${this.options.baseUrl}${path}` : `${this.options.baseUrl}/${path}`;
-        if (options.query) {
-            const urlSearchParams = new URLSearchParams();
-            for (const key of Object.keys(options.query)) {
-                const value = options.query[key];
-                (Array.isArray(value) ? value : [value]).forEach(value => {
-                    urlSearchParams.append(key, value);
-                });
-            }
-            url += `?${urlSearchParams.toString()}`;
-        }
+        let retryLimit = options.retryLimit && options.retryLimit > 1 ? options.retryLimit : 1;
+        const retryTimeout = this.httpOptions.timeout ? this.httpOptions.timeout : 500;
+        const url = this._buildUrl(path, options.query);
         const cookies = await this.getCookies();
         const headers = new Headers(options.headers);
-        headers.set('User-Agent', this.options.userAgent);
+        headers.set('User-Agent', this.httpOptions.userAgent);
         if (cookies !== null) {
             headers.set('Cookie', cookies);
         }
-        const response = await fetch(url, {
-            method,
-            ...options,
-            headers,
-            body: options.body,
-            redirect: options.followRedirects === false ? 'manual' : 'follow'
-        });
-        await this.registerCookies(response);
-        return response;
-    }
-    registerCookies(response) {
+        while (retryLimit > 0) {
+            const response = await fetch(url, {
+                method,
+                ...options,
+                headers,
+                body: options.body,
+                redirect: options.followRedirects === false ? 'manual' : 'follow'
+            });
+            if (response.status === 429 || response.status === 503) {
+                debug(`Received status=${response.status}, assume reached rate limit, retry in ${retryTimeout} ms`);
+                retryLimit--;
+                if (retryLimit > 0) {
+                    await this._delay(retryTimeout); // wait 200ms before retry
+                    continue;
+                }
+            }
+            await this.registerCookies(response);
+            return response;
+        }
+        throw new Error(`Failed to fetch ${url} after retries`);
+    }
+    // Helper: Builds URL with query string
+    _buildUrl(path, query) {
+        let url = path.startsWith('/')
+            ? `${this.httpOptions.baseUrl}${path}`
+            : `${this.httpOptions.baseUrl}/${path}`;
+        if (query) {
+            const urlSearchParams = new URLSearchParams();
+            for (const key of Object.keys(query)) {
+                const value = query[key];
+                (Array.isArray(value) ? value : [value]).forEach(v => {
+                    urlSearchParams.append(key, v);
+                });
+            }
+            url += `?${urlSearchParams.toString()}`;
+        }
+        return url;
+    }
+    // Helper: Delays execution
+    _delay(ms) {
+        return new Promise(resolve => setTimeout(resolve, ms));
+    }
+    registerCookies(_response) {
         return Promise.resolve(undefined);
     }
     async getCookies() {

package/lib/musicbrainz-api-node.js

@@ -1,5 +1,4 @@
 import { StatusCodes as HttpStatus } from 'http-status-codes';
-import Debug from 'debug';
 export { XmlMetadata } from './xml/xml-metadata.js';
 export { XmlIsrc } from './xml/xml-isrc.js';
 export { XmlIsrcList } from './xml/xml-isrc-list.js';
@@ -11,12 +10,11 @@ export * from './http-client.js';
 /*
  * https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2#Subqueries
  */
-const debug = Debug('musicbrainz-api-node');
 export class MusicBrainzApi extends MusicBrainzApiDefault {
     initHttpClient() {
         return new HttpClientNode({
             baseUrl: this.config.baseUrl,
-            timeout: 20 * 1000,
+            timeout: 500,
             userAgent: `${this.config.appName}/${this.config.appVersion} ( ${this.config.appContactInfo} )`
         });
     }

package/lib/musicbrainz-api.js

@@ -41,7 +41,7 @@ export class MusicBrainzApi {
     initHttpClient() {
         return new HttpClient({
             baseUrl: this.config.baseUrl,
-            timeout: 20 * 1000,
+            timeout: 500,
             userAgent: `${this.config.appName}/${this.config.appVersion} ( ${this.config.appContactInfo} )`
         });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "musicbrainz-api",
-  "version": "0.25.0",
+  "version": "0.25.1",
   "description": "MusicBrainz API client for reading and submitting metadata",
   "exports": {
     "node": {
@@ -61,11 +61,11 @@
     "uuid": "^11.0.3"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.8.3",
+    "@biomejs/biome": "2.1.2",
     "@types/chai": "^5.0.0",
     "@types/jsontoxml": "^1.0.5",
     "@types/mocha": "^10.0.4",
-    "@types/node": "^22.5.0",
+    "@types/node": "^24.0.3",
     "@types/sinon": "^17.0.3",
     "@types/source-map-support": "^0",
     "@types/spark-md5": "^3",
@@ -77,7 +77,7 @@
     "mocha": "^11.0.1",
     "remark-cli": "^12.0.0",
     "remark-preset-lint-recommended": "^7.0.0",
-    "sinon": "^20.0.0",
+    "sinon": "^21.0.0",
     "source-map-support": "^0.5.21",
     "ts-node": "^10.9.2",
     "typescript": "^5.5.4"
@@ -96,7 +96,8 @@
     "start": "yarn run compile && yarn run lint && yarn run cover-test",
     "test-coverage": "c8 yarn run test",
     "send-codacy": "c8 report --reporter=text-lcov | codacy-coverage",
-    "prepublishOnly": "yarn run build"
+    "prepublishOnly": "yarn run build",
+    "update-biome": "yarn add -D --exact @biomejs/biome && npx @biomejs/biome migrate --write && npm run lint:fix"
   },
   "nyc": {
     "exclude": [