musicbrainz-api 0.17.0 → 0.18.0

package/README.md

@@ -1,24 +1,38 @@
 [![Node.js CI](https://github.com/Borewit/musicbrainz-api/actions/workflows/nodejs-ci.yml/badge.svg)](https://github.com/Borewit/musicbrainz-api/actions/workflows/nodejs-ci.yml)
+[![CodeQL](https://github.com/Borewit/musicbrainz-api/actions/workflows/github-code-scanning/codeql/badge.svg)](https://github.com/Borewit/musicbrainz-api/actions/workflows/github-code-scanning/codeql)
 [![NPM version](https://img.shields.io/npm/v/musicbrainz-api.svg)](https://npmjs.org/package/musicbrainz-api)
 [![npm downloads](http://img.shields.io/npm/dm/musicbrainz-api.svg)](https://npmcharts.com/compare/musicbrainz-api?interval=30&start=365)
 [![Coverage Status](https://coveralls.io/repos/github/Borewit/musicbrainz-api/badge.svg?branch=master)](https://coveralls.io/github/Borewit/musicbrainz-api?branch=master)
 [![Codacy Badge](https://app.codacy.com/project/badge/Grade/2bc47b2006454bae8c737991f152e518)](https://app.codacy.com/gh/Borewit/musicbrainz-api/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_grade)
-[![CodeQL](https://github.com/Borewit/musicbrainz-api/actions/workflows/codeql.yml/badge.svg)](https://github.com/Borewit/musicbrainz-api/actions/workflows/codeql.yml)
 [![Known Vulnerabilities](https://snyk.io/test/github/Borewit/musicbrainz-api/badge.svg?targetFile=package.json)](https://snyk.io/test/github/Borewit/musicbrainz-api?targetFile=package.json)
 [![DeepScan grade](https://deepscan.io/api/teams/5165/projects/6991/branches/63373/badge/grade.svg)](https://deepscan.io/dashboard#view=project&tid=5165&pid=6991&bid=63373)
 [![Discord](https://img.shields.io/discord/460524735235883049.svg)](https://discord.gg/958xT5X)
+[![bundlejs.com badge](https://deno.bundlejs.com/?q=musicbrainz-api&badge)](https://bundlejs.com/?q=musicbrainz-api)
 
 # musicbrainz-api
 
 A MusicBrainz-API-client for reading and submitting metadata
 
 ## Features
-*   Access metadata from MusicBrainz
-*   Submit metadata 
-*   Smart and adjustable throttling, like MusicBrainz, it allows a bursts of requests
-*   Build in TypeScript definitions
+- Access metadata from MusicBrainz
+- Submit metadata 
+- Smart and adjustable throttling, like MusicBrainz, it allows a bursts of requests
+- Build in TypeScript definitions
 
-### Hint
+## Compatibility
+
+Module: [Pure ECMAScript Module (ESM)](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c).
+The distributed JavaScript codebase is compliant with the [ECMAScript 2020 (11th Edition)](https://en.wikipedia.org/wiki/ECMAScript_version_history#11th_Edition_%E2%80%93_ECMAScript_2020) standard.
+
+This module requires a [Node.js ≥ 20](https://nodejs.org/en/about/previous-releases) engine.
+
+> [!NOTE]
+> We are looking into making this package usable in the browser as well.
+
+## Sponsor
+If you appreciate my work and want to support the development of open-source projects like [musicbrainz-api](https://github.com/Borewit/musicbrainz-api), [music-metadata](https://github.com/Borewit/music-metadata), [file-type](https://github.com/sindresorhus/file-type), [listFix()](https://github.com/Borewit/listFix), [lizzy](https://github.com/Borewit/lizzy), [strtok3](https://github.com/Borewit/strtok3), or [tokenizer-s3](https://github.com/Borewit/tokenizer-s3), please consider becoming a sponsor or making a small contribution.
+Your support helps sustain ongoing development and improvements.
+[Become a sponsor to Borewit](https://github.com/sponsors/Borewit)
 
 This package is currently only developed for the use in a [node.js environment](http://nodejs.org/).
 We are looking into making this package usable in the browser as well.
@@ -85,15 +99,14 @@ MusicBrainz API documentation: [XML Web Service/Version 2 Lookups](https://wiki.
 ### Generic lookup function
 
 Arguments:
-*   entity: `'area'` | `'artist'` | `'collection'` | `'instrument'` | `'label'` | `'place'` | `'release'` | `'release-group'` | `'recording'` | `'series'` | `'work'` | `'url'` | `'event'`
-*   MBID [(MusicBrainz identifier)](https://wiki.musicbrainz.org/MusicBrainz_Identifier)
-*   query
+- entity: `'area'` | `'artist'` | `'collection'` | `'instrument'` | `'label'` | `'place'` | `'release'` | `'release-group'` | `'recording'` | `'series'` | `'work'` | `'url'` | `'event'`
+- MBID [(MusicBrainz identifier)](https://wiki.musicbrainz.org/MusicBrainz_Identifier)
+- query
 
 ```js
 const artist = await mbApi.lookup('artist', 'ab2528d9-719f-4261-8098-21849222a0f2');
 ```
 
-
 | Query argument        | Query value     | 
 |-----------------------|-----------------|  
 | `query.collection`    | Collection MBID |
@@ -263,19 +276,19 @@ There are different search fields depending on the entity.
 Searches can be performed using the generic search function: `query(entity: mb.EntityType, query: string | IFormData, offset?: number, limit?: number): Promise<entity>`
 
 Arguments:
-*   Entity type, which can be one of:
-    *   `artist`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Artist)
-    *   `label`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Label)
-    *   `recording`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Recording)
-    *   `release`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Release)
-    *   `release-group`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Release_Group)
-    *   `work`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Work)
-    *   `area`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Area)
-    *   `url`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#URL)
-*   `query {query: string, offset: number, limit: number}`
-    *   `query.query`: supports the full Lucene Search syntax; you can find a detailed guide at [Lucene Search Syntax](https://lucene.apache.org/core/4_3_0/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description). For example, you can set conditions while searching for a name with the AND operator.
-    *   `query.offset`: optional, return search results starting at a given offset. Used for paging through more than one page of results.
-    *   `limit.query`: optional, an integer value defining how many entries should be returned. Only values between 1 and 100 (both inclusive) are allowed. If not given, this defaults to 25.
+- Entity type, which can be one of:
+  - `artist`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Artist)
+  - `label`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Label)
+  - `recording`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Recording)
+  - `release`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Release)
+  - `release-group`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Release_Group)
+  - `work`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Work)
+  - `area`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#Area)
+  - `url`: [search fields](https://wiki.musicbrainz.org/Development/XML_Web_Service/Version_2/Search#URL)
+- `query {query: string, offset: number, limit: number}`
+  - `query.query`: supports the full Lucene Search syntax; you can find a detailed guide at [Lucene Search Syntax](https://lucene.apache.org/core/4_3_0/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description). For example, you can set conditions while searching for a name with the AND operator.
+  - `query.offset`: optional, return search results starting at a given offset. Used for paging through more than one page of results.
+  - `limit.query`: optional, an integer value defining how many entries should be returned. Only values between 1 and 100 (both inclusive) are allowed. If not given, this defaults to 25.
 
 For example, to find any recordings of _'We Will Rock You'_ by Queen:
 ```js
@@ -348,8 +361,7 @@ For all of the following function you need to use a dedicated bot account.
 
 ## Submitting ISRC via post user form-data
 
-<img width="150" src="http://www.clker.com/cliparts/i/w/L/q/u/1/work-in-progress.svg" alt="Work in progress"/>
-Use with caution, and only on a test server, it may clear existing metadata as side effect.
+Use with caution, and only on a test server, it may clear existing metadata has side effect.
       
 ```js
 
@@ -396,37 +408,48 @@ Implementation of the [Cover Art Archive API](https://musicbrainz.org/doc/Cover_
 
 ### Release Cover Art
 ```js
-import {CoverArtArchiveApi} from 'musicbrainz-api';
+import { CoverArtArchiveApi } from 'musicbrainz-api';
 
-coverArtArchiveApiClient.getReleaseCovers(releaseMbid).then(releaseCoverInfo => {
-    console.log('Release cover info', releaseCoverInfo);
-});
+const coverArtArchiveApiClient = new CoverArtArchiveApi();
 
-coverArtArchiveApiClient.getReleaseCovers(releaseMbid, 'front').then(releaseCoverInfo => {
-    console.log('Get best front cover', releaseCoverInfo);
-});
-
-coverArtArchiveApiClient.getReleaseCovers(releaseMbid, 'back').then(releaseCoverInfo => {
-    console.log('Get best back cover', releaseCoverInfo);
-});
+async function getReleaseCoverArt(releaseMbid, coverType = '') {
+    try {
+        const coverInfo = await coverArtArchiveApiClient.getReleaseCovers(releaseMbid, coverType);
+        console.log(`Cover info for ${coverType || 'all covers'}`, coverInfo);
+    } catch (error) {
+        console.error(`Failed to fetch ${coverType || 'all covers'}:`, error);
+    }
+}
 
+(async () => {
+    const releaseMbid = 'your-release-mbid-here';  // Replace with actual MBID
+    await getReleaseCoverArt(releaseMbid); // Get all covers
+    await getReleaseCoverArt(releaseMbid, 'front'); // Get best front cover
+    await getReleaseCoverArt(releaseMbid, 'back'); // Get best back cover
+})();
 ```
 
 ### Release Group Cover Art
 ```js
-import {CoverArtArchiveApi} from 'musicbrainz-api';
+import { CoverArtArchiveApi } from 'musicbrainz-api';
 
-coverArtArchiveApiClient.getReleaseGroupCovers(releaseGroupMbid).then(releaseGroupCoverInfo => {
-    console.log('Release cover info', releaseGroupCoverInfo);
-});
+const coverArtArchiveApiClient = new CoverArtArchiveApi();
 
-coverArtArchiveApiClient.getReleaseGroupCovers(releaseGroupMbid, 'front').then(releaseGroupCoverInfo => {
-    console.log('Get best front cover', releaseGroupCoverInfo);
-});
+async function getCoverArt(releaseGroupMbid, coverType = '') {
+    try {
+        const coverInfo = await coverArtArchiveApiClient.getReleaseGroupCovers(releaseGroupMbid, coverType);
+        console.log(`Cover info for ${coverType || 'all covers'}`, coverInfo);
+    } catch (error) {
+        console.error(`Failed to fetch ${coverType || 'all covers'}:`, error);
+    }
+}
 
-coverArtArchiveApiClient.getReleaseGroupCovers(releaseGroupMbid, 'back').then(releaseGroupCoverInfo => {
-    console.log('Get best back cover', releaseGroupCoverInfo);
-});
+(async () => {
+    const releaseGroupMbid = 'your-release-group-mbid-here';  // Replace with actual MBID
+    await getCoverArt(releaseGroupMbid); // Get all covers
+    await getCoverArt(releaseGroupMbid, 'front'); // Get best front cover
+    await getCoverArt(releaseGroupMbid, 'back'); // Get best back cover
+})();
 
 ```
 

package/lib/coverartarchive-api.d.ts

@@ -21,7 +21,7 @@ export interface ICoverInfo {
     release: string;
 }
 export declare class CoverArtArchiveApi {
-    private host;
+    private httpClient;
     private getJson;
     /**
      * Fetch release

package/lib/coverartarchive-api.js

@@ -1,17 +1,16 @@
 /* eslint-disable-next-line */
-import got from 'got';
+import { HttpClient } from "./httpClient.js";
 export class CoverArtArchiveApi {
     constructor() {
-        this.host = 'coverartarchive.org';
+        this.httpClient = new HttpClient({ baseUrl: 'https://coverartarchive.org', userAgent: 'Node.js musicbrains-api', timeout: 20000 });
     }
     async getJson(path) {
-        const response = await got.get(`https://${this.host}${path}`, {
+        const response = await this.httpClient.get(path, {
             headers: {
                 Accept: "application/json"
-            },
-            responseType: 'json'
+            }
         });
-        return response.body;
+        return response.json();
     }
     /**
      * Fetch release
@@ -39,14 +38,13 @@ export class CoverArtArchiveApi {
      * @param coverType Cover type
      */
     async getCovers(releaseId, releaseType = 'release', coverType) {
-        var _a;
         const path = [releaseType, releaseId];
         if (coverType) {
             path.push(coverType);
         }
         const info = await this.getJson(`/${path.join('/')}`);
         // Hack to correct http addresses into https
-        if ((_a = info.release) === null || _a === void 0 ? void 0 : _a.startsWith('http:')) {
+        if (info.release?.startsWith('http:')) {
             info.release = `https${info.release.substring(4)}`;
         }
         return info;

package/lib/digest-auth.js

@@ -1,8 +1,6 @@
 import { v4 as uuidv4 } from 'uuid';
-import * as crypto from 'node:crypto';
-function md5(str) {
-    return crypto.createHash('md5').update(str).digest('hex'); // lgtm [js/insufficient-password-hash]
-}
+import sparkMd5 from 'spark-md5';
+const md5 = sparkMd5.hash;
 export class DigestAuth {
     /**
      * RFC 2617: handle both MD5 and MD5-sess algorithms.

package/lib/httpClient.d.ts

@@ -0,0 +1,27 @@
+export type HttpFormData = {
+    [key: string]: string;
+};
+export interface IHttpClientOptions {
+    baseUrl: string;
+    timeout: number;
+    userAgent: string;
+}
+export interface IFetchOptions {
+    query?: HttpFormData;
+    retryLimit?: number;
+    body?: string;
+    headers?: HeadersInit;
+    followRedirects?: boolean;
+}
+export declare class HttpClient {
+    private options;
+    private cookieJar;
+    constructor(options: IHttpClientOptions);
+    get(path: string, options?: IFetchOptions): Promise<Response>;
+    post(path: string, options?: IFetchOptions): Promise<Response>;
+    postForm(path: string, formData: HttpFormData, options?: IFetchOptions): Promise<Response>;
+    postJson(path: string, json: Object, options?: IFetchOptions): Promise<Response>;
+    private _fetch;
+    private registerCookies;
+    getCookies(): Promise<string>;
+}

package/lib/httpClient.js

@@ -0,0 +1,55 @@
+import { CookieJar } from "tough-cookie";
+export class HttpClient {
+    constructor(options) {
+        this.options = options;
+        this.cookieJar = new CookieJar();
+    }
+    get(path, options) {
+        return this._fetch('get', path, options);
+    }
+    post(path, options) {
+        return this._fetch('post', path, options);
+    }
+    postForm(path, formData, options) {
+        const encodedFormData = new URLSearchParams(formData).toString();
+        return this._fetch('post', path, { ...options, body: encodedFormData, headers: { 'Content-Type': 'application/x-www-form-urlencoded' } });
+    }
+    // biome-ignore lint/complexity/noBannedTypes:
+    postJson(path, json, options) {
+        const encodedJson = JSON.stringify(json);
+        return this._fetch('post', path, { ...options, body: encodedJson, headers: { 'Content-Type': 'application/json.' } });
+    }
+    async _fetch(method, path, options) {
+        if (!options)
+            options = {};
+        let url = `${this.options.baseUrl}/${path}`;
+        if (options.query) {
+            url += `?${new URLSearchParams(options.query)}`;
+        }
+        const cookies = await this.getCookies();
+        const headers = {
+            ...options.headers,
+            'User-Agent': this.options.userAgent,
+            'Cookie': cookies
+        };
+        const response = await fetch(url, {
+            method,
+            ...options,
+            headers,
+            body: options.body,
+            redirect: options.followRedirects === false ? 'manual' : 'follow'
+        });
+        await this.registerCookies(response);
+        return response;
+    }
+    registerCookies(response) {
+        const cookie = response.headers.get('set-cookie');
+        if (cookie) {
+            return this.cookieJar.setCookie(cookie, response.url);
+        }
+    }
+    getCookies() {
+        return this.cookieJar.getCookieString(this.options.baseUrl); // Get cookies for the request
+    }
+}
+//# sourceMappingURL=httpClient.js.map

package/lib/musicbrainz-api.d.ts

@@ -50,7 +50,7 @@ export interface IMusicBrainzConfig {
         username?: string;
         password?: string;
     };
-    baseUrl?: string;
+    baseUrl: string;
     appName?: string;
     appVersion?: string;
     /**
@@ -74,14 +74,13 @@ export interface ISessionInformation {
 export declare class MusicBrainzApi {
     readonly config: IMusicBrainzConfig;
     private rateLimiter;
-    private options;
+    private httpClient;
     private session?;
     static fetchCsrf(html: string): ICsrfSession;
     private static fetchValue;
-    private getCookies;
     constructor(_config?: IMusicBrainzConfig);
     restGet<T>(relUrl: string, query?: {
-        [key: string]: any;
+        [key: string]: string;
     }): Promise<T>;
     /**
      * Lookup entity

package/lib/musicbrainz-api.js

@@ -1,4 +1,3 @@
-import * as assert from 'node:assert';
 import { StatusCodes as HttpStatus } from 'http-status-codes';
 import Debug from 'debug';
 export { XmlMetadata } from './xml/xml-metadata.js';
@@ -8,10 +7,8 @@ export { XmlRecording } from './xml/xml-recording.js';
 import { DigestAuth } from './digest-auth.js';
 import { RateLimitThreshold } from 'rate-limit-threshold';
 import * as mb from './musicbrainz.types.js';
-import got from 'got';
-import { CookieJar } from 'tough-cookie';
+import { HttpClient } from "./httpClient.js";
 export * from './musicbrainz.types.js';
-import { promisify } from 'node:util';
 const debug = Debug('musicbrainz-api');
 export class MusicBrainzApi {
     static fetchCsrf(html) {
@@ -36,33 +33,21 @@ export class MusicBrainzApi {
             baseUrl: 'https://musicbrainz.org'
         };
         Object.assign(this.config, _config);
-        const cookieJar = new CookieJar();
-        this.getCookies = promisify(cookieJar.getCookies.bind(cookieJar));
-        // @ts-ignore
-        this.options = {
-            prefixUrl: this.config.baseUrl,
-            timeout: {
-                read: 20 * 1000
-            },
-            headers: {
-                'User-Agent': `${this.config.appName}/${this.config.appVersion} ( ${this.config.appContactInfo} )`
-            },
-            cookieJar: cookieJar
-        };
+        this.httpClient = new HttpClient({
+            baseUrl: this.config.baseUrl,
+            timeout: 20 * 1000,
+            userAgent: `${this.config.appName}/${this.config.appVersion} ( ${this.config.appContactInfo} )`
+        });
         this.rateLimiter = new RateLimitThreshold(15, 18);
     }
     async restGet(relUrl, query = {}) {
         query.fmt = 'json';
         await this.applyRateLimiter();
-        const response = await got.get(`ws/2${relUrl}`, {
-            ...this.options,
-            searchParams: query,
-            responseType: 'json',
-            retry: {
-                limit: 10
-            }
+        const response = await this.httpClient.get(`ws/2${relUrl}`, {
+            query,
+            retryLimit: 10
         });
-        return response.body;
+        return response.json();
     }
     lookup(entity, mbid, inc = []) {
         return this.restGet(`/${entity}/${mbid}`, { inc: inc.join(' ') });
@@ -91,20 +76,18 @@ export class MusicBrainzApi {
         const clientId = `${this.config.appName.replace(/-/g, '.')}-${this.config.appVersion}`;
         const path = `ws/2/${entity}/`;
         // Get digest challenge
-        let digest;
+        let digest = '';
         let n = 1;
         const postData = xmlMetadata.toXml();
         do {
             await this.applyRateLimiter();
-            const response = await got.post(path, {
-                ...this.options,
-                searchParams: { client: clientId },
+            const response = await this.httpClient.post(path, {
+                query: { client: clientId },
                 headers: {
                     authorization: digest,
                     'Content-Type': 'application/xml'
                 },
-                body: postData,
-                throwHttpErrors: false
+                body: postData
             });
             if (response.statusCode === HttpStatus.UNAUTHORIZED) {
                 // Respond to digest challenge
@@ -119,15 +102,13 @@ export class MusicBrainzApi {
         } while (n++ < 5);
     }
     async login() {
-        var _a, _b, _c;
-        assert.ok((_a = this.config.botAccount) === null || _a === void 0 ? void 0 : _a.username, 'bot username should be set');
-        assert.ok((_b = this.config.botAccount) === null || _b === void 0 ? void 0 : _b.password, 'bot password should be set');
-        if ((_c = this.session) === null || _c === void 0 ? void 0 : _c.loggedIn) {
-            for (const cookie of await this.getCookies(this.options.prefixUrl)) {
-                if (cookie.key === 'remember_login') {
-                    return true;
-                }
-            }
+        if (!this.config.botAccount?.username)
+            throw new Error('bot username should be set');
+        if (!this.config.botAccount?.password)
+            throw new Error('bot password should be set');
+        if (this.session?.loggedIn) {
+            const cookies = await this.httpClient.getCookies();
+            return cookies.indexOf('musicbrainz_server_session') !== -1;
         }
         this.session = await this.getSession();
         const redirectUri = '/success';
@@ -136,17 +117,15 @@ export class MusicBrainzApi {
             password: this.config.botAccount.password,
             csrf_session_key: this.session.csrf.sessionKey,
             csrf_token: this.session.csrf.token,
-            remember_me: 1
+            remember_me: '1'
         };
-        const response = await got.post('login', {
-            ...this.options,
-            followRedirect: false,
-            searchParams: {
+        const response = await this.httpClient.postForm('login', formData, {
+            query: {
                 returnto: redirectUri
             },
-            form: formData
+            followRedirects: false
         });
-        const success = response.statusCode === HttpStatus.MOVED_TEMPORARILY && response.headers.location === redirectUri;
+        const success = response.status === HttpStatus.MOVED_TEMPORARILY && response.headers.get('location') === redirectUri;
         if (success) {
             this.session.loggedIn = true;
         }
@@ -157,14 +136,13 @@ export class MusicBrainzApi {
      */
     async logout() {
         const redirectUri = '/success';
-        const response = await got.get('logout', {
-            ...this.options,
-            followRedirect: false,
-            searchParams: {
+        const response = await this.httpClient.post('logout', {
+            followRedirects: false,
+            query: {
                 returnto: redirectUri
             }
         });
-        const success = response.statusCode === HttpStatus.MOVED_TEMPORARILY && response.headers.location === redirectUri;
+        const success = response.status === HttpStatus.MOVED_TEMPORARILY && response.headers.get('location') === redirectUri;
         if (success && this.session) {
             this.session.loggedIn = true;
         }
@@ -177,24 +155,21 @@ export class MusicBrainzApi {
      * @param formData
      */
     async editEntity(entity, mbid, formData) {
-        var _a, _b;
         await this.applyRateLimiter();
         this.session = await this.getSession();
         formData.csrf_session_key = this.session.csrf.sessionKey;
         formData.csrf_token = this.session.csrf.token;
-        formData.username = (_a = this.config.botAccount) === null || _a === void 0 ? void 0 : _a.username;
-        formData.password = (_b = this.config.botAccount) === null || _b === void 0 ? void 0 : _b.password;
+        formData.username = this.config.botAccount?.username;
+        formData.password = this.config.botAccount?.password;
         formData.remember_me = 1;
-        const response = await got.post(`${entity}/${mbid}/edit`, {
-            ...this.options,
-            form: formData,
-            followRedirect: false
+        const response = await this.httpClient.postForm(`${entity}/${mbid}/edit`, formData, {
+            followRedirects: false
         });
-        if (response.statusCode === HttpStatus.OK)
+        if (response.status === HttpStatus.OK)
             throw new Error("Failed to submit form data");
-        if (response.statusCode === HttpStatus.MOVED_TEMPORARILY)
+        if (response.status === HttpStatus.MOVED_TEMPORARILY)
             return;
-        throw new Error(`Unexpected status code: ${response.statusCode}`);
+        throw new Error(`Unexpected status code: ${response.status}`);
     }
     /**
      * Set URL to recording
@@ -203,14 +178,13 @@ export class MusicBrainzApi {
      * @param editNote Edit note
      */
     async addUrlToRecording(recording, url2add, editNote = '') {
-        var _a;
         const formData = {};
         formData['edit-recording.name'] = recording.title; // Required
         formData['edit-recording.comment'] = recording.disambiguation;
         formData['edit-recording.make_votable'] = true;
         formData['edit-recording.url.0.link_type_id'] = url2add.linkTypeId;
         formData['edit-recording.url.0.text'] = url2add.text;
-        (_a = recording.isrcs) === null || _a === void 0 ? void 0 : _a.forEach((isrcs, i) => {
+        recording.isrcs?.forEach((isrcs, i) => {
             formData[`edit-recording.isrcs.${i}`] = isrcs;
         });
         formData['edit-recording.edit_note'] = editNote;
@@ -246,20 +220,20 @@ export class MusicBrainzApi {
      * @param editNote Comment to add.
      */
     addSpotifyIdToRecording(recording, spotifyId, editNote) {
-        assert.strictEqual(spotifyId.length, 22);
+        if (spotifyId.length !== 22) {
+            throw new Error('Invalid Spotify ID length');
+        }
         return this.addUrlToRecording(recording, {
             linkTypeId: mb.LinkType.stream_for_free,
             text: `https://open.spotify.com/track/${spotifyId}`
         }, editNote);
     }
     async getSession() {
-        const response = await got.get('login', {
-            ...this.options,
-            followRedirect: false, // Disable redirects
-            responseType: 'text'
+        const response = await this.httpClient.get('login', {
+            followRedirects: false
         });
         return {
-            csrf: MusicBrainzApi.fetchCsrf(response.body)
+            csrf: MusicBrainzApi.fetchCsrf(await response.text())
         };
     }
     async applyRateLimiter() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "musicbrainz-api",
-  "version": "0.17.0",
+  "version": "0.18.0",
   "description": "MusicBrainz API client for reading and submitting metadata",
   "exports": "./lib/index.js",
   "types": "lib/index.d.ts",
@@ -45,36 +45,36 @@
     "url": "https://github.com/Borewit/musicbrainz-api/issues"
   },
   "dependencies": {
-    "@biomejs/biome": "1.8.3",
-    "@types/caseless": "^0.12.1",
-    "@types/request-promise-native": "^1.0.17",
-    "@types/uuid": "^10.0.0",
-    "caseless": "^0.12.0",
     "debug": "^4.3.4",
-    "got": "^14.2.1",
     "http-status-codes": "^2.1.4",
     "json-stringify-safe": "^5.0.1",
     "jsontoxml": "^1.0.1",
-    "rate-limit-threshold": "^0.1.5",
-    "source-map-support": "^0.5.16",
+    "rate-limit-threshold": "^0.2.0",
+    "spark-md5": "^3.0.2",
     "tough-cookie": "^4.1.3",
     "uuid": "^10.0.0"
   },
   "devDependencies": {
+    "@biomejs/biome": "^1.8.3",
     "@types/chai": "^4.3.0",
     "@types/jsontoxml": "^1.0.5",
     "@types/mocha": "^10.0.4",
-    "@types/node": "^22.1.0",
+    "@types/node": "^22.5.0",
     "@types/sinon": "^17.0.3",
+    "@types/source-map-support": "^0",
+    "@types/spark-md5": "^3",
+    "@types/tough-cookie": "^4.0.5",
+    "@types/uuid": "^10.0.0",
     "c8": "^10.1.2",
-    "chai": "^5.1.0",
-    "del-cli": "^5.0.0",
-    "mocha": "^10.1.0",
+    "chai": "^5.1.1",
+    "del-cli": "^5.1.0",
+    "mocha": "^10.7.3",
     "remark-cli": "^12.0.0",
     "remark-preset-lint-recommended": "^7.0.0",
     "sinon": "^18.0.0",
-    "ts-node": "^10.0.0",
-    "typescript": "^5.0.2"
+    "source-map-support": "^0.5.21",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.5.4"
   },
   "scripts": {
     "clean": "del-cli 'lib/**/*.js' 'lib/**/*.js.map' 'lib/**/*.d.ts' 'test/**/*.js' 'test/**/*.js.map'",
@@ -88,7 +88,7 @@
     "build": "yarn run clean && yarn run compile",
     "start": "yarn run compile && yarn run lint && yarn run cover-test",
     "test-coverage": "c8 yarn run test",
-    "send-codacy": "nyc report --reporter=text-lcov | codacy-coverage"
+    "send-codacy": "c8 report --reporter=text-lcov | codacy-coverage"
   },
   "nyc": {
     "exclude": [