muse-crew 0.7.17 → 0.7.19

package/workflows/crew-init.js

@@ -29,6 +29,26 @@ if (!!dashboardSlug !== !!dashboardRepoPath) throw new Error("dashboardSlug and
 
 const orchDir = crewHome + "/.orchestration";
 
+// ── Dependency node_modules resolution (clean-room defect 2026-09-16) ──
+// lib/see-act.js and lib/render-html.js resolve playwright-core by name,
+// but the release layout severs releases/<name>/lib/ from the npm install
+// that provides node_modules — Node's upward walk never reaches it, so the
+// QA see-act loop degraded to NOT POSSIBLE and a mechanical-only PASS
+// stamped done (a rubber stamp). The crew home carries a top-level
+// node_modules symlink into the install's node_modules, resolved here
+// mechanically from crewRepoPath — no new parameters, no env vars, no
+// agent judgment:
+//   npm flow: crewRepoPath is <install>/node_modules/muse-crew -> parent
+//   git flow:  crewRepoPath is a checkout -> <repo>/node_modules
+// crew-release.sh deploy enforces the same link on every deploy; the init
+// step below is the belt-and-suspenders repeat for init.
+function resolveDepNodeModules(repoPath) {
+  var r = String(repoPath).replace(/\/+$/, "");
+  var parent = r.split("/").slice(0, -1).join("/") || "/";
+  if (parent.split("/").pop() === "node_modules") return parent;
+  return r + "/node_modules";
+}
+
 // ── Gate 0: Launchable-path validation ─────────────────────────────
 // workflow_launch only accepts workspace-contained scripts. A crewHome
 // outside the workspace would produce an instance whose workflows can
@@ -200,6 +220,48 @@ try {
 }
 log("Release: " + (releaseResult.existed ? "existing" : "bootstrapped") + " at " + releaseResult.hash);
 
+// ── Dependency node_modules symlink ───────────────────────────────────
+// The release bootstrap (crew-release.sh init -> deploy) already links
+// $CREW_HOME/node_modules into the install's node_modules; this step is the
+// explicit, mechanical belt-and-suspenders repeat. The target dir is
+// computed by resolveDepNodeModules above — the agent only runs the shell
+// verbatim, it judges nothing. A missing source dir is not fatal: the QA
+// visual-loop guard parks instead of stamping when the tooling is
+// unresolvable.
+var depNodeModules = resolveDepNodeModules(crewRepoPath);
+var safeDepNm = depNodeModules.split('"').join('\\"');
+var safeCrewHomeNm = crewHome.split('"').join('\\"');
+try {
+  var depLinkResult = await agent(
+    "Ensure the crew home's dependency node_modules symlink.\n\n" +
+    "Crew home: " + crewHome + "\n" +
+    "Dependency node_modules (computed, do not alter): " + depNodeModules + "\n\n" +
+    "Steps (run in shell exactly as written):\n" +
+    "if [ -d \"" + safeDepNm + "\" ]; then\n" +
+    "  if [ -e \"" + safeCrewHomeNm + "/node_modules\" ] && [ ! -L \"" + safeCrewHomeNm + "/node_modules\" ]; then echo REAL_DIR_KEPT;\n" +
+    "  else ln -sfn \"" + safeDepNm + "\" \"" + safeCrewHomeNm + "/node_modules\" && echo LINKED;\n" +
+    "  fi\n" +
+    "else echo MISSING_SOURCE;\n" +
+    "fi\n\n" +
+    "Return JSON { linked: <true when the symlink now resolves into the computed dir, false otherwise>, note: \"<LINKED|REAL_DIR_KEPT|MISSING_SOURCE>\" }.",
+    {
+      key: "dep-node-modules-1",
+      label: "Linking dependency node_modules",
+      schema: {
+        type: "object",
+        properties: {
+          linked: { type: "boolean" },
+          note: { type: "string" }
+        },
+        required: ["linked", "note"]
+      }
+    }
+  );
+  log("Dependency node_modules: " + (depLinkResult.note || "unknown") + " -> " + depNodeModules);
+} catch (e) {
+  log("Dependency node_modules link step errored (non-fatal): " + String(e.message || e));
+}
+
 // ── Phase 2: Scaffold ─────────────────────────────────────────────────
 // Copies identities (with portraits), personas, workflow docs, and
 // feedback convention from the crew repo into .orchestration/ under crewHome.