muse-crew 0.17.2 → 0.17.3

package/workflows/standard.js

@@ -308,13 +308,17 @@ var TOOL_CHECK_PREAMBLE =
   "Then do the assignment below.\n\n";
 function buildTransportRetryTrailer(stepName, repoPath, taskId, attempt, reason) {
   // reason: "discarded" (the runtime threw the output away — the JSON-candidate
-  // scan found {...}-shaped fragments it could not parse), "empty" (agent() returned without throwing but produced
-  // nothing usable), "no-tools" (the worker's TOOL CHECK reported
-  // artifact_tools: missing), or "no-transport" (the worker's TOOL CHECK
-  // reported shell_transport: unavailable).
+  // scan found {...}-shaped fragments it could not parse), "errored" (the
+  // attempt errored — not a brace discard), "empty" (agent() returned
+  // without throwing but produced nothing usable), "no-tools" (the
+  // worker's TOOL CHECK reported artifact_tools: missing), or
+  // "no-transport" (the worker's TOOL CHECK reported shell_transport:
+  // unavailable).
   // The trailer tells the retry what to expect, not just to try again.
   var why = reason === "empty"
     ? "your previous attempt returned no usable output"
+    : reason === "errored"
+    ? "your previous attempt errored before producing a usable report (not a brace discard — diagnose the error and report the true state in plain prose)"
     : reason === "no-tools"
     ? "your previous attempt's TOOL CHECK reported artifact_tools: missing (this is a fresh launch, so run the TOOL CHECK's load step again before the work)"
     : reason === "no-transport"
@@ -482,12 +486,11 @@ function describeWorkAgentFailure(stepName, identity, attempts) {
   // Honest classification of a work-agent call that yielded no usable
   // report, with the per-attempt evidence preserved in the session notes.
   // Two distinct cases:
-  // - agent() THREW: the runtime discarded output it could not machine-read
-  //   (e.g. prose tripping the JSON-candidate heuristic). The raw output is
-  //   gone — the workflow never received it — so the surviving error text is
-  //   recorded here instead. (An earlier comment claimed the raw output was
-  //   "preserved in the run record"; that was false — nothing preserved it —
-  //   and the claim is removed.)
+  // - agent() THREW: either the runtime discarded output it could not
+  //   machine-read (prose tripping the JSON-candidate heuristic), or the
+  //   agent errored before producing a report. The raw output is gone —
+  //   the workflow never received it — so the surviving error text is
+  //   recorded here instead.
   // - agent() RETURNED EMPTY without throwing: the child produced nothing
   //   usable. Each attempt's outcome is the evidence.
   // attempts: [{threw, error, outcome}, ...], in order.
@@ -1928,13 +1931,10 @@ while (i < STEPS.length) {
         // state agent steps were deleted — their outputs fed only the
         // retired content-verdict/receipt-attribution machinery, and the
         // toolcheck ran in a workflow child that cannot reach artifact_edit.
-        // Issuance belongs to the session-carrying tick worker, which
-        // handles tool-unavailability as inconclusive per the tick protocol.)
-        // Publish at intent. Everything above — preflight, provenance base,
-        // checksummed diff, toolcheck, pre-trigger baselines — is read-only.
         // Issuance belongs to the session-carrying tick worker
         // (scan-publish-intent's intent bucket), the only caller class that
-        // can reach artifact_edit. This entry is issuer-written BY THE
+        // can reach artifact_edit; it handles tool-unavailability as
+        // inconclusive per the tick protocol. This entry is issuer-written BY THE
         // WORKFLOW and names the intent: outcome "publish-intent", never
         // "submitted" — the workflow issued nothing. The worker claims it
         // via the park note below.
@@ -2218,7 +2218,7 @@ while (i < STEPS.length) {
   for (var workAttempt = 0; workAttempt <= 2 && !mechanicalReviewFail; workAttempt++) {
     var workKey = workAttempt === 0 ? workKeyBase : workRetryKey(step.name, (totalReworkCount > 0 ? "-r" + totalReworkCount : ""), workAttempt);
     var prevAttempt = workAttempt === 0 ? null : workAttempts[workAttempt - 1];
-    var retryReason = workAttempt === 0 ? null : (prevAttempt.threw ? "discarded" : (prevAttempt.outcome === "missing-artifact-tools" ? "no-tools" : (prevAttempt.outcome === "unavailable-shell-transport" ? "no-transport" : "empty")));
+    var retryReason = workAttempt === 0 ? null : (prevAttempt.threw ? (/output was not JSON/.test(prevAttempt.error || "") ? "discarded" : "errored") : (prevAttempt.outcome === "missing-artifact-tools" ? "no-tools" : (prevAttempt.outcome === "unavailable-shell-transport" ? "no-transport" : "empty")));
     try {
       workerResult = await agent(
         workPromptBase + (workAttempt === 0 ? "" : buildTransportRetryTrailer(step.name, REPO_PATH, taskId, workAttempt, retryReason)),