muse-crew 0.14.1 → 0.14.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/AGENTS.md +1 -1
- package/docs/decisions/AGENTS.md +3 -0
- package/docs/decisions/publish-path.md +195 -6
- package/docs/decisions/workflow-core.md +1 -1
- package/docs/guide.md +3 -3
- package/docs/publish-verification.md +5 -2
- package/docs/reviews/critic-0143-redo.md +94 -0
- package/docs/reviews/critic-0143.md +108 -0
- package/lib/AGENTS.md +5 -3
- package/lib/crew-api.js +8 -6
- package/lib/publish-npm.sh +39 -2
- package/lib/retry-publish.js +5 -2
- package/lib/test-detached-integrate.sh +416 -0
- package/lib/test-publish-preflight.sh +94 -5
- package/lib/verify-publish.js +3 -4
- package/lib/worktree-lifecycle.sh +380 -94
- package/package.json +1 -1
- package/workflows/bugfix.js +67 -70
- package/workflows/chore.js +65 -68
- package/workflows/standard.js +67 -70
package/workflows/bugfix.js
CHANGED
|
@@ -416,7 +416,10 @@ function hydrateReleaseDecision(rec) {
|
|
|
416
416
|
// fabricated from the diff; it must match the artifact's real content.
|
|
417
417
|
|
|
418
418
|
// See docs/decisions/publish-path.md#publish-attempt-ledger: every trigger outcome is recorded in the durable ledger.
|
|
419
|
-
|
|
419
|
+
// keyTag (optional): same-outcome ledger writes in one pass need distinct
|
|
420
|
+
// agent-call keys — the runtime replays cached calls by key, so a shared key
|
|
421
|
+
// silently drops the second write (2026-09-19, submitted-on-issuance).
|
|
422
|
+
async function recordPublishLedger(entry, rework, keyTag) {
|
|
420
423
|
try {
|
|
421
424
|
var ledgerDir = crewHome + "/.publish-ledger";
|
|
422
425
|
var line = JSON.stringify({
|
|
@@ -438,7 +441,7 @@ async function recordPublishLedger(entry, rework) {
|
|
|
438
441
|
"Run: mkdir -p " + sq(ledgerDir) + " && printf '%s\n' " + sq(line) +
|
|
439
442
|
" | sed \"s/@LEDGER_TS@/$(date -u +%Y-%m-%dT%H:%M:%SZ)/\" >> " + sq(ledgerDir + "/" + PUBLISH_SLUG + ".jsonl") + " && echo LEDGER_OK\n" +
|
|
440
443
|
"Return JSON { \"result\": \"<verbatim output>\" } and nothing else.",
|
|
441
|
-
{ key: attemptKey("publish-ledger-" + taskId + "-" + entry.outcome, rework),
|
|
444
|
+
{ key: attemptKey("publish-ledger-" + taskId + "-" + entry.outcome + (keyTag ? "-" + keyTag : ""), rework),
|
|
442
445
|
label: "Recording publish attempt in ledger",
|
|
443
446
|
schema: { type: "object", properties: { result: { type: "string" } }, required: ["result"] } }
|
|
444
447
|
);
|
|
@@ -685,7 +688,7 @@ let releaseDecision = null; // { release: "yes"|"no", version_bump: "patch"|"min
|
|
|
685
688
|
// Already-merged idempotency: the verified sha from the builder's
|
|
686
689
|
// `repo_diff: none (already-merged: <sha>)` declaration (null when the
|
|
687
690
|
// builder made commits or declared a runtime-state deliverable). The
|
|
688
|
-
// workflow verifies the sha is an ancestor of
|
|
691
|
+
// workflow verifies the sha is an ancestor of the integration target at Build closeout;
|
|
689
692
|
// Review's no-diff branch reads this, never the builder's prose.
|
|
690
693
|
let alreadyMergedSha = null;
|
|
691
694
|
// Deterministic publish target — computed by the workflow (registry base +
|
|
@@ -1226,7 +1229,7 @@ while (i < STEPS.length) {
|
|
|
1226
1229
|
"cd " + WORKTREE_HINT + "\n" +
|
|
1227
1230
|
"git add -A\n" +
|
|
1228
1231
|
"git commit -m \"fix: " + safeTitle + "\"\n\n" +
|
|
1229
|
-
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of
|
|
1232
|
+
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of the integration target and declare `repo_diff: none` in your report, naming the runtime-state deliverable. If you verified the deliverable is already on the integration target (a prior merge or hand-repair landed it — do NOT re-implement working code), make no commit and declare `repo_diff: none (already-merged: <sha>)` naming the integration-target commit that carries the work; the workflow verifies the sha is an ancestor of the integration target, and a false declaration fails the phase. Otherwise commit your changes normally.\n\n" +
|
|
1230
1233
|
(rejectionNotes ? "This is REWORK after rejection. Address these specific issues:\n" + rejectionNotes + "\n\n" : "") +
|
|
1231
1234
|
"Report back in plain prose: what you built and the outcome." +
|
|
1232
1235
|
(PUBLISH_TYPE === "npm" ? " End your report with the release: and version_bump: lines exactly as specified above — keep them on their own lines, lowercase, unrephrased — then a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then a final line with exactly: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not." : " End your report with a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then exactly one line: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not.");
|
|
@@ -1264,16 +1267,16 @@ while (i < STEPS.length) {
|
|
|
1264
1267
|
(mapperSpec ? "MAPPER'S SPEC (the builder was asked to implement exactly this):\n" + mapperSpec + "\n\n" : "Read the spec (from the task description or spec files under " + crewHome + "/).\n\n") +
|
|
1265
1268
|
"Examine the code changes by running:\n" +
|
|
1266
1269
|
LIFECYCLE_ENV + LIFECYCLE + " inspect " + taskId + "\n\n" +
|
|
1267
|
-
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of
|
|
1270
|
+
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of the integration target (inspect prints the target name). Base your review ONLY on this output — do NOT run git log yourself to pick commits, and do NOT discuss commit hashes from any other source (they may come from stale rework rounds or a different repo).\n\n" +
|
|
1268
1271
|
"You can also read specific files in the worktree at:\n" +
|
|
1269
1272
|
WORKTREE_HINT + "/\n\n" +
|
|
1270
1273
|
"Check quality, correctness, and spec compliance.\n" +
|
|
1271
1274
|
(SURFACE_TERMINAL ? "TERMINAL UX REVIEW: judge the CLI surface against " + UX_DOCTRINE_PATH + " — help accuracy, error quality, exit codes, output clarity. Reject when the bar is not met.\n" : "") +
|
|
1272
1275
|
(SURFACE_ARTIFACT ? "ARTIFACT UX REVIEW: judge the rendered surface against " + UX_DOCTRINE_PATH + " — alignment, spacing, hierarchy, composition, balance, finish, correctness. Reject when the bar is not met.\n" : "") +
|
|
1273
1276
|
"Check that public-affecting changes have matching public doc updates (API.md or the published API contract). If the docs are missing or inaccurate, report what is stale, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1274
|
-
"If the branch has no commits ahead of
|
|
1277
|
+
"If the branch has no commits ahead of the integration target (inspect shows an empty commit log), approve ONLY if the Build summary declares `repo_diff: none` with (a) a plausible runtime-state deliverable (e.g. a cron created via the cron tool), or (b) an already-merged declaration `repo_diff: none (already-merged: <sha>)` AND the mechanical fact below confirms the sha verified. MECHANICAL FACT (computed by the workflow, never by the builder): already_merged sha = " + (alreadyMergedSha ? alreadyMergedSha + " (verified ancestor of the integration target: YES)" : "none declared") + ". Otherwise report 'no commits ahead of the integration target and no valid repo_diff: none declaration — the builder likely forgot to commit', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1275
1278
|
(PUBLISH_TYPE === "npm" ? "PACKAGE VERSION: this project publishes to the npm registry, and versions are assigned at publish time — never in branches. Two checks:\n" +
|
|
1276
|
-
"(a) The task branch must NOT have changed package.json's `version` field.
|
|
1279
|
+
"(a) The task branch must NOT have changed package.json's `version` field. First resolve the integration target: " + LIFECYCLE_ENV + LIFECYCLE + " integration-target. Then check: cd " + REPO_PATH + " && git diff <target>..." + TASK_BRANCH + " -- package.json (substitute the exact token integration-target printed — when it prints HEAD, use the literal word HEAD: `git diff HEAD...<branch>` diffs the detached checkout against the branch). If the branch touched `version` in any way, report 'versions are assigned at publish time, never in branches — remove the version change' in your notes, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1277
1280
|
"(b) The accepted Build report declares: " + releaseDecisionText() + ". " +
|
|
1278
1281
|
(releaseDecision
|
|
1279
1282
|
? "Validate this decision against the change: release must be 'yes' when the change is consumer-observable and 'no' when internal-only; the version_bump scope must fit the change (patch for fixes, minor for new behavior, major for breaking changes). If the decision is wrong or mis-scoped, report your notes, then end with exactly this line: VERDICT: FAIL."
|
|
@@ -1281,36 +1284,32 @@ while (i < STEPS.length) {
|
|
|
1281
1284
|
"Write your review as plain prose — findings, then decision. End your report with exactly one line: VERDICT: PASS if the work passes, VERDICT: FAIL if it fails.";
|
|
1282
1285
|
|
|
1283
1286
|
} else if (step.name === "Integrate") {
|
|
1284
|
-
instructions = "Merge the approved task branch into
|
|
1285
|
-
"
|
|
1286
|
-
"
|
|
1287
|
-
"
|
|
1288
|
-
"
|
|
1289
|
-
"
|
|
1290
|
-
"-
|
|
1287
|
+
instructions = "Merge the approved task branch into the integration target and push the result.\n" +
|
|
1288
|
+
"The integration target is the repo's current checkout — a branch name, or the literal word HEAD when detached (no branch name exists when detached). Print the exact token with: "+ LIFECYCLE_ENV + LIFECYCLE + " integration-target\n" +
|
|
1289
|
+
"NEVER run git checkout — the lifecycle merges into the current checkout; moving it abandons the line Publish verifies.\n\n" +
|
|
1290
|
+
"Read the staged publish base (return its stdout verbatim):\n" + crewCmd("get-provenance", { project_id: LAUNCH_PROJECT_ID }) + "\n" +
|
|
1291
|
+
"Then run: "+ LIFECYCLE_ENV + "WORKFLOW_RUN_ID=" + lockHolder + " CREW_STAGED_BASE=<provenance.source_commit, empty when null> integrate " + taskId + " \"merge: fix: " + safeTitle + "\\\"\\n" +
|
|
1292
|
+
"The script merges, reconciles, records, and pushes under the merge lock. Informational only: RECONCILED, NO_REMOTE, NO_REMOTE_RECONCILE. Read the output:\n" +
|
|
1293
|
+
"- STAGED_BASE_MISMATCH: the line left the staged base (stray checkout). VERDICT: FAIL.\n" +
|
|
1294
|
+
"- MERGED_EMPTY — check FIRST (it contains the word MERGED): either a runtime-state deliverable or an already-merged sha the workflow verified (Build declared repo_diff: none). No lock taken, no new commit. Report 'merged empty: no repo changes'. VERDICT: PASS.\n" +
|
|
1295
|
+
"- MERGED: the merge landed; the script pushed inline. Read the push line: PUSHED — report the hash (detached prints PUSHED: origin/main (refspec HEAD:main)), VERDICT: PASS; NO_REMOTE_PUSH — no remote configured, VERDICT: PASS; ERROR after MERGED — a retry recovers the push; report it, VERDICT: FAIL.\n" +
|
|
1296
|
+
"- LOCK_HELD: 10-minute backoff exhausted. VERDICT: FAIL.\n" +
|
|
1297
|
+
"- CONFLICT: the plain merge failed — aborted, the target is clean, and your task still holds the merge lock. Do NOT fail yet. Resolve it:\n" +
|
|
1291
1298
|
"RESOLUTION:\n" +
|
|
1292
|
-
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (
|
|
1293
|
-
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours =
|
|
1294
|
-
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry
|
|
1299
|
+
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (the integration target is checked out in the repo, so create the scratch worktree from HEAD — never check out another branch in the repo checkout): cd " + REPO_PATH + " && git worktree add -b resolve/" + taskId + " /tmp/crew-resolve-" + taskId + " HEAD. Reproduce the conflict in the scratch worktree: cd /tmp/crew-resolve-" + taskId + " && git merge " + TASK_BRANCH + ". This reproduces the exact conflict (the integration target has not moved — the lock was held throughout). The task branch " + TASK_BRANCH + " is never modified.\n" +
|
|
1300
|
+
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours = the integration target), git show :3:<file> (theirs = task branch). Resolve each hunk by keeping both sides' changes when they do not semantically overlap. Version-only hunks resolve to the higher semver (safety net). Never invent new behavior. Leave no markers.\n" +
|
|
1301
|
+
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry using the failure output as context — max 3 attempts total.\n" +
|
|
1295
1302
|
"R4. Commit the resolution on resolve/" + taskId + ": git add -A && git commit -m \"resolve conflicts: " + taskId + "\".\n" +
|
|
1296
|
-
"R5. Back in " + REPO_PATH + ": git
|
|
1303
|
+
"R5. Back in " + REPO_PATH + ": git merge --ff-only resolve/" + taskId + " — merges the resolution into the current checkout (the integration target; no git checkout anywhere). It fast-forwards — the target has not moved under the lock. Report the merged hash.\n" +
|
|
1297
1304
|
"R6. Clean up: cd " + REPO_PATH + " && git worktree remove --force /tmp/crew-resolve-" + taskId + " && git branch -D resolve/" + taskId + ".\n" +
|
|
1298
|
-
"ESCALATE —
|
|
1299
|
-
"-
|
|
1300
|
-
"\n" +
|
|
1301
|
-
"
|
|
1302
|
-
"
|
|
1303
|
-
"
|
|
1304
|
-
|
|
1305
|
-
|
|
1306
|
-
" NEVER force-push. Do not run any --force variant. The lifecycle's `integrate` already reconciled origin/main under the merge lock, so a rejection means the remote advanced after that reconcile — recover mechanically while you still hold the lock:\n" +
|
|
1307
|
-
" 1. Run: cd " + REPO_PATH + " && git fetch origin main && git merge --no-edit origin/main -m \"merge: push-time reconcile (" + taskId + ")\".\n" +
|
|
1308
|
-
" 2. If the merge conflicts, abort it (git merge --abort), report 'push-time reconcile conflicted — manual resolution required', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1309
|
-
" 3. If it merges cleanly, retry the push exactly once: git push origin main. If the second push still rejects, report 'push rejected twice as non-fast-forward', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1310
|
-
" 4. If the retry succeeds, report the merged commit hash.\n\n" +
|
|
1311
|
-
"Report back in plain prose — what happened at each step — and end your report with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1312
|
-
|
|
1313
|
-
} else if (step.name === "Publish") {
|
|
1305
|
+
"ESCALATE — 'conflict needs human resolution', VERDICT: FAIL — when: 3 attempts are exhausted; the conflict touches generated files, migrations, or public API contracts; or 'looks right + checks pass' is not sufficient for any other reason. On escalation, RELEASE THE LOCK so the task can be reworked later: run CREW_HOME=" + crewHome + " CREW_REPO=" + REPO_PATH + " " + MERGE_LOCK + " release " + taskId + " (release is keyed on task id; no PID needed). Do NOT run post-deploy on escalation — it would delete the untouched task branch the human still needs.\n" +
|
|
1306
|
+
"- ERROR: report it. VERDICT: FAIL.\n\n" +
|
|
1307
|
+
"R5-PUSH (manual R5 resolution only — the normal path pushed inline). Run: " + LIFECYCLE_ENV + LIFECYCLE + " push-target " + taskId + "\n" +
|
|
1308
|
+
"PUSHED — report the merged hash (detached prints PUSHED: origin/main (refspec HEAD:main)), VERDICT: PASS; PUSH_SKIPPED — no push attempted (no record + no lock); NO_REMOTE_PUSH — no remote; VERDICT: PASS; ERROR or CONFLICT — report it, VERDICT: FAIL.\n" +
|
|
1309
|
+
"NEVER force-push.\n\n" +
|
|
1310
|
+
"Report what happened at each step, ending with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1311
|
+
|
|
1312
|
+
} else if (step.name === "Publish") {
|
|
1314
1313
|
if (PUBLISH_TYPE === "npm") {
|
|
1315
1314
|
// Deterministic publish: the workflow computed the target version and the
|
|
1316
1315
|
// agent runs exactly one command — the pinned publish script. The script
|
|
@@ -1327,7 +1326,7 @@ while (i < STEPS.length) {
|
|
|
1327
1326
|
" bash " + PUBLISH_NPM + "\n\n" +
|
|
1328
1327
|
"Do NOT run npm, npm pack, npm publish, or the python publish script yourself. Do NOT compare local and registry versions. Do NOT decide whether to publish.\n\n" +
|
|
1329
1328
|
"If the command exits nonzero, put the script's PUBLISH_FAILED line in your report, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1330
|
-
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of
|
|
1329
|
+
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Paste the marker block verbatim into your report, then end your report with exactly these three lines, in this order — lowercase, no trailing period, do not rephrase:\n" +
|
|
1331
1330
|
"TARGET_VERSION=" + publishTarget.target + " computed as " + publishTarget.base + " + " + publishTarget.scope + " → " + publishTarget.target + "\n" +
|
|
1332
1331
|
"skipped: no-lock-held (empty-diff Integrate — nothing merged, nothing to ship)\n" +
|
|
1333
1332
|
"VERDICT: PASS\n\n" +
|
|
@@ -1644,7 +1643,7 @@ while (i < STEPS.length) {
|
|
|
1644
1643
|
log("Publish pre-trigger baseline read failed for task " + taskId + " (" + (baselineErr && baselineErr.message ? baselineErr.message : baselineErr) + ") — receipt attribution skipped; durable audit-dir evidence is the only positive signal");
|
|
1645
1644
|
}
|
|
1646
1645
|
// See docs/decisions/publish-path.md#trigger-await: the artifact_edit call is awaited.
|
|
1647
|
-
var rebuildTrigger = null;
|
|
1646
|
+
var rebuildTrigger = null, triggerThrew = false;
|
|
1648
1647
|
try {
|
|
1649
1648
|
var triggerText = String(await agent(rebuildPrompt,
|
|
1650
1649
|
{ key: rebuildAttemptKey, label: "Triggering artifact rebuild" }) || "");
|
|
@@ -1664,7 +1663,18 @@ while (i < STEPS.length) {
|
|
|
1664
1663
|
}
|
|
1665
1664
|
} catch (triggerErr) {
|
|
1666
1665
|
log("Publish rebuild trigger for task " + taskId + " threw (" + (triggerErr && triggerErr.message ? triggerErr.message : triggerErr) + ") — outcome unknown until observation confirms it; the edit may have gone through");
|
|
1666
|
+
triggerThrew = true;
|
|
1667
1667
|
}
|
|
1668
|
+
// (2026-09-19, room #22) Submitted-on-issuance: see docs/decisions/publish-path.md#submitted-on-issuance.
|
|
1669
|
+
await recordPublishLedger({
|
|
1670
|
+
commit: mergeCommitForPublish,
|
|
1671
|
+
attempt: rebuildAttemptKey,
|
|
1672
|
+
agent_id: null,
|
|
1673
|
+
applied_report: publishAppliedObservation,
|
|
1674
|
+
manifest_before: preTriggerManifest,
|
|
1675
|
+
outcome: "submitted",
|
|
1676
|
+
detail: "trigger issuance: rebuild-trigger agent invoked; receipt/observation pending. Invocation only - not evidence of artifact_edit or build acceptance." + (triggerThrew ? "; trigger-threw" : "; trigger-returned")
|
|
1677
|
+
}, totalReworkCount, "issuance");
|
|
1668
1678
|
// Post-trigger observation (primary, not fallback): the workflow
|
|
1669
1679
|
// attributes the edit itself. First the in-flight build state — a
|
|
1670
1680
|
// build whose agent_id is new relative to the pre-trigger baseline
|
|
@@ -1784,8 +1794,8 @@ while (i < STEPS.length) {
|
|
|
1784
1794
|
applied_report: publishAppliedObservation,
|
|
1785
1795
|
manifest_before: preTriggerManifest,
|
|
1786
1796
|
outcome: "submitted",
|
|
1787
|
-
detail: "fire-and-forget trigger; build receipt captured by workflow-owned build-state observation (pre/post-trigger diff)"
|
|
1788
|
-
}, totalReworkCount);
|
|
1797
|
+
detail: "fire-and-forget trigger; build receipt captured by workflow-owned build-state observation (pre/post-trigger diff); observation, not re-issuance"
|
|
1798
|
+
}, totalReworkCount, "receipt");
|
|
1789
1799
|
} else {
|
|
1790
1800
|
var newAuditDirs = [];
|
|
1791
1801
|
try {
|
|
@@ -1916,10 +1926,6 @@ while (i < STEPS.length) {
|
|
|
1916
1926
|
// its outcome — submitted, rejected, or unknown (unknown is recorded
|
|
1917
1927
|
// at the park site above). A later run or human matches commit hash +
|
|
1918
1928
|
// attempt key against the builder's eventual completion.
|
|
1919
|
-
// (2026-09-16) The trigger is fire-and-forget: the observation above
|
|
1920
|
-
// already recorded the ledger's submitted line on both positive paths
|
|
1921
|
-
// and parked on unknown — there is no applied report to observe and
|
|
1922
|
-
// no rejection signal to record.
|
|
1923
1929
|
// (2026-09-18, H2 verdict-first) The verdict was decided exactly
|
|
1924
1930
|
// once above; dispatch on it. landed bypasses the receipt poll
|
|
1925
1931
|
// (the audit evidence already proved completion); an explicit
|
|
@@ -2053,21 +2059,12 @@ while (i < STEPS.length) {
|
|
|
2053
2059
|
log("Publish build landed for task " + taskId + " — provenance stamp deferred to parent content verification");
|
|
2054
2060
|
} else {
|
|
2055
2061
|
// STEP 1b durable audit-dir fallback (2026-09-15, task aadeccc3):
|
|
2056
|
-
// the poll
|
|
2057
|
-
//
|
|
2058
|
-
//
|
|
2059
|
-
//
|
|
2060
|
-
//
|
|
2061
|
-
//
|
|
2062
|
-
// that appeared during the attempt window is evidence a build
|
|
2063
|
-
// completed. Attribution is by window, not by build identity:
|
|
2064
|
-
// the poll's saw_stranger signal only catches stranger builds in
|
|
2065
|
-
// flight AT a check — a stranger that finished entirely inside
|
|
2066
|
-
// the window is indistinguishable, so any observed stranger
|
|
2067
|
-
// blocks attribution and the outcome stays unknown. This never
|
|
2068
|
-
// re-issues the edit and never stamps provenance — ok=true only
|
|
2069
|
-
// routes to the parent's independent content read-back, which
|
|
2070
|
-
// remains the real verification.
|
|
2062
|
+
// the poll observes only in-flight builds; a build that finished
|
|
2063
|
+
// inside the window leaves a durable audit dir. Diff the audit
|
|
2064
|
+
// listing against the pre-trigger snapshot: a new timestamped dir
|
|
2065
|
+
// is evidence a build completed. Attribution is by window, not by build identity: any
|
|
2066
|
+
// observed stranger blocks it. Never re-issues, never stamps;
|
|
2067
|
+
// ok=true routes to the parent's read-back (the verification).
|
|
2071
2068
|
//
|
|
2072
2069
|
// The poll end-state is read from the poll's own observations,
|
|
2073
2070
|
// not from build_done alone: a build in flight at the last check
|
|
@@ -2236,7 +2233,7 @@ while (i < STEPS.length) {
|
|
|
2236
2233
|
// artifact_edit would trigger a duplicate build.
|
|
2237
2234
|
if (publishSkippedNoLock) {
|
|
2238
2235
|
instructions = "Publish was skipped deterministically by the workflow before your step — do NOT call artifact_edit, artifact_status, setprovenance, or post-deploy yourself; doing so would disturb the finalized state.\n\n" +
|
|
2239
|
-
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of
|
|
2236
|
+
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Post-deploy step finished per its return — do NOT run post-deploy yourself.\n\n" +
|
|
2240
2237
|
"Write plain prose describing the skip, then on its own line: VERDICT: PASS\n" +
|
|
2241
2238
|
"The VERDICT line must be the last line of your report.";
|
|
2242
2239
|
} else {
|
|
@@ -2265,7 +2262,7 @@ while (i < STEPS.length) {
|
|
|
2265
2262
|
// publish skip becomes a loud QA failure with evidence, not a pass.
|
|
2266
2263
|
var npmPublishCheck = (PUBLISH_TYPE === "npm" && releaseDecision && releaseDecision.release === "yes")
|
|
2267
2264
|
? "NPM PUBLISH CHECK: the accepted Build report declared release: yes, so this run's Publish phase must have published — UNLESS it was skipped deterministically on an empty-diff Integrate. Find this task's recorded Publish result: run in shell and return the stdout verbatim:\n" + crewCmd("get-state", { events_limit: 1 }) + "\n, then find the session for this task_id with step \"Publish\" (status completed) in the returned sessions array and read its session notes (the Publish agent's summary — event history does NOT carry it).\n" +
|
|
2268
|
-
"CHECK THE SKIP PATH FIRST: if the notes contain a line matching skipped: no-lock-held, Publish was skipped deterministically — Integrate reported MERGED_EMPTY (no commits ahead of
|
|
2265
|
+
"CHECK THE SKIP PATH FIRST: if the notes contain a line matching skipped: no-lock-held, Publish was skipped deterministically — Integrate reported MERGED_EMPTY (no commits ahead of the integration target), so no merge lock was taken and there was nothing to ship. Verify the notes contain that skip-marker line and do NOT contain a line matching published: muse-crew@. Do NOT run npm view and do NOT demand registry movement — nothing was supposed to ship. Report 'npm publish check: Publish skipped deterministically (empty-diff Integrate — nothing to ship)' and PASS this check.\n" +
|
|
2269
2266
|
"Only when the notes contain no skip marker must the publish have landed — run the full verification below.\n" +
|
|
2270
2267
|
"Extract the line matching TARGET_VERSION=<new-version> computed as <base> + <scope> → <new-version> (the workflow appends it to the Publish notes, so it is always present). If the line is missing, report 'npm publish verification failed: Publish notes did not carry the computed target version', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
2271
2268
|
"Verify the bump SCOPE: the <scope> in that line MUST equal the accepted version_bump scope \"" + releaseDecision.version_bump + "\" — if it differs, report the mismatch, then end your report with exactly this line: VERDICT: FAIL. Verify the ARITHMETIC: <base> + <scope> must equal <new-version> (patch increments the last segment only, e.g. 0.3.0 + patch → 0.3.1; minor increments the middle and resets the last to 0; major increments the first and resets the rest to 0) — if the math is wrong, report it, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
@@ -2318,7 +2315,7 @@ while (i < STEPS.length) {
|
|
|
2318
2315
|
"Public docs (API.md, README) are NOT source code — read them freely, exactly as a user would.\n" +
|
|
2319
2316
|
"Read the shared UX bar FIRST: " + UX_DOCTRINE_PATH + " — it is the bar the whole crew builds to, and your verdict judges against it point by point.\n\n" +
|
|
2320
2317
|
"STEP 1: Experiential terminal inspection — drive the fixed CLI as a user would, one command at a time, and verify the reported bug is actually fixed.\n" +
|
|
2321
|
-
"a. The CLI under test lives in " + REPO_PATH + " (the merged change is on
|
|
2318
|
+
"a. The CLI under test lives in " + REPO_PATH + " (the merged change is on the integration target there). Start like a new user: run --help. You may RUN the CLI; you may never READ its source.\n" +
|
|
2322
2319
|
"b. Terminal targets for this task: " + btermTargetsLine + ".\n" +
|
|
2323
2320
|
"c. Bounded terminal loop — at most 8 commands. For each target: run it RIGHT (the happy path — the reported bug's scenario first), then run it WRONG on purpose (bad flags, missing args, nonexistent files, empty input, contradictory flags). Error quality is half the grade: every failure must exit non-zero, say what went wrong in plain language, and tell the user the fix. A raw stack trace shown to a user is a defect — file it as one.\n" +
|
|
2324
2321
|
"d. Evidence: capture EVERY invocation as a transcript. Run: mkdir -p " + btermEvidence + "\n" +
|
|
@@ -2718,19 +2715,19 @@ while (i < STEPS.length) {
|
|
|
2718
2715
|
var amCheck = await agent(
|
|
2719
2716
|
"Verify the builder's already-merged declaration.\n" +
|
|
2720
2717
|
"Run in shell and return the stdout verbatim:\n" +
|
|
2721
|
-
"cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + "
|
|
2718
|
+
"TARGET=$(" + LIFECYCLE_ENV + LIFECYCLE + " integration-target) && cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + " $TARGET && echo ALREADY_MERGED_YES || echo ALREADY_MERGED_NO",
|
|
2722
2719
|
{ key: "verify-already-merged" + (totalReworkCount > 0 ? "-r" + totalReworkCount : ""), label: "Verifying already-merged declaration" }
|
|
2723
2720
|
);
|
|
2724
2721
|
var amOut = (typeof amCheck === "string") ? amCheck : JSON.stringify(amCheck);
|
|
2725
2722
|
if (!/ALREADY_MERGED_YES/.test(amOut)) {
|
|
2726
|
-
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of
|
|
2723
|
+
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of the integration target — marking failed for retry");
|
|
2727
2724
|
await agent(
|
|
2728
2725
|
"Record already-merged verification failure.\n" +
|
|
2729
2726
|
"Run in shell and return the stdout verbatim:\n" + crewCmd("record-phase", {
|
|
2730
2727
|
task_id: taskId,
|
|
2731
2728
|
session: { id: activeSessionId, task_id: taskId, identity: step.identity, step: step.name, status: "failed",
|
|
2732
|
-
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2733
|
-
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of
|
|
2729
|
+
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target in the configured repo. The declaration is fabricated or mistaken; the work is not on the integration target. Phase failed for retry" },
|
|
2730
|
+
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of the integration target, phase failed, dispatcher will retry" }
|
|
2734
2731
|
}),
|
|
2735
2732
|
{ key: "record-already-merged-fail-" + step.name, label: "Recording already-merged verification failure" }
|
|
2736
2733
|
);
|
|
@@ -2738,13 +2735,13 @@ while (i < STEPS.length) {
|
|
|
2738
2735
|
__hatchWorkflowControl: "blocked",
|
|
2739
2736
|
result: {
|
|
2740
2737
|
blocked_reason: "Build already-merged declaration failed verification",
|
|
2741
|
-
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2738
|
+
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target. The work is not on the integration target; the phase is marked failed and the dispatcher will retry Build.",
|
|
2742
2739
|
task_id: taskId
|
|
2743
2740
|
}
|
|
2744
2741
|
};
|
|
2745
2742
|
}
|
|
2746
2743
|
alreadyMergedSha = am.sha;
|
|
2747
|
-
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of
|
|
2744
|
+
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of the integration target");
|
|
2748
2745
|
}
|
|
2749
2746
|
}
|
|
2750
2747
|
|
|
@@ -2773,7 +2770,7 @@ while (i < STEPS.length) {
|
|
|
2773
2770
|
integrateVerifyOut = "";
|
|
2774
2771
|
}
|
|
2775
2772
|
if (/^VERIFIED:/m.test(integrateVerifyOut)) {
|
|
2776
|
-
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of
|
|
2773
|
+
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of the integration target");
|
|
2777
2774
|
} else {
|
|
2778
2775
|
var integrateVerifyReason = integrateVerifyOut
|
|
2779
2776
|
? integrateVerifyOut.split("\n")[0].slice(0, 200)
|
|
@@ -2934,12 +2931,12 @@ while (i < STEPS.length) {
|
|
|
2934
2931
|
}
|
|
2935
2932
|
rejectionNotes = summary;
|
|
2936
2933
|
// Already-merged corrective (room #16 blocker 11): when Review rejected
|
|
2937
|
-
// an empty branch but the work is already on
|
|
2934
|
+
// an empty branch but the work is already on the integration target (the workflow verified
|
|
2938
2935
|
// the sha), Wren must declare it — not re-implement or re-commit
|
|
2939
2936
|
// already-landed work. Scoped to the empty-branch rejection; any other
|
|
2940
2937
|
// rejection already carries its own specific notes.
|
|
2941
|
-
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of main/i.test(summary)) {
|
|
2942
|
-
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on
|
|
2938
|
+
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of (main|the integration target)/i.test(summary)) {
|
|
2939
|
+
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on the integration target — the workflow mechanically verified that " + alreadyMergedSha + " is an ancestor of the integration target. Do NOT re-implement the work and do NOT create a new commit for it. In your Build report, declare exactly: repo_diff: none (already-merged: " + alreadyMergedSha + ") — then end with VERDICT: PASS.";
|
|
2943
2940
|
log("Rework corrective appended for task " + taskId + ": already-merged " + alreadyMergedSha + " — Wren must declare, not rebuild");
|
|
2944
2941
|
}
|
|
2945
2942
|
i = BUILD_INDEX;
|