muse-crew 0.14.1 → 0.14.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/AGENTS.md +1 -1
- package/docs/decisions/publish-path.md +6 -6
- package/docs/decisions/workflow-core.md +1 -1
- package/docs/guide.md +3 -3
- package/lib/AGENTS.md +3 -2
- package/lib/publish-npm.sh +9 -1
- package/lib/test-detached-integrate.sh +340 -0
- package/lib/worktree-lifecycle.sh +338 -94
- package/package.json +1 -1
- package/workflows/bugfix.js +42 -46
- package/workflows/chore.js +40 -44
- package/workflows/standard.js +42 -46
package/workflows/bugfix.js
CHANGED
|
@@ -685,7 +685,7 @@ let releaseDecision = null; // { release: "yes"|"no", version_bump: "patch"|"min
|
|
|
685
685
|
// Already-merged idempotency: the verified sha from the builder's
|
|
686
686
|
// `repo_diff: none (already-merged: <sha>)` declaration (null when the
|
|
687
687
|
// builder made commits or declared a runtime-state deliverable). The
|
|
688
|
-
// workflow verifies the sha is an ancestor of
|
|
688
|
+
// workflow verifies the sha is an ancestor of the integration target at Build closeout;
|
|
689
689
|
// Review's no-diff branch reads this, never the builder's prose.
|
|
690
690
|
let alreadyMergedSha = null;
|
|
691
691
|
// Deterministic publish target — computed by the workflow (registry base +
|
|
@@ -1226,7 +1226,7 @@ while (i < STEPS.length) {
|
|
|
1226
1226
|
"cd " + WORKTREE_HINT + "\n" +
|
|
1227
1227
|
"git add -A\n" +
|
|
1228
1228
|
"git commit -m \"fix: " + safeTitle + "\"\n\n" +
|
|
1229
|
-
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of
|
|
1229
|
+
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of the integration target and declare `repo_diff: none` in your report, naming the runtime-state deliverable. If you verified the deliverable is already on the integration target (a prior merge or hand-repair landed it — do NOT re-implement working code), make no commit and declare `repo_diff: none (already-merged: <sha>)` naming the integration-target commit that carries the work; the workflow verifies the sha is an ancestor of the integration target, and a false declaration fails the phase. Otherwise commit your changes normally.\n\n" +
|
|
1230
1230
|
(rejectionNotes ? "This is REWORK after rejection. Address these specific issues:\n" + rejectionNotes + "\n\n" : "") +
|
|
1231
1231
|
"Report back in plain prose: what you built and the outcome." +
|
|
1232
1232
|
(PUBLISH_TYPE === "npm" ? " End your report with the release: and version_bump: lines exactly as specified above — keep them on their own lines, lowercase, unrephrased — then a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then a final line with exactly: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not." : " End your report with a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then exactly one line: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not.");
|
|
@@ -1264,16 +1264,16 @@ while (i < STEPS.length) {
|
|
|
1264
1264
|
(mapperSpec ? "MAPPER'S SPEC (the builder was asked to implement exactly this):\n" + mapperSpec + "\n\n" : "Read the spec (from the task description or spec files under " + crewHome + "/).\n\n") +
|
|
1265
1265
|
"Examine the code changes by running:\n" +
|
|
1266
1266
|
LIFECYCLE_ENV + LIFECYCLE + " inspect " + taskId + "\n\n" +
|
|
1267
|
-
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of
|
|
1267
|
+
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of the integration target (inspect prints the target name). Base your review ONLY on this output — do NOT run git log yourself to pick commits, and do NOT discuss commit hashes from any other source (they may come from stale rework rounds or a different repo).\n\n" +
|
|
1268
1268
|
"You can also read specific files in the worktree at:\n" +
|
|
1269
1269
|
WORKTREE_HINT + "/\n\n" +
|
|
1270
1270
|
"Check quality, correctness, and spec compliance.\n" +
|
|
1271
1271
|
(SURFACE_TERMINAL ? "TERMINAL UX REVIEW: judge the CLI surface against " + UX_DOCTRINE_PATH + " — help accuracy, error quality, exit codes, output clarity. Reject when the bar is not met.\n" : "") +
|
|
1272
1272
|
(SURFACE_ARTIFACT ? "ARTIFACT UX REVIEW: judge the rendered surface against " + UX_DOCTRINE_PATH + " — alignment, spacing, hierarchy, composition, balance, finish, correctness. Reject when the bar is not met.\n" : "") +
|
|
1273
1273
|
"Check that public-affecting changes have matching public doc updates (API.md or the published API contract). If the docs are missing or inaccurate, report what is stale, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1274
|
-
"If the branch has no commits ahead of
|
|
1274
|
+
"If the branch has no commits ahead of the integration target (inspect shows an empty commit log), approve ONLY if the Build summary declares `repo_diff: none` with (a) a plausible runtime-state deliverable (e.g. a cron created via the cron tool), or (b) an already-merged declaration `repo_diff: none (already-merged: <sha>)` AND the mechanical fact below confirms the sha verified. MECHANICAL FACT (computed by the workflow, never by the builder): already_merged sha = " + (alreadyMergedSha ? alreadyMergedSha + " (verified ancestor of the integration target: YES)" : "none declared") + ". Otherwise report 'no commits ahead of the integration target and no valid repo_diff: none declaration — the builder likely forgot to commit', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1275
1275
|
(PUBLISH_TYPE === "npm" ? "PACKAGE VERSION: this project publishes to the npm registry, and versions are assigned at publish time — never in branches. Two checks:\n" +
|
|
1276
|
-
"(a) The task branch must NOT have changed package.json's `version` field.
|
|
1276
|
+
"(a) The task branch must NOT have changed package.json's `version` field. First resolve the integration target: " + LIFECYCLE_ENV + LIFECYCLE + " integration-target. Then check: cd " + REPO_PATH + " && git diff <target>..." + TASK_BRANCH + " -- package.json (substitute the exact token integration-target printed — when it prints HEAD, use the literal word HEAD: `git diff HEAD...<branch>` diffs the detached checkout against the branch). If the branch touched `version` in any way, report 'versions are assigned at publish time, never in branches — remove the version change' in your notes, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1277
1277
|
"(b) The accepted Build report declares: " + releaseDecisionText() + ". " +
|
|
1278
1278
|
(releaseDecision
|
|
1279
1279
|
? "Validate this decision against the change: release must be 'yes' when the change is consumer-observable and 'no' when internal-only; the version_bump scope must fit the change (patch for fixes, minor for new behavior, major for breaking changes). If the decision is wrong or mis-scoped, report your notes, then end with exactly this line: VERDICT: FAIL."
|
|
@@ -1281,36 +1281,32 @@ while (i < STEPS.length) {
|
|
|
1281
1281
|
"Write your review as plain prose — findings, then decision. End your report with exactly one line: VERDICT: PASS if the work passes, VERDICT: FAIL if it fails.";
|
|
1282
1282
|
|
|
1283
1283
|
} else if (step.name === "Integrate") {
|
|
1284
|
-
instructions = "Merge the approved task branch into
|
|
1285
|
-
"
|
|
1286
|
-
"
|
|
1287
|
-
"
|
|
1288
|
-
"
|
|
1289
|
-
"
|
|
1290
|
-
"-
|
|
1284
|
+
instructions = "Merge the approved task branch into the integration target and push the result.\n" +
|
|
1285
|
+
"The integration target is the repo's current checkout — a branch name, or the literal word HEAD when detached (no branch name exists when detached). Print the exact token with: "+ LIFECYCLE_ENV + LIFECYCLE + " integration-target\n" +
|
|
1286
|
+
"NEVER run git checkout — the lifecycle merges into the current checkout; moving it abandons the line Publish verifies.\n\n" +
|
|
1287
|
+
"Read the staged publish base (return its stdout verbatim):\n" + crewCmd("get-provenance", { project_id: LAUNCH_PROJECT_ID }) + "\n" +
|
|
1288
|
+
"Then run: "+ LIFECYCLE_ENV + "WORKFLOW_RUN_ID=" + lockHolder + " CREW_STAGED_BASE=<provenance.source_commit, empty when null> integrate " + taskId + " \"merge: fix: " + safeTitle + "\\\"\\n" +
|
|
1289
|
+
"The script merges, reconciles, records, and pushes under the merge lock. Informational only: RECONCILED, NO_REMOTE, NO_REMOTE_RECONCILE. Read the output:\n" +
|
|
1290
|
+
"- STAGED_BASE_MISMATCH: the line left the staged base (stray checkout). VERDICT: FAIL.\n" +
|
|
1291
|
+
"- MERGED_EMPTY — check FIRST (it contains the word MERGED): either a runtime-state deliverable or an already-merged sha the workflow verified (Build declared repo_diff: none). No lock taken, no new commit. Report 'merged empty: no repo changes'. VERDICT: PASS.\n" +
|
|
1292
|
+
"- MERGED: the merge landed; the script pushed inline. Read the push line: PUSHED — report the hash, VERDICT: PASS; PUSH_SKIPPED — the detached line is room-local (the merge commit + record are the evidence), VERDICT: PASS; NO_REMOTE_PUSH — no remote configured, VERDICT: PASS; ERROR after MERGED — a retry recovers the push; report it, VERDICT: FAIL.\n" +
|
|
1293
|
+
"- LOCK_HELD: 10-minute backoff exhausted. VERDICT: FAIL.\n" +
|
|
1294
|
+
"- CONFLICT: the plain merge failed — aborted, the target is clean, and your task still holds the merge lock. Do NOT fail yet. Resolve it:\n" +
|
|
1291
1295
|
"RESOLUTION:\n" +
|
|
1292
|
-
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (
|
|
1293
|
-
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours =
|
|
1294
|
-
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry
|
|
1296
|
+
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (the integration target is checked out in the repo, so create the scratch worktree from HEAD — never check out another branch in the repo checkout): cd " + REPO_PATH + " && git worktree add -b resolve/" + taskId + " /tmp/crew-resolve-" + taskId + " HEAD. Reproduce the conflict in the scratch worktree: cd /tmp/crew-resolve-" + taskId + " && git merge " + TASK_BRANCH + ". This reproduces the exact conflict (the integration target has not moved — the lock was held throughout). The task branch " + TASK_BRANCH + " is never modified.\n" +
|
|
1297
|
+
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours = the integration target), git show :3:<file> (theirs = task branch). Resolve each hunk by keeping both sides' changes when they do not semantically overlap. Version-only hunks resolve to the higher semver (safety net). Never invent new behavior. Leave no markers.\n" +
|
|
1298
|
+
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry using the failure output as context — max 3 attempts total.\n" +
|
|
1295
1299
|
"R4. Commit the resolution on resolve/" + taskId + ": git add -A && git commit -m \"resolve conflicts: " + taskId + "\".\n" +
|
|
1296
|
-
"R5. Back in " + REPO_PATH + ": git
|
|
1300
|
+
"R5. Back in " + REPO_PATH + ": git merge --ff-only resolve/" + taskId + " — merges the resolution into the current checkout (the integration target; no git checkout anywhere). It fast-forwards — the target has not moved under the lock. Report the merged hash.\n" +
|
|
1297
1301
|
"R6. Clean up: cd " + REPO_PATH + " && git worktree remove --force /tmp/crew-resolve-" + taskId + " && git branch -D resolve/" + taskId + ".\n" +
|
|
1298
|
-
"ESCALATE —
|
|
1299
|
-
"-
|
|
1300
|
-
"\n" +
|
|
1301
|
-
"
|
|
1302
|
-
"
|
|
1303
|
-
"
|
|
1304
|
-
|
|
1305
|
-
|
|
1306
|
-
" NEVER force-push. Do not run any --force variant. The lifecycle's `integrate` already reconciled origin/main under the merge lock, so a rejection means the remote advanced after that reconcile — recover mechanically while you still hold the lock:\n" +
|
|
1307
|
-
" 1. Run: cd " + REPO_PATH + " && git fetch origin main && git merge --no-edit origin/main -m \"merge: push-time reconcile (" + taskId + ")\".\n" +
|
|
1308
|
-
" 2. If the merge conflicts, abort it (git merge --abort), report 'push-time reconcile conflicted — manual resolution required', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1309
|
-
" 3. If it merges cleanly, retry the push exactly once: git push origin main. If the second push still rejects, report 'push rejected twice as non-fast-forward', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1310
|
-
" 4. If the retry succeeds, report the merged commit hash.\n\n" +
|
|
1311
|
-
"Report back in plain prose — what happened at each step — and end your report with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1312
|
-
|
|
1313
|
-
} else if (step.name === "Publish") {
|
|
1302
|
+
"ESCALATE — 'conflict needs human resolution', VERDICT: FAIL — when: 3 attempts are exhausted; the conflict touches generated files, migrations, or public API contracts; or 'looks right + checks pass' is not sufficient for any other reason. On escalation, RELEASE THE LOCK so the task can be reworked later: run CREW_HOME=" + crewHome + " CREW_REPO=" + REPO_PATH + " " + MERGE_LOCK + " release " + taskId + " (release is keyed on task id; no PID needed). Do NOT run post-deploy on escalation — it would delete the untouched task branch the human still needs.\n" +
|
|
1303
|
+
"- ERROR: report it. VERDICT: FAIL.\n\n" +
|
|
1304
|
+
"R5-PUSH (manual R5 resolution only — the normal path pushed inline). Run: " + LIFECYCLE_ENV + LIFECYCLE + " push-target " + taskId + "\n" +
|
|
1305
|
+
"PUSHED — report the merged hash, VERDICT: PASS; PUSH_SKIPPED or NO_REMOTE_PUSH — nothing to push, VERDICT: PASS; ERROR or CONFLICT — report it, VERDICT: FAIL.\n" +
|
|
1306
|
+
"NEVER force-push.\n\n" +
|
|
1307
|
+
"Report what happened at each step, ending with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1308
|
+
|
|
1309
|
+
} else if (step.name === "Publish") {
|
|
1314
1310
|
if (PUBLISH_TYPE === "npm") {
|
|
1315
1311
|
// Deterministic publish: the workflow computed the target version and the
|
|
1316
1312
|
// agent runs exactly one command — the pinned publish script. The script
|
|
@@ -1327,7 +1323,7 @@ while (i < STEPS.length) {
|
|
|
1327
1323
|
" bash " + PUBLISH_NPM + "\n\n" +
|
|
1328
1324
|
"Do NOT run npm, npm pack, npm publish, or the python publish script yourself. Do NOT compare local and registry versions. Do NOT decide whether to publish.\n\n" +
|
|
1329
1325
|
"If the command exits nonzero, put the script's PUBLISH_FAILED line in your report, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1330
|
-
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of
|
|
1326
|
+
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Paste the marker block verbatim into your report, then end your report with exactly these three lines, in this order — lowercase, no trailing period, do not rephrase:\n" +
|
|
1331
1327
|
"TARGET_VERSION=" + publishTarget.target + " computed as " + publishTarget.base + " + " + publishTarget.scope + " → " + publishTarget.target + "\n" +
|
|
1332
1328
|
"skipped: no-lock-held (empty-diff Integrate — nothing merged, nothing to ship)\n" +
|
|
1333
1329
|
"VERDICT: PASS\n\n" +
|
|
@@ -2236,7 +2232,7 @@ while (i < STEPS.length) {
|
|
|
2236
2232
|
// artifact_edit would trigger a duplicate build.
|
|
2237
2233
|
if (publishSkippedNoLock) {
|
|
2238
2234
|
instructions = "Publish was skipped deterministically by the workflow before your step — do NOT call artifact_edit, artifact_status, setprovenance, or post-deploy yourself; doing so would disturb the finalized state.\n\n" +
|
|
2239
|
-
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of
|
|
2235
|
+
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Post-deploy step finished per its return — do NOT run post-deploy yourself.\n\n" +
|
|
2240
2236
|
"Write plain prose describing the skip, then on its own line: VERDICT: PASS\n" +
|
|
2241
2237
|
"The VERDICT line must be the last line of your report.";
|
|
2242
2238
|
} else {
|
|
@@ -2265,7 +2261,7 @@ while (i < STEPS.length) {
|
|
|
2265
2261
|
// publish skip becomes a loud QA failure with evidence, not a pass.
|
|
2266
2262
|
var npmPublishCheck = (PUBLISH_TYPE === "npm" && releaseDecision && releaseDecision.release === "yes")
|
|
2267
2263
|
? "NPM PUBLISH CHECK: the accepted Build report declared release: yes, so this run's Publish phase must have published — UNLESS it was skipped deterministically on an empty-diff Integrate. Find this task's recorded Publish result: run in shell and return the stdout verbatim:\n" + crewCmd("get-state", { events_limit: 1 }) + "\n, then find the session for this task_id with step \"Publish\" (status completed) in the returned sessions array and read its session notes (the Publish agent's summary — event history does NOT carry it).\n" +
|
|
2268
|
-
"CHECK THE SKIP PATH FIRST: if the notes contain a line matching skipped: no-lock-held, Publish was skipped deterministically — Integrate reported MERGED_EMPTY (no commits ahead of
|
|
2264
|
+
"CHECK THE SKIP PATH FIRST: if the notes contain a line matching skipped: no-lock-held, Publish was skipped deterministically — Integrate reported MERGED_EMPTY (no commits ahead of the integration target), so no merge lock was taken and there was nothing to ship. Verify the notes contain that skip-marker line and do NOT contain a line matching published: muse-crew@. Do NOT run npm view and do NOT demand registry movement — nothing was supposed to ship. Report 'npm publish check: Publish skipped deterministically (empty-diff Integrate — nothing to ship)' and PASS this check.\n" +
|
|
2269
2265
|
"Only when the notes contain no skip marker must the publish have landed — run the full verification below.\n" +
|
|
2270
2266
|
"Extract the line matching TARGET_VERSION=<new-version> computed as <base> + <scope> → <new-version> (the workflow appends it to the Publish notes, so it is always present). If the line is missing, report 'npm publish verification failed: Publish notes did not carry the computed target version', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
2271
2267
|
"Verify the bump SCOPE: the <scope> in that line MUST equal the accepted version_bump scope \"" + releaseDecision.version_bump + "\" — if it differs, report the mismatch, then end your report with exactly this line: VERDICT: FAIL. Verify the ARITHMETIC: <base> + <scope> must equal <new-version> (patch increments the last segment only, e.g. 0.3.0 + patch → 0.3.1; minor increments the middle and resets the last to 0; major increments the first and resets the rest to 0) — if the math is wrong, report it, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
@@ -2318,7 +2314,7 @@ while (i < STEPS.length) {
|
|
|
2318
2314
|
"Public docs (API.md, README) are NOT source code — read them freely, exactly as a user would.\n" +
|
|
2319
2315
|
"Read the shared UX bar FIRST: " + UX_DOCTRINE_PATH + " — it is the bar the whole crew builds to, and your verdict judges against it point by point.\n\n" +
|
|
2320
2316
|
"STEP 1: Experiential terminal inspection — drive the fixed CLI as a user would, one command at a time, and verify the reported bug is actually fixed.\n" +
|
|
2321
|
-
"a. The CLI under test lives in " + REPO_PATH + " (the merged change is on
|
|
2317
|
+
"a. The CLI under test lives in " + REPO_PATH + " (the merged change is on the integration target there). Start like a new user: run --help. You may RUN the CLI; you may never READ its source.\n" +
|
|
2322
2318
|
"b. Terminal targets for this task: " + btermTargetsLine + ".\n" +
|
|
2323
2319
|
"c. Bounded terminal loop — at most 8 commands. For each target: run it RIGHT (the happy path — the reported bug's scenario first), then run it WRONG on purpose (bad flags, missing args, nonexistent files, empty input, contradictory flags). Error quality is half the grade: every failure must exit non-zero, say what went wrong in plain language, and tell the user the fix. A raw stack trace shown to a user is a defect — file it as one.\n" +
|
|
2324
2320
|
"d. Evidence: capture EVERY invocation as a transcript. Run: mkdir -p " + btermEvidence + "\n" +
|
|
@@ -2718,19 +2714,19 @@ while (i < STEPS.length) {
|
|
|
2718
2714
|
var amCheck = await agent(
|
|
2719
2715
|
"Verify the builder's already-merged declaration.\n" +
|
|
2720
2716
|
"Run in shell and return the stdout verbatim:\n" +
|
|
2721
|
-
"cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + "
|
|
2717
|
+
"TARGET=$(" + LIFECYCLE_ENV + LIFECYCLE + " integration-target) && cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + " $TARGET && echo ALREADY_MERGED_YES || echo ALREADY_MERGED_NO",
|
|
2722
2718
|
{ key: "verify-already-merged" + (totalReworkCount > 0 ? "-r" + totalReworkCount : ""), label: "Verifying already-merged declaration" }
|
|
2723
2719
|
);
|
|
2724
2720
|
var amOut = (typeof amCheck === "string") ? amCheck : JSON.stringify(amCheck);
|
|
2725
2721
|
if (!/ALREADY_MERGED_YES/.test(amOut)) {
|
|
2726
|
-
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of
|
|
2722
|
+
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of the integration target — marking failed for retry");
|
|
2727
2723
|
await agent(
|
|
2728
2724
|
"Record already-merged verification failure.\n" +
|
|
2729
2725
|
"Run in shell and return the stdout verbatim:\n" + crewCmd("record-phase", {
|
|
2730
2726
|
task_id: taskId,
|
|
2731
2727
|
session: { id: activeSessionId, task_id: taskId, identity: step.identity, step: step.name, status: "failed",
|
|
2732
|
-
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2733
|
-
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of
|
|
2728
|
+
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target in the configured repo. The declaration is fabricated or mistaken; the work is not on the integration target. Phase failed for retry" },
|
|
2729
|
+
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of the integration target, phase failed, dispatcher will retry" }
|
|
2734
2730
|
}),
|
|
2735
2731
|
{ key: "record-already-merged-fail-" + step.name, label: "Recording already-merged verification failure" }
|
|
2736
2732
|
);
|
|
@@ -2738,13 +2734,13 @@ while (i < STEPS.length) {
|
|
|
2738
2734
|
__hatchWorkflowControl: "blocked",
|
|
2739
2735
|
result: {
|
|
2740
2736
|
blocked_reason: "Build already-merged declaration failed verification",
|
|
2741
|
-
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2737
|
+
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target. The work is not on the integration target; the phase is marked failed and the dispatcher will retry Build.",
|
|
2742
2738
|
task_id: taskId
|
|
2743
2739
|
}
|
|
2744
2740
|
};
|
|
2745
2741
|
}
|
|
2746
2742
|
alreadyMergedSha = am.sha;
|
|
2747
|
-
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of
|
|
2743
|
+
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of the integration target");
|
|
2748
2744
|
}
|
|
2749
2745
|
}
|
|
2750
2746
|
|
|
@@ -2773,7 +2769,7 @@ while (i < STEPS.length) {
|
|
|
2773
2769
|
integrateVerifyOut = "";
|
|
2774
2770
|
}
|
|
2775
2771
|
if (/^VERIFIED:/m.test(integrateVerifyOut)) {
|
|
2776
|
-
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of
|
|
2772
|
+
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of the integration target");
|
|
2777
2773
|
} else {
|
|
2778
2774
|
var integrateVerifyReason = integrateVerifyOut
|
|
2779
2775
|
? integrateVerifyOut.split("\n")[0].slice(0, 200)
|
|
@@ -2934,12 +2930,12 @@ while (i < STEPS.length) {
|
|
|
2934
2930
|
}
|
|
2935
2931
|
rejectionNotes = summary;
|
|
2936
2932
|
// Already-merged corrective (room #16 blocker 11): when Review rejected
|
|
2937
|
-
// an empty branch but the work is already on
|
|
2933
|
+
// an empty branch but the work is already on the integration target (the workflow verified
|
|
2938
2934
|
// the sha), Wren must declare it — not re-implement or re-commit
|
|
2939
2935
|
// already-landed work. Scoped to the empty-branch rejection; any other
|
|
2940
2936
|
// rejection already carries its own specific notes.
|
|
2941
|
-
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of main/i.test(summary)) {
|
|
2942
|
-
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on
|
|
2937
|
+
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of (main|the integration target)/i.test(summary)) {
|
|
2938
|
+
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on the integration target — the workflow mechanically verified that " + alreadyMergedSha + " is an ancestor of the integration target. Do NOT re-implement the work and do NOT create a new commit for it. In your Build report, declare exactly: repo_diff: none (already-merged: " + alreadyMergedSha + ") — then end with VERDICT: PASS.";
|
|
2943
2939
|
log("Rework corrective appended for task " + taskId + ": already-merged " + alreadyMergedSha + " — Wren must declare, not rebuild");
|
|
2944
2940
|
}
|
|
2945
2941
|
i = BUILD_INDEX;
|
package/workflows/chore.js
CHANGED
|
@@ -690,7 +690,7 @@ let releaseDecision = null; // { release: "yes"|"no", version_bump: "patch"|"min
|
|
|
690
690
|
// Already-merged idempotency: the verified sha from the builder's
|
|
691
691
|
// `repo_diff: none (already-merged: <sha>)` declaration (null when the
|
|
692
692
|
// builder made commits or declared a runtime-state deliverable). The
|
|
693
|
-
// workflow verifies the sha is an ancestor of
|
|
693
|
+
// workflow verifies the sha is an ancestor of the integration target at Build closeout;
|
|
694
694
|
// Review's no-diff branch reads this, never the builder's prose.
|
|
695
695
|
let alreadyMergedSha = null;
|
|
696
696
|
// Deterministic publish target — computed by the workflow (registry base +
|
|
@@ -1132,7 +1132,7 @@ while (i < STEPS.length) {
|
|
|
1132
1132
|
"cd " + WORKTREE_HINT + "\n" +
|
|
1133
1133
|
"git add -A\n" +
|
|
1134
1134
|
"git commit -m \"chore: " + safeTitle + "\"\n\n" +
|
|
1135
|
-
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of
|
|
1135
|
+
"If the task's deliverable is runtime state (a cron definition, scheduler change, or dashboard/config state created outside the repo) and the repository genuinely needs no change, do NOT fabricate a commit: leave the branch with no commits ahead of the integration target and declare `repo_diff: none` in your report, naming the runtime-state deliverable. If you verified the deliverable is already on the integration target (a prior merge or hand-repair landed it — do NOT re-implement working code), make no commit and declare `repo_diff: none (already-merged: <sha>)` naming the integration-target commit that carries the work; the workflow verifies the sha is an ancestor of the integration target, and a false declaration fails the phase. Otherwise commit your changes normally.\n\n" +
|
|
1136
1136
|
(rejectionNotes ? "REWORK after rejection. Address:\n" + rejectionNotes + "\n\n" : "") +
|
|
1137
1137
|
"Report back in plain prose: what you built and the outcome." +
|
|
1138
1138
|
(PUBLISH_TYPE === "npm" ? " End your report with the release: and version_bump: lines exactly as specified above — keep them on their own lines, lowercase, unrephrased — then a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then a final line with exactly: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not." : " End your report with a line `worktree: ` followed by the exact working directory path from above (copy it verbatim \u2014 it must match character-for-character), then exactly one line: VERDICT: PASS if the build is complete, VERDICT: FAIL if it is not.");
|
|
@@ -1170,16 +1170,16 @@ while (i < STEPS.length) {
|
|
|
1170
1170
|
(mapperSpec ? "MAPPER'S SPEC (the builder was asked to implement exactly this):\n" + mapperSpec + "\n\n" : "Read the spec from the task description.\n\n") +
|
|
1171
1171
|
"Examine the code changes by running:\n" +
|
|
1172
1172
|
LIFECYCLE_ENV + LIFECYCLE + " inspect " + taskId + "\n\n" +
|
|
1173
|
-
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of
|
|
1173
|
+
"The inspect output is authoritative: it prints the task branch's actual tip commit (TIP) and every commit ahead of the integration target (inspect prints the target name). Base your review ONLY on this output — do NOT run git log yourself to pick commits, and do NOT discuss commit hashes from any other source (they may come from stale rework rounds or a different repo).\n\n" +
|
|
1174
1174
|
"You can also read specific files in the worktree at:\n" +
|
|
1175
1175
|
WORKTREE_HINT + "/\n\n" +
|
|
1176
1176
|
"Check quality, correctness, spec compliance.\n" +
|
|
1177
1177
|
(SURFACE_TERMINAL ? "TERMINAL UX REVIEW: judge the CLI surface against " + UX_DOCTRINE_PATH + " — help accuracy, error quality, exit codes, output clarity. Reject when the bar is not met.\n" : "") +
|
|
1178
1178
|
(SURFACE_ARTIFACT ? "ARTIFACT UX REVIEW: judge the rendered surface against " + UX_DOCTRINE_PATH + " — alignment, spacing, hierarchy, composition, balance, finish, correctness. Reject when the bar is not met.\n" : "") +
|
|
1179
1179
|
"Check that public-affecting changes have matching public doc updates (API.md or the published API contract). If the docs are missing or inaccurate, report what is stale, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1180
|
-
"If the branch has no commits ahead of
|
|
1180
|
+
"If the branch has no commits ahead of the integration target (inspect shows an empty commit log), approve ONLY if the Build summary declares `repo_diff: none` with (a) a plausible runtime-state deliverable (e.g. a cron created via the cron tool), or (b) an already-merged declaration `repo_diff: none (already-merged: <sha>)` AND the mechanical fact below confirms the sha verified. MECHANICAL FACT (computed by the workflow, never by the builder): already_merged sha = " + (alreadyMergedSha ? alreadyMergedSha + " (verified ancestor of the integration target: YES)" : "none declared") + ". Otherwise report 'no commits ahead of the integration target and no valid repo_diff: none declaration — the builder likely forgot to commit', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1181
1181
|
(PUBLISH_TYPE === "npm" ? "PACKAGE VERSION: this project publishes to the npm registry, and versions are assigned at publish time — never in branches. Two checks:\n" +
|
|
1182
|
-
"(a) The task branch must NOT have changed package.json's `version` field.
|
|
1182
|
+
"(a) The task branch must NOT have changed package.json's `version` field. First resolve the integration target: " + LIFECYCLE_ENV + LIFECYCLE + " integration-target. Then check: cd " + REPO_PATH + " && git diff <target>..." + TASK_BRANCH + " -- package.json (substitute the exact token integration-target printed — when it prints HEAD, use the literal word HEAD: `git diff HEAD...<branch>` diffs the detached checkout against the branch). If the branch touched `version` in any way, report 'versions are assigned at publish time, never in branches — remove the version change' in your notes, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1183
1183
|
"(b) The accepted Build report declares: " + releaseDecisionText() + ". " +
|
|
1184
1184
|
(releaseDecision
|
|
1185
1185
|
? "Validate this decision against the change: release must be 'yes' when the change is consumer-observable and 'no' when internal-only; the version_bump scope must fit the change (patch for fixes, minor for new behavior, major for breaking changes). If the decision is wrong or mis-scoped, report your notes, then end with exactly this line: VERDICT: FAIL."
|
|
@@ -1187,36 +1187,32 @@ while (i < STEPS.length) {
|
|
|
1187
1187
|
"Write your review as plain prose — findings, then decision. End your report with exactly one line: VERDICT: PASS if it passes, VERDICT: FAIL if it fails.";
|
|
1188
1188
|
|
|
1189
1189
|
} else if (step.name === "Integrate") {
|
|
1190
|
-
instructions = "Merge the approved task branch into
|
|
1191
|
-
"
|
|
1192
|
-
"
|
|
1193
|
-
"
|
|
1194
|
-
"
|
|
1195
|
-
"
|
|
1196
|
-
"-
|
|
1190
|
+
instructions = "Merge the approved task branch into the integration target and push the result.\n" +
|
|
1191
|
+
"The integration target is the repo's current checkout — a branch name, or the literal word HEAD when detached (no branch name exists when detached). Print the exact token with: "+ LIFECYCLE_ENV + LIFECYCLE + " integration-target\n" +
|
|
1192
|
+
"NEVER run git checkout — the lifecycle merges into the current checkout; moving it abandons the line Publish verifies.\n\n" +
|
|
1193
|
+
"Read the staged publish base (return its stdout verbatim):\n" + crewCmd("get-provenance", { project_id: LAUNCH_PROJECT_ID }) + "\n" +
|
|
1194
|
+
"Then run: "+ LIFECYCLE_ENV + "WORKFLOW_RUN_ID=" + lockHolder + " CREW_STAGED_BASE=<provenance.source_commit, empty when null> integrate " + taskId + " \"merge: chore: " + safeTitle + "\\\"\\n" +
|
|
1195
|
+
"The script merges, reconciles, records, and pushes under the merge lock. Informational only: RECONCILED, NO_REMOTE, NO_REMOTE_RECONCILE. Read the output:\n" +
|
|
1196
|
+
"- STAGED_BASE_MISMATCH: the line left the staged base (stray checkout). VERDICT: FAIL.\n" +
|
|
1197
|
+
"- MERGED_EMPTY — check FIRST (it contains the word MERGED): either a runtime-state deliverable or an already-merged sha the workflow verified (Build declared repo_diff: none). No lock taken, no new commit. Report 'merged empty: no repo changes'. VERDICT: PASS.\n" +
|
|
1198
|
+
"- MERGED: the merge landed; the script pushed inline. Read the push line: PUSHED — report the hash, VERDICT: PASS; PUSH_SKIPPED — the detached line is room-local (the merge commit + record are the evidence), VERDICT: PASS; NO_REMOTE_PUSH — no remote configured, VERDICT: PASS; ERROR after MERGED — a retry recovers the push; report it, VERDICT: FAIL.\n" +
|
|
1199
|
+
"- LOCK_HELD: 10-minute backoff exhausted. VERDICT: FAIL.\n" +
|
|
1200
|
+
"- CONFLICT: the plain merge failed — aborted, the target is clean, and your task still holds the merge lock. Do NOT fail yet. Resolve it:\n" +
|
|
1197
1201
|
"RESOLUTION:\n" +
|
|
1198
|
-
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (
|
|
1199
|
-
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours =
|
|
1200
|
-
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry
|
|
1202
|
+
"R1. Refresh the merge lock FIRST (a long resolution must not silently lose the lock to the orphan sweep): "+ LIFECYCLE_ENV + " refresh-lock " + taskId + ". Create a scratch worktree WITH A NEW BRANCH (the integration target is checked out in the repo, so create the scratch worktree from HEAD — never check out another branch in the repo checkout): cd " + REPO_PATH + " && git worktree add -b resolve/" + taskId + " /tmp/crew-resolve-" + taskId + " HEAD. Reproduce the conflict in the scratch worktree: cd /tmp/crew-resolve-" + taskId + " && git merge " + TASK_BRANCH + ". This reproduces the exact conflict (the integration target has not moved — the lock was held throughout). The task branch " + TASK_BRANCH + " is never modified.\n" +
|
|
1203
|
+
"R2. For each conflicted file, read the three sides: git show :1:<file> (base), git show :2:<file> (ours = the integration target), git show :3:<file> (theirs = task branch). Resolve each hunk by keeping both sides' changes when they do not semantically overlap. Version-only hunks resolve to the higher semver (safety net). Never invent new behavior. Leave no markers.\n" +
|
|
1204
|
+
"R3. Verify in the scratch worktree, in this order: (a) git diff --check is clean; (b) git grep -n '^<<<<<<<' -- . returns nothing; (c) node --check every changed .js file (conflicted files plus everything listed by git diff --name-only). If any check fails, refresh the merge lock ("+ LIFECYCLE_ENV + " refresh-lock " + taskId + "), then retry using the failure output as context — max 3 attempts total.\n" +
|
|
1201
1205
|
"R4. Commit the resolution on resolve/" + taskId + ": git add -A && git commit -m \"resolve conflicts: " + taskId + "\".\n" +
|
|
1202
|
-
"R5. Back in " + REPO_PATH + ": git
|
|
1206
|
+
"R5. Back in " + REPO_PATH + ": git merge --ff-only resolve/" + taskId + " — merges the resolution into the current checkout (the integration target; no git checkout anywhere). It fast-forwards — the target has not moved under the lock. Report the merged hash.\n" +
|
|
1203
1207
|
"R6. Clean up: cd " + REPO_PATH + " && git worktree remove --force /tmp/crew-resolve-" + taskId + " && git branch -D resolve/" + taskId + ".\n" +
|
|
1204
|
-
"ESCALATE —
|
|
1205
|
-
"-
|
|
1206
|
-
"\n" +
|
|
1207
|
-
"
|
|
1208
|
-
"
|
|
1209
|
-
"
|
|
1210
|
-
|
|
1211
|
-
|
|
1212
|
-
" NEVER force-push. Do not run any --force variant. The lifecycle's `integrate` already reconciled origin/main under the merge lock, so a rejection means the remote advanced after that reconcile — recover mechanically while you still hold the lock:\n" +
|
|
1213
|
-
" 1. Run: cd " + REPO_PATH + " && git fetch origin main && git merge --no-edit origin/main -m \"merge: push-time reconcile (" + taskId + ")\".\n" +
|
|
1214
|
-
" 2. If the merge conflicts, abort it (git merge --abort), report 'push-time reconcile conflicted — manual resolution required', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1215
|
-
" 3. If it merges cleanly, retry the push exactly once: git push origin main. If the second push still rejects, report 'push rejected twice as non-fast-forward', then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1216
|
-
" 4. If the retry succeeds, report the merged commit hash.\n\n" +
|
|
1217
|
-
"Report back in plain prose — what happened at each step — and end your report with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1218
|
-
|
|
1219
|
-
} else if (step.name === "Publish") {
|
|
1208
|
+
"ESCALATE — 'conflict needs human resolution', VERDICT: FAIL — when: 3 attempts are exhausted; the conflict touches generated files, migrations, or public API contracts; or 'looks right + checks pass' is not sufficient for any other reason. On escalation, RELEASE THE LOCK so the task can be reworked later: run CREW_HOME=" + crewHome + " CREW_REPO=" + REPO_PATH + " " + MERGE_LOCK + " release " + taskId + " (release is keyed on task id; no PID needed). Do NOT run post-deploy on escalation — it would delete the untouched task branch the human still needs.\n" +
|
|
1209
|
+
"- ERROR: report it. VERDICT: FAIL.\n\n" +
|
|
1210
|
+
"R5-PUSH (manual R5 resolution only — the normal path pushed inline). Run: " + LIFECYCLE_ENV + LIFECYCLE + " push-target " + taskId + "\n" +
|
|
1211
|
+
"PUSHED — report the merged hash, VERDICT: PASS; PUSH_SKIPPED or NO_REMOTE_PUSH — nothing to push, VERDICT: PASS; ERROR or CONFLICT — report it, VERDICT: FAIL.\n" +
|
|
1212
|
+
"NEVER force-push.\n\n" +
|
|
1213
|
+
"Report what happened at each step, ending with exactly one line: VERDICT: PASS or VERDICT: FAIL.";
|
|
1214
|
+
|
|
1215
|
+
} else if (step.name === "Publish") {
|
|
1220
1216
|
if (PUBLISH_TYPE === "npm") {
|
|
1221
1217
|
// Deterministic publish: the workflow computed the target version and the
|
|
1222
1218
|
// agent runs exactly one command — the pinned publish script. The script
|
|
@@ -1233,7 +1229,7 @@ while (i < STEPS.length) {
|
|
|
1233
1229
|
" bash " + PUBLISH_NPM + "\n\n" +
|
|
1234
1230
|
"Do NOT run npm, npm pack, npm publish, or the python publish script yourself. Do NOT compare local and registry versions. Do NOT decide whether to publish.\n\n" +
|
|
1235
1231
|
"If the command exits nonzero, put the script's PUBLISH_FAILED line in your report, then end your report with exactly this line: VERDICT: FAIL.\n" +
|
|
1236
|
-
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of
|
|
1232
|
+
"If the script's output contains PUBLISH_SKIPPED=no-lock-held, the publish was skipped gracefully: Integrate reported MERGED_EMPTY (no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Paste the marker block verbatim into your report, then end your report with exactly these three lines, in this order — lowercase, no trailing period, do not rephrase:\n" +
|
|
1237
1233
|
"TARGET_VERSION=" + publishTarget.target + " computed as " + publishTarget.base + " + " + publishTarget.scope + " → " + publishTarget.target + "\n" +
|
|
1238
1234
|
"skipped: no-lock-held (empty-diff Integrate — nothing merged, nothing to ship)\n" +
|
|
1239
1235
|
"VERDICT: PASS\n\n" +
|
|
@@ -2142,7 +2138,7 @@ while (i < STEPS.length) {
|
|
|
2142
2138
|
// artifact_edit would trigger a duplicate build.
|
|
2143
2139
|
if (publishSkippedNoLock) {
|
|
2144
2140
|
instructions = "Publish was skipped deterministically by the workflow before your step — do NOT call artifact_edit, artifact_status, setprovenance, or post-deploy yourself; doing so would disturb the finalized state.\n\n" +
|
|
2145
|
-
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of
|
|
2141
|
+
"Integrate reported MERGED_EMPTY (the task branch had no commits ahead of the integration target), so no merge lock was taken and there is nothing to ship. Post-deploy step finished per its return — do NOT run post-deploy yourself.\n\n" +
|
|
2146
2142
|
"Write plain prose describing the skip, then on its own line: VERDICT: PASS\n" +
|
|
2147
2143
|
"The VERDICT line must be the last line of your report.";
|
|
2148
2144
|
} else {
|
|
@@ -2346,19 +2342,19 @@ while (i < STEPS.length) {
|
|
|
2346
2342
|
var amCheck = await agent(
|
|
2347
2343
|
"Verify the builder's already-merged declaration.\n" +
|
|
2348
2344
|
"Run in shell and return the stdout verbatim:\n" +
|
|
2349
|
-
"cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + "
|
|
2345
|
+
"TARGET=$(" + LIFECYCLE_ENV + LIFECYCLE + " integration-target) && cd " + REPO_PATH + " && git rev-parse --verify --quiet " + am.sha + " >/dev/null && git merge-base --is-ancestor " + am.sha + " $TARGET && echo ALREADY_MERGED_YES || echo ALREADY_MERGED_NO",
|
|
2350
2346
|
{ key: "verify-already-merged" + (reworkCount > 0 ? "-r" + reworkCount : ""), label: "Verifying already-merged declaration" }
|
|
2351
2347
|
);
|
|
2352
2348
|
var amOut = (typeof amCheck === "string") ? amCheck : JSON.stringify(amCheck);
|
|
2353
2349
|
if (!/ALREADY_MERGED_YES/.test(amOut)) {
|
|
2354
|
-
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of
|
|
2350
|
+
log("Build already-merged declaration failed verification — " + am.sha + " is not an ancestor of the integration target — marking failed for retry");
|
|
2355
2351
|
await agent(
|
|
2356
2352
|
"Record already-merged verification failure.\n" +
|
|
2357
2353
|
"Run in shell and return the stdout verbatim:\n" + crewCmd("record-phase", {
|
|
2358
2354
|
task_id: taskId,
|
|
2359
2355
|
session: { id: activeSessionId, task_id: taskId, identity: step.identity, step: step.name, status: "failed",
|
|
2360
|
-
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2361
|
-
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of
|
|
2356
|
+
notes: "Build declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target in the configured repo. The declaration is fabricated or mistaken; the work is not on the integration target. Phase failed for retry" },
|
|
2357
|
+
event: { task_id: taskId, type: "failed", message: "Build already-merged declaration failed verification — " + am.sha + " not an ancestor of the integration target, phase failed, dispatcher will retry" }
|
|
2362
2358
|
}),
|
|
2363
2359
|
{ key: "record-already-merged-fail-" + step.name, label: "Recording already-merged verification failure" }
|
|
2364
2360
|
);
|
|
@@ -2366,13 +2362,13 @@ while (i < STEPS.length) {
|
|
|
2366
2362
|
__hatchWorkflowControl: "blocked",
|
|
2367
2363
|
result: {
|
|
2368
2364
|
blocked_reason: "Build already-merged declaration failed verification",
|
|
2369
|
-
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of
|
|
2365
|
+
message: "The builder declared repo_diff: none (already-merged: " + am.sha + ") but " + am.sha + " is not an ancestor of the integration target. The work is not on the integration target; the phase is marked failed and the dispatcher will retry Build.",
|
|
2370
2366
|
task_id: taskId
|
|
2371
2367
|
}
|
|
2372
2368
|
};
|
|
2373
2369
|
}
|
|
2374
2370
|
alreadyMergedSha = am.sha;
|
|
2375
|
-
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of
|
|
2371
|
+
log("Build already-merged declaration verified: " + am.sha + " is an ancestor of the integration target");
|
|
2376
2372
|
}
|
|
2377
2373
|
}
|
|
2378
2374
|
|
|
@@ -2401,7 +2397,7 @@ while (i < STEPS.length) {
|
|
|
2401
2397
|
integrateVerifyOut = "";
|
|
2402
2398
|
}
|
|
2403
2399
|
if (/^VERIFIED:/m.test(integrateVerifyOut)) {
|
|
2404
|
-
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of
|
|
2400
|
+
log("Integrate verified for task " + taskId + ": task branch tip is an ancestor of the integration target");
|
|
2405
2401
|
} else {
|
|
2406
2402
|
var integrateVerifyReason = integrateVerifyOut
|
|
2407
2403
|
? integrateVerifyOut.split("\n")[0].slice(0, 200)
|
|
@@ -2535,12 +2531,12 @@ while (i < STEPS.length) {
|
|
|
2535
2531
|
}
|
|
2536
2532
|
rejectionNotes = summary;
|
|
2537
2533
|
// Already-merged corrective (room #16 blocker 11): when Review rejected
|
|
2538
|
-
// an empty branch but the work is already on
|
|
2534
|
+
// an empty branch but the work is already on the integration target (the workflow verified
|
|
2539
2535
|
// the sha), Wren must declare it — not re-implement or re-commit
|
|
2540
2536
|
// already-landed work. Scoped to the empty-branch rejection; any other
|
|
2541
2537
|
// rejection already carries its own specific notes.
|
|
2542
|
-
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of main/i.test(summary)) {
|
|
2543
|
-
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on
|
|
2538
|
+
if (step.name === "Review" && alreadyMergedSha && /no commits ahead of (main|the integration target)/i.test(summary)) {
|
|
2539
|
+
rejectionNotes += "\n\nCORRECTIVE (from the workflow, not the reviewer): the deliverable is already on the integration target — the workflow mechanically verified that " + alreadyMergedSha + " is an ancestor of the integration target. Do NOT re-implement the work and do NOT create a new commit for it. In your Build report, declare exactly: repo_diff: none (already-merged: " + alreadyMergedSha + ") — then end with VERDICT: PASS.";
|
|
2544
2540
|
log("Rework corrective appended for task " + taskId + ": already-merged " + alreadyMergedSha + " — Wren must declare, not rebuild");
|
|
2545
2541
|
}
|
|
2546
2542
|
i = BUILD_INDEX;
|