munim-bluetooth 0.3.17 → 0.3.19

package/ios/HybridMunimBluetooth.swift

@@ -95,34 +95,47 @@ class HybridMunimBluetooth: HybridMunimBluetoothSpec {
         
         var advertisingData: [String: Any] = [:]
         
-        // Service UUIDs
+        // Service UUIDs - ALLOWED
         if !options.serviceUUIDs.isEmpty {
             let uuids = options.serviceUUIDs.compactMap { CBUUID(string: $0) }
             advertisingData[CBAdvertisementDataServiceUUIDsKey] = uuids
             NSLog("[MunimBluetooth] Advertising service UUIDs: %@", options.serviceUUIDs)
         }
         
-        // Local name
+        // Local name - ALLOWED
         if let localName = options.localName {
             advertisingData[CBAdvertisementDataLocalNameKey] = localName
             NSLog("[MunimBluetooth] Advertising local name: %@", localName)
         }
         
-        // Manufacturer data
-        if let manufacturerData = options.manufacturerData,
-           let data = hexStringToData(manufacturerData) {
-            advertisingData[CBAdvertisementDataManufacturerDataKey] = data
-            NSLog("[MunimBluetooth] Advertising manufacturer data: %@ bytes", String(data.count))
+        // Manufacturer data - NOT ALLOWED by iOS for peripheral advertising
+        // This can only be included when you're a central scanning for peripherals
+        if options.manufacturerData != nil {
+            NSLog("[MunimBluetooth] ⚠️ WARNING: Manufacturer data cannot be advertised on iOS")
+            NSLog("[MunimBluetooth] iOS only allows localName and serviceUUIDs in peripheral advertisements")
+            // Don't add it to advertisingData - it will cause a warning/error
         }
         
-        // Advertising data
+        // Advertising data types - Most are NOT ALLOWED
         if let advertisingDataTypes = options.advertisingData {
-            processAdvertisingData(advertisingDataTypes, into: &advertisingData)
+            // Only process allowed fields
+            if let completeLocalName = advertisingDataTypes.completeLocalName {
+                advertisingData[CBAdvertisementDataLocalNameKey] = completeLocalName
+                NSLog("[MunimBluetooth] Using complete local name from advertising data: %@", completeLocalName)
+            }
+            
+            // Warn about unsupported fields
+            if advertisingDataTypes.txPowerLevel != nil {
+                NSLog("[MunimBluetooth] ⚠️ WARNING: txPowerLevel cannot be set in peripheral advertisements on iOS")
+            }
+            if advertisingDataTypes.flags != nil {
+                NSLog("[MunimBluetooth] ⚠️ WARNING: flags cannot be set in peripheral advertisements on iOS")
+            }
         }
         
         currentAdvertisingData = options.advertisingData
         
-        NSLog("[MunimBluetooth] Starting advertising with data: %@", advertisingData)
+        NSLog("[MunimBluetooth] Starting advertising with allowed data: %@", advertisingData)
         peripheralManager.startAdvertising(advertisingData)
     }
     
@@ -196,15 +209,32 @@ class HybridMunimBluetooth: HybridMunimBluetoothSpec {
                     }
                 }
                 
-                var value: Data?
-                if let valueString = characteristic.value {
-                    value = hexStringToData(valueString)
-                    if !properties.contains(.read) {
-                        properties.insert(.read)
+                // Important: In CoreBluetooth, if you provide a 'value' parameter,
+                // the characteristic becomes cached and read-only.
+                // For writable characteristics, the value MUST be nil.
+                var value: Data? = nil
+                let hasWriteProperty = properties.contains(.write) || properties.contains(.writeWithoutResponse)
+                
+                if !hasWriteProperty {
+                    // Only set a static value for read-only characteristics
+                    if let valueString = characteristic.value {
+                        value = hexStringToData(valueString)
                     }
                 }
                 
-                let permissions: CBAttributePermissions = value != nil ? .readable : [.readable, .writeable]
+                // Always ensure read is present if we have a value
+                if value != nil && !properties.contains(.read) {
+                    properties.insert(.read)
+                }
+                
+                // Set permissions based on properties
+                var permissions: CBAttributePermissions = []
+                if properties.contains(.read) {
+                    permissions.insert(.readable)
+                }
+                if hasWriteProperty {
+                    permissions.insert(.writeable)
+                }
                 
                 let mutableChar = CBMutableCharacteristic(
                     type: charUUID,
@@ -214,7 +244,8 @@ class HybridMunimBluetooth: HybridMunimBluetoothSpec {
                 )
                 
                 characteristics.append(mutableChar)
-                NSLog("[MunimBluetooth] Characteristic added: %@ with properties: %lu", characteristic.uuid, properties.rawValue)
+                NSLog("[MunimBluetooth] Characteristic added: %@ with properties: %lu, hasValue: %@", 
+                      characteristic.uuid, properties.rawValue, value != nil ? "YES" : "NO")
             }
             
             mutableService.characteristics = characteristics

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "munim-bluetooth",
-  "version": "0.3.17",
+  "version": "0.3.19",
   "description": "A comprehensive React Native library for all your Bluetooth Low Energy (BLE) needs, supporting both peripheral and central roles with Expo support",
   "main": "./lib/commonjs/index.js",
   "module": "./lib/module/index.js",