multi-db-orm 1.3.1 → 1.3.2

package/README.md

@@ -24,7 +24,7 @@ const { MultiDbORM, FireStoreDB, MongoDB, SQLiteDB, Sync } = require("multi-db-o
 
 // Firestore
 var firebasedb = new FireStoreDB(require("/path/to/serviceAccountFile.json"));
-Note: If you use firebase DB then keys with undefined values will be removed while insert or update
+Note: If you use firebase DB then keys with undefined values will be set to null while insert or update as firebase dosent support undefined values
 
 // Sqlite
 var sqlitedb = new SQLiteDB("/path/to/mydatabase.db"); // if no path is passed , an in-memory db is used

package/engines/firestoredb.js

@@ -1,16 +1,19 @@
 const { MultiDbORM } = require("./multidb");
 
-function removeUndefined(obj) {
+function replaceUndefinedWithNull(obj) {
     try {
 
-        Object.keys(obj).forEach(function (key) {
-            if (typeof obj[key] === 'undefined') {
-                delete obj[key];
+        for (let key in obj) {
+            if (obj.hasOwnProperty(key)) {
+                if (typeof obj[key] === 'object' && obj[key] !== null) {
+                    replaceUndefinedWithNull(obj[key]);
+                } else if (typeof obj[key] === 'undefined') {
+                    obj[key] = null;
+                }
             }
-        });
-        return obj
+        }
     } catch (e) {
-        console.log('Error in sanitizing update of object ! ', e.message)
+        console.log('Error in sanitizing object before insert/update ! ', e.message)
     }
 }
 
@@ -142,7 +145,7 @@ class FireStoreDB extends MultiDbORM {
     }
 
     async insert(modelname, object, id) {
-        removeUndefined(object)
+        replaceUndefinedWithNull(object)
         this.sync.insert(modelname, object, id)
         this.metrics.insert(modelname, object, id)
 
@@ -150,7 +153,7 @@ class FireStoreDB extends MultiDbORM {
         var idx = id || object.id || Date.now()
         const docref = db.collection(modelname).doc("" + idx);
         try {
-            removeUndefined(object)
+            replaceUndefinedWithNull(object)
             return await docref.set(object);
         } catch (e) {
 
@@ -172,7 +175,7 @@ class FireStoreDB extends MultiDbORM {
 
 
         try {
-            removeUndefined(object)
+            replaceUndefinedWithNull(object)
             if (idx) {
                 this.metrics.update(modelname, filter, object, id)
                 await this.getdb().collection(modelname).doc(idx).update(object);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "multi-db-orm",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "CRUD , Backup , Restore and Migration library for multiple databases",
   "main": "index.js",
   "dependencies": {