mulmoclaude 2.5.0 → 2.6.0

package/server/index.ts

@@ -59,6 +59,10 @@ import "./plugins/html-builtin.js";
 // presentShapeScript View's useRuntime().dispatch({ kind }) resolves — the
 // source editor's load / save against artifacts/shapes/.
 import "./plugins/shapescript-builtin.js";
+// Side-effect: registers the built-in "kentei" dispatch handler so the
+// manageKenteiScript View's useRuntime().dispatch({ kind: "grade" }) resolves
+// (JEV grading with the server's TYPESAFE_API_KEY).
+import "./plugins/kentei-builtin.js";
 import { enableShapeScriptManifold } from "./plugins/shapescript-csg.js";
 import { loadRuntimePlugins } from "./plugins/runtime-loader.js";
 import { evaluateDevPluginGate, loadDevPlugins, parseDevPluginsEnv } from "./plugins/dev-loader.js";

package/server/plugins/kentei-builtin.ts

@@ -0,0 +1,47 @@
+// MulmoClaude's host wiring for the manageKenteiScript plugin (`kenteiscript`
+// npm package). Two entry points reach the package's executor:
+//
+//   - the tool's actions (getGuide / getSchema / checkScript / present), posted
+//     by the MCP bridge to API_ROUTES.kentei.dispatch (server/api/routes/plugins.ts);
+//   - the View's `useRuntime().dispatch({ kind: "grade", … })`, registered here
+//     as the built-in "kentei" dispatch handler so it resolves on
+//     /api/plugins/runtime/kentei/dispatch.
+//
+// Both hand the package the same context. Its only capability is
+// `files.byPath` (`.json` only), which is what makes the tool's `path`
+// argument work — a runtime-plugin install gets an empty context
+// (server/api/routes/runtime-plugin.ts), so `path` would be refused there.
+// Grading reads TYPESAFE_API_KEY (and optional JEV_MODEL / JEV_URL) from this
+// process's environment inside the package; the key never reaches the browser.
+// Imported for side effect at boot (server/index.ts).
+
+import { isGradeRequest, manageKenteiScript, type KenteiContext } from "kenteiscript/plugin";
+import { describeKind, registerBuiltinDispatch } from "./builtin-dispatch.js";
+import { makeByPathFileOps } from "../utils/files/by-path.js";
+
+/** Scope name — matches `wrapWithScope("kentei", …)` in
+ *  `src/plugins/manageKenteiScript/index.ts`, which is what the View's
+ *  `useRuntime().dispatch` uses as the `:pkg` path segment. */
+const KENTEI_SCOPE = "kentei";
+
+/** A KenteiScript is a JSON file, so `path` may name only `.json`. */
+export const KENTEI_SCRIPT_EXTENSIONS: readonly string[] = [".json"];
+
+// Built once: by-path file ops hold no state.
+const kenteiFiles = { byPath: makeByPathFileOps(KENTEI_SCRIPT_EXTENSIONS) };
+
+/** Run the package's executor with MulmoClaude's capabilities added to
+ *  whatever per-request context the caller has (e.g. `currentResult`). */
+export function executeKenteiScript(context: KenteiContext, args: unknown): Promise<unknown> {
+  return manageKenteiScript({ ...context, files: kenteiFiles }, args);
+}
+
+// `args` is whatever the View put on the wire. The View dispatches only
+// `{ kind: "grade" }`; tool actions arrive on the MCP route, so anything else
+// here is refused rather than run.
+registerBuiltinDispatch(KENTEI_SCOPE, async (args) => {
+  if (!isGradeRequest(args)) {
+    throw new Error(`kentei plugin: unrecognised dispatch payload (kind=${describeKind(args)})`);
+  }
+  return executeKenteiScript({}, args);
+});

package/src/config/roles.ts

@@ -239,11 +239,12 @@ export const ROLES: [Role, ...Role[]] = [
     name: "Tutor",
     icon: "school",
     prompt:
-      "You are an experienced tutor who adapts to each student's level. Before teaching any topic, you MUST first evaluate the student's current knowledge by asking them 4-5 relevant questions about the topic by calling the putQuestions API. Based on their answers, adjust your teaching approach to match their understanding level. When explaining something to the student, choose the best presentation method for the topic: use presentHTML for topics that benefit from interactive or visual elements (e.g. diagrams, animations, interactive demos, math visualizations, maps, timelines), and use presentDocument for topics that are best explained with structured text and sections (e.g. definitions, historical facts, step-by-step processes). Use generateImage to create visual aids when appropriate. Always encourage critical thinking by asking follow-up questions and checking for understanding throughout the lesson. To evaluate the student's understanding, you can use the presentForm API to create a form that the student can fill out.",
+      "You are an experienced tutor who adapts to each student's level. Before teaching any topic, you MUST first evaluate the student's current knowledge with a short quiz of 4-5 questions about the topic. If you have the manageKenteiScript tool, use it for this quiz (the student answers in their own words and each answer is graded); only if you do not have it, ask the questions with putQuestions instead. If manageKenteiScript returns an error, or the quiz results say its answers couldn't be graded, ask the questions again with putQuestions rather than leaving the student without an assessment. Based on the results, adjust your teaching approach to match their understanding level. When explaining something to the student, choose the best presentation method for the topic: use presentHTML for topics that benefit from interactive or visual elements (e.g. diagrams, animations, interactive demos, math visualizations, maps, timelines), and use presentDocument for topics that are best explained with structured text and sections (e.g. definitions, historical facts, step-by-step processes). Use generateImage to create visual aids when appropriate. Always encourage critical thinking by asking follow-up questions and checking for understanding throughout the lesson. To evaluate the student's understanding, you can use the presentForm API to create a form that the student can fill out. For a practice test after a lesson, use manageKenteiScript the same way (or putQuestions if you do not have it). With manageKenteiScript, call getGuide, then write the KenteiScript and call present with it, in one go without replying to the student in between; if present lists problems, fix them and call present again; then wait for the results the student sends.",
     availablePlugins: [
       TOOL_NAMES.putQuestions,
       TOOL_NAMES.presentDocument,
       TOOL_NAMES.presentForm,
+      TOOL_NAMES.manageKenteiScript,
       TOOL_NAMES.generateImage,
       TOOL_NAMES.presentHtml,
       TOOL_NAMES.presentChart,

package/src/main.ts

@@ -60,6 +60,7 @@ const pluginEndpointRegistry: EndpointRegistry = {
   html: API_ROUTES.html,
   svg: API_ROUTES.svg,
   shapescript: API_ROUTES.shapescript,
+  kentei: API_ROUTES.kentei,
   chart: API_ROUTES.chart,
   accounting: API_ROUTES.accounting,
   canvas: API_ROUTES.canvas,

package/src/plugins/_generated/metas.ts

@@ -8,6 +8,7 @@ import { META as canvasMeta } from "../canvas/meta";
 import { META as chartMeta } from "../chart/meta";
 import { META as editImagesMeta } from "../editImages/meta";
 import { META as generateImageMeta } from "../generateImage/meta";
+import { META as manageKenteiScriptMeta } from "../manageKenteiScript/meta";
 import { META as manageSkillsMeta } from "../manageSkills/meta";
 import { META as markdownMeta } from "../markdown/meta";
 import { META as photoLocationsMeta } from "../photoLocations/meta";
@@ -29,6 +30,7 @@ export const GENERATED_PLUGIN_METAS = [
   chartMeta,
   editImagesMeta,
   generateImageMeta,
+  manageKenteiScriptMeta,
   manageSkillsMeta,
   markdownMeta,
   photoLocationsMeta,

package/src/plugins/_generated/registrations.ts

@@ -8,6 +8,7 @@ import { REGISTRATION as canvasRegistration } from "../canvas";
 import { REGISTRATION as chartRegistration } from "../chart";
 import { REGISTRATION as editImagesRegistration } from "../editImages";
 import { REGISTRATION as generateImageRegistration } from "../generateImage";
+import { REGISTRATION as manageKenteiScriptRegistration } from "../manageKenteiScript";
 import { REGISTRATION as manageSkillsRegistration } from "../manageSkills";
 import { REGISTRATION as markdownRegistration } from "../markdown";
 import { REGISTRATION as photoLocationsRegistration } from "../photoLocations";
@@ -33,6 +34,7 @@ export const GENERATED_PLUGIN_REGISTRATIONS: readonly PluginRegistration[] = [
   chartRegistration,
   editImagesRegistration,
   generateImageRegistration,
+  manageKenteiScriptRegistration,
   manageSkillsRegistration,
   markdownRegistration,
   photoLocationsRegistration,

package/src/plugins/_generated/server-bindings.ts

@@ -7,6 +7,7 @@ import { mcpBinding } from "../server-bindings-types";
 import accountingDef from "../accounting/definition";
 import canvasDef from "../canvas/definition";
 import chartDef from "../chart/definition";
+import manageKenteiScriptDef from "../manageKenteiScript/definition";
 import manageSkillsDef from "../manageSkills/definition";
 import markdownDef from "../markdown/definition";
 import photoLocationsDef from "../photoLocations/definition";
@@ -21,6 +22,7 @@ import spreadsheetDef from "../spreadsheet/definition";
 import { META as accountingMeta } from "../accounting/meta";
 import { META as canvasMeta } from "../canvas/meta";
 import { META as chartMeta } from "../chart/meta";
+import { META as manageKenteiScriptMeta } from "../manageKenteiScript/meta";
 import { META as manageSkillsMeta } from "../manageSkills/meta";
 import { META as markdownMeta } from "../markdown/meta";
 import { META as photoLocationsMeta } from "../photoLocations/meta";
@@ -40,6 +42,7 @@ export const GENERATED_SERVER_BINDINGS: readonly ServerPluginBinding[] = [
   mcpBinding(accountingDef, accountingMeta),
   mcpBinding(canvasDef, canvasMeta),
   mcpBinding(chartDef, chartMeta),
+  mcpBinding(manageKenteiScriptDef, manageKenteiScriptMeta),
   mcpBinding(manageSkillsDef, manageSkillsMeta),
   mcpBinding(markdownDef, markdownMeta),
   mcpBinding(photoLocationsDef, photoLocationsMeta),

package/src/plugins/manageKenteiScript/definition.ts

@@ -0,0 +1,20 @@
+import { META } from "./meta";
+import type { ResolvedRoute } from "../meta-types";
+import { TOOL_DEFINITION } from "kenteiscript/plugin";
+
+// manageKenteiScript's tool schema, KenteiScript validation, JEV grading, View
+// and Preview live in the `kenteiscript` npm package (also used by MulmoTerminal
+// and MulmoChat). This built-in is a thin host adapter, like presentShapeScript:
+// it keeps MulmoClaude's routing META and scoped-runtime wrapping, and exists
+// (rather than a runtime plugin) so the server can hand the package
+// `files.byPath`, which is what makes the tool's `path` argument work.
+//
+// Server-only: this imports the package's server entry. The browser side
+// (index.ts) takes the definition from `kenteiscript/plugin/vue`.
+export const TOOL_NAME = META.toolName;
+
+/** Resolved-URL view of the plugin's routes (dispatch). Auto-derived from META. */
+export type KenteiScriptEndpoints = { readonly [K in keyof typeof META.apiRoutes]: ResolvedRoute };
+
+export { TOOL_DEFINITION };
+export default TOOL_DEFINITION;

package/src/plugins/manageKenteiScript/index.ts

@@ -0,0 +1,39 @@
+import type { ToolPlugin } from "gui-chat-protocol/vue";
+import type { PluginRegistration } from "../../tools/types";
+import { plugin as kenteiPlugin, type KenteiData, type KenteiJson } from "kenteiscript/plugin/vue";
+// The View's scoped styles are a standalone stylesheet; Vite lib mode does not
+// inject it, so the consumer imports it (same as presentShapeScript / presentForm).
+import "kenteiscript/plugin/style.css";
+import type { KenteiScriptEndpoints } from "./definition";
+import { META } from "./meta";
+import { makeRouteExecute } from "../execute";
+import { wrapWithScope } from "../scope";
+
+// Scope name: the View's `useRuntime().dispatch({ kind: "grade", … })` posts to
+// /api/plugins/runtime/kentei/dispatch, answered by the built-in dispatch handler
+// registered in server/plugins/kentei-builtin.ts (JEV grading with the server's
+// TYPESAFE_API_KEY — the key never reaches the browser).
+const KENTEI_SCOPE = "kentei";
+
+const TOOL_NAME = META.toolName;
+
+// Imported from the browser entry, not ./definition, so the server bundle (Zod
+// and the grading code) stays out of the client.
+const pkg: ToolPlugin<KenteiData, KenteiJson, object> = kenteiPlugin;
+
+// `unknown` JSON slot: the route executor returns the server body as-is, so it
+// cannot vouch for `jsonData`'s shape (the View reads `data`, not `jsonData`).
+const kenteiScriptPlugin: ToolPlugin<KenteiData, unknown, object> = {
+  ...pkg,
+  // Every action runs on the server (POST /api/kentei), which owns the key
+  // check and the `files.byPath` capability for `path`.
+  execute: makeRouteExecute<KenteiScriptEndpoints, KenteiData>(KENTEI_SCOPE, "dispatch", TOOL_NAME),
+  ...(pkg.viewComponent ? { viewComponent: wrapWithScope(KENTEI_SCOPE, pkg.viewComponent) } : {}),
+  ...(pkg.previewComponent ? { previewComponent: wrapWithScope(KENTEI_SCOPE, pkg.previewComponent) } : {}),
+};
+export { TOOL_NAME };
+
+export const REGISTRATION: PluginRegistration = {
+  toolName: TOOL_NAME,
+  entry: kenteiScriptPlugin,
+};

package/src/plugins/manageKenteiScript/meta.ts

@@ -0,0 +1,13 @@
+import { definePluginMeta } from "../meta-types";
+
+export const META = definePluginMeta({
+  toolName: "manageKenteiScript",
+  apiNamespace: "kentei",
+  apiRoutes: {
+    /** POST /api/kentei — a manageKenteiScript action (getGuide / getSchema /
+     *  checkScript / present). The View's `{ kind: "grade" }` calls go through
+     *  the built-in dispatch channel instead (server/plugins/kentei-builtin.ts). */
+    dispatch: { method: "POST", path: "" },
+  },
+  mcpDispatch: "dispatch",
+});

package/src/plugins/spreadsheet/engine/cellBuilder.ts

@@ -11,6 +11,9 @@
  */
 
 import type { SpreadsheetCell } from "./types.js";
+import { isCallableName } from "./registry.js";
+// Registers the functions, so isCallableName knows LOG10 before any sheet is calculated.
+import "./functions/index.js";
 
 /** Inputs to the cell builder. Mirrors the mini editor refs in the
  *  View but as plain values so unit tests don't need a Vue runtime. */
@@ -29,7 +32,12 @@ export interface MiniEditorInput {
 // Anchored at the start of the input (after optional unary +/-) so we
 // only treat expressions that clearly begin with a function call as
 // formulas. Unanchored would match "abc FOO(" inside ordinary text.
-const FORMULA_FUNCTION_CALL = /^[-+]?\s*[A-Z]+\s*\(/i;
+const FORMULA_FUNCTION_CALL = /^[-+]?\s*([A-Z][A-Z0-9]*)\s*\(/i;
+
+const startsWithFunctionCall = (input: string): boolean => {
+  const name = input.match(FORMULA_FUNCTION_CALL)?.[1];
+  return name !== undefined && isCallableName(name);
+};
 
 // `A1 + B2` style — cell reference next to an arithmetic operator.
 const FORMULA_CELL_OP = /[A-Z]+\d+\s*[+\-*/^]/;
@@ -49,7 +57,7 @@ const STRICT_NUMBER = /^[-+]?(?:\d+\.?\d*|\.\d+)(?:[eE][-+]?\d+)?$/;
  * formula and gets the "=" prefix the engine expects.
  */
 export function looksLikeFormula(input: string): boolean {
-  return FORMULA_FUNCTION_CALL.test(input) || FORMULA_CELL_OP.test(input) || FORMULA_NUMERIC_OP.test(input);
+  return startsWithFunctionCall(input) || FORMULA_CELL_OP.test(input) || FORMULA_NUMERIC_OP.test(input);
 }
 
 /**

package/src/plugins/spreadsheet/engine/evaluator.ts

@@ -4,7 +4,7 @@
  * Evaluates spreadsheet formulas including functions, cell references, and arithmetic
  */
 
-import { functionRegistry, tooFewArgumentsError } from "./registry";
+import { functionRegistry, isCallableName, tooFewArgumentsError } from "./registry";
 import type { CellValue } from "./types";
 import { parseDate } from "./date-parser";
 import { caretToPow, replaceConcatOperator, rewriteComparisonEq, isSafeArithmetic, isSafeComparison } from "./translateFormula";
@@ -281,8 +281,8 @@ export function evaluateFormula(formula: string, context: EvaluatorContext): Cel
 
   // Check if it's a SIMPLE function call (not a complex expression)
   // We need to ensure the formula is JUST a function, not "FUNC(...) + something"
-  const [, funcName, argsStr] = formula.match(/^([A-Z]+)\((.*)\)$/i) ?? [];
-  if (funcName !== undefined && argsStr !== undefined) {
+  const [, funcName, argsStr] = formula.match(/^([A-Z][A-Z0-9]*)\((.*)\)$/i) ?? [];
+  if (funcName !== undefined && argsStr !== undefined && isCallableName(funcName)) {
     // Check that the closing paren is actually the end of the function
     // by counting parentheses in argsStr
     let parenDepth = 0;
@@ -346,8 +346,13 @@ export function evaluateFormula(formula: string, context: EvaluatorContext): Cel
 
   while (searchIndex < expr.length && iterations < maxIterations) {
     iterations++;
-    const [, funcName] = expr.substring(searchIndex).match(/^([A-Z]+)\(/i) ?? [];
-    if (funcName === undefined) {
+    // A call written inside a string literal is text, not a call.
+    if (expr[searchIndex] === '"' || expr[searchIndex] === "'") {
+      searchIndex = endOfStringLiteral(expr, searchIndex);
+      continue;
+    }
+    const [, funcName] = expr.substring(searchIndex).match(/^([A-Z][A-Z0-9]*)\(/i) ?? [];
+    if (funcName === undefined || !isCallableName(funcName)) {
       // No more functions found, move to next character
       searchIndex++;
       if (searchIndex >= expr.length) break;

package/src/plugins/spreadsheet/engine/registry.ts

@@ -101,6 +101,11 @@ class FunctionRegistry {
 
 export const functionRegistry = new FunctionRegistry();
 
+/** Whether `name` written before "(" is a function call. A letters-only name is,
+ *  registered or not (an unknown one reports #NAME?). A name with digits is only
+ *  when registered: LOG10 is also shaped like a cell reference, so `A1(2)` is not. */
+export const isCallableName = (name: string): boolean => /^[A-Z]+$/i.test(name) || functionRegistry.hasFunction(name);
+
 /**
  * Lenient numeric coercion for range aggregation: anything unreadable is 0.
  * PINNED behaviour (booleans are 0, not Excel's 1/0) — the string parsing lives