mulmoclaude 0.9.2 → 0.9.3

package/src/plugins/textResponse/View.vue

@@ -18,6 +18,18 @@
             <span class="material-icons text-gray-400 text-base shrink-0 group-open:rotate-180 transition-transform">expand_more</span>
           </summary>
           <div class="border-t border-purple-200 p-4 bg-white rounded-b-lg">
+            <div
+              v-if="truncationInfo.wasTruncated"
+              class="mb-3 p-3 rounded border border-amber-300 bg-amber-50 text-amber-900 text-sm"
+              data-testid="text-response-seeded-truncation-banner"
+            >
+              {{
+                t("pluginTextResponse.truncatedForRender", {
+                  omitted: truncationInfo.omittedChars.toLocaleString(locale),
+                  total: truncationInfo.originalChars.toLocaleString(locale),
+                })
+              }}
+            </div>
             <!-- eslint-disable vue/no-v-html -- marked.parse output of the plugin-seeded prompt; trusted in-process render matching the standard textResponse path. Multi-line element so disable/enable pair (CLAUDE.md UI rule). -->
             <div ref="markdownContainerRef" class="markdown-content prose prose-slate max-w-none" @click="openLinksInNewTab" v-html="renderedHtml"></div>
             <!-- eslint-enable vue/no-v-html -->
@@ -62,6 +74,18 @@
                   <span class="font-medium text-gray-700">{{ speakerLabel }}</span>
                   <span v-if="transportKind" class="italic">{{ transportKind }}</span>
                 </div>
+                <div
+                  v-if="truncationInfo.wasTruncated"
+                  class="mb-3 p-3 rounded border border-amber-300 bg-amber-50 text-amber-900 text-sm"
+                  data-testid="text-response-truncation-banner"
+                >
+                  {{
+                    t("pluginTextResponse.truncatedForRender", {
+                      omitted: truncationInfo.omittedChars.toLocaleString(locale),
+                      total: truncationInfo.originalChars.toLocaleString(locale),
+                    })
+                  }}
+                </div>
                 <!-- eslint-disable vue/no-v-html -- marked.parse output of app-owned assistant response text; trusted in-process render. Multi-line element so disable/enable pair (CLAUDE.md UI rule) instead of -next-line. -->
                 <div
                   ref="markdownContainerRef"
@@ -110,9 +134,9 @@ import { usePdfDownload } from "../../composables/usePdfDownload";
 import { useMarkdownZip } from "../../composables/useMarkdownZip";
 import { useClipboardCopy } from "../../composables/useClipboardCopy";
 import { buildPdfFilename } from "../../utils/files/filename";
-import { extractTextResponseTitle } from "./utils";
+import { extractTextResponseTitle, truncateForRender } from "./utils";
 
-const { t } = useI18n();
+const { t, locale } = useI18n();
 const appApi = useAppApi();
 
 const props = withDefaults(
@@ -162,19 +186,30 @@ const seededByPlugin = computed<string>(() => props.selectedResult.data?.seededB
 // inherently scoped to the opening message.
 const isSeededUserTurn = computed(() => Boolean(seededByPlugin.value) && messageRole.value === "user");
 
+// Truncation summary surfaced to the template — the banner renders when
+// `wasTruncated` is true, telling the user the visible content is a preview
+// and the raw text is available via Copy. See #1863 for the pathological
+// input this defends against (Opus 4.8 degenerate repetition freezing Safari).
+const truncationInfo = computed(() => truncateForRender(messageText.value ?? ""));
+
 const renderedHtml = computed(() => {
-  if (!messageText.value) return "";
-
-  let processedText = messageText.value;
-
-  // Detect and wrap JSON content in code fences
-  const trimmedText = processedText.trim();
-  if ((trimmedText.startsWith("{") && trimmedText.endsWith("}")) || (trimmedText.startsWith("[") && trimmedText.endsWith("]"))) {
-    try {
-      JSON.parse(trimmedText);
-      processedText = `\`\`\`json\n${trimmedText}\n\`\`\``;
-    } catch {
-      // Not valid JSON, continue with original text
+  const { displayText } = truncationInfo.value;
+  if (!displayText) return "";
+
+  let processedText = displayText;
+
+  // Detect and wrap JSON content in code fences (skip for truncated views —
+  // JSON.parse of a truncated tail would throw anyway, and a partial JSON
+  // dump is more informative rendered as markdown).
+  if (!truncationInfo.value.wasTruncated) {
+    const trimmedText = processedText.trim();
+    if ((trimmedText.startsWith("{") && trimmedText.endsWith("}")) || (trimmedText.startsWith("[") && trimmedText.endsWith("]"))) {
+      try {
+        JSON.parse(trimmedText);
+        processedText = `\`\`\`json\n${trimmedText}\n\`\`\``;
+      } catch {
+        // Not valid JSON, continue with original text
+      }
     }
   }
 

package/src/plugins/textResponse/utils.ts

@@ -4,6 +4,43 @@
 
 const MAX_TITLE_CHARS = 50;
 
+// Cap on how much of an assistant message we feed into marked() at once.
+// The Opus 4.8 "degenerate repetition" bug can generate hundreds of
+// thousands of chars of blank-line-separated single words; marked itself
+// parses that fine (~120ms), but Safari's layout/paint on ~30k <p>
+// elements freezes the tab for minutes (#1863). 100_000 is comfortably
+// larger than any real assistant reply (Claude's ~200k token ceiling is
+// well below that in bytes) and small enough that pathological input
+// bounces off it well before the render blows up.
+export const RENDER_TRUNCATE_CHARS = 100_000;
+// The preview slice we DO render when a message trips the cap. Small
+// enough that even a fully-blank-line-separated payload stays under a
+// few thousand block elements. Users get "Copy" for the full raw text.
+export const RENDER_TRUNCATE_PREVIEW_CHARS = 20_000;
+
+export interface TruncationResult {
+  displayText: string;
+  wasTruncated: boolean;
+  originalChars: number;
+  omittedChars: number;
+}
+
+// Truncate an assistant message so pathological model output can't
+// freeze the render path. Pure so it can be unit-tested from
+// node:test without a Vue runtime.
+export function truncateForRender(text: string): TruncationResult {
+  const originalChars = text.length;
+  if (originalChars <= RENDER_TRUNCATE_CHARS) {
+    return { displayText: text, wasTruncated: false, originalChars, omittedChars: 0 };
+  }
+  return {
+    displayText: text.slice(0, RENDER_TRUNCATE_PREVIEW_CHARS),
+    wasTruncated: true,
+    originalChars,
+    omittedChars: originalChars - RENDER_TRUNCATE_PREVIEW_CHARS,
+  };
+}
+
 // Pull a short, human-meaningful title out of a chat reply for use as
 // a download filename. Priority:
 //   1. First markdown H1 ("# ...") — the model often opens a long

package/src/utils/html/previewCsp.ts

@@ -5,23 +5,14 @@
 // random `https://` origins, phone-home `fetch()` calls, etc. —
 // is rejected.
 //
-// Widen by editing `HTML_PREVIEW_CSP_ALLOWED_CDNS` below. Keep the
-// list audited — every entry is a potential supply-chain surface.
+// The list itself lives in `@mulmoclaude/core/remote-view`
+// (SANDBOXED_VIEW_CDN_ALLOWLIST) so the remote-view CSP and these
+// desktop policies can't drift — widen it THERE, and keep it
+// audited: every entry is a potential supply-chain surface.
 
-export const HTML_PREVIEW_CSP_ALLOWED_CDNS: readonly string[] = [
-  "https://cdn.jsdelivr.net",
-  "https://unpkg.com",
-  "https://cdnjs.cloudflare.com",
-  "https://fonts.googleapis.com",
-  "https://fonts.gstatic.com",
-  // Plotly's official CDN. The LLM defaults to this URL when it
-  // includes a Sankey or other Plotly chart in presentHtml output —
-  // Plotly's docs recommend it, so unconditioned LLM output ends up
-  // pointing here. Also reachable through jsdelivr, but adding the
-  // first-party CDN keeps historical artifacts (where the URL is
-  // already baked into the file on disk) rendering correctly.
-  "https://cdn.plot.ly",
-];
+import { SANDBOXED_VIEW_CDN_ALLOWLIST } from "@mulmoclaude/core/remote-view";
+
+export const HTML_PREVIEW_CSP_ALLOWED_CDNS: readonly string[] = SANDBOXED_VIEW_CDN_ALLOWLIST;
 
 /**
  * Build the CSP string. Split from the wrapper so tests can exercise

package/src/utils/role/icon.ts

@@ -10,9 +10,16 @@ import type { Role } from "../../config/roles";
 // don't render the literal text inside a Material Icons span.
 const MATERIAL_ICON_RE = /^[a-z_]+$/;
 
+// `smart_toy` (robot glyph) is used for both fallback cases —
+// "role not found" and "role icon isn't a valid Material Icon name".
+// Reserved specifically to avoid collision with `star`, which is the
+// PinToggle glyph for collection shortcuts; using `star` here would
+// make an unknown role look identical to a pinned collection (#1684).
+const FALLBACK_ICON = "smart_toy";
+
 export function roleIcon(roles: Role[], roleId: string): string {
-  const icon = roles.find((role) => role.id === roleId)?.icon ?? "star";
-  return MATERIAL_ICON_RE.test(icon) ? icon : "smart_toy";
+  const icon = roles.find((role) => role.id === roleId)?.icon ?? FALLBACK_ICON;
+  return MATERIAL_ICON_RE.test(icon) ? icon : FALLBACK_ICON;
 }
 
 export function roleName(roles: Role[], roleId: string): string {