mts-booking-library 3.0.13 → 3.1.0

package/README.md

@@ -1,9 +1,37 @@
 # Publish
 
-1. `npm i`
-1. `npm version patch`
-1. `git push && git push --tags`
-1. `npm publish`
+To publish a new version of the library, first create a new version with the `npm version` command,
+specifying the semver increment (`patch`, `minor` or `major`, e.g. `npm version patch`).
+
+The library will be published to npm by the pipelines every time a new version is detected on the
+`main` branch.
+
+For that to work, the `NPM_TOKEN` secret must be kept up-to-date, as it expires **every 90 days**
+and has to be rotated manually.
+
+**LAST UPDATE: 2026-05-07**
+
+### How to update the npm token
+
+1. Go to https://www.npmjs.com/login
+1. Login with the `sviluppatoriinfos` username, and its password
+1. 2FA will be required, ask Jacopo Gargano (jacopo.gargano@infos.it)
+1. Once logged in, navigate to https://www.npmjs.com/settings/sviluppatoriinfos/tokens
+1. On that page, delete the outdated token
+1. Click on "Generate New Token" (may require a second 2FA code)
+1. Use the following settings:
+   - Token name: `mts-booking-library publishing`
+   - Bypass two-factor authentication (2FA): true
+   - Packages and scopes
+     - Permissions: Read and write
+     - Select packages > Only select packages and scopes: `mts-booking-library`
+   - Expiration > Expiration Date: 90 days
+1. Click on "Generate token", and copy the token
+1. Go to the edit pipeline page in Azure:
+   https://dev.azure.com/infoservicesrl/MyTicketSolution%202.0/_apps/hub/ms.vss-build-web.ci-designer-hub?pipelineId=88&branch=main
+1. Click on Variables > `NPM_TOKEN`
+1. Paste the new value, then Save > Save
+1. Update the date above
 
 # Test
 

package/lib/booking/journeyBooking.js

@@ -134,17 +134,20 @@ var JourneyBooking = /** @class */ (function (_super) {
     };
     JourneyBooking.prototype.fetchAndSetCart = function (cartGuid, options) {
         return __awaiter(this, void 0, void 0, function () {
-            var cart;
-            return __generator(this, function (_a) {
-                switch (_a.label) {
+            var cart, isDeadCart;
+            var _a, _b;
+            return __generator(this, function (_c) {
+                switch (_c.label) {
                     case 0: return [4 /*yield*/, this.fetchCart(cartGuid, options)];
                     case 1:
-                        cart = _a.sent();
+                        cart = _c.sent();
                         if (!cart)
                             return [2 /*return*/];
+                        isDeadCart = cart.hasCanceledTickets === true && ((_b = (_a = cart.bookings) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0) === 0;
                         if (cart.bookingDueDateTime &&
                             new Date(cart.bookingDueDateTime.dateTime) > new Date() &&
-                            !cart.hasIssuedTickets) {
+                            !cart.hasIssuedTickets &&
+                            !isDeadCart) {
                             this.cart = cart;
                             this.cartGuid = cart.guid;
                             this.bookingDueDateTime = cart.bookingDueDateTime; // See Booking class

package/lib/booking/serviceBooking.js

@@ -134,17 +134,20 @@ var ServiceBooking = /** @class */ (function (_super) {
     };
     ServiceBooking.prototype.fetchAndSetCart = function (cartGuid, options) {
         return __awaiter(this, void 0, void 0, function () {
-            var cart;
-            return __generator(this, function (_a) {
-                switch (_a.label) {
+            var cart, isDeadCart;
+            var _a, _b;
+            return __generator(this, function (_c) {
+                switch (_c.label) {
                     case 0: return [4 /*yield*/, this.fetchCart(cartGuid, options)];
                     case 1:
-                        cart = _a.sent();
+                        cart = _c.sent();
                         if (!cart)
                             return [2 /*return*/];
+                        isDeadCart = cart.hasCanceledTickets === true && ((_b = (_a = cart.bookings) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0) === 0;
                         if (cart.bookingDueDateTime &&
                             new Date(cart.bookingDueDateTime.dateTime) > new Date() &&
-                            !cart.hasIssuedTickets) {
+                            !cart.hasIssuedTickets &&
+                            !isDeadCart) {
                             this.cart = cart;
                             this.cartGuid = cart.guid;
                             this.bookingDueDateTime = cart.bookingDueDateTime; // See Booking class

package/lib/booking/subscriptionBooking.js

@@ -134,17 +134,20 @@ var SubscriptionBooking = /** @class */ (function (_super) {
     };
     SubscriptionBooking.prototype.fetchAndSetCart = function (cartGuid, options) {
         return __awaiter(this, void 0, void 0, function () {
-            var cart;
-            return __generator(this, function (_a) {
-                switch (_a.label) {
+            var cart, isDeadCart;
+            var _a, _b;
+            return __generator(this, function (_c) {
+                switch (_c.label) {
                     case 0: return [4 /*yield*/, this.fetchCart(cartGuid, options)];
                     case 1:
-                        cart = _a.sent();
+                        cart = _c.sent();
                         if (!cart)
                             return [2 /*return*/];
+                        isDeadCart = cart.hasCanceledTickets === true && ((_b = (_a = cart.bookings) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0) === 0;
                         if (cart.bookingDueDateTime &&
                             new Date(cart.bookingDueDateTime.dateTime) > new Date() &&
-                            !cart.hasIssuedTickets) {
+                            !cart.hasIssuedTickets &&
+                            !isDeadCart) {
                             this.cart = cart;
                             this.cartGuid = cart.guid;
                             this.bookingDueDateTime = cart.bookingDueDateTime; // See Booking class

package/lib/booking/tplBooking.js

@@ -141,17 +141,20 @@ var TplBooking = /** @class */ (function (_super) {
     };
     TplBooking.prototype.fetchAndSetCart = function (cartGuid, options) {
         return __awaiter(this, void 0, void 0, function () {
-            var cart;
-            return __generator(this, function (_a) {
-                switch (_a.label) {
+            var cart, isDeadCart;
+            var _a, _b;
+            return __generator(this, function (_c) {
+                switch (_c.label) {
                     case 0: return [4 /*yield*/, this.fetchCart(cartGuid, options)];
                     case 1:
-                        cart = _a.sent();
+                        cart = _c.sent();
                         if (!cart)
                             return [2 /*return*/];
+                        isDeadCart = cart.hasCanceledTickets === true && ((_b = (_a = cart.bookings) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0) === 0;
                         if (cart.bookingDueDateTime &&
                             new Date(cart.bookingDueDateTime.dateTime) > new Date() &&
-                            !cart.hasIssuedTickets) {
+                            !cart.hasIssuedTickets &&
+                            !isDeadCart) {
                             this.cart = cart;
                             this.cartGuid = cart.guid;
                             this.bookingDueDateTime = cart.bookingDueDateTime; // See Booking class

package/lib/index.d.ts

@@ -10,6 +10,7 @@ export { Person, DEFAULT_PERSON, initializePerson } from "./types/common/Person"
 export { GetBuyerPassengersDetailsResponse, GetPersonRequest, GetPassenger, EditPassengerRequestType, EditPassengersDetailsRequest } from "./types/common/Person";
 export { Tariff, TariffsMatrix, TariffSummary, TariffType, TermsType, PassengerTariff, ExtraTariff } from "./types/common/Tariffs";
 export { ReductionType, Reduction, AddReductionRequest } from "./types/common/Reduction";
+export { GetChangeInformationRequest, GetChangeInformationResponse, ChangeTicketInformation } from "./types/common/ChangeInformation";
 export { Gateway, GetSellerGatewaysResponse, GetPaymentInformationFromGatewayResponse, IssueCartResponse, GatewayTypes, PaymentMethods } from "./types/common/Payment";
 export { ErrorResponse, objectIsMTSErrorResponse } from "./types/ErrorResponse";
 export { City } from "./types/common/City";

package/lib/types/common/Cart.d.ts

@@ -70,6 +70,14 @@ export type Cart = {
      * cart. It is expressed in the currency of the cart.
      */
     totalCreditFromChange: number;
+    /**
+     * Sum of penalty (penale) amounts levied on the original tickets being replaced
+     * by this change cart. Positive number, in the same currency as
+     * {@link Cart.currency}. Zero when no change is in progress or no penalty rule
+     * applies to the changed tickets. Surfaced so the booking summary can render a
+     * "Penale cambio" line alongside {@link Cart.totalCreditFromChange}.
+     */
+    totalChangePenalty: number;
     /** The total amount to pay by buyer */
     totalAmountToPayByBuyer: number;
     /**
@@ -105,6 +113,14 @@ export type Cart = {
      * possible to add tickets to an issued cart. Thus, all data should be reset.
      */
     hasIssuedTickets: boolean;
+    /**
+     * True when at least one ticket attached to the cart has been canceled (e.g. all
+     * gateway transactions expired before capture and the parent service transaction
+     * also expired, auto-canceling the ticket). Combined with an empty `bookings`
+     * list this flags a dead cart that the library will drop from persisted state.
+     * Optional for forward compatibility against backends that pre-date the field.
+     */
+    hasCanceledTickets?: boolean;
     /** The booking due date as ISO string */
     bookingDueDateTime: DateWithTimeZone;
     /** The ids of the tickets in the cart */

package/lib/types/common/ChangeInformation.d.ts

@@ -0,0 +1,54 @@
+/**
+ * Types for the BE preview endpoint `GET /v3_tickets/change/info`.
+ *
+ * Fetches the change-penalty (PENALE) for a set of tickets WITHOUT creating a
+ * change cart, so the FE can render a confirmation pop-up before the user
+ * commits to the change:
+ *
+ *   "Il costo del cambio è di euro xx
+ *    Vuoi procedere?
+ *    [si] [indietro]"
+ */
+export type GetChangeInformationRequest = {
+    /**
+     * Convenience single-PNR alternative to {@link ticketsToChange}. Either this
+     * or `ticketsToChange` must be set.
+     */
+    pnr?: string;
+    /**
+     * The PNRs / ticket codes to preview the change penalty for. Pass when the
+     * user is changing more than one ticket at once.
+     */
+    ticketsToChange?: string[];
+};
+export type GetChangeInformationResponse = {
+    /** Per-ticket breakdown of the penalty preview. */
+    ticketsToChange: ChangeTicketInformation[];
+    /**
+     * Sum of {@link ChangeTicketInformation.penalty} across all tickets in the
+     * request. Positive value, in {@link GetChangeInformationResponse.currency}.
+     * Surfaced so the FE can render a single "Il costo del cambio è di euro xx"
+     * line in the pop-up.
+     */
+    totalChangePenalty: number;
+    /**
+     * Currency of {@link totalChangePenalty}. Sourced from the first ticket in
+     * the request — if the caller passes tickets with different currencies, only
+     * the first is reflected here. Mixed-currency requests are unsupported; use
+     * the per-ticket {@link ChangeTicketInformation.currency} for authoritative
+     * per-ticket display.
+     */
+    currency: string;
+};
+export type ChangeTicketInformation = {
+    pnr: string;
+    /**
+     * Penalty owed to the seller for changing this ticket. Computed via the
+     * tariff's value-date rule, capped at the ticket's actual value to the
+     * buyer. Zero when no rule applies.
+     */
+    penalty: number;
+    /** True when the ticket is changeable per its terms-type configuration. */
+    isChangeable: boolean;
+    currency: string;
+};

package/lib/types/common/ChangeInformation.js

@@ -0,0 +1,13 @@
+"use strict";
+/**
+ * Types for the BE preview endpoint `GET /v3_tickets/change/info`.
+ *
+ * Fetches the change-penalty (PENALE) for a set of tickets WITHOUT creating a
+ * change cart, so the FE can render a confirmation pop-up before the user
+ * commits to the change:
+ *
+ *   "Il costo del cambio è di euro xx
+ *    Vuoi procedere?
+ *    [si] [indietro]"
+ */
+Object.defineProperty(exports, "__esModule", { value: true });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mts-booking-library",
-  "version": "3.0.13",
+  "version": "3.1.0",
   "description": "Library for using MyTicketSolution Booking API",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",