mtg-playerinfo 1.3.0 → 1.3.2

package/test/untapped.test.js

@@ -15,29 +15,75 @@ test('UntappedFetcher: parses most recent match and extracts MTGA rank', () => {
   const matches = JSON.parse(fixtureJson)
 
   const url = 'https://mtga.untapped.gg/profile/7de50700-c3f6-48e4-a38d-2add5b0d9b71/76DCDWCZS5FX5PIEEMUVY6GV74'
-  const result = fetcher.parseMatch(matches[0], url)
+  const result = fetcher.parseMatches(matches, url)
 
   assert.strictEqual(result.source, 'Untapped.gg')
   assert.strictEqual(result.url, url)
 
-  assert.match(result.mtga_rank, /^(Bronze|Silver|Gold|Platinum|Diamond|Mythic)\s\d+$/)
+  assert.strictEqual(typeof result.mtga_rank, 'object')
+
+  // Format is either "Rank Tier" (e.g. "Diamond 2") or "Mythic #Place" (e.g. "Mythic #123")
+  if (result.mtga_rank.constructed !== undefined) {
+    assert.match(result.mtga_rank.constructed, /^(Bronze|Silver|Gold|Platinum|Diamond|Mythic)(\s\d+|\s#\d+)$/)
+  }
+  if (result.mtga_rank.limited !== undefined) {
+    assert.match(result.mtga_rank.limited, /^(Bronze|Silver|Gold|Platinum|Diamond|Mythic)(\s\d+|\s#\d+)$/)
+  }
 })
 
 test('UntappedFetcher: handles missing rank data', () => {
   const fetcher = new UntappedFetcher()
-  const testMatch = {
-    friendly_ranking_class_after: null,
-    friendly_ranking_tier_after: null
-  }
+  const testMatches = [
+    {
+      super_format: 2,
+      friendly_ranking_class_after: null,
+      friendly_ranking_tier_after: null,
+      match_start: 1000
+    },
+    {
+      super_format: 1,
+      friendly_ranking_class_after: null,
+      friendly_ranking_tier_after: null,
+      match_start: 2000
+    }
+  ]
 
   const url = 'https://mtga.untapped.gg/profile/test-user/test-code'
-  const result = fetcher.parseMatch(testMatch, url)
+  const result = fetcher.parseMatches(testMatches, url)
 
-  assert.strictEqual(result.mtga_rank, null)
+  assert.strictEqual('constructed' in result.mtga_rank, false)
+  assert.strictEqual('limited' in result.mtga_rank, false)
 })
 
-test('UntappedFetcher: constructs correct API URL from two-part ID', () => {
+test('UntappedFetcher: formats Mythic rank with leaderboard place or percentile', () => {
   const fetcher = new UntappedFetcher()
+  const testMatches = [
+    {
+      super_format: 2,
+      friendly_ranking_class_after: 'Mythic',
+      friendly_ranking_tier_after: null,
+      friendly_mythic_leaderboard_place_after: 123,
+      friendly_mythic_percentile_after: 101.5,
+      match_start: 1000
+    },
+    {
+      super_format: 1,
+      friendly_ranking_class_after: 'Mythic',
+      friendly_ranking_tier_after: null,
+      friendly_mythic_leaderboard_place_after: null,
+      friendly_mythic_percentile_after: 98.789,
+      match_start: 2000
+    }
+  ]
+
+  const url = 'https://mtga.untapped.gg/profile/test-user/test-code'
+  const result = fetcher.parseMatches(testMatches, url)
+
+  assert.strictEqual(result.mtga_rank.constructed, 'Mythic #123')
+  assert.strictEqual(result.mtga_rank.limited, 'Mythic 98%')
+})
+
+test('UntappedFetcher: constructs correct API URL from two-part ID', () => {
   const userId = '7de50700-c3f6-48e4-a38d-2add5b0d9b71'
   const playerCode = '76DCDWCZS5FX5PIEEMUVY6GV74'
   const id = `${userId}/${playerCode}`
@@ -53,6 +99,3 @@ test('UntappedFetcher: constructs correct API URL from two-part ID', () => {
   const profileUrl = `https://mtga.untapped.gg/profile/${parts[0]}/${parts[1]}`
   assert.strictEqual(profileUrl, 'https://mtga.untapped.gg/profile/7de50700-c3f6-48e4-a38d-2add5b0d9b71/76DCDWCZS5FX5PIEEMUVY6GV74')
 })
-
-
-

package/test/verboseLogging.test.js

@@ -13,7 +13,7 @@ test('PlayerInfoManager: verbose mode logs promoted properties', async () => {
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
@@ -45,12 +45,12 @@ test('PlayerInfoManager: verbose mode logs matching property values', async () =
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
   try {
-    const merged = manager.mergeData(results, true)
+    manager.mergeData(results, true)
     assert.ok(capturedLogs.some(log => log.includes('🆗') && log.includes('name') && log.includes('Source2')),
       'Should log matching property with 🆗 emoji')
     assert.ok(capturedLogs.some(log => log.includes('🆗') && log.includes('team') && log.includes('Source2')),
@@ -76,7 +76,7 @@ test('PlayerInfoManager: verbose mode logs conflicting property values', async (
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
@@ -108,12 +108,12 @@ test('PlayerInfoManager: verbose mode uses photo emoji for photo conflicts', asy
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
   try {
-    const merged = manager.mergeData(results, true)
+    manager.mergeData(results, true)
     assert.ok(capturedLogs.some(log => log.includes('🆕') && log.includes('photo')),
       'Should log photo conflict with 🆕 emoji instead of 🆚')
   } finally {
@@ -141,12 +141,12 @@ test('PlayerInfoManager: verbose mode logs with null/undefined properties', asyn
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
   try {
-    const merged = manager.mergeData(results, true)
+    manager.mergeData(results, true)
     assert.ok(capturedLogs.some(log => log.includes('⬆️') && log.includes('bio') && log.includes('Source2')),
       'Should promote bio from Source2 after Source1 had null')
     assert.ok(capturedLogs.some(log => log.includes('⬆️') && log.includes('team') && log.includes('Source2')),
@@ -167,12 +167,12 @@ test('PlayerInfoManager: verbose mode is false by default and logs nothing', asy
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
   try {
-    const merged = manager.mergeData(results, false)
+    manager.mergeData(results, false)
     assert.equal(capturedLogs.length, 0, 'Should not log when verbose is false')
   } finally {
     console.log = originalLog
@@ -194,13 +194,12 @@ test('PlayerInfoManager: verbose mode logs each property separately', async () =
     }
   ]
 
-  let capturedLogs = []
+  const capturedLogs = []
   const originalLog = console.log
   console.log = (msg) => { capturedLogs.push(msg) }
 
   try {
-    const merged = manager.mergeData(results, true)
-    // Should have multiple promoted property logs
+    manager.mergeData(results, true)
     const promotedLogs = capturedLogs.filter(log => log.includes('⬆️'))
     assert.ok(promotedLogs.length >= 5, `Should log 5+ promoted properties, got ${promotedLogs.length}`)
     assert.ok(promotedLogs.some(log => log.includes('name')))
@@ -212,4 +211,3 @@ test('PlayerInfoManager: verbose mode logs each property separately', async () =
     console.log = originalLog
   }
 })
-