mtg-playerinfo 1.0.2 → 1.0.4

package/README.md

@@ -89,12 +89,12 @@ Example output:
 
 The following sites are currently supported based on HTML scraping and/or API calls. In general, API calls are preferred over scraping due to their higher reliability and independence from site structure changes.
 
-| Site            | Method                 |
-|-----------------|------------------------|
-| Unity League    | ✅Scraping              |
-| MTG Elo Project | ✅Scraping              |
-| Topdeck         | ✅Scraping              |
-| Melee           | ✅Scraping / 🚧API (#1) |
+| Site            | Method                                                                       |
+|-----------------|------------------------------------------------------------------------------|
+| Unity League    | ✅Scraping                                                                    |
+| MTG Elo Project | ✅Scraping                                                                    |
+| Topdeck         | ✅Scraping                                                                    |
+| Melee           | 🚧Scraping/API ([#1](https://github.com/bkimminich/mtg-playerinfo/issues/1)) |
 
 _Note: Some sites may have anti-bot protections that can lead to "Maximum number of redirects exceeded" or "403 Forbidden" errors depending on the execution environment._
 

package/cli.js

@@ -1,4 +1,4 @@
-#!/usr/bin/env node
+#!/usr/bin/env node
 const { program } = require('commander');
 const PlayerInfoManager = require('./src/index');
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mtg-playerinfo",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "A simple NPM module and CLI tool to pull Magic: The Gathering player data from various sources",
   "main": "src/index.js",
   "bin": {

package/src/fetchers/melee.js

@@ -16,13 +16,14 @@ class MeleeFetcher {
   parseHtml(html, url, username) {
     const $ = cheerio.load(html);
     const name = $('span[style*="font-size: xx-large"]').first().text().trim() || username;
-    const photo = $('.profile-button-column img').first().attr('src') || $('img.m-auto').attr('src');
+    // FIXME Photos cannot be loaded with unauthenticated requests from Melee.gg
+    // const photo = $('.profile-button-column img').first().attr('src') || $('img.m-auto').attr('src');
 
     const data = {
       source: 'Melee',
       url,
       name,
-      photo: photo ? (photo.startsWith('http') ? photo : `https://melee.gg${photo}`) : null,
+      // photo: photo ? (photo.startsWith('http') ? photo : `https://melee.gg${photo}`) : null,
       details: { }
     };
 

package/src/fetchers/unityLeague.js

@@ -70,10 +70,10 @@ class UnityLeagueFetcher {
       headers.forEach((header, i) => {
         if (header && values[i]) {
           let val = values[i];
-          if (val.startsWith('#')) {
-            val = val.substring(1);
+          val = val.replace(/\D/g, ''); // remove non-numeric characters to support #23->23, 1st->1, and 42nd->42 etc.
+          if (val) {
+            data.details[`Rank ${header}`] = val;
           }
-          data.details[`Rank ${header}`] = val;
         }
       });
     }