mstro-app 0.5.1 → 0.5.6

package/dist/server/services/websocket/quality-eta.js

@@ -0,0 +1,110 @@
+// Copyright (c) 2025-present Mstro, Inc. All rights reserved.
+// ── Heuristic constants ──────────────────────────────────────
+//
+// Numbers tuned against typical TypeScript codebases (mstro cli/server/web)
+// observed in the wild — see history.json for the corpus. Treat them as
+// reasonable defaults that the history-based path will quickly correct once
+// real durations land in storage.
+/** Per-file overhead for a CLI scan (linting, formatting, file/function-length checks). */
+const SCAN_PER_FILE_MS = 250;
+/** Per-1000-LOC overhead for a CLI scan, dominated by `tsc --noEmit` on TS projects. */
+const SCAN_PER_KLOC_MS = 800;
+/** Fixed overhead per scan: tool detection, file collection, score computation. */
+const SCAN_FIXED_MS = 8_000;
+/** Floor — the smallest "I'm doing something" we should ever show. */
+const SCAN_MIN_MS = 5_000;
+/** Per-file overhead for the AI code-review agent (Claude Read calls, validation). */
+const REVIEW_PER_FILE_MS = 1_200;
+/** Per-1000-LOC overhead for the AI code-review agent. */
+const REVIEW_PER_KLOC_MS = 2_500;
+/** Fixed overhead per review: Claude spawn, prompt building, persistence. */
+const REVIEW_FIXED_MS = 25_000;
+/** Floor for the review estimate. */
+const REVIEW_MIN_MS = 30_000;
+// ── History smoothing ────────────────────────────────────────
+//
+// Use the last few real durations for the same directory and weight them by
+// recency. A single one-off slow run shouldn't dominate the estimate, but
+// fresh data should outweigh stale data (codebase grew, machine got faster,
+// etc.).
+const MAX_HISTORY_SAMPLES = 5;
+function recentDurations(history, dirPath, field) {
+    const values = [];
+    // Walk newest → oldest; only consider entries that actually touched this directory.
+    for (let i = history.length - 1; i >= 0 && values.length < MAX_HISTORY_SAMPLES; i--) {
+        const entry = history[i];
+        if (!entry.directories.some((d) => d.path === dirPath))
+            continue;
+        const v = entry[field];
+        if (typeof v === 'number' && v > 0)
+            values.push(v);
+    }
+    return values;
+}
+/**
+ * Weighted average favouring newer samples. Weights are 1, 2, 3, 4, 5 for the
+ * 5 most-recent runs (newest first → highest weight) — a "this run mostly
+ * matters" curve that still smooths over a single anomaly.
+ */
+function weightedRecentAverage(values) {
+    if (values.length === 0)
+        return null;
+    let weightSum = 0;
+    let valueSum = 0;
+    // values[0] is newest, so its weight is `values.length`.
+    for (let i = 0; i < values.length; i++) {
+        const w = values.length - i;
+        valueSum += values[i] * w;
+        weightSum += w;
+    }
+    return weightSum > 0 ? valueSum / weightSum : null;
+}
+/**
+ * Heuristic estimate for a CLI scan when we have no history. Combines a fixed
+ * floor with per-file + per-KLOC components — `tsc --noEmit` and lint scale
+ * with codebase size, so scaling on both files and lines maps reality better
+ * than scaling on either alone.
+ */
+export function heuristicScanMs({ files, lines }) {
+    const kloc = Math.max(0, lines) / 1_000;
+    const raw = SCAN_FIXED_MS + files * SCAN_PER_FILE_MS + kloc * SCAN_PER_KLOC_MS;
+    return Math.max(SCAN_MIN_MS, Math.round(raw));
+}
+/** Heuristic estimate for the AI review agent when we have no history. */
+export function heuristicReviewMs({ files, lines }) {
+    const kloc = Math.max(0, lines) / 1_000;
+    const raw = REVIEW_FIXED_MS + files * REVIEW_PER_FILE_MS + kloc * REVIEW_PER_KLOC_MS;
+    return Math.max(REVIEW_MIN_MS, Math.round(raw));
+}
+/**
+ * Best-available ETA for a CLI scan. Prefers a weighted average of recent
+ * durations for this exact directory; falls back to the heuristic when no
+ * timing history exists.
+ */
+export function estimateScanMs(size, history, dirPath) {
+    const recent = recentDurations(history, dirPath, 'scanDurationMs');
+    const fromHistory = weightedRecentAverage(recent);
+    if (fromHistory !== null)
+        return Math.max(SCAN_MIN_MS, Math.round(fromHistory));
+    return heuristicScanMs(size);
+}
+/** Best-available ETA for the AI code-review agent. Same fallback shape as `estimateScanMs`. */
+export function estimateReviewMs(size, history, dirPath) {
+    const recent = recentDurations(history, dirPath, 'reviewDurationMs');
+    const fromHistory = weightedRecentAverage(recent);
+    if (fromHistory !== null)
+        return Math.max(REVIEW_MIN_MS, Math.round(fromHistory));
+    return heuristicReviewMs(size);
+}
+/**
+ * Estimate codebase size from a directory using the same fast traversal the
+ * scan itself uses. Pulled out as a thin wrapper so the handler can call it
+ * before kicking off the scan to compute an initial ETA.
+ */
+export async function estimateCodebaseSize(dirPath) {
+    const { collectSourceFiles } = await import('./quality-tools.js');
+    const files = await collectSourceFiles(dirPath, dirPath);
+    const lines = files.reduce((sum, f) => sum + f.lines, 0);
+    return { files: files.length, lines };
+}
+//# sourceMappingURL=quality-eta.js.map

package/dist/server/services/websocket/quality-eta.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality-eta.js","sourceRoot":"","sources":["../../../../server/services/websocket/quality-eta.ts"],"names":[],"mappings":"AAAA,8DAA8D;AAgB9D,gEAAgE;AAChE,EAAE;AACF,4EAA4E;AAC5E,wEAAwE;AACxE,4EAA4E;AAC5E,kCAAkC;AAElC,2FAA2F;AAC3F,MAAM,gBAAgB,GAAG,GAAG,CAAC;AAC7B,wFAAwF;AACxF,MAAM,gBAAgB,GAAG,GAAG,CAAC;AAC7B,mFAAmF;AACnF,MAAM,aAAa,GAAG,KAAK,CAAC;AAC5B,sEAAsE;AACtE,MAAM,WAAW,GAAG,KAAK,CAAC;AAE1B,sFAAsF;AACtF,MAAM,kBAAkB,GAAG,KAAK,CAAC;AACjC,0DAA0D;AAC1D,MAAM,kBAAkB,GAAG,KAAK,CAAC;AACjC,6EAA6E;AAC7E,MAAM,eAAe,GAAG,MAAM,CAAC;AAC/B,qCAAqC;AACrC,MAAM,aAAa,GAAG,MAAM,CAAC;AAE7B,gEAAgE;AAChE,EAAE;AACF,4EAA4E;AAC5E,0EAA0E;AAC1E,4EAA4E;AAC5E,SAAS;AACT,MAAM,mBAAmB,GAAG,CAAC,CAAC;AAO9B,SAAS,eAAe,CACtB,OAAkC,EAClC,OAAe,EACf,KAA4C;IAE5C,MAAM,MAAM,GAAa,EAAE,CAAC;IAC5B,oFAAoF;IACpF,KAAK,IAAI,CAAC,GAAG,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,MAAM,GAAG,mBAAmB,EAAE,CAAC,EAAE,EAAE,CAAC;QACpF,MAAM,KAAK,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QACzB,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,OAAO,CAAC;YAAE,SAAS;QACjE,MAAM,CAAC,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;QACvB,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,GAAG,CAAC;YAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACrD,CAAC;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAED;;;;GAIG;AACH,SAAS,qBAAqB,CAAC,MAAgB;IAC7C,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IACrC,IAAI,SAAS,GAAG,CAAC,CAAC;IAClB,IAAI,QAAQ,GAAG,CAAC,CAAC;IACjB,yDAAyD;IACzD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACvC,MAAM,CAAC,GAAG,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;QAC5B,QAAQ,IAAI,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;QAC1B,SAAS,IAAI,CAAC,CAAC;IACjB,CAAC;IACD,OAAO,SAAS,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,GAAG,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC;AACrD,CAAC;AAWD;;;;;GAKG;AACH,MAAM,UAAU,eAAe,CAAC,EAAE,KAAK,EAAE,KAAK,EAAgB;IAC5D,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,CAAC,GAAG,KAAK,CAAC;IACxC,MAAM,GAAG,GAAG,aAAa,GAAG,KAAK,GAAG,gBAAgB,GAAG,IAAI,GAAG,gBAAgB,CAAC;IAC/E,OAAO,IAAI,CAAC,GAAG,CAAC,WAAW,EAAE,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;AAChD,CAAC;AAED,0EAA0E;AAC1E,MAAM,UAAU,iBAAiB,CAAC,EAAE,KAAK,EAAE,KAAK,EAAgB;IAC9D,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,CAAC,GAAG,KAAK,CAAC;IACxC,MAAM,GAAG,GAAG,eAAe,GAAG,KAAK,GAAG,kBAAkB,GAAG,IAAI,GAAG,kBAAkB,CAAC;IACrF,OAAO,IAAI,CAAC,GAAG,CAAC,aAAa,EAAE,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;AAClD,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,cAAc,CAC5B,IAAkB,EAClB,OAAkC,EAClC,OAAe;IAEf,MAAM,MAAM,GAAG,eAAe,CAAC,OAAO,EAAE,OAAO,EAAE,gBAAgB,CAAC,CAAC;IACnE,MAAM,WAAW,GAAG,qBAAqB,CAAC,MAAM,CAAC,CAAC;IAClD,IAAI,WAAW,KAAK,IAAI;QAAE,OAAO,IAAI,CAAC,GAAG,CAAC,WAAW,EAAE,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC;IAChF,OAAO,eAAe,CAAC,IAAI,CAAC,CAAC;AAC/B,CAAC;AAED,gGAAgG;AAChG,MAAM,UAAU,gBAAgB,CAC9B,IAAkB,EAClB,OAAkC,EAClC,OAAe;IAEf,MAAM,MAAM,GAAG,eAAe,CAAC,OAAO,EAAE,OAAO,EAAE,kBAAkB,CAAC,CAAC;IACrE,MAAM,WAAW,GAAG,qBAAqB,CAAC,MAAM,CAAC,CAAC;IAClD,IAAI,WAAW,KAAK,IAAI;QAAE,OAAO,IAAI,CAAC,GAAG,CAAC,aAAa,EAAE,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC;IAClF,OAAO,iBAAiB,CAAC,IAAI,CAAC,CAAC;AACjC,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,oBAAoB,CAAC,OAAe;IACxD,MAAM,EAAE,kBAAkB,EAAE,GAAG,MAAM,MAAM,CAAC,oBAAoB,CAAC,CAAC;IAClE,MAAM,KAAK,GAAG,MAAM,kBAAkB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IACzD,MAAM,KAAK,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,GAAG,GAAG,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC;IACzD,OAAO,EAAE,KAAK,EAAE,KAAK,CAAC,MAAM,EAAE,KAAK,EAAE,CAAC;AACxC,CAAC"}

package/dist/server/services/websocket/quality-grading.d.ts

@@ -1,5 +1,10 @@
 export type DimensionName = 'security' | 'reliability' | 'maintainability';
-export type Grade = 'A' | 'B' | 'C' | 'D' | 'F' | 'N/A';
+/**
+ * Letter grades. New code emits all variants except `'D'` (kept only for
+ * legacy reports persisted before the +/- rollout). See quality-types.ts for
+ * the score-band reference.
+ */
+export type Grade = 'A+' | 'A' | 'A-' | 'B+' | 'B' | 'B-' | 'C+' | 'C' | 'C-' | 'D' | 'F+' | 'F' | 'F-' | 'N/A';
 type Severity = 'critical' | 'high' | 'medium' | 'low';
 export interface DimensionScore {
     name: DimensionName;
@@ -30,9 +35,27 @@ export interface QualityRating {
  */
 export declare function categoryToDimension(category: string): DimensionName;
 /**
- * Score-to-grade conversion used by legacy callers that still operate on a
- * single 0-100 number. The new multi-dimensional path computes grades
- * directly from finding shape; this remains for backward compatibility.
+ * Convert a 0-100 score to the full letter grade including +/- modifier.
+ *
+ * Within an A/B/C band, the band is split into thirds:
+ *   X-  bottom third (e.g., A-: 90-92)
+ *   X   middle third (e.g., A : 93-96)
+ *   X+  top third    (e.g., A+: 97-100)
+ *
+ * The F band uses two slices instead of three because there is no academic
+ * "F0" anchor and the user wanted F+/F/F-:
+ *   F-  0-55           "critically broken"
+ *   F   56-64          "broken"
+ *   F+  65-69          "barely failing"
+ *
+ * Compile/critical-severity hard caps are applied separately, not by score.
+ */
+export declare function scoreToGrade(score: number): Grade;
+/**
+ * Legacy single-letter conversion. Returns the *base* grade only (no
+ * modifier) for compatibility with callers that pre-date the +/- rollout
+ * (`scoreBreakdown.categoryPenalties[].grade`, etc.). New surfaces should
+ * call `scoreToGrade()` instead.
  */
 export declare function gradeFromScore(score: number): Grade;
 export declare function computeQualityRating(allFindings: Array<{

package/dist/server/services/websocket/quality-grading.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"quality-grading.d.ts","sourceRoot":"","sources":["../../../../server/services/websocket/quality-grading.ts"],"names":[],"mappings":"AAwBA,MAAM,MAAM,aAAa,GAAG,UAAU,GAAG,aAAa,GAAG,iBAAiB,CAAC;AAC3E,MAAM,MAAM,KAAK,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,KAAK,CAAC;AACxD,KAAK,QAAQ,GAAG,UAAU,GAAG,MAAM,GAAG,QAAQ,GAAG,KAAK,CAAC;AAEvD,MAAM,WAAW,cAAc;IAC7B,IAAI,EAAE,aAAa,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,KAAK,CAAC;IACb,SAAS,EAAE,MAAM,CAAC;IAClB,SAAS,EAAE,OAAO,CAAC;IACnB,YAAY,EAAE,MAAM,CAAC;IACrB,aAAa,EAAE,QAAQ,GAAG,IAAI,CAAC;CAChC;AAED,MAAM,WAAW,WAAW;IAC1B,MAAM,EAAE,OAAO,CAAC;IAChB,iBAAiB,EAAE,MAAM,EAAE,CAAC;CAC7B;AAED,MAAM,WAAW,aAAa;IAC5B,OAAO,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,KAAK,CAAA;KAAE,CAAC;IACzC,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,WAAW,EAAE,WAAW,CAAC;IACzB,cAAc,EAAE,MAAM,CAAC;CACxB;AAmBD;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,QAAQ,EAAE,MAAM,GAAG,aAAa,CAKnE;AAMD;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,KAAK,EAAE,MAAM,GAAG,KAAK,CAMnD;AAyaD,wBAAgB,oBAAoB,CAClC,WAAW,EAAE,KAAK,CAAC;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,CAAC,EAC1D,UAAU,EAAE,MAAM,EAClB,OAAO,CAAC,EAAE;IAAE,mBAAmB,CAAC,EAAE,GAAG,CAAC,aAAa,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,GAAG,CAAC,aAAa,CAAC,CAAA;CAAE,GACnF,aAAa,CA6Bf"}
+{"version":3,"file":"quality-grading.d.ts","sourceRoot":"","sources":["../../../../server/services/websocket/quality-grading.ts"],"names":[],"mappings":"AAqCA,MAAM,MAAM,aAAa,GAAG,UAAU,GAAG,aAAa,GAAG,iBAAiB,CAAC;AAE3E;;;;GAIG;AACH,MAAM,MAAM,KAAK,GACb,IAAI,GAAG,GAAG,GAAG,IAAI,GACjB,IAAI,GAAG,GAAG,GAAG,IAAI,GACjB,IAAI,GAAG,GAAG,GAAG,IAAI,GACjB,GAAG,GACH,IAAI,GAAG,GAAG,GAAG,IAAI,GACjB,KAAK,CAAC;AAKV,KAAK,QAAQ,GAAG,UAAU,GAAG,MAAM,GAAG,QAAQ,GAAG,KAAK,CAAC;AAEvD,MAAM,WAAW,cAAc;IAC7B,IAAI,EAAE,aAAa,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,KAAK,CAAC;IACb,SAAS,EAAE,MAAM,CAAC;IAClB,SAAS,EAAE,OAAO,CAAC;IACnB,YAAY,EAAE,MAAM,CAAC;IACrB,aAAa,EAAE,QAAQ,GAAG,IAAI,CAAC;CAChC;AAED,MAAM,WAAW,WAAW;IAC1B,MAAM,EAAE,OAAO,CAAC;IAChB,iBAAiB,EAAE,MAAM,EAAE,CAAC;CAC7B;AAED,MAAM,WAAW,aAAa;IAC5B,OAAO,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,KAAK,CAAA;KAAE,CAAC;IACzC,UAAU,EAAE,cAAc,EAAE,CAAC;IAC7B,WAAW,EAAE,WAAW,CAAC;IACzB,cAAc,EAAE,MAAM,CAAC;CACxB;AAmBD;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,QAAQ,EAAE,MAAM,GAAG,aAAa,CAKnE;AA2BD;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,MAAM,GAAG,KAAK,CAajD;AAED;;;;;GAKG;AACH,wBAAgB,cAAc,CAAC,KAAK,EAAE,MAAM,GAAG,KAAK,CAInD;AAgiBD,wBAAgB,oBAAoB,CAClC,WAAW,EAAE,KAAK,CAAC;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,CAAC,EAC1D,UAAU,EAAE,MAAM,EAClB,OAAO,CAAC,EAAE;IAAE,mBAAmB,CAAC,EAAE,GAAG,CAAC,aAAa,CAAC,CAAC;IAAC,OAAO,CAAC,EAAE,GAAG,CAAC,aAAa,CAAC,CAAA;CAAE,GACnF,aAAa,CAiCf"}