mstro-app 0.4.44 → 0.4.46

package/server/services/websocket/quality-service.ts

@@ -4,9 +4,12 @@
 import { extname } from 'node:path';
 import { analyzeComplexity, analyzeFunctionLength } from './quality-complexity.js';
 import { analyzeLinting } from './quality-linting.js';
-import { collectSourceFiles, detectEcosystem, runCommand, type SourceFile } from './quality-tools.js';
+import { chunkFileList, collectSourceFiles, detectEcosystem, filesByExt, runCommand, type SourceFile } from './quality-tools.js';
 import { type CategoryPenalty, type CategoryScore, type Ecosystem, FILE_LENGTH_THRESHOLD, hasInstalledToolInCategory, type QualityFinding, type QualityResults, type ScanProgress, type ScoreBreakdown, TOTAL_STEPS } from './quality-types.js';
 
+const NODE_FMT_EXTS = ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'];
+const PY_FMT_EXTS = ['.py', '.pyi'];
+
 export { detectEcosystem, detectTools, installTools } from './quality-tools.js';
 // Re-export public API for backward compatibility
 export type { CategoryPenalty, CategoryScore, QualityFinding, QualityResults, QualityTool, ScanProgress, ScoreBreakdown } from './quality-types.js';
@@ -27,34 +30,51 @@ function newFmtAccumulator(): FmtAccumulator {
 }
 
 async function fmtNode(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
-  const result = await runCommand('npx', ['prettier', '--check', '.'], dirPath);
-  acc.ran = true;
-  const unformatted = result.stdout.split('\n').filter((l) => l.trim() && !l.startsWith('Checking'));
-  const nodeFiles = files.filter((f) => ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'].includes(extname(f.path)));
-  acc.totalFiles += nodeFiles.length;
-  acc.passingFiles += Math.max(0, nodeFiles.length - unformatted.length);
-  for (const filePath of unformatted) {
-    if (!filePath.trim()) continue;
-    const rel = filePath.startsWith('/') ? filePath.replace(`${dirPath}/`, '') : filePath;
+  const targets = filesByExt(files, NODE_FMT_EXTS);
+  if (targets.length === 0) return;
+
+  acc.totalFiles += targets.length;
+  const unformattedSet = new Set<string>();
+
+  for (const chunk of chunkFileList(targets)) {
+    const result = await runCommand('npx', ['prettier', '--check', ...chunk], dirPath);
+    acc.ran = true;
+    for (const line of result.stdout.split('\n')) {
+      if (!line.trim() || line.startsWith('Checking')) continue;
+      const rel = line.startsWith('/') ? line.replace(`${dirPath}/`, '') : line;
+      unformattedSet.add(rel.trim());
+    }
+  }
+
+  acc.passingFiles += Math.max(0, targets.length - unformattedSet.size);
+  for (const rel of unformattedSet) {
     acc.findings.push({ severity: 'low', category: 'format', file: rel, line: null, title: 'File not formatted', description: 'Does not match Prettier formatting rules.' });
   }
 }
 
 async function fmtPython(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
-  const result = await runCommand('black', ['--check', '--quiet', '.'], dirPath);
-  acc.ran = true;
-  const pyFiles = files.filter((f) => ['.py', '.pyi'].includes(extname(f.path)));
-  acc.totalFiles += pyFiles.length;
-  if (result.exitCode === 0) {
-    acc.passingFiles += pyFiles.length;
-    return;
-  }
-  const reformatLines = result.stderr.split('\n').filter((l) => l.includes('would reformat'));
-  acc.passingFiles += Math.max(0, pyFiles.length - reformatLines.length);
-  for (const line of reformatLines) {
-    const match = line.match(/would reformat (.+)/);
-    if (match) acc.findings.push({ severity: 'low', category: 'format', file: match[1].trim(), line: null, title: 'File not formatted', description: 'Does not match Black formatting rules.' });
+  const targets = filesByExt(files, PY_FMT_EXTS);
+  if (targets.length === 0) return;
+
+  acc.totalFiles += targets.length;
+  let reformatCount = 0;
+  const findings: typeof acc.findings = [];
+
+  for (const chunk of chunkFileList(targets)) {
+    const result = await runCommand('black', ['--check', '--quiet', ...chunk], dirPath);
+    acc.ran = true;
+    if (result.exitCode === 0) continue;
+
+    const reformatLines = result.stderr.split('\n').filter((l) => l.includes('would reformat'));
+    reformatCount += reformatLines.length;
+    for (const line of reformatLines) {
+      const match = line.match(/would reformat (.+)/);
+      if (match) findings.push({ severity: 'low', category: 'format', file: match[1].trim(), line: null, title: 'File not formatted', description: 'Does not match Black formatting rules.' });
+    }
   }
+
+  acc.passingFiles += Math.max(0, targets.length - reformatCount);
+  acc.findings.push(...findings);
 }
 
 async function fmtRust(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
@@ -223,21 +243,6 @@ export function computeFormulaScore(
   };
 }
 
-/** @deprecated — use computeFormulaScore instead */
-export function computeAiReviewScore(
-  findings: Array<{ severity: string }>,
-  totalLines: number,
-): number {
-  if (findings.length === 0) return 100;
-  const effectiveKloc = Math.max(totalLines / 1000, 1.0);
-  const totalPenalty = findings.reduce(
-    (sum, f) => sum + (SEVERITY_WEIGHT[f.severity] ?? 2.0),
-    0,
-  );
-  const penaltyDensity = totalPenalty / effectiveKloc;
-  return Math.round(100 * Math.exp(-0.10 * penaltyDensity));
-}
-
 // ============================================================================
 // Main Scan
 // ============================================================================
@@ -278,7 +283,7 @@ export async function runQualityScan(
 
   // Step 4: Analyze complexity (using real tools: Biome, ESLint, radon)
   progress('Analyzing complexity', 4);
-  const complexityResult = await analyzeComplexity(dirPath, ecosystems, installedToolNames);
+  const complexityResult = await analyzeComplexity(dirPath, ecosystems, files, installedToolNames);
 
   // Step 5: Check file lengths
   progress('Checking file lengths', 5);

package/server/services/websocket/quality-tools.ts

@@ -239,6 +239,39 @@ export async function collectSourceFiles(dirPath: string, rootPath: string): Pro
   return files;
 }
 
+// ============================================================================
+// File List Helpers
+// ============================================================================
+
+/**
+ * Filter a SourceFile list by extension and return relative paths.
+ * Used to pass an explicit, git-ignored-filtered file list to external tools
+ * (prettier, biome, eslint, ...) so they don't walk ignored directories like
+ * web/dist or nested build outputs in monorepos.
+ */
+export function filesByExt(files: SourceFile[], exts: string[]): string[] {
+  const set = new Set(exts.map((e) => e.toLowerCase()));
+  const out: string[] = [];
+  for (const f of files) {
+    if (set.has(extname(f.path).toLowerCase())) out.push(f.relativePath);
+  }
+  return out;
+}
+
+/**
+ * Split a file list into chunks so a single command invocation doesn't
+ * blow past ARG_MAX. macOS ARG_MAX is ~256KB; 400 paths at ~200 chars each
+ * leaves plenty of headroom.
+ */
+export function chunkFileList(paths: string[], size = 400): string[][] {
+  if (paths.length === 0) return [];
+  const chunks: string[][] = [];
+  for (let i = 0; i < paths.length; i += size) {
+    chunks.push(paths.slice(i, i + size));
+  }
+  return chunks;
+}
+
 // ============================================================================
 // Command Runner
 // ============================================================================

package/server/services/websocket/session-handlers.ts

@@ -91,7 +91,13 @@ function getSession(ctx: HandlerContext, ws: WSContext, tabId: string): Improvis
 
 export function buildOutputHistory(session: ImprovisationSessionManager): Array<Record<string, unknown>> {
   const history = session.getHistory();
-  return history.movements.flatMap(convertMovementToLines);
+  // Skip in-progress movements (durationMs == 0). Their state is replayed on
+  // the web via executionEvents; including them here would emit a bogus
+  // "Completed" marker and duplicate the user prompt that executionEvents
+  // is about to replay.
+  return history.movements
+    .filter((m) => (m.durationMs ?? 0) > 0)
+    .flatMap(convertMovementToLines);
 }
 
 export function setupSessionListeners(ctx: HandlerContext, session: ImprovisationSessionManager, ws: WSContext, tabId: string): void {
@@ -157,7 +163,7 @@ export function setupSessionListeners(ctx: HandlerContext, session: Improvisatio
 }
 
 /** Merge pre-uploaded files (from chunked upload) with any inline attachments */
-function mergePreUploadedAttachments(ctx: HandlerContext, tabId: string, inlineAttachments?: FileAttachment[]): FileAttachment[] | undefined {
+export function mergePreUploadedAttachments(ctx: HandlerContext, tabId: string, inlineAttachments?: FileAttachment[]): FileAttachment[] | undefined {
   if (!ctx.fileUploadHandler) return inlineAttachments;
   const preUploaded = ctx.fileUploadHandler.getAndClearCompletedUploads(tabId);
   if (preUploaded.length === 0) return inlineAttachments;
@@ -200,6 +206,17 @@ export function handleSessionMessage(ctx: HandlerContext, ws: WSContext, msg: We
       const effectiveDir = worktreeDir || session.getSessionInfo().workingDir;
       const resolved = resolveSkillPrompt(rawPrompt, effectiveDir);
 
+      // Authoritative prompt-input clear for all connected devices. The
+      // submitter already cleared locally; this guarantees other devices
+      // clear even if the submitter's debounced syncPromptText never fires
+      // (e.g. mobile tab suspended after Send). Clients suppress this via
+      // locallyEditingTabs if the user is actively typing a new prompt.
+      ctx.broadcastToAll({
+        type: 'promptTextSync',
+        tabId,
+        data: { tabId, text: '' },
+      });
+
       session.executePrompt(
         resolved ? resolved.prompt : rawPrompt,
         attachments,

package/server/services/websocket/types.ts

@@ -42,7 +42,7 @@ const SessionSyncMessages = ['getActiveTabs', 'createTab', 'reorderTabs', 'syncT
 
 const SettingsMessages = ['getSettings', 'updateSettings'] as const;
 
-const QualityMessages = ['qualityDetectTools', 'qualityScan', 'qualityInstallTools', 'qualityCodeReview', 'qualityFixIssues', 'qualityLoadState', 'qualitySaveDirectories'] as const;
+const QualityMessages = ['qualityDetectTools', 'qualityScan', 'qualityInstallTools', 'qualityCodeReview', 'qualityLoadState', 'qualitySaveDirectories'] as const;
 
 const FileUploadMessages = ['fileUploadStart', 'fileUploadChunk', 'fileUploadComplete', 'fileUploadCancel'] as const;
 
@@ -105,7 +105,7 @@ const SessionSyncResponseMessages = ['activeTabs', 'tabCreated', 'tabRemoved', '
 
 const SettingsResponseMessages = ['settings', 'settingsUpdated'] as const;
 
-const QualityResponseMessages = ['qualityToolsDetected', 'qualityScanProgress', 'qualityScanResults', 'qualityInstallProgress', 'qualityInstallComplete', 'qualityCodeReview', 'qualityCodeReviewProgress', 'qualityPostSession', 'qualityFixProgress', 'qualityFixComplete', 'qualityError', 'qualityStateLoaded'] as const;
+const QualityResponseMessages = ['qualityToolsDetected', 'qualityScanProgress', 'qualityScanResults', 'qualityInstallProgress', 'qualityInstallComplete', 'qualityCodeReview', 'qualityCodeReviewProgress', 'qualityPostSession', 'qualityError', 'qualityStateLoaded'] as const;
 
 const FileUploadResponseMessages = ['fileUploadAck', 'fileUploadReady', 'fileUploadError'] as const;
 

package/dist/server/services/websocket/quality-fix-agent.d.ts

@@ -1,16 +0,0 @@
-import type { ToolUseEvent } from '../../cli/headless/types.js';
-import type { HandlerContext } from './handler-context.js';
-import type { QualityPersistence } from './quality-persistence.js';
-import type { WSContext } from './types.js';
-export interface FindingForFix {
-    severity: string;
-    category: string;
-    file: string;
-    line: number | null;
-    title: string;
-    description: string;
-    suggestion?: string;
-}
-export declare function createToolProgressCallback(ctx: HandlerContext, ws: WSContext, reportPath: string): (event: ToolUseEvent) => void;
-export declare function handleFixIssues(ctx: HandlerContext, ws: WSContext, reportPath: string, dirPath: string, workingDir: string, section: string | undefined, findings: FindingForFix[], getPersistence: (dir: string) => QualityPersistence): Promise<void>;
-//# sourceMappingURL=quality-fix-agent.d.ts.map

package/dist/server/services/websocket/quality-fix-agent.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"quality-fix-agent.d.ts","sourceRoot":"","sources":["../../../../server/services/websocket/quality-fix-agent.ts"],"names":[],"mappings":"AAUA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAEhE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAC3D,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,0BAA0B,CAAC;AAEnE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAI5C,MAAM,WAAW,aAAa;IAC5B,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,WAAW,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB;AAYD,wBAAgB,0BAA0B,CAAC,GAAG,EAAE,cAAc,EAAE,EAAE,EAAE,SAAS,EAAE,UAAU,EAAE,MAAM,IAEvF,OAAO,YAAY,UAmB5B;AAiDD,wBAAsB,eAAe,CACnC,GAAG,EAAE,cAAc,EACnB,EAAE,EAAE,SAAS,EACb,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,EACf,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,GAAG,SAAS,EAC3B,QAAQ,EAAE,aAAa,EAAE,EACzB,cAAc,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,kBAAkB,GAClD,OAAO,CAAC,IAAI,CAAC,CAiGf"}

package/dist/server/services/websocket/quality-fix-agent.js

@@ -1,181 +0,0 @@
-// Copyright (c) 2025-present Mstro, Inc. All rights reserved.
-// Licensed under the MIT License. See LICENSE file for details.
-/**
- * Quality Fix Agent — AI-powered issue fixing using Claude Code headless runner.
- *
- * Builds the fix prompt, runs the agent, re-scans, and persists updated results.
- */
-import { ResilientRunner } from '../../cli/headless/resilient-runner.js';
-import { loadSkillPrompt } from '../plan/agent-loader.js';
-import { detectTools, runQualityScan } from './quality-service.js';
-// ── Progress callback ─────────────────────────────────────────
-const TOOL_MESSAGES = {
-    Read: 'Reading files to understand issues...',
-    Edit: 'Applying fixes...',
-    Write: 'Writing fixes...',
-    Grep: 'Searching for related code...',
-    Bash: 'Running verification...',
-};
-export function createToolProgressCallback(ctx, ws, reportPath) {
-    const seenTools = new Set();
-    return (event) => {
-        try {
-            if (event.type === 'tool_start' && event.toolName && !seenTools.has(event.toolName)) {
-                seenTools.add(event.toolName);
-                const message = TOOL_MESSAGES[event.toolName];
-                if (message) {
-                    ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message } });
-                }
-            }
-            if (event.type === 'tool_complete' && event.toolName === 'Edit' && event.completeInput?.file_path) {
-                ctx.send(ws, {
-                    type: 'qualityFixProgress',
-                    data: { path: reportPath, message: `Fixed ${String(event.completeInput.file_path).split('/').slice(-2).join('/')}` },
-                });
-            }
-        }
-        catch {
-            // WebSocket closed — progress lost but fix operation continues
-        }
-    };
-}
-function startFixHeartbeat(ctx, ws, reportPath, intervalMs = 30_000) {
-    let elapsed = 0;
-    const timer = setInterval(() => {
-        elapsed += intervalMs;
-        const mins = Math.floor(elapsed / 60_000);
-        const secs = Math.floor((elapsed % 60_000) / 1000);
-        const timeStr = mins > 0 ? `${mins}m ${secs}s` : `${secs}s`;
-        try {
-            ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message: `Fixing issues (${timeStr} elapsed, still working...)` } });
-        }
-        catch {
-            // WebSocket closed — heartbeat lost but fix continues
-        }
-    }, intervalMs);
-    return () => clearInterval(timer);
-}
-// ── Prompt ────────────────────────────────────────────────────
-function buildFixPrompt(findings, section) {
-    const filtered = section ? findings.filter((f) => f.category === section) : findings;
-    const sorted = filtered.sort((a, b) => {
-        const order = { critical: 0, high: 1, medium: 2, low: 3 };
-        return (order[a.severity] ?? 4) - (order[b.severity] ?? 4);
-    });
-    const issueList = sorted.slice(0, 30).map((f, i) => {
-        const loc = f.line ? `${f.file}:${f.line}` : f.file;
-        const parts = [`${i + 1}. [${f.severity.toUpperCase()}] ${loc} — ${f.title}`];
-        if (f.description)
-            parts.push(`   ${f.description}`);
-        if (f.suggestion)
-            parts.push(`   Suggestion: ${f.suggestion}`);
-        return parts.join('\n');
-    }).join('\n\n');
-    const fromSkill = loadSkillPrompt('fix-quality', {
-        issueList,
-        issueCount: String(sorted.length),
-        showCount: String(Math.min(30, sorted.length)),
-    });
-    if (fromSkill)
-        return fromSkill;
-    return `You are a code quality fix agent. Fix the following quality issues in the codebase.\n\n## Issues to Fix (${sorted.length} total, showing top ${Math.min(30, sorted.length)})\n\n${issueList}\n\nFix each issue by editing the relevant file. Work from most to least severe. Do NOT introduce new issues.`;
-}
-// ── Handler ───────────────────────────────────────────────────
-const activeFixes = new Set();
-export async function handleFixIssues(ctx, ws, reportPath, dirPath, workingDir, section, findings, getPersistence) {
-    if (activeFixes.has(dirPath)) {
-        ctx.send(ws, {
-            type: 'qualityError',
-            data: { path: reportPath, error: 'A fix operation is already running for this directory.' },
-        });
-        return;
-    }
-    if (findings.length === 0) {
-        ctx.send(ws, {
-            type: 'qualityError',
-            data: { path: reportPath, error: 'No findings to fix.' },
-        });
-        return;
-    }
-    activeFixes.add(dirPath);
-    const stopHeartbeat = startFixHeartbeat(ctx, ws, reportPath);
-    try {
-        try {
-            ctx.send(ws, {
-                type: 'qualityFixProgress',
-                data: { path: reportPath, message: 'Starting Claude Code to fix issues...' },
-            });
-        }
-        catch { /* WS closed */ }
-        const prompt = buildFixPrompt(findings, section);
-        const runner = new ResilientRunner({
-            workingDir: dirPath,
-            prompt,
-            policy: 'STANDARD',
-            stallWarningMs: 300_000,
-            stallKillMs: 1_200_000,
-            stallHardCapMs: 1_800_000,
-            toolUseCallback: createToolProgressCallback(ctx, ws, reportPath),
-            logLabel: 'code-review-fix',
-        });
-        await runner.run();
-        try {
-            ctx.send(ws, {
-                type: 'qualityFixProgress',
-                data: { path: reportPath, message: 'Fixes applied. Re-running quality checks...' },
-            });
-        }
-        catch { /* WS closed */ }
-        // Re-run quality scan after fixing
-        const { tools: detectedTools } = await detectTools(dirPath);
-        const installedToolNames = detectedTools.filter((t) => t.installed).map((t) => t.name);
-        const results = await runQualityScan(dirPath, (progress) => {
-            try {
-                ctx.send(ws, {
-                    type: 'qualityScanProgress',
-                    data: { path: reportPath, progress },
-                });
-            }
-            catch { /* WS closed */ }
-        }, installedToolNames);
-        // Persist before sending — results survive WebSocket drops
-        try {
-            const persistence = getPersistence(workingDir);
-            persistence.saveReport(reportPath, results);
-            persistence.appendHistory(results, reportPath);
-        }
-        catch {
-            // Persistence failure should not break the fix flow
-        }
-        const resultData = { path: reportPath, results };
-        try {
-            ctx.send(ws, { type: 'qualityFixComplete', data: resultData });
-        }
-        catch {
-            // WebSocket closed — save as pending for delivery on reconnect
-            const persistence = getPersistence(workingDir);
-            persistence.addPendingResult({
-                type: 'fixComplete',
-                path: reportPath,
-                data: resultData,
-                completedAt: new Date().toISOString(),
-            });
-        }
-    }
-    catch (error) {
-        try {
-            ctx.send(ws, {
-                type: 'qualityError',
-                data: { path: reportPath, error: error instanceof Error ? error.message : String(error) },
-            });
-        }
-        catch {
-            // WebSocket closed — error lost but operation tracked via activeOps
-        }
-    }
-    finally {
-        stopHeartbeat();
-        activeFixes.delete(dirPath);
-    }
-}
-//# sourceMappingURL=quality-fix-agent.js.map

package/dist/server/services/websocket/quality-fix-agent.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"quality-fix-agent.js","sourceRoot":"","sources":["../../../../server/services/websocket/quality-fix-agent.ts"],"names":[],"mappings":"AAAA,8DAA8D;AAC9D,gEAAgE;AAEhE;;;;GAIG;AAEH,OAAO,EAAE,eAAe,EAAE,MAAM,wCAAwC,CAAC;AAEzE,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAG1D,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAenE,iEAAiE;AAEjE,MAAM,aAAa,GAA2B;IAC5C,IAAI,EAAE,uCAAuC;IAC7C,IAAI,EAAE,mBAAmB;IACzB,KAAK,EAAE,kBAAkB;IACzB,IAAI,EAAE,+BAA+B;IACrC,IAAI,EAAE,yBAAyB;CAChC,CAAC;AAEF,MAAM,UAAU,0BAA0B,CAAC,GAAmB,EAAE,EAAa,EAAE,UAAkB;IAC/F,MAAM,SAAS,GAAG,IAAI,GAAG,EAAU,CAAC;IACpC,OAAO,CAAC,KAAmB,EAAE,EAAE;QAC7B,IAAI,CAAC;YACH,IAAI,KAAK,CAAC,IAAI,KAAK,YAAY,IAAI,KAAK,CAAC,QAAQ,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACpF,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;gBAC9B,MAAM,OAAO,GAAG,aAAa,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;gBAC9C,IAAI,OAAO,EAAE,CAAC;oBACZ,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;gBACpF,CAAC;YACH,CAAC;YACD,IAAI,KAAK,CAAC,IAAI,KAAK,eAAe,IAAI,KAAK,CAAC,QAAQ,KAAK,MAAM,IAAI,KAAK,CAAC,aAAa,EAAE,SAAS,EAAE,CAAC;gBAClG,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;oBACX,IAAI,EAAE,oBAAoB;oBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,SAAS,MAAM,CAAC,KAAK,CAAC,aAAa,CAAC,SAAS,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE;iBACrH,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,+DAA+D;QACjE,CAAC;IACH,CAAC,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,GAAmB,EAAE,EAAa,EAAE,UAAkB,EAAE,UAAU,GAAG,MAAM;IACpG,IAAI,OAAO,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,WAAW,CAAC,GAAG,EAAE;QAC7B,OAAO,IAAI,UAAU,CAAC;QACtB,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,MAAM,CAAC,CAAC;QAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,GAAG,MAAM,CAAC,GAAG,IAAI,CAAC,CAAC;QACnD,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,IAAI,KAAK,IAAI,GAAG,CAAC,CAAC,CAAC,GAAG,IAAI,GAAG,CAAC;QAC5D,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,kBAAkB,OAAO,6BAA6B,EAAE,EAAE,CAAC,CAAC;QAC5I,CAAC;QAAC,MAAM,CAAC;YACP,sDAAsD;QACxD,CAAC;IACH,CAAC,EAAE,UAAU,CAAC,CAAC;IACf,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC;AACpC,CAAC;AAED,iEAAiE;AAEjE,SAAS,cAAc,CAAC,QAAyB,EAAE,OAAgB;IACjE,MAAM,QAAQ,GAAG,OAAO,CAAC,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC;IACrF,MAAM,MAAM,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACpC,MAAM,KAAK,GAA2B,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC;QAClF,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;IAC7D,CAAC,CAAC,CAAC;IAEH,MAAM,SAAS,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACjD,MAAM,GAAG,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QACpD,MAAM,KAAK,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,QAAQ,CAAC,WAAW,EAAE,KAAK,GAAG,MAAM,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC;QAC9E,IAAI,CAAC,CAAC,WAAW;YAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,CAAC,CAAC;QACrD,IAAI,CAAC,CAAC,UAAU;YAAE,KAAK,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC;QAC/D,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAEhB,MAAM,SAAS,GAAG,eAAe,CAAC,aAAa,EAAE;QAC/C,SAAS;QACT,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;QACjC,SAAS,EAAE,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;KAC/C,CAAC,CAAC;IACH,IAAI,SAAS;QAAE,OAAO,SAAS,CAAC;IAEhC,OAAO,4GAA4G,MAAM,CAAC,MAAM,uBAAuB,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,MAAM,CAAC,MAAM,CAAC,QAAQ,SAAS,+GAA+G,CAAC;AACrT,CAAC;AAED,iEAAiE;AAEjE,MAAM,WAAW,GAAG,IAAI,GAAG,EAAU,CAAC;AAEtC,MAAM,CAAC,KAAK,UAAU,eAAe,CACnC,GAAmB,EACnB,EAAa,EACb,UAAkB,EAClB,OAAe,EACf,UAAkB,EAClB,OAA2B,EAC3B,QAAyB,EACzB,cAAmD;IAEnD,IAAI,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;QAC7B,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;YACX,IAAI,EAAE,cAAc;YACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,wDAAwD,EAAE;SAC5F,CAAC,CAAC;QACH,OAAO;IACT,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;YACX,IAAI,EAAE,cAAc;YACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,qBAAqB,EAAE;SACzD,CAAC,CAAC;QACH,OAAO;IACT,CAAC;IAED,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IACzB,MAAM,aAAa,GAAG,iBAAiB,CAAC,GAAG,EAAE,EAAE,EAAE,UAAU,CAAC,CAAC;IAC7D,IAAI,CAAC;QACH,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,oBAAoB;gBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,uCAAuC,EAAE;aAC7E,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAE3B,MAAM,MAAM,GAAG,cAAc,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAEjD,MAAM,MAAM,GAAG,IAAI,eAAe,CAAC;YACjC,UAAU,EAAE,OAAO;YACnB,MAAM;YACN,MAAM,EAAE,UAAU;YAClB,cAAc,EAAE,OAAO;YACvB,WAAW,EAAE,SAAS;YACtB,cAAc,EAAE,SAAS;YACzB,eAAe,EAAE,0BAA0B,CAAC,GAAG,EAAE,EAAE,EAAE,UAAU,CAAC;YAChE,QAAQ,EAAE,iBAAiB;SAC5B,CAAC,CAAC;QAEH,MAAM,MAAM,CAAC,GAAG,EAAE,CAAC;QAEnB,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,oBAAoB;gBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,6CAA6C,EAAE;aACnF,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAE3B,mCAAmC;QACnC,MAAM,EAAE,KAAK,EAAE,aAAa,EAAE,GAAG,MAAM,WAAW,CAAC,OAAO,CAAC,CAAC;QAC5D,MAAM,kBAAkB,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QAEvF,MAAM,OAAO,GAAG,MAAM,cAAc,CAAC,OAAO,EAAE,CAAC,QAAQ,EAAE,EAAE;YACzD,IAAI,CAAC;gBACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;oBACX,IAAI,EAAE,qBAAqB;oBAC3B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,QAAQ,EAAE;iBACrC,CAAC,CAAC;YACL,CAAC;YAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAC7B,CAAC,EAAE,kBAAkB,CAAC,CAAC;QAEvB,2DAA2D;QAC3D,IAAI,CAAC;YACH,MAAM,WAAW,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;YAC/C,WAAW,CAAC,UAAU,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;YAC5C,WAAW,CAAC,aAAa,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QACjD,CAAC;QAAC,MAAM,CAAC;YACP,oDAAoD;QACtD,CAAC;QAED,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,CAAC;QACjD,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;QACjE,CAAC;QAAC,MAAM,CAAC;YACP,+DAA+D;YAC/D,MAAM,WAAW,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;YAC/C,WAAW,CAAC,gBAAgB,CAAC;gBAC3B,IAAI,EAAE,aAAa;gBACnB,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,UAAgD;gBACtD,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;aACtC,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,cAAc;gBACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE;aAC1F,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACP,oEAAoE;QACtE,CAAC;IACH,CAAC;YAAS,CAAC;QACT,aAAa,EAAE,CAAC;QAChB,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;IAC9B,CAAC;AACH,CAAC"}

package/server/services/websocket/quality-fix-agent.ts

@@ -1,216 +0,0 @@
-// Copyright (c) 2025-present Mstro, Inc. All rights reserved.
-// Licensed under the MIT License. See LICENSE file for details.
-
-/**
- * Quality Fix Agent — AI-powered issue fixing using Claude Code headless runner.
- *
- * Builds the fix prompt, runs the agent, re-scans, and persists updated results.
- */
-
-import { ResilientRunner } from '../../cli/headless/resilient-runner.js';
-import type { ToolUseEvent } from '../../cli/headless/types.js';
-import { loadSkillPrompt } from '../plan/agent-loader.js';
-import type { HandlerContext } from './handler-context.js';
-import type { QualityPersistence } from './quality-persistence.js';
-import { detectTools, runQualityScan } from './quality-service.js';
-import type { WSContext } from './types.js';
-
-// ── Types ─────────────────────────────────────────────────────
-
-export interface FindingForFix {
-  severity: string;
-  category: string;
-  file: string;
-  line: number | null;
-  title: string;
-  description: string;
-  suggestion?: string;
-}
-
-// ── Progress callback ─────────────────────────────────────────
-
-const TOOL_MESSAGES: Record<string, string> = {
-  Read: 'Reading files to understand issues...',
-  Edit: 'Applying fixes...',
-  Write: 'Writing fixes...',
-  Grep: 'Searching for related code...',
-  Bash: 'Running verification...',
-};
-
-export function createToolProgressCallback(ctx: HandlerContext, ws: WSContext, reportPath: string) {
-  const seenTools = new Set<string>();
-  return (event: ToolUseEvent) => {
-    try {
-      if (event.type === 'tool_start' && event.toolName && !seenTools.has(event.toolName)) {
-        seenTools.add(event.toolName);
-        const message = TOOL_MESSAGES[event.toolName];
-        if (message) {
-          ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message } });
-        }
-      }
-      if (event.type === 'tool_complete' && event.toolName === 'Edit' && event.completeInput?.file_path) {
-        ctx.send(ws, {
-          type: 'qualityFixProgress',
-          data: { path: reportPath, message: `Fixed ${String(event.completeInput.file_path).split('/').slice(-2).join('/')}` },
-        });
-      }
-    } catch {
-      // WebSocket closed — progress lost but fix operation continues
-    }
-  };
-}
-
-function startFixHeartbeat(ctx: HandlerContext, ws: WSContext, reportPath: string, intervalMs = 30_000): () => void {
-  let elapsed = 0;
-  const timer = setInterval(() => {
-    elapsed += intervalMs;
-    const mins = Math.floor(elapsed / 60_000);
-    const secs = Math.floor((elapsed % 60_000) / 1000);
-    const timeStr = mins > 0 ? `${mins}m ${secs}s` : `${secs}s`;
-    try {
-      ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message: `Fixing issues (${timeStr} elapsed, still working...)` } });
-    } catch {
-      // WebSocket closed — heartbeat lost but fix continues
-    }
-  }, intervalMs);
-  return () => clearInterval(timer);
-}
-
-// ── Prompt ────────────────────────────────────────────────────
-
-function buildFixPrompt(findings: FindingForFix[], section?: string): string {
-  const filtered = section ? findings.filter((f) => f.category === section) : findings;
-  const sorted = filtered.sort((a, b) => {
-    const order: Record<string, number> = { critical: 0, high: 1, medium: 2, low: 3 };
-    return (order[a.severity] ?? 4) - (order[b.severity] ?? 4);
-  });
-
-  const issueList = sorted.slice(0, 30).map((f, i) => {
-    const loc = f.line ? `${f.file}:${f.line}` : f.file;
-    const parts = [`${i + 1}. [${f.severity.toUpperCase()}] ${loc} — ${f.title}`];
-    if (f.description) parts.push(`   ${f.description}`);
-    if (f.suggestion) parts.push(`   Suggestion: ${f.suggestion}`);
-    return parts.join('\n');
-  }).join('\n\n');
-
-  const fromSkill = loadSkillPrompt('fix-quality', {
-    issueList,
-    issueCount: String(sorted.length),
-    showCount: String(Math.min(30, sorted.length)),
-  });
-  if (fromSkill) return fromSkill;
-
-  return `You are a code quality fix agent. Fix the following quality issues in the codebase.\n\n## Issues to Fix (${sorted.length} total, showing top ${Math.min(30, sorted.length)})\n\n${issueList}\n\nFix each issue by editing the relevant file. Work from most to least severe. Do NOT introduce new issues.`;
-}
-
-// ── Handler ───────────────────────────────────────────────────
-
-const activeFixes = new Set<string>();
-
-export async function handleFixIssues(
-  ctx: HandlerContext,
-  ws: WSContext,
-  reportPath: string,
-  dirPath: string,
-  workingDir: string,
-  section: string | undefined,
-  findings: FindingForFix[],
-  getPersistence: (dir: string) => QualityPersistence,
-): Promise<void> {
-  if (activeFixes.has(dirPath)) {
-    ctx.send(ws, {
-      type: 'qualityError',
-      data: { path: reportPath, error: 'A fix operation is already running for this directory.' },
-    });
-    return;
-  }
-
-  if (findings.length === 0) {
-    ctx.send(ws, {
-      type: 'qualityError',
-      data: { path: reportPath, error: 'No findings to fix.' },
-    });
-    return;
-  }
-
-  activeFixes.add(dirPath);
-  const stopHeartbeat = startFixHeartbeat(ctx, ws, reportPath);
-  try {
-    try {
-      ctx.send(ws, {
-        type: 'qualityFixProgress',
-        data: { path: reportPath, message: 'Starting Claude Code to fix issues...' },
-      });
-    } catch { /* WS closed */ }
-
-    const prompt = buildFixPrompt(findings, section);
-
-    const runner = new ResilientRunner({
-      workingDir: dirPath,
-      prompt,
-      policy: 'STANDARD',
-      stallWarningMs: 300_000,
-      stallKillMs: 1_200_000,
-      stallHardCapMs: 1_800_000,
-      toolUseCallback: createToolProgressCallback(ctx, ws, reportPath),
-      logLabel: 'code-review-fix',
-    });
-
-    await runner.run();
-
-    try {
-      ctx.send(ws, {
-        type: 'qualityFixProgress',
-        data: { path: reportPath, message: 'Fixes applied. Re-running quality checks...' },
-      });
-    } catch { /* WS closed */ }
-
-    // Re-run quality scan after fixing
-    const { tools: detectedTools } = await detectTools(dirPath);
-    const installedToolNames = detectedTools.filter((t) => t.installed).map((t) => t.name);
-
-    const results = await runQualityScan(dirPath, (progress) => {
-      try {
-        ctx.send(ws, {
-          type: 'qualityScanProgress',
-          data: { path: reportPath, progress },
-        });
-      } catch { /* WS closed */ }
-    }, installedToolNames);
-
-    // Persist before sending — results survive WebSocket drops
-    try {
-      const persistence = getPersistence(workingDir);
-      persistence.saveReport(reportPath, results);
-      persistence.appendHistory(results, reportPath);
-    } catch {
-      // Persistence failure should not break the fix flow
-    }
-
-    const resultData = { path: reportPath, results };
-    try {
-      ctx.send(ws, { type: 'qualityFixComplete', data: resultData });
-    } catch {
-      // WebSocket closed — save as pending for delivery on reconnect
-      const persistence = getPersistence(workingDir);
-      persistence.addPendingResult({
-        type: 'fixComplete',
-        path: reportPath,
-        data: resultData as unknown as Record<string, unknown>,
-        completedAt: new Date().toISOString(),
-      });
-    }
-  } catch (error) {
-    try {
-      ctx.send(ws, {
-        type: 'qualityError',
-        data: { path: reportPath, error: error instanceof Error ? error.message : String(error) },
-      });
-    } catch {
-      // WebSocket closed — error lost but operation tracked via activeOps
-    }
-  } finally {
-    stopHeartbeat();
-    activeFixes.delete(dirPath);
-  }
-}