mstro-app 0.2.0 → 0.3.1

package/server/mcp/server.ts

@@ -73,7 +73,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
 
   const { tool_name, input } = request.params.arguments as {
     tool_name: string;
-    input: Record<string, any>;
+    input: Record<string, unknown>;
   };
 
   console.error(`[MCP Bouncer] Analyzing ${tool_name} request...`);
@@ -84,7 +84,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
 
   // Extract file path with multiple property name support
   // Claude Code may use file_path, filePath, or path depending on context
-  const getFilePath = (inp: Record<string, any>) =>
+  const getFilePath = (inp: Record<string, unknown>) =>
     inp.file_path || inp.filePath || inp.path;
 
   if (tool_name === 'Bash' && input.command) {
@@ -141,8 +141,9 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
         },
       ],
     };
-  } catch (error: any) {
-    console.error(`[MCP Bouncer] Error: ${error.message}`);
+  } catch (error: unknown) {
+    const errorMessage = error instanceof Error ? error.message : String(error);
+    console.error(`[MCP Bouncer] Error: ${errorMessage}`);
 
     // Fail-safe: deny on error
     return {
@@ -151,7 +152,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
           type: 'text',
           text: JSON.stringify({
             behavior: 'deny',
-            message: `Security analysis failed: ${error.message}. Denying for safety.`,
+            message: `Security analysis failed: ${errorMessage}. Denying for safety.`,
           }),
         },
       ],

package/server/services/analytics.ts

@@ -23,7 +23,19 @@ import { getClientId } from './client-id.js'
 
 const MSTRO_DIR = join(homedir(), '.mstro')
 const CONFIG_FILE = join(MSTRO_DIR, 'config.json')
-const PLATFORM_URL = process.env.PLATFORM_URL || 'https://api.mstro.app'
+
+// Read SERVER_URL from ~/.mstro/.env if it exists (for local dev)
+function getServerUrl(): string {
+  try {
+    const envPath = join(MSTRO_DIR, '.env')
+    const content = readFileSync(envPath, 'utf-8')
+    const match = content.match(/^SERVER_URL=(.+)$/m)
+    if (match) return match[1].trim()
+  } catch {}
+  return 'https://api.mstro.app'
+}
+
+const PLATFORM_URL = process.env.PLATFORM_URL || getServerUrl()
 
 let client: PostHog | null = null
 let telemetryEnabled: boolean | null = null
@@ -146,7 +158,7 @@ function getDistinctId(): string {
 /**
  * Get common properties included with all events
  */
-function getCommonProperties(): Record<string, any> {
+function getCommonProperties(): Record<string, unknown> {
   return {
     os: platform(),
     arch: arch(),
@@ -159,7 +171,7 @@ function getCommonProperties(): Record<string, any> {
 /**
  * Track a custom event
  */
-export function trackEvent(event: string, properties?: Record<string, any>): void {
+export function trackEvent(event: string, properties?: Record<string, unknown>): void {
   if (!client || !isTelemetryEnabled()) return
 
   client.capture({
@@ -175,7 +187,7 @@ export function trackEvent(event: string, properties?: Record<string, any>): voi
 /**
  * Identify a user (call after login)
  */
-export function identifyUser(userId: string, properties?: Record<string, any>): void {
+export function identifyUser(userId: string, properties?: Record<string, unknown>): void {
   if (!client || !isTelemetryEnabled()) return
 
   // Link the client ID to the user ID

package/server/services/files.ts

@@ -332,9 +332,9 @@ export function listDirectory(
       success: true,
       entries: directoryEntries
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     // Handle permission errors gracefully
-    if (error.code === 'EACCES') {
+    if (error instanceof Error && 'code' in error && (error as NodeJS.ErrnoException).code === 'EACCES') {
       return {
         success: false,
         error: 'Permission denied'
@@ -344,7 +344,7 @@ export function listDirectory(
     console.error('[FileService] Error listing directory:', error)
     return {
       success: false,
-      error: error.message || 'Failed to list directory'
+      error: error instanceof Error ? error.message : 'Failed to list directory'
     }
   }
 }
@@ -408,11 +408,11 @@ export function writeFile(
       success: true,
       path: resolvedPath.replace(`${workingDir}/`, '')
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[FileService] Error writing file:', error)
     return {
       success: false,
-      error: error.message || 'Failed to write file'
+      error: error instanceof Error ? error.message : 'Failed to write file'
     }
   }
 }
@@ -471,11 +471,11 @@ export function createFile(
       success: true,
       path: resolvedPath.replace(`${workingDir}/`, '')
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[FileService] Error creating file:', error)
     return {
       success: false,
-      error: error.message || 'Failed to create file'
+      error: error instanceof Error ? error.message : 'Failed to create file'
     }
   }
 }
@@ -536,11 +536,11 @@ export function createDirectory(
       success: true,
       path: resolvedPath.replace(`${workingDir}/`, '')
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[FileService] Error creating directory:', error)
     return {
       success: false,
-      error: error.message || 'Failed to create directory'
+      error: error instanceof Error ? error.message : 'Failed to create directory'
     }
   }
 }
@@ -618,11 +618,11 @@ export function deleteFile(
       success: true,
       path: resolvedPath.replace(`${workingDir}/`, '')
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[FileService] Error deleting file:', error)
     return {
       success: false,
-      error: error.message || 'Failed to delete'
+      error: error instanceof Error ? error.message : 'Failed to delete'
     }
   }
 }
@@ -700,11 +700,11 @@ export function renameFile(
       success: true,
       path: resolvedNewPath.replace(`${workingDir}/`, '')
     }
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[FileService] Error renaming file:', error)
     return {
       success: false,
-      error: error.message || 'Failed to rename'
+      error: error instanceof Error ? error.message : 'Failed to rename'
     }
   }
 }

package/server/services/pathUtils.ts

@@ -71,12 +71,12 @@ export function validatePathWithinWorkingDir(
       valid: true,
       resolvedPath
     };
-  } catch (error: any) {
+  } catch (error: unknown) {
     console.error('[PathUtils] Error validating path:', error);
     return {
       valid: false,
       resolvedPath: '',
-      error: `Invalid path: ${error.message}`
+      error: `Invalid path: ${error instanceof Error ? error.message : String(error)}`
     };
   }
 }

package/server/services/platform.ts

@@ -102,7 +102,18 @@ if (typeof WebSocket !== 'undefined') {
   WebSocketImpl = WS as unknown as typeof WebSocket
 }
 
-const DEFAULT_PLATFORM_URL = process.env.PLATFORM_URL || 'https://api.mstro.app'
+// Read SERVER_URL from ~/.mstro/.env if it exists (for local dev)
+function getServerUrl(): string {
+  try {
+    const envPath = join(MSTRO_DIR, '.env')
+    const content = readFileSync(envPath, 'utf-8')
+    const match = content.match(/^SERVER_URL=(.+)$/m)
+    if (match) return match[1].trim()
+  } catch {}
+  return 'https://api.mstro.app'
+}
+
+const DEFAULT_PLATFORM_URL = process.env.PLATFORM_URL || getServerUrl()
 
 interface ConnectionCallbacks {
   onConnected?: (connectionId: string) => void
@@ -110,7 +121,7 @@ interface ConnectionCallbacks {
   onError?: (error: string) => void
   onWebConnected?: () => void
   onWebDisconnected?: () => void
-  onRelayedMessage?: (message: any) => void
+  onRelayedMessage?: (message: unknown) => void
 }
 
 /**
@@ -340,15 +351,15 @@ export class PlatformConnection {
     }
   }
 
-  private handleMessage(message: any): void {
+  private handleMessage(message: Record<string, unknown>): void {
     switch (message.type) {
       case 'paired':
         this.isConnected = true
-        this.connectionId = message.connectionId
+        this.connectionId = message.connectionId as string
         // Connection status printed by onConnected callback
         // Start heartbeat to keep server-side TTL refreshed
         this.startHeartbeat()
-        this.callbacks.onConnected?.(message.connectionId)
+        this.callbacks.onConnected?.(message.connectionId as string)
         break
 
       case 'web_connected':
@@ -393,7 +404,7 @@ export class PlatformConnection {
   /**
    * Send message to platform (will be relayed to web if connected)
    */
-  send(message: any): void {
+  send(message: unknown): void {
     if (this.ws && this.ws.readyState === WebSocketImpl.OPEN) {
       this.ws.send(JSON.stringify(message))
     }

package/server/services/sentry.ts

@@ -65,7 +65,7 @@ export function initSentry(): void {
   })
 }
 
-export function captureException(error: unknown, context?: Record<string, any>): void {
+export function captureException(error: unknown, context?: Record<string, unknown>): void {
   if (!initialized) return
   Sentry.captureException(error, context ? { extra: context } : undefined)
 }

package/server/services/terminal/pty-manager.ts

@@ -17,6 +17,7 @@
  */
 
 import { EventEmitter } from 'node:events';
+import { createRequire } from 'node:module';
 import { homedir, platform } from 'node:os';
 import { sanitizeEnvForSandbox } from '../sandbox-utils.js';
 
@@ -26,8 +27,8 @@ let _ptyLoadError: string | null = null;
 
 try {
   pty = await import('node-pty');
-} catch (error: any) {
-  _ptyLoadError = error.message || 'Failed to load node-pty';
+} catch (error: unknown) {
+  _ptyLoadError = error instanceof Error ? error.message : 'Failed to load node-pty';
   console.warn('[PTYManager] node-pty not available - terminal features disabled');
   console.warn('[PTYManager] To enable terminals, run: mstro setup-terminal');
 }
@@ -39,6 +40,32 @@ export function isPtyAvailable(): boolean {
   return pty !== null;
 }
 
+/**
+ * Re-attempt loading node-pty at runtime.
+ * Called after `mstro setup-terminal` compiles the native module
+ * so the running server can pick it up without a restart.
+ *
+ * Uses createRequire (CJS) to bypass ESM's module cache — a failed
+ * ESM import is permanently cached, but CJS require cache entries
+ * can be deleted and re-required.
+ */
+export async function reloadPty(): Promise<boolean> {
+  if (pty) return true;
+  try {
+    const require = createRequire(import.meta.url);
+    // Clear any cached failure so require() retries the native load
+    const resolved = require.resolve('node-pty');
+    delete require.cache[resolved];
+    pty = require('node-pty');
+    _ptyLoadError = null;
+    console.log('[PTYManager] node-pty loaded successfully after reload');
+    return true;
+  } catch (error: unknown) {
+    _ptyLoadError = error instanceof Error ? error.message : 'Failed to load node-pty';
+    return false;
+  }
+}
+
 /**
  * Get installation instructions for node-pty based on platform
  */
@@ -87,6 +114,9 @@ export interface PTYSession {
   // Current dimensions
   cols: number;
   rows: number;
+  // Output coalescing: buffer small chunks into fewer WS messages
+  _outputBuffer: string;
+  _outputTimer: ReturnType<typeof setTimeout> | null;
 }
 
 /**
@@ -227,25 +257,63 @@ export class PTYManager extends EventEmitter {
         lastActivityAt: Date.now(),
         cols,
         rows,
+        _outputBuffer: '',
+        _outputTimer: null,
       };
       this.terminals.set(terminalId, session);
 
-      // Handle data output
+      // Handle data output — coalesce small chunks to reduce WebSocket message count.
+      // On macOS, node-pty emits many tiny chunks (sometimes single bytes) and zsh
+      // wraps echoed chars in multi-part ANSI sequences (RPROMPT, syntax highlighting).
+      // A longer window on macOS ensures these multi-part sequences arrive as one chunk,
+      // which the browser's predictive echo can match correctly.
+      const OUTPUT_COALESCE_MS = platform() === 'darwin' ? 24 : 8;
+      // High-water mark: flush immediately when buffer exceeds this size
+      // to prevent unbounded memory growth during high-output commands (e.g. `yes`)
+      const OUTPUT_HIGH_WATER = 64 * 1024; // 64KB
+      // Maximum chunk size per WebSocket message to prevent browser overload
+      const OUTPUT_CHUNK_SIZE = 64 * 1024;
+
+      const flushOutputBuffer = () => {
+        if (session._outputTimer) {
+          clearTimeout(session._outputTimer);
+          session._outputTimer = null;
+        }
+        const buffered = session._outputBuffer;
+        session._outputBuffer = '';
+        // Chunk large output to prevent single massive WebSocket frames
+        for (let i = 0; i < buffered.length; i += OUTPUT_CHUNK_SIZE) {
+          this.emit('output', terminalId, buffered.slice(i, i + OUTPUT_CHUNK_SIZE));
+        }
+      };
+
       ptyProcess.onData((data: string) => {
         session.lastActivityAt = Date.now();
-        this.emit('output', terminalId, data);
+        session._outputBuffer += data;
+        // Flush immediately if buffer exceeds high-water mark
+        if (session._outputBuffer.length >= OUTPUT_HIGH_WATER) {
+          flushOutputBuffer();
+        } else if (!session._outputTimer) {
+          session._outputTimer = setTimeout(flushOutputBuffer, OUTPUT_COALESCE_MS);
+        }
       });
 
-      // Handle exit
+      // Handle exit — flush any buffered output first
       ptyProcess.onExit(({ exitCode }) => {
+        if (session._outputBuffer) {
+          flushOutputBuffer();
+        } else if (session._outputTimer) {
+          clearTimeout(session._outputTimer);
+          session._outputTimer = null;
+        }
         this.emit('exit', terminalId, exitCode);
         this.terminals.delete(terminalId);
       });
 
       return { shell: session.shell, cwd, isReconnect: false };
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error(`[PTYManager] Failed to create terminal ${terminalId}:`, error);
-      this.emit('error', terminalId, error.message || 'Failed to create terminal');
+      this.emit('error', terminalId, error instanceof Error ? error.message : 'Failed to create terminal');
       throw error;
     }
   }
@@ -263,9 +331,9 @@ export class PTYManager extends EventEmitter {
     try {
       session.pty.write(data);
       return true;
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error(`[PTYManager] Error writing to terminal ${terminalId}:`, error);
-      this.emit('error', terminalId, error.message || 'Write failed');
+      this.emit('error', terminalId, error instanceof Error ? error.message : 'Write failed');
       return false;
     }
   }
@@ -283,7 +351,7 @@ export class PTYManager extends EventEmitter {
     try {
       session.pty.resize(cols, rows);
       return true;
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error(`[PTYManager] Error resizing terminal ${terminalId}:`, error);
       return false;
     }
@@ -300,10 +368,19 @@ export class PTYManager extends EventEmitter {
 
 
     try {
+      // Flush any coalesced output before closing
+      if (session._outputTimer) {
+        clearTimeout(session._outputTimer);
+        if (session._outputBuffer) {
+          this.emit('output', terminalId, session._outputBuffer);
+          session._outputBuffer = '';
+        }
+        session._outputTimer = null;
+      }
       session.pty.kill();
       this.terminals.delete(terminalId);
       return true;
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error(`[PTYManager] Error closing terminal ${terminalId}:`, error);
       this.terminals.delete(terminalId);
       return false;