mssql 7.2.1 → 7.3.2

package/CHANGELOG.txt

@@ -1,3 +1,17 @@
+v7.3.2 (2022-02-24)
+-------------------
+[fix] nodemsqlv8 driver tests working against Node 10 ([#1368](https://github.com/tediousjs/node-mssql/pull/1368))
+[fix] quote identifiers in table primary keys ([#1394](https://github.com/tediousjs/node-mssql/pull/1394))
+
+v7.3.1 (2022-02-24)
+-------------------
+[fix] Bump debug dependency ([#1361](https://github.com/tediousjs/node-mssql/pull/1361))
+
+v7.3.0 (2021-11-18)
+-------------------
+[new] Transaction/PreparedStatements expose the config from their parent connection
+[fix] Fix inherited request configs from the pool. Specifically stream and arrayRowMode now inherit accurately from the connection config ([#1338](https://github.com/tediousjs/node-mssql/pull/1338))
+
 v7.2.1 (2021-08-19)
 -------------------
 [fix] Fix issue with bulk insert of dates ((#1298)[https://github.com/tediousjs/node-mssql/pull/1298])
@@ -44,6 +58,15 @@ v7.0.0 (2021-05-06)
 [fix] Connection config objects are now deep cloned when stored against a connection pool ([#1217](https://github.com/tediousjs/node-mssql/pull/1217))
 [removed] Support for connection uri format has been removed (eg: `mssql://user:password@host/?params=values`)
 
+v6.4.1 (2022-02-24)
+-------------------
+[fix] Bump debug dependency ([#1361](https://github.com/tediousjs/node-mssql/pull/1361))
+
+v6.4.0 (2021-11-18)
+-------------------
+[new] Transaction/PreparedStatements expose the config from their parent connection
+[fix] Fix inherited request configs from the pool. Specifically stream and arrayRowMode now inherit accurately from the connection config ([#1338](https://github.com/tediousjs/node-mssql/pull/1338))
+
 v6.3.2 (2021-05-13)
 -------------------
 [fix] Bump various dependencies for security fixes

package/README.md

@@ -140,7 +140,7 @@ async () => {
 * [SQL injection](#sql-injection)
 * [Known Issues](#known-issues)
 * [Contributing](https://github.com/tediousjs/node-mssql/wiki/Contributing)
-* [6.x to 7.x changes (pre-release)](#6x-to-7x-changes-pre-release)
+* [6.x to 7.x changes](#6x-to-7x-changes)
 * [5.x to 6.x changes](#5x-to-6x-changes)
 * [4.x to 5.x changes](#4x-to-5x-changes)
 * [3.x to 4.x changes](#3x-to-4x-changes)
@@ -2094,11 +2094,15 @@ request.query('select @myval as myval', (err, result) => {
 - If you're facing problems with connecting SQL Server 2000, try setting the default TDS version to 7.1 with `config.options.tdsVersion = '7_1'` ([issue](https://github.com/tediousjs/node-mssql/issues/36))
 - If you're executing a statement longer than 4000 chars on SQL Server 2000, always use [batch](#batch-batch-callback) instead of [query](#query-command-callback) ([issue](https://github.com/tediousjs/node-mssql/issues/68))
 
-## 6.x to 7.x changes (pre-release)
+## 6.x to 7.x changes
 
-- Upgraded tedious version to v8
+- Upgraded tedious version to v11
+- Upgraded msnodesqlv8 version support to v2
+- Upgraded tarn.js version to v3
 - Requests in stream mode that pipe into other streams no longer pass errors up the stream chain
+- Request.pipe now pipes a true node stream for better support of backpressure
 - tedious config option `trustServerCertificate` defaults to `false` if not supplied
+- Dropped support for Node < 10
 
 ## 5.x to 6.x changes
 

package/lib/base/prepared-statement.js

@@ -35,6 +35,10 @@ class PreparedStatement extends EventEmitter {
     this.parameters = {}
   }
 
+  get config () {
+    return this.parent.config
+  }
+
   get connected () {
     return this.parent.connected
   }

package/lib/base/request.js

@@ -26,7 +26,7 @@ class Request extends EventEmitter {
   /**
    * Create new Request.
    *
-   * @param {Connection|ConnectionPool|Transaction|PreparedStatement} parent If ommited, global connection is used instead.
+   * @param {Connection|ConnectionPool|Transaction|PreparedStatement} parent If omitted, global connection is used instead.
    */
 
   constructor (parent) {
@@ -39,6 +39,8 @@ class Request extends EventEmitter {
     this._paused = false
     this.parent = parent || globalConnection.pool
     this.parameters = {}
+    this.stream = null
+    this.arrayRowMode = null
   }
 
   get paused () {
@@ -224,8 +226,8 @@ class Request extends EventEmitter {
    */
 
   batch (batch, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {
@@ -288,11 +290,11 @@ class Request extends EventEmitter {
    */
 
   _batch (batch, callback) {
-    if (!this.connection) {
+    if (!this.parent) {
       return setImmediate(callback, new RequestError('No connection is specified for that request.', 'ENOCONN'))
     }
 
-    if (!this.connection.connected) {
+    if (!this.parent.connected) {
       return setImmediate(callback, new ConnectionError('Connection is closed.', 'ECONNCLOSED'))
     }
 
@@ -317,8 +319,8 @@ class Request extends EventEmitter {
       options = {}
     }
 
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
 
     if (this.stream || typeof callback === 'function') {
       this._bulk(table, options, (err, rowsAffected) => {
@@ -419,8 +421,8 @@ class Request extends EventEmitter {
    */
 
   query (command, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {
@@ -508,8 +510,8 @@ class Request extends EventEmitter {
    */
 
   execute (command, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {

package/lib/base/transaction.js

@@ -37,6 +37,10 @@ class Transaction extends EventEmitter {
     this.name = ''
   }
 
+  get config () {
+    return this.parent.config
+  }
+
   get connected () {
     return this.parent.connected
   }

package/lib/table.js

@@ -92,7 +92,7 @@ Table.prototype._makeBulk = function _makeBulk () {
 }
 
 Table.prototype.declare = function declare () {
-  const pkey = this.columns.filter(col => col.primary === true).map(col => col.name)
+  const pkey = this.columns.filter(col => col.primary === true).map(col => `[${col.name}]`)
   const cols = this.columns.map(col => {
     const def = [`[${col.name}] ${declareType(col.type, col)}`]
 

package/package.json

@@ -21,20 +21,20 @@
     "azure",
     "node-mssql"
   ],
-  "version": "7.2.1",
+  "version": "7.3.2",
   "main": "index.js",
   "repository": "github:tediousjs/node-mssql",
   "license": "MIT",
   "dependencies": {
     "@tediousjs/connection-string": "^0.3.0",
-    "debug": "^4.3.2",
+    "debug": "^4.3.3",
     "rfdc": "^1.3.0",
     "tarn": "^3.0.1",
     "tedious": "^11.4.0"
   },
   "devDependencies": {
     "mocha": "^8.4.0",
-    "standard": "^16.0.3"
+    "standard": "^16.0.4"
   },
   "engines": {
     "node": ">=10"
@@ -42,8 +42,8 @@
   "files": [
     "lib/",
     "bin/",
-    "*.js",
-    "*.md"
+    "tedious.js",
+    "index.js"
   ],
   "scripts": {
     "test": "npm run lint && npm run test-unit",

package/msnodesqlv8.js

@@ -1 +0,0 @@
-module.exports = require('./lib/msnodesqlv8')

package/test.js

@@ -1,47 +0,0 @@
-'use strict'
-
-const mssql = require('./')
-
-const sqlConfig = {
-  password: 'Upper_l0wercase',
-  database: 'di_production',
-  stream: false,
-  options: {
-    trustServerCertificate: true,
-    enableArithAbort: true,
-    encrypt: true,
-    abortTransactionOnError: false,
-  },
-  pool: {
-    max: 1,
-    min: 0,
-  },
-  port: 1433,
-  user: 'sa',
-  server: 'localhost',
-}
-
-async function main () {
-  const pool = new mssql.ConnectionPool(sqlConfig)
-  await pool.connect()
-
-  try {
-    const temp = new mssql.Table('#mytemptable');
-    temp.create = true;
-    temp.columns.add('ts', mssql.DateTime());
-
-    temp.rows.push(['obviously_bad_data']); // obviously bad data
-
-    const request = pool.request();
-    await request.bulk(temp); /////// <<<<< Error occurs here
-    const { recordset } = await request.query(`SELECT * FROM #mytemptable`);
-
-    console.log(recordset);
-  } catch (e) {
-    console.error(e);
-  } finally {
-    await pool.close();
-  }
-}
-
-main().catch(console.error);