mssql 7.1.2 → 7.3.0

package/CHANGELOG.txt

@@ -1,10 +1,26 @@
+v7.3.0 (2021-11-18)
+-------------------
+[new] Transaction/PreparedStatements expose the config from their parent connection
+[fix] Fix inherited request configs from the pool. Specifically stream and arrayRowMode now inherit accurately from the connection config ([#1338](https://github.com/tediousjs/node-mssql/pull/1338))
+
+v7.2.1 (2021-08-19)
+-------------------
+[fix] Fix issue with bulk insert of dates ((#1298)[https://github.com/tediousjs/node-mssql/pull/1298])
+
+v7.2.0 (2021-07-29)
+-------------------
+[new] Update Geography field parsing to provide lat/lng props from Geography Point ((#1282)[https://github.com/tediousjs/node-mssql/pull/1282])
+[fix] Handle errors when adding rows to bulk operations ((#1264)[https://github.com/tediousjs/node-mssql/pull/1264])
+[fix] Input/Output parameter passing fix for msnodesqlv8 driver ((#1275)[https://github.com/tediousjs/node-mssql/pull/1275])
+
+v7.1.3 (2021-06-11)
+-------------------
+[fix] Request timeout settings now respect value parsed from connection strings ((#1257)[https://github.com/tediousjs/node-mssql/pull/1257)
+
 v7.1.1 (2021-06-09)
 -------------------
-[fix] Errors from tedious connection creation now cause connection promise to
-reject ((#1254)[https://github.com/tediousjs/node-mssql/pull/1254])
-[fix] Encrypt and transaction binding settings now respect value parsed from
-connection strings
-((#1252)[https://github.com/tediousjs/node-mssql/pull/1252)
+[fix] Errors from tedious connection creation now cause connection promise to reject ((#1254)[https://github.com/tediousjs/node-mssql/pull/1254])
+[fix] Encrypt and transaction binding settings now respect value parsed from connection strings ((#1252)[https://github.com/tediousjs/node-mssql/pull/1252)
 
 v7.1.0 (2021-05-13)
 -------------------
@@ -31,7 +47,12 @@ v7.0.0 (2021-05-06)
 [fix] Trailing rows from request streams using msnodesqlv8 driver fail to be emitted ([#1109](https://github.com/tediousjs/node-mssql/pull/1109))
 [fix] Issue with geography v2 parsing resolve ([#1138](https://github.com/tediousjs/node-mssql/pull/1138))
 [fix] Connection config objects are now deep cloned when stored against a connection pool ([#1217](https://github.com/tediousjs/node-mssql/pull/1217))
-[removed] Support for connection uri format has been removed (eg: `mssql://user:password@host/?params=values`
+[removed] Support for connection uri format has been removed (eg: `mssql://user:password@host/?params=values`)
+
+v6.4.0 (2021-11-18)
+-------------------
+[new] Transaction/PreparedStatements expose the config from their parent connection
+[fix] Fix inherited request configs from the pool. Specifically stream and arrayRowMode now inherit accurately from the connection config ([#1338](https://github.com/tediousjs/node-mssql/pull/1338))
 
 v6.3.2 (2021-05-13)
 -------------------

package/README.md

@@ -140,7 +140,7 @@ async () => {
 * [SQL injection](#sql-injection)
 * [Known Issues](#known-issues)
 * [Contributing](https://github.com/tediousjs/node-mssql/wiki/Contributing)
-* [6.x to 7.x changes (pre-release)](#6x-to-7x-changes-pre-release)
+* [6.x to 7.x changes](#6x-to-7x-changes)
 * [5.x to 6.x changes](#5x-to-6x-changes)
 * [4.x to 5.x changes](#4x-to-5x-changes)
 * [3.x to 4.x changes](#3x-to-4x-changes)
@@ -693,11 +693,14 @@ require('mssql').connect({...config, beforeConnect: conn => {
 - **options.tdsVersion** - The version of TDS to use (default: `7_4`, available: `7_1`, `7_2`, `7_3_A`, `7_3_B`, `7_4`).
 - **options.appName** - Application name used for SQL server logging.
 - **options.abortTransactionOnError** - A boolean determining whether to rollback a transaction automatically if any error is encountered during the given transaction's execution. This sets the value for `XACT_ABORT` during the initial SQL phase of a connection.
-- **options.authentication** - An object with authentication settings, according to the [Tedious Documentation](https://tediousjs.github.io/tedious/api-connection.html). Passing this object will override `options.user`, `options.password`, `options.domain` settings.
-- **options.authentication.type** - Type of the authentication method, valid types are `default`, `ntlm`, `azure-active-directory-password`, `azure-active-directory-access-token`, `azure-active-directory-msi-vm`, or `azure-active-directory-msi-app-service`
-- **options.authentication.options** - Options of the authentication required by the `tedious` driver, depends on `options.authentication.type`. For more details, check [Tedious Authentication Interfaces](https://github.com/tediousjs/tedious/blob/master/src/connection.ts#L237)
 
+**Authentication:**
 
+On top of the extra options, an `authentication` property can be added to the pool config option
+
+- **authentication** - An object with authentication settings, according to the [Tedious Documentation](https://tediousjs.github.io/tedious/api-connection.html). Passing this object will override `user`, `password`, `domain` settings.
+- **authentication.type** - Type of the authentication method, valid types are `default`, `ntlm`, `azure-active-directory-password`, `azure-active-directory-access-token`, `azure-active-directory-msi-vm`, or `azure-active-directory-msi-app-service`
+- **authentication.options** - Options of the authentication required by the `tedious` driver, depends on `authentication.type`. For more details, check [Tedious Authentication Interfaces](https://github.com/tediousjs/tedious/blob/v11.1.1/src/connection.ts#L200-L318)
 
 More information about Tedious specific options: http://tediousjs.github.io/tedious/api-connection.html
 
@@ -1511,32 +1514,65 @@ If you omit config path argument, mssql will try to load it from current working
 
 ## Geography and Geometry
 
-node-mssql has built-in serializer for Geography and Geometry CLR data types.
+node-mssql has built-in deserializer for Geography and Geometry CLR data types.
+
+### Geography
+
+Geography types can be constructed several different ways. Refer carefully to documentation to verify the coordinate ordering; the ST methods tend to order parameters as longitude (x) then latitude (y), while custom CLR methods tend to prefer to order them as latitude (y) then longitude (x).
+
+The query:
 
 ```sql
-select geography::STGeomFromText('LINESTRING(-122.360 47.656, -122.343 47.656 )', 4326)
-select geometry::STGeomFromText('LINESTRING (100 100 10.3 12, 20 180, 180 180)', 0)
+select geography::STGeomFromText(N'POLYGON((1 1, 3 1, 3 1, 1 1))',4326)
 ```
 
-Results in:
+results in:
 
 ```javascript
-{ srid: 4326,
-  version: 1,
-  points: [ { x: 47.656, y: -122.36 }, { x: 47.656, y: -122.343 } ],
+{
+  srid: 4326,
+  version: 2,
+  points: [
+    Point { lat: 1, lng: 1, z: null, m: null },
+    Point { lat: 1, lng: 3, z: null, m: null },
+    Point { lat: 1, lng: 3, z: null, m: null },
+    Point { lat: 1, lng: 1, z: null, m: null }
+  ],
   figures: [ { attribute: 1, pointOffset: 0 } ],
-  shapes: [ { parentOffset: -1, figureOffset: 0, type: 2 } ],
-  segments: [] }
+  shapes: [ { parentOffset: -1, figureOffset: 0, type: 3 } ],
+  segments: []
+}
+```
+
+**NOTE:** You will also see `x` and `y` coordinates in parsed Geography points,
+they are not recommended for use. They have thus been omitted from this example.
+For compatibility, they remain flipped (x, the horizontal offset, is instead used for latitude, the vertical), and thus risk misleading you.
+Prefer instead to use the `lat` and `lng` properties.
 
-{ srid: 0,
+### Geometry
+
+Geometry types can also be constructed in several ways. Unlike Geographies, they are consistent in always placing x before y. node-mssql decodes the result of this query:
+
+```sql
+select geometry::STGeomFromText(N'POLYGON((1 1, 3 1, 3 7, 1 1))',4326)
+```
+
+into the JavaScript object:
+
+```javascript
+{
+  srid: 4326,
   version: 1,
-  points:
-   [ { x: 100, y: 100, z: 10.3, m: 12 },
-     { x: 20, y: 180, z: NaN, m: NaN },
-     { x: 180, y: 180, z: NaN, m: NaN } ],
-  figures: [ { attribute: 1, pointOffset: 0 } ],
-  shapes: [ { parentOffset: -1, figureOffset: 0, type: 2 } ],
-  segments: [] }
+  points: [
+    Point { x: 1, y: 1, z: null, m: null },
+    Point { x: 1, y: 3, z: null, m: null },
+    Point { x: 7, y: 3, z: null, m: null },
+    Point { x: 1, y: 1, z: null, m: null }
+  ],
+  figures: [ { attribute: 2, pointOffset: 0 } ],
+  shapes: [ { parentOffset: -1, figureOffset: 0, type: 3 } ],
+  segments: []
+}
 ```
 
 ## Table-Valued Parameter (TVP)
@@ -2058,11 +2094,15 @@ request.query('select @myval as myval', (err, result) => {
 - If you're facing problems with connecting SQL Server 2000, try setting the default TDS version to 7.1 with `config.options.tdsVersion = '7_1'` ([issue](https://github.com/tediousjs/node-mssql/issues/36))
 - If you're executing a statement longer than 4000 chars on SQL Server 2000, always use [batch](#batch-batch-callback) instead of [query](#query-command-callback) ([issue](https://github.com/tediousjs/node-mssql/issues/68))
 
-## 6.x to 7.x changes (pre-release)
+## 6.x to 7.x changes
 
-- Upgraded tedious version to v8
+- Upgraded tedious version to v11
+- Upgraded msnodesqlv8 version support to v2
+- Upgraded tarn.js version to v3
 - Requests in stream mode that pipe into other streams no longer pass errors up the stream chain
+- Request.pipe now pipes a true node stream for better support of backpressure
 - tedious config option `trustServerCertificate` defaults to `false` if not supplied
+- Dropped support for Node < 10
 
 ## 5.x to 6.x changes
 

package/lib/base/connection-pool.js

@@ -247,7 +247,7 @@ class ConnectionPool extends EventEmitter {
             workstationId: value
           })
           break
-        case 'requesttimeout':
+        case 'request timeout':
           Object.assign(config, {
             requestTimeout: parseInt(value, 10)
           })

package/lib/base/prepared-statement.js

@@ -35,6 +35,10 @@ class PreparedStatement extends EventEmitter {
     this.parameters = {}
   }
 
+  get config () {
+    return this.parent.config
+  }
+
   get connected () {
     return this.parent.connected
   }

package/lib/base/request.js

@@ -26,7 +26,7 @@ class Request extends EventEmitter {
   /**
    * Create new Request.
    *
-   * @param {Connection|ConnectionPool|Transaction|PreparedStatement} parent If ommited, global connection is used instead.
+   * @param {Connection|ConnectionPool|Transaction|PreparedStatement} parent If omitted, global connection is used instead.
    */
 
   constructor (parent) {
@@ -39,6 +39,8 @@ class Request extends EventEmitter {
     this._paused = false
     this.parent = parent || globalConnection.pool
     this.parameters = {}
+    this.stream = null
+    this.arrayRowMode = null
   }
 
   get paused () {
@@ -224,8 +226,8 @@ class Request extends EventEmitter {
    */
 
   batch (batch, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {
@@ -288,11 +290,11 @@ class Request extends EventEmitter {
    */
 
   _batch (batch, callback) {
-    if (!this.connection) {
+    if (!this.parent) {
       return setImmediate(callback, new RequestError('No connection is specified for that request.', 'ENOCONN'))
     }
 
-    if (!this.connection.connected) {
+    if (!this.parent.connected) {
       return setImmediate(callback, new ConnectionError('Connection is closed.', 'ECONNCLOSED'))
     }
 
@@ -317,8 +319,8 @@ class Request extends EventEmitter {
       options = {}
     }
 
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
 
     if (this.stream || typeof callback === 'function') {
       this._bulk(table, options, (err, rowsAffected) => {
@@ -419,8 +421,8 @@ class Request extends EventEmitter {
    */
 
   query (command, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {
@@ -508,8 +510,8 @@ class Request extends EventEmitter {
    */
 
   execute (command, callback) {
-    if (this.stream == null && this.connection) this.stream = this.connection.config.stream
-    if (this.arrayRowMode == null && this.connection) this.arrayRowMode = this.connection.config.arrayRowMode
+    if (this.stream === null && this.parent) this.stream = this.parent.config.stream
+    if (this.arrayRowMode === null && this.parent) this.arrayRowMode = this.parent.config.arrayRowMode
     this.rowsAffected = 0
 
     if (typeof callback === 'function') {

package/lib/base/transaction.js

@@ -37,6 +37,10 @@ class Transaction extends EventEmitter {
     this.name = ''
   }
 
+  get config () {
+    return this.parent.config
+  }
+
   get connected () {
     return this.parent.connected
   }

package/lib/msnodesqlv8/request.js

@@ -146,7 +146,11 @@ class Request extends BaseRequest {
     super._bulk(table, options, err => {
       if (err) return callback(err)
 
-      table._makeBulk()
+      try {
+        table._makeBulk()
+      } catch (e) {
+        return callback(new RequestError(e, 'EREQUEST'))
+      }
 
       if (!table.name) {
         setImmediate(callback, new RequestError('Table name must be specified for bulk insert.', 'ENAME'))
@@ -358,7 +362,7 @@ class Request extends BaseRequest {
             continue
           }
           const param = this.parameters[name]
-          if (param.io === 1) {
+          if (param.io === 1 || (param.io === 2 && param.value)) {
             params.push(castParameter(param.value, param.type, param))
           }
         }
@@ -633,7 +637,19 @@ class Request extends BaseRequest {
         }
       }
 
-      let cmd = `declare ${['@___return___ int'].concat(params).join(', ')};`
+      // set output params w/ values
+      const sets = []
+      for (const name in this.parameters) {
+        if (!objectHasProperty(this.parameters, name)) {
+          continue
+        }
+        const param = this.parameters[name]
+        if (param.io === 2 && param.value) {
+          sets.push(`set @${param.name}=?`)
+        }
+      }
+
+      let cmd = `declare ${['@___return___ int'].concat(params).join(', ')};${sets.join(';')};`
       cmd += `exec @___return___ = ${procedure} `
 
       const spp = []

package/lib/tedious/request.js

@@ -213,7 +213,11 @@ class Request extends BaseRequest {
     super._bulk(table, options, err => {
       if (err) return callback(err)
 
-      table._makeBulk()
+      try {
+        table._makeBulk()
+      } catch (e) {
+        return callback(new RequestError(e, 'EREQUEST'))
+      }
 
       if (!table.name) {
         return callback(new RequestError('Table name must be specified for bulk insert.', 'ENAME'))
@@ -266,14 +270,21 @@ class Request extends BaseRequest {
       }
 
       this.parent.acquire(this, (err, connection) => {
-        if (err) return callback(err)
+        const callbackWithRelease = (err, ...args) => {
+          try {
+            this.parent.release(connection)
+          } catch (e) {
+            // noop
+          }
+          callback(err, ...args)
+        }
+        if (err) return callbackWithRelease(err)
 
         debug('connection(%d): borrowed to request #%d', IDS.get(connection), IDS.get(this))
 
         if (this.canceled) {
           debug('request(%d): canceled', IDS.get(this))
-          this.parent.release(connection)
-          return callback(new RequestError('Canceled.', 'ECANCEL'))
+          return callbackWithRelease(new RequestError('Canceled.', 'ECANCEL'))
         }
 
         this._cancel = () => {
@@ -307,13 +318,12 @@ class Request extends BaseRequest {
               connection.removeListener(event, errorHandlers[event])
             }
 
-            this.parent.release(connection)
             hasReturned = true
 
             if (this.stream) {
-              callback(null, rowCount)
+              callbackWithRelease(null, rowCount)
             } else {
-              callback(error, rowCount)
+              callbackWithRelease(error, rowCount)
             }
           }
         }
@@ -325,7 +335,11 @@ class Request extends BaseRequest {
         }
 
         for (const row of table.rows) {
-          bulk.addRow(row)
+          try {
+            bulk.addRow(row)
+          } catch (e) {
+            return handleError(true, connection, e)
+          }
         }
 
         if (table.create) {

package/lib/udt.js

@@ -53,20 +53,42 @@ class Point {
   }
 }
 
-const parsePoints = (buffer, count) => {
+const parsePoints = (buffer, count, isGeometryPoint) => {
   // s2.1.5 + s2.1.6
+  // The key distinction for parsing is that a GEOGRAPHY POINT is ordered Lat (y) then Long (x),
+  // while a GEOMETRY POINT is ordered x then y.
+  // Further, there are additional range constraints on GEOGRAPHY POINT that are useful for testing that the coordinate order has not been flipped, such as that Lat must be in the range [-90, +90].
 
   const points = []
   if (count < 1) {
     return points
   }
 
-  for (let i = 1; i <= count; i++) {
-    const point = new Point()
-    points.push(point)
-    point.x = buffer.readDoubleLE(buffer.position)
-    point.y = buffer.readDoubleLE(buffer.position + 8)
-    buffer.position += 16
+  if (isGeometryPoint) {
+    // GEOMETRY POINT (s2.1.6): x then y.
+    for (let i = 1; i <= count; i++) {
+      const point = new Point()
+      points.push(point)
+      point.x = buffer.readDoubleLE(buffer.position)
+      point.y = buffer.readDoubleLE(buffer.position + 8)
+      buffer.position += 16
+    }
+  } else {
+    // GEOGRAPHY POINT (s2.1.5): Lat (y) then Long (x).
+    for (let i = 1; i <= count; i++) {
+      const point = new Point()
+      points.push(point)
+      point.lat = buffer.readDoubleLE(buffer.position)
+      point.lng = buffer.readDoubleLE(buffer.position + 8)
+
+      // For backwards compatibility, preserve the coordinate inversion in x and y.
+      // A future breaking change likely eliminate x and y for geography points in favor of just the lat and lng fields, as they've proven marvelously confusing.
+      // See discussion at: https://github.com/tediousjs/node-mssql/pull/1282#discussion_r677769531
+      point.x = point.lat
+      point.y = point.lng
+
+      buffer.position += 16
+    }
   }
 
   return points
@@ -182,7 +204,7 @@ const parseSegments = (buffer, count) => {
   return segments
 }
 
-const parseGeography = buffer => {
+const parseGeography = (buffer, isUsingGeometryPoints) => {
   // s2.1.1 + s.2.1.2
 
   const srid = buffer.readInt32LE(0)
@@ -227,7 +249,7 @@ const parseGeography = buffer => {
 
   // console.log("numberOfPoints", numberOfPoints)
 
-  value.points = parsePoints(buffer, numberOfPoints)
+  value.points = parsePoints(buffer, numberOfPoints, isUsingGeometryPoints)
 
   if (properties.Z) {
     parseZ(buffer, value.points)
@@ -289,10 +311,10 @@ const parseGeography = buffer => {
 
 module.exports.PARSERS = {
   geography (buffer) {
-    return parseGeography(buffer)
+    return parseGeography(buffer, /* isUsingGeometryPoints: */false)
   },
 
   geometry (buffer) {
-    return parseGeography(buffer)
+    return parseGeography(buffer, /* isUsingGeometryPoints: */true)
   }
 }

package/package.json

@@ -21,20 +21,20 @@
     "azure",
     "node-mssql"
   ],
-  "version": "7.1.2",
+  "version": "7.3.0",
   "main": "index.js",
   "repository": "github:tediousjs/node-mssql",
   "license": "MIT",
   "dependencies": {
     "@tediousjs/connection-string": "^0.3.0",
-    "debug": "^4",
+    "debug": "^4.3.2",
     "rfdc": "^1.3.0",
     "tarn": "^3.0.1",
-    "tedious": "^11.0.7"
+    "tedious": "^11.4.0"
   },
   "devDependencies": {
-    "mocha": "^8.3.2",
-    "standard": "^16.0.3"
+    "mocha": "^8.4.0",
+    "standard": "^16.0.4"
   },
   "engines": {
     "node": ">=10"

package/test.js

@@ -20,28 +20,21 @@ const sqlConfig = {
   },
   port: 1433,
   user: 'sa',
-  server: 'localhost'
-};
+  server: 'localhost',
+  arrayRowMode: true
+}
 
-(async () => {
-  const pool = new mssql.ConnectionPool(sqlConfig)
-  try {
-    await pool.connect();
-
-    const  request = pool.request();
-    request.arrayRowMode = true;
-    request.multiple = true;
-
-    const result = await request.batch('SELECT 1;');
-
-    Object.entries(result.recordset.columns).forEach(([key, value]) => {
-      console.log(`Column: ${key}, ${JSON.stringify(value)}`);
-    });
-  } catch (err) {
-    console.error(err)
-  } finally {
-    console.log('closing pool')
-    await pool.close()
-    console.log('closed')
-  }
-})()
+mssql.connect(sqlConfig).then((pool) => {
+  console.log('Connected to SQL server')
+  const request = pool.request()
+  request.stream = true
+  request.on('error', (err) => {
+    console.error('good', err)
+  })
+  return request.query('SELECT * FROM nontable')
+}).catch((err) => {
+  console.error('bad', err)
+}).then(() => {
+  console.log('Disconnecting from SQL server')
+  return mssql.close()
+}).then(() => console.log('Disconnected'))

package/test2.js

@@ -1,211 +0,0 @@
-const values = [
-  1810,
-  1729,
-  1857,
-  1777,
-  1927,
-  1936,
-  1797,
-  1719,
-  1703,
-  1758,
-  1768,
-  2008,
-  1963,
-  1925,
-  1919,
-  1911,
-  1782,
-  2001,
-  1744,
-  1738,
-  1742,
-  1799,
-  1765,
-  1819,
-  1888,
-  127,
-  1880,
-  1984,
-  1697,
-  1760,
-  1680,
-  1951,
-  1745,
-  1817,
-  1704,
-  1736,
-  1969,
-  1705,
-  1690,
-  1848,
-  1885,
-  1912,
-  1982,
-  1895,
-  1959,
-  1769,
-  1722,
-  1807,
-  1901,
-  1983,
-  1993,
-  1871,
-  1795,
-  1955,
-  1921,
-  1934,
-  1743,
-  1899,
-  1942,
-  1964,
-  1034,
-  1952,
-  1851,
-  1716,
-  1800,
-  1771,
-  1945,
-  1877,
-  1917,
-  1930,
-  1970,
-  1948,
-  1914,
-  1767,
-  1910,
-  563,
-  1121,
-  1897,
-  1946,
-  1882,
-  1739,
-  1900,
-  1714,
-  1931,
-  2000,
-  311,
-  1881,
-  1876,
-  354,
-  1965,
-  1842,
-  1979,
-  1998,
-  1960,
-  1852,
-  1847,
-  1938,
-  1369,
-  1780,
-  1698,
-  1753,
-  1746,
-  1868,
-  1752,
-  1802,
-  1892,
-  1755,
-  1818,
-  1913,
-  1706,
-  1862,
-  326,
-  1941,
-  1926,
-  1809,
-  1879,
-  1815,
-  1939,
-  1859,
-  1999,
-  1947,
-  1898,
-  1794,
-  1737,
-  1971,
-  1977,
-  1944,
-  1812,
-  1905,
-  1359,
-  1788,
-  1754,
-  1774,
-  1825,
-  1748,
-  1701,
-  1791,
-  1786,
-  1692,
-  1894,
-  1961,
-  1902,
-  1849,
-  1967,
-  1770,
-  1987,
-  1831,
-  1728,
-  1896,
-  1805,
-  1733,
-  1918,
-  1731,
-  661,
-  1776,
-  1494,
-  2005,
-  2009,
-  2004,
-  1915,
-  1695,
-  1710,
-  1804,
-  1929,
-  1725,
-  1772,
-  1933,
-  609,
-  1708,
-  1822,
-  1978,
-  1811,
-  1816,
-  1073,
-  1874,
-  1845,
-  1989,
-  1696,
-  1953,
-  1823,
-  1923,
-  1907,
-  1834,
-  1806,
-  1861,
-  1785,
-  297,
-  1968,
-  1764,
-  1932,
-  1937,
-  1826,
-  1732,
-  1962,
-  1916,
-  1756,
-  1975,
-  1775,
-  1922,
-  1773
-]
-
-values.forEach((first) => {
-  values.forEach((second) => {
-    const third = 2020 - first - second
-    if (values.includes(third)) {
-      console.log(first * second * third)
-    }
-  })
-})