msgpackr 2.0.2 → 2.0.3

package/dist/test.js

@@ -1410,7 +1410,14 @@
 							let newSharedData = (packr._prepareStructures || prepareStructures)(structures, packr);
 							if (!encodingError) { // TODO: If there is an encoding error, should make the structures as uninitialized so they get rebuilt next time
 								if (packr.saveStructures(newSharedData, newSharedData.isCompatible) === false) {
-									// get updated structures and try again if the update failed
+									// The save was declined (a concurrent writer updated the shared structures,
+									// or the store transaction did not durably commit). Our in-memory
+									// structures + transition trie may now reference record ids that were
+									// never persisted; re-packing as-is would re-emit the same record pointing
+									// at an unpersisted structure (-> "Record id is not defined" on decode).
+									// Mark structures uninitialized so the re-pack reloads durable structures
+									// via getStructures, rebuilds the transition trie, and re-mints + re-saves.
+									structures.uninitialized = true;
 									return packr.pack(value, encodeOptions);
 								}
 								packr.lastNamedStructuresLength = sharedLength;
@@ -3307,6 +3314,30 @@
 			assert.deepEqual(inputData, outputData);
 		});
 
+		test('declined structure save re-packs against durable structures (no dangling record)', function() {
+			// Regression: when saveStructures declines a save (a concurrent writer updated the shared
+			// structures, or the store txn did not durably commit), the in-memory structures/transition
+			// trie reference a record id that was never persisted. The re-pack must reload the durable
+			// structures and re-mint/re-save — otherwise it re-emits the same record pointing at an
+			// unsaved structure, and reads throw "Record id is not defined".
+			const meta = new Packr();
+			let store = null;
+			let declinedOnce = false;
+			const packr = new Packr({
+				useRecords: true,
+				getStructures() { return store ? meta.unpack(store) : undefined; },
+				saveStructures(structures) {
+					if (!declinedOnce) { declinedOnce = true; return false; } // decline the first save
+					store = meta.pack(structures); return true;
+				},
+			});
+			const a = packr.pack({ x: 9, y: 8 });
+			const b = packr.pack({ x: 7, y: 6 });
+			const reader = new Packr({ getStructures() { return store ? meta.unpack(store) : undefined; } });
+			assert.deepEqual(reader.unpack(a), { x: 9, y: 8 });
+			assert.deepEqual(reader.unpack(b), { x: 7, y: 6 });
+		});
+
 		test('big buffer', function() {
 			var size = 100000000;
 			var data = new Uint8Array(size).fill(1);