msgpack5 3.4.1 → 3.6.1

package/example.js

@@ -1,3 +1,6 @@
+'use strict'
+
+var Buffer = require('safe-buffer').Buffer
 var msgpack = require('./')() // namespace our extensions
 var a = new MyType(2, 'a')
 var encode = msgpack.encode
@@ -22,7 +25,7 @@ function MyType (size, value) {
 }
 
 function mytipeEncode (obj) {
-  var buf = new Buffer(obj.size)
+  var buf = Buffer.allocUnsafe(obj.size)
   buf.fill(obj.value)
   return buf
 }

package/index.js

@@ -1,3 +1,6 @@
+'use strict'
+
+var Buffer = require('safe-buffer').Buffer
 var assert = require('assert')
 var bl = require('bl')
 var streams = require('./lib/streams')
@@ -10,7 +13,9 @@ function msgpack (options) {
 
   options = options || {
     forceFloat64: false,
-    compatibilityMode: false
+    compatibilityMode: false,
+    // options.protoAction: 'error' (default) / 'remove' / 'ignore'
+    protoAction: 'error'
   }
 
   function registerEncoder (check, encode) {
@@ -47,7 +52,7 @@ function msgpack (options) {
 
     function reEncode (obj) {
       var buf = bl()
-      var header = new Buffer(1)
+      var header = Buffer.allocUnsafe(1)
 
       header.writeInt8(type, 0)
 
@@ -65,7 +70,7 @@ function msgpack (options) {
 
   return {
     encode: buildEncode(encodingTypes, options.forceFloat64, options.compatibilityMode),
-    decode: buildDecode(decodingTypes),
+    decode: buildDecode(decodingTypes, options),
     register: register,
     registerEncoder: registerEncoder,
     registerDecoder: registerDecoder,

package/lib/decoder.js

@@ -12,7 +12,7 @@ function IncompleteBufferError (message) {
 
 util.inherits(IncompleteBufferError, Error)
 
-module.exports = function buildDecode (decodingTypes) {
+module.exports = function buildDecode (decodingTypes, options) {
   return decode
 
   function getSize (first) {
@@ -358,6 +358,17 @@ module.exports = function buildDecode (decodingTypes) {
         var valueResult = tryDecode(buf, offset)
         if (valueResult) {
           key = keyResult.value
+
+          if (key === '__proto__') {
+            if (options.protoAction === 'error') {
+              throw new SyntaxError('Object contains forbidden prototype property')
+            }
+
+            if (options.protoAction === 'remove') {
+              continue
+            }
+          }
+
           result[key] = valueResult.value
           offset += valueResult.bytesConsumed
           totalBytesConsumed += (keyResult.bytesConsumed + valueResult.bytesConsumed)

package/lib/encoder.js

@@ -1,3 +1,6 @@
+'use strict'
+
+var Buffer = require('safe-buffer').Buffer
 var bl = require('bl')
 var TOLERANCE = 0.1
 
@@ -9,52 +12,55 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
     if (obj === undefined) {
       throw new Error('undefined is not encodable in msgpack!')
     } else if (obj === null) {
-      buf = new Buffer(1)
+      buf = Buffer.allocUnsafe(1)
       buf[0] = 0xc0
     } else if (obj === true) {
-      buf = new Buffer(1)
+      buf = Buffer.allocUnsafe(1)
       buf[0] = 0xc3
     } else if (obj === false) {
-      buf = new Buffer(1)
+      buf = Buffer.allocUnsafe(1)
       buf[0] = 0xc2
     } else if (typeof obj === 'string') {
       len = Buffer.byteLength(obj)
       if (len < 32) {
-        buf = new Buffer(1 + len)
+        buf = Buffer.allocUnsafe(1 + len)
         buf[0] = 0xa0 | len
         if (len > 0) {
           buf.write(obj, 1)
         }
       } else if (len <= 0xff && !compatibilityMode) {
         // str8, but only when not in compatibility mode
-        buf = new Buffer(2 + len)
+        buf = Buffer.allocUnsafe(2 + len)
         buf[0] = 0xd9
         buf[1] = len
         buf.write(obj, 2)
       } else if (len <= 0xffff) {
-        buf = new Buffer(3 + len)
+        buf = Buffer.allocUnsafe(3 + len)
         buf[0] = 0xda
         buf.writeUInt16BE(len, 1)
         buf.write(obj, 3)
       } else {
-        buf = new Buffer(5 + len)
+        buf = Buffer.allocUnsafe(5 + len)
         buf[0] = 0xdb
         buf.writeUInt32BE(len, 1)
         buf.write(obj, 5)
       }
-    } else if (obj && obj.readUInt32LE) {
+    } else if (obj && (obj.readUInt32LE || obj instanceof Uint8Array)) {
+      if (obj instanceof Uint8Array) {
+        obj = Buffer.from(obj)
+      }
       // weird hack to support Buffer
       // and Buffer-like objects
       if (obj.length <= 0xff) {
-        buf = new Buffer(2)
+        buf = Buffer.allocUnsafe(2)
         buf[0] = 0xc4
         buf[1] = obj.length
       } else if (obj.length <= 0xffff) {
-        buf = new Buffer(3)
+        buf = Buffer.allocUnsafe(3)
         buf[0] = 0xc5
         buf.writeUInt16BE(obj.length, 1)
       } else {
-        buf = new Buffer(5)
+        buf = Buffer.allocUnsafe(5)
         buf[0] = 0xc6
         buf.writeUInt32BE(obj.length, 1)
       }
@@ -62,14 +68,14 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
       buf = bl([buf, obj])
     } else if (Array.isArray(obj)) {
       if (obj.length < 16) {
-        buf = new Buffer(1)
+        buf = Buffer.allocUnsafe(1)
         buf[0] = 0x90 | obj.length
       } else if (obj.length < 65536) {
-        buf = new Buffer(3)
+        buf = Buffer.allocUnsafe(3)
         buf[0] = 0xdc
         buf.writeUInt16BE(obj.length, 1)
       } else {
-        buf = new Buffer(5)
+        buf = Buffer.allocUnsafe(5)
         buf[0] = 0xdd
         buf.writeUInt32BE(obj.length, 1)
       }
@@ -85,22 +91,22 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
         return encodeFloat(obj, forceFloat64)
       } else if (obj >= 0) {
         if (obj < 128) {
-          buf = new Buffer(1)
+          buf = Buffer.allocUnsafe(1)
           buf[0] = obj
         } else if (obj < 256) {
-          buf = new Buffer(2)
+          buf = Buffer.allocUnsafe(2)
           buf[0] = 0xcc
           buf[1] = obj
         } else if (obj < 65536) {
-          buf = new Buffer(3)
+          buf = Buffer.allocUnsafe(3)
           buf[0] = 0xcd
           buf.writeUInt16BE(obj, 1)
         } else if (obj <= 0xffffffff) {
-          buf = new Buffer(5)
+          buf = Buffer.allocUnsafe(5)
           buf[0] = 0xce
           buf.writeUInt32BE(obj, 1)
         } else if (obj <= 9007199254740991) {
-          buf = new Buffer(9)
+          buf = Buffer.allocUnsafe(9)
           buf[0] = 0xcf
           write64BitUint(buf, obj)
         } else {
@@ -108,22 +114,22 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
         }
       } else {
         if (obj >= -32) {
-          buf = new Buffer(1)
+          buf = Buffer.allocUnsafe(1)
           buf[0] = 0x100 + obj
         } else if (obj >= -128) {
-          buf = new Buffer(2)
+          buf = Buffer.allocUnsafe(2)
           buf[0] = 0xd0
           buf.writeInt8(obj, 1)
         } else if (obj >= -32768) {
-          buf = new Buffer(3)
+          buf = Buffer.allocUnsafe(3)
           buf[0] = 0xd1
           buf.writeInt16BE(obj, 1)
         } else if (obj > -214748365) {
-          buf = new Buffer(5)
+          buf = Buffer.allocUnsafe(5)
           buf[0] = 0xd2
           buf.writeInt32BE(obj, 1)
         } else if (obj >= -9007199254740991) {
-          buf = new Buffer(9)
+          buf = Buffer.allocUnsafe(9)
           buf[0] = 0xd3
           write64BitInt(buf, 1, obj)
         } else {
@@ -189,7 +195,7 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
       headers.push(length & 0x000000ff)
     }
 
-    return bl().append(new Buffer(headers)).append(encoded)
+    return bl().append(Buffer.from(headers)).append(encoded)
   }
 
   function encodeObject (obj) {
@@ -209,10 +215,10 @@ module.exports = function buildEncode (encodingTypes, forceFloat64, compatibilit
     }
 
     if (length < 16) {
-      header = new Buffer(1)
+      header = Buffer.allocUnsafe(1)
       header[0] = 0x80 | length
     } else {
-      header = new Buffer(3)
+      header = Buffer.allocUnsafe(3)
       header[0] = 0xde
       header.writeUInt16BE(length, 1)
     }
@@ -266,14 +272,14 @@ function isFloat (n) {
 function encodeFloat (obj, forceFloat64) {
   var buf
 
-  buf = new Buffer(5)
+  buf = Buffer.allocUnsafe(5)
   buf[0] = 0xca
   buf.writeFloatBE(obj, 1)
 
   // FIXME is there a way to check if a
   // value fits in a float?
   if (forceFloat64 || Math.abs(obj - buf.readFloatBE(1)) > TOLERANCE) {
-    buf = new Buffer(9)
+    buf = Buffer.allocUnsafe(9)
     buf[0] = 0xcb
     buf.writeDoubleBE(obj, 1)
   }

package/lib/streams.js

@@ -1,3 +1,5 @@
+'use strict'
+
 var Transform = require('readable-stream').Transform
 var inherits = require('inherits')
 var bl = require('bl')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "msgpack5",
-  "version": "3.4.1",
+  "version": "3.6.1",
   "description": "A msgpack v5 implementation for node.js and the browser, with extension points",
   "main": "index.js",
   "scripts": {
@@ -21,8 +21,7 @@
     "msgpack",
     "extension",
     "v5",
-    "msgpack",
-    "v5",
+    "MessagePack",
     "ext"
   ],
   "author": "Matteo collina <hello@matteocollina.com>",
@@ -32,15 +31,15 @@
   },
   "homepage": "https://github.com/mcollina/msgpack5",
   "devDependencies": {
-    "browserify": "^10.2.4",
+    "browserify": "^14.0.0",
     "faucet": "0.0.1",
-    "jshint": "^2.5.2",
-    "level-test": "^2.0.0",
-    "pre-commit": "1.0.10",
-    "standard": "^8.0.0",
-    "tape": "^4.0.0",
+    "jshint": "^2.9.5",
+    "memdb": "^1.3.1",
+    "pre-commit": "^1.2.2",
+    "standard": "^10.0.3",
+    "tape": "^4.8.0",
     "testling": "^1.7.1",
-    "uglify-js": "^2.4.15"
+    "uglify-js": "^3.0.28"
   },
   "standard": {
     "ignore": [
@@ -61,8 +60,9 @@
     ]
   },
   "dependencies": {
-    "bl": "^1.0.0",
-    "inherits": "^2.0.1",
-    "readable-stream": "^2.0.1"
+    "bl": "^1.2.1",
+    "inherits": "^2.0.3",
+    "readable-stream": "^2.3.3",
+    "safe-buffer": "^5.1.1"
   }
 }

package/test/1-byte-length-buffers.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -7,7 +8,7 @@ var bl = require('bl')
 function build (size) {
   var buf
 
-  buf = new Buffer(size)
+  buf = Buffer.allocUnsafe(size)
   buf.fill('a')
 
   return buf
@@ -20,7 +21,7 @@ test('encode/decode 2^8-1 bytes buffers', function (t) {
   all.push(build(Math.pow(2, 8) - 1))
   all.push(build(Math.pow(2, 6) + 1))
   all.push(build(1))
-  all.push(new Buffer(0))
+  all.push(Buffer.allocUnsafe(0))
 
   all.forEach(function (orig) {
     t.test('encoding a buffer of length ' + orig.length, function (t) {
@@ -33,7 +34,7 @@ test('encode/decode 2^8-1 bytes buffers', function (t) {
     })
 
     t.test('decoding a buffer of length ' + orig.length, function (t) {
-      var buf = new Buffer(2 + orig.length)
+      var buf = Buffer.allocUnsafe(2 + orig.length)
       buf[0] = 0xc4
       buf[1] = orig.length
       orig.copy(buf, 2)
@@ -53,7 +54,7 @@ test('encode/decode 2^8-1 bytes buffers', function (t) {
 test('decoding a chopped 2^8-1 bytes buffer', function (t) {
   var encoder = msgpack()
   var orig = build(Math.pow(2, 6))
-  var buf = new Buffer(2 + orig.length)
+  var buf = Buffer.allocUnsafe(2 + orig.length)
   buf[0] = 0xc4
   buf[1] = Math.pow(2, 8) - 1 // set bigger size
   orig.copy(buf, 2)
@@ -68,7 +69,7 @@ test('decoding a chopped 2^8-1 bytes buffer', function (t) {
 
 test('decoding an incomplete header of 2^8-1 bytes buffer', function (t) {
   var encoder = msgpack()
-  var buf = new Buffer(1)
+  var buf = Buffer.allocUnsafe(1)
   buf[0] = 0xc4
   buf = bl().append(buf)
   var origLength = buf.length

package/test/1-byte-length-exts.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -14,7 +15,7 @@ test('encode/decode variable ext data up to 0xff', function (t) {
   }
 
   function mytipeEncode (obj) {
-    var buf = new Buffer(obj.size)
+    var buf = Buffer.allocUnsafe(obj.size)
     buf.fill(obj.value)
     return buf
   }
@@ -72,7 +73,7 @@ test('encode/decode variable ext data up to 0xff', function (t) {
 
   t.test('decoding an incomplete variable ext data up to 0xff', function (t) {
     var obj = encoder.encode(new MyType(250, 'a'))
-    var buf = new Buffer(obj.length)
+    var buf = Buffer.allocUnsafe(obj.length)
     buf[0] = 0xc7
     buf.writeUInt8(obj.length + 2, 1) // set bigger size
     obj.copy(buf, 2, 2, obj.length)
@@ -86,7 +87,7 @@ test('encode/decode variable ext data up to 0xff', function (t) {
   })
 
   t.test('decoding an incomplete header of variable ext data up to 0xff', function (t) {
-    var buf = new Buffer(2)
+    var buf = Buffer.allocUnsafe(2)
     buf[0] = 0xc7
     buf = bl().append(buf)
     var origLength = buf.length

package/test/1-byte-length-strings.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -28,7 +29,7 @@ test('encode/decode 32 <-> (2^8-1) bytes strings', function (t) {
     })
 
     t.test('decoding a string of length ' + str.length, function (t) {
-      var buf = new Buffer(2 + Buffer.byteLength(str))
+      var buf = Buffer.allocUnsafe(2 + Buffer.byteLength(str))
       buf[0] = 0xd9
       buf[1] = Buffer.byteLength(str)
       buf.write(str, 2)
@@ -50,7 +51,7 @@ test('decoding a chopped string', function (t) {
   var str
   for (str = 'a'; str.length < 40; str += 'a') {
   }
-  var buf = new Buffer(2 + Buffer.byteLength(str))
+  var buf = Buffer.allocUnsafe(2 + Buffer.byteLength(str))
   buf[0] = 0xd9
   buf[1] = Buffer.byteLength(str) + 10 // set bigger size
   buf.write(str, 2)
@@ -65,7 +66,7 @@ test('decoding a chopped string', function (t) {
 
 test('decoding an incomplete header of a string', function (t) {
   var encoder = msgpack()
-  var buf = new Buffer(1)
+  var buf = Buffer.allocUnsafe(1)
   buf[0] = 0xd9
   buf = bl().append(buf)
   var origLength = buf.length

package/test/1-byte-length-uint8arrays.js

@@ -0,0 +1,43 @@
+'use strict'
+
+var Buffer = require('safe-buffer').Buffer
+var test = require('tape').test
+var msgpack = require('../')
+
+function build (size) {
+  var array = []
+  var i
+
+  for (i = 0; i < size; i++) {
+    array.push(42)
+  }
+
+  return new Uint8Array(array)
+}
+
+test('encode/decode 2^8-1 Uint8Arrays', function (t) {
+  var encoder = msgpack()
+  var all = []
+
+  all.push(build(Math.pow(2, 8) - 1))
+  all.push(build(Math.pow(2, 6) + 1))
+  all.push(build(1))
+  all.push(new Uint8Array(0))
+
+  all.forEach(function (array) {
+    t.test('encoding Uint8Array of length ' + array.byteLength + ' bytes', function (t) {
+      var buf = encoder.encode(array)
+      t.equal(buf.length, 2 + array.byteLength, 'must have the right length')
+      t.equal(buf.readUInt8(0), 0xc4, 'must have the proper header')
+      t.equal(buf.readUInt8(1), array.byteLength, 'must include the buf length')
+      t.end()
+    })
+
+    t.test('mirror test for an Uint8Array of length ' + array.byteLength + ' bytes', function (t) {
+      t.deepEqual(encoder.decode(encoder.encode(array)), new Buffer(array), 'must stay the same')
+      t.end()
+    })
+  })
+
+  t.end()
+})

package/test/15-elements-arrays.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -65,7 +66,7 @@ test('decoding an incomplete array', function (t) {
 
   var array = ['a', 'b', 'c']
   var size = computeLength(array)
-  var buf = new Buffer(size)
+  var buf = Buffer.allocUnsafe(size)
   buf[0] = 0x90 | array.length + 2 // set bigger size
   var pos = 1
   for (var i = 0; i < array.length; i++) {

package/test/15-elements-maps.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -74,7 +75,7 @@ test('encode/decode map with buf, ints and strings', function (t) {
   var map = {
     topic: 'hello',
     qos: 1,
-    payload: new Buffer('world'),
+    payload: Buffer.from('world'),
     messageId: '42',
     ttl: 1416309270167
   }
@@ -87,7 +88,7 @@ test('encode/decode map with buf, ints and strings', function (t) {
 test('decoding a chopped map', function (t) {
   var encoder = msgpack()
   var map = encoder.encode({'a': 'b', 'c': 'd', 'e': 'f'})
-  var buf = new Buffer(map.length)
+  var buf = Buffer.allocUnsafe(map.length)
   buf[0] = 0x80 | 5 // set bigger size
   map.copy(buf, 1, 1, map.length)
   buf = bl().append(buf)

package/test/16-bits-signed-integers.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -25,7 +26,7 @@ test('encoding/decoding 16-bits big-endian signed integers', function (t) {
     })
 
     t.test('decoding ' + num, function (t) {
-      var buf = new Buffer(3)
+      var buf = Buffer.allocUnsafe(3)
       buf[0] = 0xd1
       buf.writeInt16BE(num, 1)
       t.equal(encoder.decode(buf), num, 'must decode correctly')
@@ -43,7 +44,7 @@ test('encoding/decoding 16-bits big-endian signed integers', function (t) {
 
 test('decoding an incomplete 16-bits big-endian integer', function (t) {
   var encoder = msgpack()
-  var buf = new Buffer(2)
+  var buf = Buffer.allocUnsafe(2)
   buf[0] = 0xd1
   buf = bl().append(buf)
   var origLength = buf.length

package/test/16-bits-unsigned-integers.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -25,7 +26,7 @@ test('encoding/decoding 16-bits big-endian unsigned integers', function (t) {
     })
 
     t.test('decoding ' + num, function (t) {
-      var buf = new Buffer(3)
+      var buf = Buffer.allocUnsafe(3)
       buf[0] = 0xcd
       buf.writeUInt16BE(num, 1)
       t.equal(encoder.decode(buf), num, 'must decode correctly')
@@ -43,7 +44,7 @@ test('encoding/decoding 16-bits big-endian unsigned integers', function (t) {
 
 test('decoding an incomplete 16-bits big-endian unsigned integer', function (t) {
   var encoder = msgpack()
-  var buf = new Buffer(2)
+  var buf = Buffer.allocUnsafe(2)
   buf[0] = 0xcd
   buf = bl().append(buf)
   var origLength = buf.length

package/test/2-bytes-length-arrays.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -50,7 +51,7 @@ test('decoding an incomplete array', function (t) {
   var encoder = msgpack()
 
   var array = build(0xffff / 2)
-  var buf = new Buffer(3 + array.length)
+  var buf = Buffer.allocUnsafe(3 + array.length)
   buf[0] = 0xdc
   buf.writeUInt16BE(array.length + 10, 1) // set bigger size
   var pos = 3
@@ -71,7 +72,7 @@ test('decoding an incomplete array', function (t) {
 test('decoding an incomplete header', function (t) {
   var encoder = msgpack()
 
-  var buf = new Buffer(2)
+  var buf = Buffer.allocUnsafe(2)
   buf[0] = 0xdc
   buf = bl().append(buf)
   var origLength = buf.length

package/test/2-bytes-length-buffers.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -7,7 +8,7 @@ var bl = require('bl')
 function build (size) {
   var buf
 
-  buf = new Buffer(size)
+  buf = Buffer.allocUnsafe(size)
   buf.fill('a')
 
   return buf
@@ -33,7 +34,7 @@ test('encode/decode 2^16-1 bytes buffers', function (t) {
     })
 
     t.test('decoding a buffer of length ' + orig.length, function (t) {
-      var buf = new Buffer(3 + orig.length)
+      var buf = Buffer.allocUnsafe(3 + orig.length)
       buf[0] = 0xc5
       buf.writeUInt16BE(orig.length, 1)
       orig.copy(buf, 3)
@@ -53,7 +54,7 @@ test('encode/decode 2^16-1 bytes buffers', function (t) {
 test('decoding a chopped 2^16-1 bytes buffer', function (t) {
   var encoder = msgpack()
   var orig = build(Math.pow(2, 12))
-  var buf = new Buffer(3 + orig.length)
+  var buf = Buffer.allocUnsafe(3 + orig.length)
   buf[0] = 0xc5
   buf[1] = Math.pow(2, 16) - 1 // set bigger size
   orig.copy(buf, 3)
@@ -68,7 +69,7 @@ test('decoding a chopped 2^16-1 bytes buffer', function (t) {
 
 test('decoding an incomplete header of 2^16-1 bytes buffer', function (t) {
   var encoder = msgpack()
-  var buf = new Buffer(2)
+  var buf = Buffer.allocUnsafe(2)
   buf[0] = 0xc5
   buf = bl().append(buf)
   var origLength = buf.length

package/test/2-bytes-length-exts.js

@@ -1,5 +1,6 @@
 'use strict'
 
+var Buffer = require('safe-buffer').Buffer
 var test = require('tape').test
 var msgpack = require('../')
 var bl = require('bl')
@@ -14,7 +15,7 @@ test('encode/decode variable ext data up between 0x0100 and 0xffff', function (t
   }
 
   function mytipeEncode (obj) {
-    var buf = new Buffer(obj.size)
+    var buf = Buffer.allocUnsafe(obj.size)
     buf.fill(obj.value)
     return buf
   }
@@ -56,7 +57,7 @@ test('encode/decode variable ext data up between 0x0100 and 0xffff', function (t
 
   t.test('decoding an incomplete variable ext data up between 0x0100 and 0xffff', function (t) {
     var obj = encoder.encode(new MyType(0xfff0, 'a'))
-    var buf = new Buffer(obj.length)
+    var buf = Buffer.allocUnsafe(obj.length)
     buf[0] = 0xc8
     buf.writeUInt16BE(obj.length + 2, 1) // set bigger size
     obj.copy(buf, 3, 3, obj.length)
@@ -70,7 +71,7 @@ test('encode/decode variable ext data up between 0x0100 and 0xffff', function (t
   })
 
   t.test('decoding an incomplete header of variable ext data up between 0x0100 and 0xffff', function (t) {
-    var buf = new Buffer(3)
+    var buf = Buffer.allocUnsafe(3)
     buf[0] = 0xc8
     buf = bl().append(buf)
     var origLength = buf.length