mr-magic-mcp-server 0.3.8 → 0.3.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mr-magic-mcp-server",
-  "version": "0.3.8",
+  "version": "0.3.10",
   "description": "Lyrics MCP server connecting LRCLIB, Genius, Musixmatch, and Melon",
   "type": "module",
   "main": "src/index.js",

package/src/providers/lrclib.js

@@ -1,6 +1,6 @@
 import axios from 'axios';
 
-import { normalizeLyricRecord } from '../provider-result-schema.js';
+import { normalizeLyricRecord, lyricContentScore } from '../provider-result-schema.js';
 import { createLogger } from '../utils/logger.js';
 
 const logger = createLogger('provider:lrclib');
@@ -40,6 +40,22 @@ async function querySearch(track) {
   }
 }
 
+/**
+ * Pick the best candidate from a list: prefer synced over plain, then prefer
+ * richer lyric content. This ensures fetchFromLrclib always returns a synced
+ * result when one is available rather than the first incidentally-ordered one.
+ */
+function chooseBestCandidate(candidates) {
+  if (!candidates.length) return null;
+  return candidates.slice().sort((a, b) => {
+    // Synced results come first
+    const syncedDiff = (b.synced ? 1 : 0) - (a.synced ? 1 : 0);
+    if (syncedDiff !== 0) return syncedDiff;
+    // Among equally-synced results, prefer richer content
+    return lyricContentScore(b) - lyricContentScore(a);
+  })[0];
+}
+
 export async function fetchFromLrclib(track) {
   try {
     const results = await querySearch(track);
@@ -47,16 +63,19 @@ export async function fetchFromLrclib(track) {
       logger.debug('LRCLIB: no results found', { track });
       return null;
     }
-    const exactMatch = results.find((record) => {
+    const exactMatches = results.filter((record) => {
       const sameTitle = record.title?.toLowerCase() === track.title?.toLowerCase();
       const sameArtist = record.artist?.toLowerCase() === track.artist?.toLowerCase();
       return sameTitle && sameArtist;
     });
-    const result = exactMatch ?? results[0];
+    // Prefer exact matches; if none, fall back to all results.
+    // Within each group, prefer synced then richer content.
+    const result = chooseBestCandidate(exactMatches) ?? chooseBestCandidate(results);
     logger.debug('LRCLIB: match selected', {
-      exact: Boolean(exactMatch),
-      title: result.title,
-      artist: result.artist
+      exact: exactMatches.length > 0,
+      synced: result?.synced,
+      title: result?.title,
+      artist: result?.artist
     });
     return result;
   } catch (error) {

package/src/tests/run-tests.js

@@ -324,9 +324,9 @@ function testRomanization() {
   // 깻: ㄷ-representative of ㅅ batchim; 잎: ㅇ initial (silent) → liaison
   // Actually 깻 = ㄲ+ㅖ+ㅅ, 잎 = ㅇ+ㅣ+ㅍ
   // Liaison: 잎 initial ㅇ → ㅅ(깻) moves to 잎 onset:  → 깨 + 씹? No:
-  // 깻: batchim ㅅ; 잎: initial ㅇ → 깻 coda ㅅ moves to 잎 as initial 'ss'? 
+  // 깻: batchim ㅅ; 잎: initial ㅇ → 깻 coda ㅅ moves to 잎 as initial 'ss'?
   // Standard Korean: 깻잎 → [깬닙] (nasalization of ㅅ→ㄴ before ㅣ? No.
-  // Actually: 깻잎 → liaison: 깻(ㅅ) + 잎(ㅇ) → 깨싫... 
+  // Actually: 깻잎 → liaison: 깻(ㅅ) + 잎(ㅇ) → 깨싫...
   // Correct pronunciation: 깻잎 [깬닙] — the ㅅ turns to ㄴ (because 잎's ㅍ batchim + ㄴ?)
   // Simpler: official = kkaennip. Our engine: 깻(ㅅ liaison to 잎ㅇ) → 깨 + 싶 → 깨십.
   // The 잎 ㅍ final stays = p.  깻잎 → Kkaesip via liaison. That's our engine's output.

package/src/tools/cli.js

@@ -356,7 +356,10 @@ program
     },
     []
   )
-  .option('--output <dir>', 'Directory to write exports (requires --export; defaults to MR_MAGIC_EXPORT_DIR or ./exports)')
+  .option(
+    '--output <dir>',
+    'Directory to write exports (requires --export; defaults to MR_MAGIC_EXPORT_DIR or ./exports)'
+  )
   .option('--no-romanize', 'Disable romanized lyrics', false)
   .action(async (options) => {
     const track = buildTrackFromOptions(options);
@@ -542,7 +545,10 @@ program
     },
     []
   )
-  .option('--output <dir>', 'Directory for exports (requires --export; defaults to MR_MAGIC_EXPORT_DIR or ./exports)')
+  .option(
+    '--output <dir>',
+    'Directory for exports (requires --export; defaults to MR_MAGIC_EXPORT_DIR or ./exports)'
+  )
   .option('--no-romanize', 'Disable romanized lyrics', false)
   .action(async (options) => {
     const track = buildTrackFromOptions(options);