motionmcp 2.2.4 → 2.4.0

package/dist/services/motionApi.js

@@ -83,16 +83,16 @@ class MotionApiService {
             throw error;
         }
     }
-    constructor() {
-        const apiKey = process.env.MOTION_API_KEY;
-        if (!apiKey) {
+    constructor(apiKey) {
+        const resolvedApiKey = apiKey || process.env.MOTION_API_KEY;
+        if (!resolvedApiKey) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Motion API key not found in environment variables', {
                 component: 'MotionApiService',
                 method: 'constructor'
             });
             throw new Error('MOTION_API_KEY environment variable is required');
         }
-        this.apiKey = apiKey;
+        this.apiKey = resolvedApiKey;
         this.baseUrl = 'https://api.usemotion.com/v1';
         (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Initializing Motion API service', {
             component: 'MotionApiService',
@@ -230,70 +230,77 @@ class MotionApiService {
             throw new Error('limit must be a non-negative integer');
         }
         const cacheKey = `projects:workspace:${workspaceId}`;
-        return this.projectCache.withCache(cacheKey, async () => {
+        // Check cache - return items only (no stale truncation info)
+        const cachedItems = this.projectCache.get(cacheKey);
+        if (cachedItems !== null) {
+            return { items: cachedItems };
+        }
+        try {
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Fetching projects from Motion API', {
+                method: 'getProjects',
+                workspaceId,
+                maxPages,
+                limit
+            });
+            // Create a fetch function for potential pagination
+            const fetchPage = async (cursor) => {
+                const params = new URLSearchParams();
+                params.append('workspaceId', workspaceId);
+                if (cursor) {
+                    params.append('cursor', cursor);
+                }
+                const queryString = params.toString();
+                const url = `/projects?${queryString}`;
+                return this.requestWithRetry(() => this.client.get(url));
+            };
             try {
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Fetching projects from Motion API', {
-                    method: 'getProjects',
-                    workspaceId,
+                // Attempt pagination-aware fetch with new response wrapper
+                const paginatedResult = await (0, paginationNew_1.fetchAllPages)(fetchPage, 'projects', {
                     maxPages,
-                    limit
+                    logProgress: false,
+                    ...(limit ? { maxItems: limit } : {})
                 });
-                // Create a fetch function for potential pagination
-                const fetchPage = async (cursor) => {
-                    const params = new URLSearchParams();
-                    params.append('workspaceId', workspaceId);
-                    if (cursor) {
-                        params.append('cursor', cursor);
-                    }
-                    const queryString = params.toString();
-                    const url = `/projects?${queryString}`;
-                    return this.requestWithRetry(() => this.client.get(url));
-                };
-                try {
-                    // Attempt pagination-aware fetch with new response wrapper
-                    const paginatedResult = await (0, paginationNew_1.fetchAllPages)(fetchPage, 'projects', {
-                        maxPages,
-                        logProgress: false,
-                        ...(limit ? { maxItems: limit } : {})
-                    });
-                    if (paginatedResult.totalFetched > 0) {
-                        let projects = paginatedResult.items;
-                        (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Projects fetched successfully with pagination', {
-                            method: 'getProjects',
-                            totalCount: projects.length,
-                            hasMore: paginatedResult.hasMore,
-                            workspaceId
-                        });
-                        return projects;
-                    }
-                }
-                catch (paginationError) {
-                    (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Pagination failed, falling back to simple fetch', {
+                if (paginatedResult.totalFetched > 0) {
+                    let projects = paginatedResult.items;
+                    (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Projects fetched successfully with pagination', {
                         method: 'getProjects',
-                        error: paginationError instanceof Error ? paginationError.message : String(paginationError)
+                        totalCount: projects.length,
+                        hasMore: paginatedResult.hasMore,
+                        workspaceId
                     });
+                    // Cache only items, not truncation metadata
+                    this.projectCache.set(cacheKey, projects);
+                    return { items: projects, truncation: paginatedResult.truncation };
                 }
-                // Use new response wrapper for single page fallback
-                const response = await fetchPage();
-                const unwrapped = (0, responseWrapper_1.unwrapApiResponse)(response.data, 'projects');
-                let projects = unwrapped.data;
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Projects fetched successfully (single page)', {
-                    method: 'getProjects',
-                    count: projects.length,
-                    workspaceId
-                });
-                return projects;
             }
-            catch (error) {
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch projects', {
+            catch (paginationError) {
+                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Pagination failed, falling back to simple fetch', {
                     method: 'getProjects',
-                    error: getErrorMessage(error),
-                    apiStatus: (0, axios_1.isAxiosError)(error) ? error.response?.status : undefined,
-                    apiMessage: (0, axios_1.isAxiosError)(error) ? error.response?.data?.message : undefined
+                    error: paginationError instanceof Error ? paginationError.message : String(paginationError)
                 });
-                throw this.formatApiError(error, 'fetch', 'project');
             }
-        });
+            // Use new response wrapper for single page fallback
+            const response = await fetchPage();
+            const unwrapped = (0, responseWrapper_1.unwrapApiResponse)(response.data, 'projects');
+            let projects = unwrapped.data;
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Projects fetched successfully (single page)', {
+                method: 'getProjects',
+                count: projects.length,
+                workspaceId
+            });
+            // Cache only items
+            this.projectCache.set(cacheKey, projects);
+            return { items: projects };
+        }
+        catch (error) {
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch projects', {
+                method: 'getProjects',
+                error: getErrorMessage(error),
+                apiStatus: (0, axios_1.isAxiosError)(error) ? error.response?.status : undefined,
+                apiMessage: (0, axios_1.isAxiosError)(error) ? error.response?.data?.message : undefined
+            });
+            throw this.formatApiError(error, 'fetch', 'project');
+        }
     }
     async getAllProjects() {
         try {
@@ -302,10 +309,14 @@ class MotionApiService {
             });
             const allWorkspaces = await this.getWorkspaces();
             const allProjects = [];
+            let aggregateTruncation;
             for (const workspace of allWorkspaces) {
                 try {
-                    const workspaceProjects = await this.getProjects(workspace.id);
-                    allProjects.push(...workspaceProjects);
+                    const { items, truncation } = await this.getProjects(workspace.id);
+                    allProjects.push(...items);
+                    if (truncation?.wasTruncated && !aggregateTruncation) {
+                        aggregateTruncation = { ...truncation, returnedCount: allProjects.length };
+                    }
                 }
                 catch (workspaceError) {
                     // Log error but continue with other workspaces
@@ -322,7 +333,10 @@ class MotionApiService {
                 totalProjects: allProjects.length,
                 workspaceCount: allWorkspaces.length
             });
-            return allProjects;
+            if (aggregateTruncation) {
+                aggregateTruncation.returnedCount = allProjects.length;
+            }
+            return { items: allProjects, truncation: aggregateTruncation };
         }
         catch (error) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch projects from all workspaces', {
@@ -457,7 +471,7 @@ class MotionApiService {
     // TASK API METHODS
     // ========================================
     async getTasks(options) {
-        const { workspaceId, projectId, status, assigneeId, priority, dueDate, labels, limit, maxPages = 5 } = options;
+        const { workspaceId, projectId, status, includeAllStatuses, assigneeId, priority, dueDate, labels, limit, maxPages = 5 } = options;
         // Validate limit parameter if provided
         if (limit !== undefined && (limit < 0 || !Number.isInteger(limit))) {
             throw new Error('limit must be a non-negative integer');
@@ -468,6 +482,7 @@ class MotionApiService {
                 workspaceId,
                 projectId,
                 status,
+                includeAllStatuses,
                 assigneeId,
                 priority,
                 dueDate,
@@ -482,7 +497,22 @@ class MotionApiService {
                     params.append('projectId', projectId);
                 }
                 if (status) {
-                    params.append('status', status);
+                    if (Array.isArray(status)) {
+                        // Deduplicate and skip empty strings before appending
+                        // Note: Motion API supports repeated status= params for multi-value filtering
+                        const uniqueStatuses = Array.from(new Set(status));
+                        for (const s of uniqueStatuses) {
+                            if (s) {
+                                params.append('status', s);
+                            }
+                        }
+                    }
+                    else {
+                        params.append('status', status);
+                    }
+                }
+                if (includeAllStatuses) {
+                    params.append('includeAllStatuses', 'true');
                 }
                 if (assigneeId) {
                     params.append('assigneeId', assigneeId);
@@ -525,7 +555,7 @@ class MotionApiService {
                         projectId,
                         limitApplied: limit
                     });
-                    return paginatedResult.items;
+                    return { items: paginatedResult.items, truncation: paginatedResult.truncation };
                 }
             }
             catch (paginationError) {
@@ -550,7 +580,7 @@ class MotionApiService {
                 projectId,
                 limitApplied: limit
             });
-            return tasks;
+            return { items: tasks };
         }
         catch (error) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch tasks', {
@@ -1010,7 +1040,7 @@ class MotionApiService {
                 workspaceId
             });
             // First, search in the specified workspace
-            const projects = await this.getProjects(workspaceId);
+            const { items: projects } = await this.getProjects(workspaceId);
             const project = projects.find(p => p.name === projectName);
             if (project) {
                 (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Project found by name in specified workspace', {
@@ -1037,7 +1067,7 @@ class MotionApiService {
                         searchingWorkspaceId: workspace.id,
                         searchingWorkspaceName: workspace.name
                     });
-                    const workspaceProjects = await this.getProjects(workspace.id);
+                    const { items: workspaceProjects } = await this.getProjects(workspace.id);
                     const foundProject = workspaceProjects.find(p => p.name === projectName);
                     if (foundProject) {
                         (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Project found by name in different workspace', {
@@ -1092,12 +1122,16 @@ class MotionApiService {
             const effectiveLimit = limit || constants_1.LIMITS.MAX_SEARCH_RESULTS;
             const lowerQuery = query.toLowerCase();
             const allMatchingTasks = [];
+            let aggregateTruncation;
             // First, search in the specified workspace
-            const primaryTasks = await this.getTasks({
+            const { items: primaryTasks, truncation: primaryTruncation } = await this.getTasks({
                 workspaceId,
                 limit: (0, paginationNew_1.calculateAdaptiveFetchLimit)(allMatchingTasks.length, effectiveLimit),
                 maxPages: constants_1.LIMITS.MAX_PAGES
             });
+            if (primaryTruncation?.wasTruncated && !aggregateTruncation) {
+                aggregateTruncation = primaryTruncation;
+            }
             const primaryMatches = primaryTasks.filter(task => task.name?.toLowerCase().includes(lowerQuery) ||
                 task.description?.toLowerCase().includes(lowerQuery));
             allMatchingTasks.push(...primaryMatches.slice(0, effectiveLimit));
@@ -1128,11 +1162,14 @@ class MotionApiService {
                                 searchingWorkspaceName: workspace.name,
                                 remainingNeeded: effectiveLimit - allMatchingTasks.length
                             });
-                            const workspaceTasks = await this.getTasks({
+                            const { items: workspaceTasks, truncation: wsTruncation } = await this.getTasks({
                                 workspaceId: workspace.id,
                                 limit: fetchLimit,
                                 maxPages: constants_1.LIMITS.MAX_PAGES
                             });
+                            if (wsTruncation?.wasTruncated && !aggregateTruncation) {
+                                aggregateTruncation = wsTruncation;
+                            }
                             const workspaceMatches = workspaceTasks.filter(task => task.name?.toLowerCase().includes(lowerQuery) ||
                                 task.description?.toLowerCase().includes(lowerQuery));
                             // Only add as many as we still need
@@ -1176,7 +1213,10 @@ class MotionApiService {
                 returnedResults: allMatchingTasks.length,
                 limit: effectiveLimit
             });
-            return allMatchingTasks;
+            if (aggregateTruncation) {
+                aggregateTruncation.returnedCount = allMatchingTasks.length;
+            }
+            return { items: allMatchingTasks, truncation: aggregateTruncation };
         }
         catch (error) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to search tasks', {
@@ -1199,11 +1239,15 @@ class MotionApiService {
             const effectiveLimit = limit || constants_1.LIMITS.MAX_SEARCH_RESULTS;
             const lowerQuery = query.toLowerCase();
             const allMatchingProjects = [];
+            let aggregateTruncation;
             // First, search in the specified workspace
-            const primaryProjects = await this.getProjects(workspaceId, {
+            const { items: primaryProjects, truncation: primaryTruncation } = await this.getProjects(workspaceId, {
                 maxPages: constants_1.LIMITS.MAX_PAGES,
                 limit: (0, paginationNew_1.calculateAdaptiveFetchLimit)(allMatchingProjects.length, effectiveLimit)
             });
+            if (primaryTruncation?.wasTruncated && !aggregateTruncation) {
+                aggregateTruncation = primaryTruncation;
+            }
             const primaryMatches = primaryProjects.filter(project => project.name?.toLowerCase().includes(lowerQuery) ||
                 project.description?.toLowerCase().includes(lowerQuery));
             allMatchingProjects.push(...primaryMatches.slice(0, effectiveLimit));
@@ -1234,10 +1278,13 @@ class MotionApiService {
                                 searchingWorkspaceName: workspace.name,
                                 remainingNeeded: effectiveLimit - allMatchingProjects.length
                             });
-                            const workspaceProjects = await this.getProjects(workspace.id, {
+                            const { items: workspaceProjects, truncation: wsTruncation } = await this.getProjects(workspace.id, {
                                 maxPages: constants_1.LIMITS.MAX_PAGES,
                                 limit: fetchLimit
                             });
+                            if (wsTruncation?.wasTruncated && !aggregateTruncation) {
+                                aggregateTruncation = wsTruncation;
+                            }
                             const workspaceMatches = workspaceProjects.filter(project => project.name?.toLowerCase().includes(lowerQuery) ||
                                 project.description?.toLowerCase().includes(lowerQuery));
                             // Only add as many as we still need
@@ -1281,7 +1328,10 @@ class MotionApiService {
                 returnedResults: allMatchingProjects.length,
                 limit: effectiveLimit
             });
-            return allMatchingProjects;
+            if (aggregateTruncation) {
+                aggregateTruncation.returnedCount = allMatchingProjects.length;
+            }
+            return { items: allMatchingProjects, truncation: aggregateTruncation };
         }
         catch (error) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to search projects', {
@@ -1664,51 +1714,56 @@ class MotionApiService {
     async getRecurringTasks(workspaceId, options) {
         const { maxPages = 10, limit } = options || {};
         const cacheKey = workspaceId ? `recurring-tasks:workspace:${workspaceId}` : 'recurring-tasks:all';
-        return this.recurringTaskCache.withCache(cacheKey, async () => {
-            try {
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Fetching recurring tasks from Motion API with pagination', {
-                    method: 'getRecurringTasks',
-                    workspaceId,
-                    maxPages,
-                    limit
-                });
-                // Create a fetch function for pagination utility
-                const fetchPage = async (cursor) => {
-                    const params = new URLSearchParams();
-                    if (workspaceId)
-                        params.append('workspaceId', workspaceId);
-                    if (cursor)
-                        params.append('cursor', cursor);
-                    const queryString = params.toString();
-                    const url = queryString ? `/recurring-tasks?${queryString}` : '/recurring-tasks';
-                    return this.requestWithRetry(() => this.client.get(url));
-                };
-                // Use pagination utility to fetch all pages
-                const paginatedResult = await (0, paginationNew_1.fetchAllPages)(fetchPage, 'recurring-tasks', {
-                    maxPages,
-                    logProgress: true,
-                    ...(limit ? { maxItems: limit } : {})
-                });
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Recurring tasks fetched successfully with pagination', {
-                    method: 'getRecurringTasks',
-                    totalCount: paginatedResult.totalFetched,
-                    pagesProcessed: Math.ceil(paginatedResult.totalFetched / 50), // Assuming ~50 items per page
-                    hasMore: paginatedResult.hasMore,
-                    workspaceId
-                });
-                return paginatedResult.items;
-            }
-            catch (error) {
-                (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch recurring tasks', {
-                    method: 'getRecurringTasks',
-                    error: getErrorMessage(error),
-                    apiStatus: (0, axios_1.isAxiosError)(error) ? error.response?.status : undefined,
-                    apiMessage: (0, axios_1.isAxiosError)(error) ? error.response?.data?.message : undefined,
-                    workspaceId
-                });
-                throw this.formatApiError(error, 'fetch', 'recurring task');
-            }
-        });
+        // Check cache - return items only (no stale truncation info)
+        const cachedItems = this.recurringTaskCache.get(cacheKey);
+        if (cachedItems !== null) {
+            return { items: cachedItems };
+        }
+        try {
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.DEBUG, 'Fetching recurring tasks from Motion API with pagination', {
+                method: 'getRecurringTasks',
+                workspaceId,
+                maxPages,
+                limit
+            });
+            // Create a fetch function for pagination utility
+            const fetchPage = async (cursor) => {
+                const params = new URLSearchParams();
+                if (workspaceId)
+                    params.append('workspaceId', workspaceId);
+                if (cursor)
+                    params.append('cursor', cursor);
+                const queryString = params.toString();
+                const url = queryString ? `/recurring-tasks?${queryString}` : '/recurring-tasks';
+                return this.requestWithRetry(() => this.client.get(url));
+            };
+            // Use pagination utility to fetch all pages
+            const paginatedResult = await (0, paginationNew_1.fetchAllPages)(fetchPage, 'recurring-tasks', {
+                maxPages,
+                logProgress: true,
+                ...(limit ? { maxItems: limit } : {})
+            });
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.INFO, 'Recurring tasks fetched successfully with pagination', {
+                method: 'getRecurringTasks',
+                totalCount: paginatedResult.totalFetched,
+                pagesProcessed: Math.ceil(paginatedResult.totalFetched / 50), // Assuming ~50 items per page
+                hasMore: paginatedResult.hasMore,
+                workspaceId
+            });
+            // Cache only items, not truncation metadata
+            this.recurringTaskCache.set(cacheKey, paginatedResult.items);
+            return { items: paginatedResult.items, truncation: paginatedResult.truncation };
+        }
+        catch (error) {
+            (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch recurring tasks', {
+                method: 'getRecurringTasks',
+                error: getErrorMessage(error),
+                apiStatus: (0, axios_1.isAxiosError)(error) ? error.response?.status : undefined,
+                apiMessage: (0, axios_1.isAxiosError)(error) ? error.response?.data?.message : undefined,
+                workspaceId
+            });
+            throw this.formatApiError(error, 'fetch', 'recurring task');
+        }
     }
     /**
      * Create a new recurring task
@@ -1953,6 +2008,7 @@ class MotionApiService {
             // Apply limit to prevent resource exhaustion
             const effectiveLimit = limit || constants_1.LIMITS.MAX_SEARCH_RESULTS;
             const allUncompletedTasks = [];
+            let aggregateTruncation;
             try {
                 // Get all workspaces
                 const workspaces = await this.getWorkspaces();
@@ -1971,12 +2027,15 @@ class MotionApiService {
                         if (fetchLimit <= 0)
                             break;
                         // Get tasks from this workspace with adaptive limit
-                        const workspaceTasks = await this.getTasks({
+                        const { items: workspaceTasks, truncation: wsTruncation } = await this.getTasks({
                             workspaceId: workspace.id,
                             assigneeId,
                             limit: fetchLimit,
                             maxPages: constants_1.LIMITS.MAX_PAGES
                         });
+                        if (wsTruncation?.wasTruncated && !aggregateTruncation) {
+                            aggregateTruncation = wsTruncation;
+                        }
                         // Filter for uncompleted tasks
                         const uncompletedTasks = workspaceTasks.filter(task => {
                             // Task is uncompleted if status is missing or isResolvedStatus is false
@@ -2024,7 +2083,10 @@ class MotionApiService {
                 returned: allUncompletedTasks.length,
                 limit: effectiveLimit
             });
-            return allUncompletedTasks;
+            if (aggregateTruncation) {
+                aggregateTruncation.returnedCount = allUncompletedTasks.length;
+            }
+            return { items: allUncompletedTasks, truncation: aggregateTruncation };
         }
         catch (error) {
             (0, logger_1.mcpLog)(constants_1.LOG_LEVELS.ERROR, 'Failed to fetch all uncompleted tasks', {