moshcode 0.74.0 → 0.75.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "moshcode",
-  "version": "0.74.0",
+  "version": "0.75.0",
   "type": "module",
   "description": "moshcode \u2014 a metal wrapper for coding engines and native UGig/CoinPay workflow CLIs, with OpenPRD and moshscript",
   "repository": {

package/src/billing.mjs

@@ -19,6 +19,7 @@ import { spawnSync } from "node:child_process";
 
 import { loadBusiness, loadTimers, newId, updateBusiness, updateTimers } from "./business-store.mjs";
 import { clientLabel, parseFields, resolveClient } from "./clients.mjs";
+import { captureSpec } from "./pty.mjs";
 import { GATEWAYS, defaultGateway, gatewayState } from "./payments.mjs";
 import { chargeFor, describeRate, formatMoney, isDollarPegged, isFiat, rateFor } from "./rates.mjs";
 import { humanDuration, selectEntries, windowFrom } from "./timer.mjs";
@@ -289,7 +290,12 @@ function handOff(record, invoice, business, fields, write, run) {
     return 0;
   }
 
-  const result = run("coinpay", args, { stdio: "inherit" });
+  // Mirrored like every other hand-off: sending an invoice is exactly the kind
+  // of thing you want to read back from the session page afterwards.
+  const launch = captureSpec({ cmd: "coinpay", args });
+  let result;
+  try { result = run(launch.cmd, launch.args, { stdio: "inherit" }); }
+  finally { launch.stop(); }
   if (result?.error) { write(err(String(result.error.message || result.error))); return 1; }
   if (result?.status) { write(err(`coinpay exited ${result.status} — invoice ${record.id} is still a local draft`)); return result.status; }
   updateBusiness((data) => {

package/src/commands.mjs

@@ -22,6 +22,7 @@ import { capture, killSession, remoteStatus, sendPrompt } from "./herd.mjs";
 import { herdStart, isRemoteMember, roster, waitForMany, waitMember } from "./herd-cli.mjs";
 import { endTask, findTask, readTasks, startTask } from "./herd-tasks.mjs";
 import { shellInvocation } from "./shell.mjs";
+import { captureSpec } from "./pty.mjs";
 import { identity, loginAuto, logout as forgetCreds } from "./auth.mjs";
 import { expandAlias, getAlias, loadAliases, removeAlias, setAlias } from "./aliases.mjs";
 import { CORE_CLI_COMMAND_NAMES, PIT_COMMANDS } from "./cli-schema.mjs";
@@ -116,7 +117,15 @@ const SHELL = {
     // has the reasoning, including why a headless run stays non-interactive.
     const { shell: sh, args: shArgs } = shellInvocation(cmd);
     ctx.out(`  ▶ shell: ${cmd}`);
-    const res = spawnSync(sh, shArgs, { stdio: "inherit" });
+    // Captured for the session mirror like the pit's own `!cmd`. A blocking
+    // spawn holds the event loop, so the follower's poll never runs and the
+    // whole command arrives in the drain stop() does — batched rather than
+    // live, which is still the difference between reading it from a phone and
+    // not.
+    const launch = captureSpec({ cmd: sh, args: shArgs });
+    let res;
+    try { res = spawnSync(launch.cmd, launch.args, { stdio: "inherit" }); }
+    finally { launch.stop(); }
     if (res.error) throw res.error;
     const code = res.status ?? 1;
     if (code !== 0) {

package/src/engines.mjs

@@ -32,11 +32,11 @@
 // a session that starts fresh is a small disappointment, and one that starts
 // with a flag the engine does not have is a crash.
 import { spawn } from "node:child_process";
-import { existsSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from "node:fs";
-import { homedir, tmpdir } from "node:os";
+import { existsSync, readFileSync, statSync } from "node:fs";
+import { homedir } from "node:os";
 import path from "node:path";
 
-import { followFile, ptyEnabled, ptySpec, scriptFlavor, stripScriptBanner } from "./pty.mjs";
+import { captureSpec } from "./pty.mjs";
 
 export const ENGINES = {
   opencode: {
@@ -439,21 +439,29 @@ export function runCmd(cmd, args = [], { capture = false } = {}) {
     let child;
     const spec = spawnSpec(cmd, args);
     const stdio = capture ? ["inherit", "pipe", "pipe"] : "inherit";
-    try { child = spawn(spec.cmd, spec.args, { stdio }); }
-    catch (e) { resolve({ ok: false, error: e }); return; }
+    // The `capture` branch already reaches a watching browser: it re-writes
+    // every byte through this process's own stdout/stderr, which the mirror
+    // tees. The inherited branch does not — those bytes go to the tty and
+    // nowhere else — so it goes under a pty when a mirror is live. This is what
+    // an upgrade, a plugin install and an `mcp add` all run through, and all
+    // three used to be a rule, a blank stretch, and a result line.
+    const launch = capture ? { ...spec, stop: () => {} } : captureSpec(spec);
+    const finish = (result) => { try { launch.stop(); } catch { /* already drained */ } resolve(result); };
+    try { child = spawn(launch.cmd, launch.args, { stdio }); }
+    catch (e) { finish({ ok: false, error: e }); return; }
     let output = "";
     if (capture) {
       for (const [stream, sink] of [[child.stdout, process.stdout], [child.stderr, process.stderr]]) {
         stream?.on("data", (chunk) => { output += chunk.toString(); sink.write(chunk); });
       }
     }
-    child.on("error", (e) => resolve({ ok: false, error: e, output }));
+    child.on("error", (e) => finish({ ok: false, error: e, output }));
     // "exit" fires as soon as the process is gone, which with pipes can leave
     // the last chunk still queued — the one line we are trying to read. "close"
     // waits for the streams too. With stdio inherited there are no streams, so
     // the two are the same moment and existing callers are unaffected; the
     // distinction is kept explicit so neither branch changes by accident.
-    child.on(capture ? "close" : "exit", (code, signal) => resolve({ ok: true, code, signal, output }));
+    child.on(capture ? "close" : "exit", (code, signal) => finish({ ok: true, code, signal, output }));
   });
 }
 
@@ -501,35 +509,8 @@ export function openPassthrough(target, args = [], { onOutput } = {}) {
     // the child the tty's own file descriptors, so none of its bytes ever pass
     // through this process. See src/pty.mjs for why this is script(1) and not
     // a pipe or node-pty.
-    let transcript = null;
-    let workDir = null;
-    let stopFollow = null;
-    let launch = { ...spec, stdio: "inherit" };
-    if (ptyEnabled(onOutput)) {
-      try {
-        workDir = mkdtempSync(path.join(tmpdir(), "moshcode-pty-"));
-        transcript = path.join(workDir, "transcript");
-        writeFileSync(transcript, "");
-        const wrapped = ptySpec(spec.cmd, spec.args, transcript, scriptFlavor());
-        if (wrapped) {
-          launch = { ...wrapped, stdio: "inherit" };
-          let first = true;
-          stopFollow = followFile(transcript, (chunk) => {
-            const clean = stripScriptBanner(chunk, first);
-            first = false;
-            if (clean) onOutput(clean);
-          });
-        }
-      } catch {
-        // Capture is a nicety; never let it stop the session from opening.
-        transcript = null;
-      }
-    }
-
-    const cleanup = () => {
-      try { stopFollow?.(); } catch { /* nothing left to drain */ }
-      if (workDir) { try { rmSync(workDir, { recursive: true, force: true }); } catch { /* temp dir */ } }
-    };
+    const launch = captureSpec(spec, onOutput);
+    const cleanup = () => launch.stop();
 
     let child;
     try { child = spawn(launch.cmd, launch.args, { stdio: "inherit", env }); }

package/src/mirror.mjs

@@ -56,6 +56,28 @@ export function pressKey(name, rl = null, stdin = process.stdin) {
 const FLUSH_MS = 150;      // batch writes so a busy render is one request, not fifty
 const MAX_BUFFER = 16000;  // flush early once a batch gets big
 
+// Where a child process's output should be copied while a mirror is watching.
+//
+// Module-level rather than threaded through every call, because "is anyone
+// watching this pit" is one fact about the process and the launchers that need
+// it are scattered: the shell, the installers, the upgrader, the plugin/skill/
+// MCP hand-offs. Passing it down by hand is what left most of them writing
+// straight to the tty with the session page showing nothing — each new launcher
+// had to remember, and none of them did. src/pty.mjs reads this as its default,
+// so capture is what a launcher gets for free and opting out is the deliberate
+// act.
+let activeSink = null;
+
+/** Point child capture at this mirror (or null when the pit stops mirroring). */
+export function setActiveSink(sink) {
+  activeSink = typeof sink === "function" ? sink : null;
+}
+
+/** The sink a child's output should be copied to, or null when unmirrored. */
+export function activeChildSink() {
+  return activeSink;
+}
+
 export function createMirror({
   version = "",
   cwd = process.cwd(),

package/src/payments.mjs

@@ -22,6 +22,7 @@
 // `/payments connect stripe` records a *reference* — vault and key name — and
 // says out loud where the secret should go.
 import { spawnSync } from "node:child_process";
+import { captureSpec } from "./pty.mjs";
 
 import { loadBusiness, updateBusiness } from "./business-store.mjs";
 import { parseFields } from "./clients.mjs";
@@ -178,7 +179,10 @@ function connectGateway(args, write, run) {
     return 1;
   }
   write(info(`handing you to ${bone(gateway.bin)} — it owns its own session`));
-  const result = run(gateway.bin, gateway.connect, { stdio: "inherit" });
+  const launch = captureSpec({ cmd: gateway.bin, args: gateway.connect });
+  let result;
+  try { result = run(launch.cmd, launch.args, { stdio: "inherit" }); }
+  finally { launch.stop(); }
   if (result?.error) { write(err(String(result.error.message || result.error))); return 1; }
   if (result?.status) {
     write(err(`${gateway.bin} ${gateway.connect.join(" ")} exited ${result.status} — nothing recorded`));

package/src/pty.mjs

@@ -19,8 +19,11 @@
 // `script` disagree on both flag names and argument order, and anything we
 // cannot positively identify falls back to today's plain `inherit`.
 import { spawnSync } from "node:child_process";
-import { closeSync, existsSync, openSync, readSync, statSync } from "node:fs";
+import { closeSync, existsSync, mkdtempSync, openSync, readSync, rmSync, statSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
 import { StringDecoder } from "node:string_decoder";
+import { activeChildSink } from "./mirror.mjs";
 
 /**
  * POSIX single-quote escaping, for argv that has to survive being flattened
@@ -178,3 +181,57 @@ export function ptyEnabled(sink, flavor = scriptFlavor()) {
   if (process.env.MOSHCODE_MIRROR_PTY === "0") return false;
   return Boolean(flavor);
 }
+
+/**
+ * Wrap a spawn spec so a copy of everything the child prints reaches `onOutput`
+ * while the child still owns the real terminal.
+ *
+ * The whole capture dance in one place — temp transcript, the flavour-specific
+ * `script` argv, the follower, the banner strip, the cleanup — because every
+ * launcher in the pit needs it, and each one growing its own copy is how a
+ * shell command ended up invisible in the mirror while `/agents claude` was
+ * captured: both spawn `inherit`, and only one of them had been taught this.
+ *
+ * `onOutput` defaults to whatever the live mirror is (src/mirror.mjs), so a
+ * launcher gets capture without having to know the mirror exists — the reverse
+ * of how this started, where each launcher had to be taught separately and only
+ * two ever were. Pass `null` to opt a launch out.
+ *
+ * Returns `{ cmd, args, stop }`. With nothing watching, or on a box with no
+ * `script(1)` we can drive, `cmd`/`args` come back exactly as passed in and
+ * `stop` is a no-op — the caller spawns what it always spawned. `stop()` must
+ * be called once the child exits: it drains the tail of the transcript (the
+ * last lines of a command are usually the ones you were waiting for) and
+ * removes the temp dir.
+ */
+export function captureSpec({ cmd, args = [] }, onOutput = activeChildSink(), { flavor = scriptFlavor() } = {}) {
+  const plain = { cmd, args, stop: () => {} };
+  if (!ptyEnabled(onOutput, flavor)) return plain;
+  let workDir = null;
+  try {
+    workDir = mkdtempSync(path.join(tmpdir(), "moshcode-pty-"));
+    const transcript = path.join(workDir, "transcript");
+    writeFileSync(transcript, "");
+    const wrapped = ptySpec(cmd, args, transcript, flavor);
+    if (!wrapped) throw new Error("no script(1) spec for this flavour");
+    let first = true;
+    const stopFollow = followFile(transcript, (chunk) => {
+      const clean = stripScriptBanner(chunk, first);
+      first = false;
+      if (clean) onOutput(clean);
+    });
+    const dir = workDir;
+    return {
+      cmd: wrapped.cmd,
+      args: wrapped.args,
+      stop() {
+        try { stopFollow(); } catch { /* nothing left to drain */ }
+        try { rmSync(dir, { recursive: true, force: true }); } catch { /* temp dir */ }
+      },
+    };
+  } catch {
+    // Capture is a nicety; never let it stop a command from running.
+    if (workDir) { try { rmSync(workDir, { recursive: true, force: true }); } catch { /* temp dir */ } }
+    return plain;
+  }
+}

package/src/tui.mjs

@@ -18,7 +18,7 @@ import { createPrd, listPrds, authoringPrompt } from "./prd.mjs";
 import { loginAuto, whoami, logout } from "./auth.mjs";
 import { startAutoSync } from "./autosync.mjs";
 import { loadCommand, saveCommand } from "./settings-sync.mjs";
-import { createMirror, pressKey, teeOutput } from "./mirror.mjs";
+import { createMirror, pressKey, setActiveSink, teeOutput } from "./mirror.mjs";
 import { fetchMotdAd } from "./ads.mjs";
 import { runScript } from "./runtime.mjs";
 import { moshVocabulary } from "./commands.mjs";
@@ -28,6 +28,7 @@ import { cryptoCommand } from "./crypto.mjs";
 import { gamesCommand } from "./games.mjs";
 import { canOpenBrowser, openBrowser } from "./open-url.mjs";
 import { shellInvocation } from "./shell.mjs";
+import { captureSpec } from "./pty.mjs";
 import { needsRootHere, primeEscalation } from "./escalate.mjs";
 import { banner, hr, acid, ash, bone, dim, ok, err, warn, info, moshcodeVersion } from "./ui.mjs";
 import { CORE_CLI_COMMAND_NAMES } from "./cli-schema.mjs";
@@ -678,14 +679,23 @@ async function openWorkflowTool(key, tool, args) {
 // command string → `$SHELL +m -ic "<cmd>"` (one-off). Interactive so the command
 // can see the aliases and functions in ~/.zshrc — see src/shell.mjs for why
 // that is not optional. Resolves { ok, code, signal }.
-function runShell(rawCmd) {
+//
+// Captured through a pty when the mirror is watching, for the same reason an
+// engine is: a shell command is where most of what a pit does actually happens
+// — `!cmd`, /shell, and every shell-valued /alias land here — and with plain
+// `inherit` none of its bytes, on stdout or stderr, ever pass through this
+// process. The session page was showing the echoed command line and the exit
+// note with nothing in between.
+export function runShell(rawCmd, { onOutput } = {}) {
   return new Promise((resolve) => {
     const { shell, args } = shellInvocation(rawCmd);
+    const launch = captureSpec({ cmd: shell, args }, onOutput);
+    const done = (result) => { try { launch.stop(); } catch { /* already drained */ } resolve(result); };
     let child;
-    try { child = spawn(shell, args, { stdio: "inherit" }); }
-    catch (e) { resolve({ ok: false, error: e }); return; }
-    child.on("error", (e) => resolve({ ok: false, error: e }));
-    child.on("exit", (code, signal) => resolve({ ok: true, code, signal }));
+    try { child = spawn(launch.cmd, launch.args, { stdio: "inherit" }); }
+    catch (e) { done({ ok: false, error: e }); return; }
+    child.on("error", (e) => done({ ok: false, error: e }));
+    child.on("exit", (code, signal) => done({ ok: true, code, signal }));
   });
 }
 
@@ -700,7 +710,7 @@ async function openShell(rawCmd) {
     ? `${bone(shellName)} ${ash(flags)} ${ash(rawCmd)}`
     : `dropping to ${bone(shellName)} — ${ash("`exit` or Ctrl-D brings you back to the pit")}`));
   console.log(hr());
-  const r = await runShell(rawCmd);
+  const r = await runShell(rawCmd, { onOutput: childSink() });
   console.log(hr());
   if (!r.ok) {
     console.log(err(`couldn't start shell: ${r.error?.message || r.error}`));
@@ -720,14 +730,22 @@ function installTarget(key) {
     // something the installer's output scrolled into view.
     if (needsRootHere(target)) primeEscalation({ what: key, out: (s) => console.log(info(s.replace(/^· /, ""))) });
     console.log(hr());
-    const child = spawn(target.install.cmd, target.install.args, { stdio: "inherit" });
+    // Installers are long, chatty, and the thing you most want to read from a
+    // phone — so they go through the mirror's pty like everything else.
+    const launch = captureSpec(
+      { cmd: target.install.cmd, args: target.install.args },
+      childSink(),
+    );
+    const child = spawn(launch.cmd, launch.args, { stdio: "inherit" });
     child.on("error", (e) => {
+      launch.stop();
       console.log(hr());
       console.log(err(`install failed: ${e.message}`));
       if (e.code === "ENOENT" && target.installHelp) console.log(info(target.installHelp));
       resolve();
     });
     child.on("exit", (code) => {
+      launch.stop();
       console.log(hr());
       if (code !== 0) { console.log(err(`install exited ${code}`)); return resolve(); }
       console.log(ok(`${key} installed. 🤘`));
@@ -1292,6 +1310,10 @@ async function startMirror() {
   if (!started) return noop;
 
   activeMirror = mirror;
+  // Every launcher that spawns a child reads this rather than being handed a
+  // sink, so a command run from the pit is captured whether or not whoever
+  // wrote that launcher knew the mirror existed.
+  setActiveSink((chunk) => activeMirror?.write(chunk));
   const restoreTee = teeOutput((chunk) => mirror.write(chunk));
 
   // Commands arrive whenever; the prompt is only ready between engine
@@ -1326,6 +1348,7 @@ async function startMirror() {
 async function stopMirror(restoreTee) {
   const mirror = activeMirror;
   activeMirror = null;
+  setActiveSink(null);
   try { restoreTee?.(); } catch { /* noop */ }
   try { await mirror?.stop(); } catch { /* best effort */ }
 }