monorepo-next 9.2.0 → 9.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "monorepo-next",
-  "version": "9.2.0",
+  "version": "9.2.2",
   "description": "Detach monorepo packages from normal linking",
   "bin": {
     "next": "bin/next.js"
@@ -80,8 +80,8 @@
     "chai-as-promised": "^7.1.1",
     "common-tags": "^1.8.2",
     "eslint": "^8.0.0",
-    "eslint-config-crowdstrike": "^9.0.0",
-    "eslint-config-crowdstrike-node": "^3.0.0",
+    "eslint-config-crowdstrike": "10.1.0",
+    "eslint-config-crowdstrike-node": "3.0.1",
     "eslint-plugin-json-files": "^2.0.0",
     "eslint-plugin-mocha": "^10.0.0",
     "eslint-plugin-node": "^11.0.0",
@@ -95,6 +95,6 @@
     "sinon": "^15.0.0",
     "sinon-chai": "^3.5.0",
     "standard-node-template": "3.2.1",
-    "yargs-help-output": "^2.0.0"
+    "yargs-help-output": "^3.0.0"
   }
 }

package/src/cycle.js

@@ -2,101 +2,61 @@
 
 const dependencyTypes = require('./dependency-types');
 
-function createPackageNode({
-  packageName,
-  dependencyType,
-  dependencyRange,
-  parent,
-  branch,
-}) {
-  let group = {
-    parent,
-    dependencyType,
-    dependencyRange,
-    isCycle: false,
-    packageName,
-  };
-
-  let newBranch = [...branch, group].filter(Boolean);
-
-  return {
-    newGroup: group,
-    newBranch,
-  };
-}
-
-function findGroupInBranchByPackageName(branch, packageName) {
-  let _i = -1;
-
-  for (let i = 0; i < branch.length; i++) {
-    if (branch[i].packageName === packageName) {
-      _i = i;
-
-      break;
-    }
-  }
-
-  return _i;
-}
-
 function _getCycles({
   packages,
   _package,
   dependencyType,
   dependencyRange,
-  parent,
   branch,
   visitedNodes,
   cycles,
   shouldDetectDevDependencies,
 }) {
-  let visitedNode = visitedNodes[_package.packageName];
-
-  if (visitedNode) {
-    let i = findGroupInBranchByPackageName(branch, _package.packageName);
+  let { packageName } = _package;
 
-    let isCycle = i !== -1;
+  let hasVisitedNode = visitedNodes.has(packageName);
 
-    let existingGroup = {
-      parent,
-      dependencyType,
-      dependencyRange,
-      isCycle,
-      packageName: visitedNode,
-    };
+  if (hasVisitedNode) {
+    let isCycle = branch.has(packageName);
 
     if (isCycle) {
-      let newBranch = [...branch.slice(i), existingGroup];
+      let existingGroup = {
+        dependencyType,
+        dependencyRange,
+        packageName,
+      };
+
+      let newBranch = [...[...branch.values()].slice([...branch.keys()].indexOf(packageName)), existingGroup];
 
       let cycle = newBranch.map(({ dependencyType, packageName }) => {
         return [dependencyType, packageName];
       });
 
-      cycles[cycle.flat().slice(1).join(' < ')] = existingGroup;
+      cycles.add(cycle.flat().slice(1).join(' < '));
     }
 
     return;
   }
 
-  let {
-    newGroup,
-    newBranch,
-  } = createPackageNode({
-    packageName: _package.packageName,
+  let newGroup = {
     dependencyType,
     dependencyRange,
-    parent,
-    branch,
-  });
+    packageName,
+  };
 
-  visitedNodes[_package.packageName] = newGroup.packageName;
+  let newBranch = new Map([...branch, [packageName, newGroup]]);
+
+  visitedNodes.add(packageName);
 
   for (let dependencyType of dependencyTypes) {
     if (!shouldDetectDevDependencies && dependencyType === 'devDependencies') {
       continue;
     }
 
-    for (let [packageName, dependencyRange] of Object.entries(_package[dependencyType])) {
+    let dependencies = _package[dependencyType];
+
+    for (let packageName of Object.keys(dependencies).sort()) {
+      let dependencyRange = dependencies[packageName];
       let _package = packages[packageName];
 
       _getCycles({
@@ -104,7 +64,6 @@ function _getCycles({
         _package,
         dependencyType,
         dependencyRange,
-        parent: newGroup,
         branch: newBranch,
         visitedNodes,
         cycles,
@@ -117,22 +76,24 @@ function _getCycles({
 function getCycles(workspaceMeta, {
   shouldDetectDevDependencies,
 } = {}) {
-  let cycles = {};
-  let visitedNodes = {};
+  let cycles = new Set();
+  let visitedNodes = new Set();
   let { packages } = workspaceMeta;
 
-  for (let _package of Object.values(packages)) {
+  for (let packageName of Object.keys(packages).sort()) {
+    let _package = packages[packageName];
+
     _getCycles({
       packages,
       _package,
-      branch: [],
+      branch: new Map(),
       visitedNodes,
       cycles,
       shouldDetectDevDependencies,
     });
   }
 
-  return Object.keys(cycles);
+  return [...cycles].sort();
 }
 
 Object.assign(module.exports, {