monorepo-next 8.3.1 → 8.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "monorepo-next",
-  "version": "8.3.1",
+  "version": "8.3.2",
   "description": "Detach monorepo packages from normal linking",
   "bin": {
     "next": "bin/next.js"

package/src/build-change-graph.js

@@ -21,22 +21,17 @@ async function getPackageChangedFiles({
   packageCwd,
   options,
 }) {
-  let isAncestor = await isCommitAncestorOf(fromCommit, toCommit, options);
-
-  let olderCommit;
-  let newerCommit;
-  if (isAncestor) {
-    olderCommit = fromCommit;
-    newerCommit = toCommit;
-  } else {
-    olderCommit = toCommit;
-    newerCommit = fromCommit;
-  }
+  // Be careful you don't accidentally use `...` instead of `..`.
+  // `...` finds the merge-base and uses that instead of `fromCommit`.
+  // https://stackoverflow.com/a/60496462
+  let committedChanges = await git(['diff', '--name-only', `${fromCommit}..${toCommit}`, packageCwd], options);
 
-  let committedChanges = await git(['diff', '--name-only', `${olderCommit}...${newerCommit}`, packageCwd], options);
   committedChanges = getLinesFromOutput(committedChanges);
+
   let dirtyChanges = await git(['status', '--porcelain', packageCwd, '-u'], options);
+
   dirtyChanges = getLinesFromOutput(dirtyChanges).map(line => line.substr(3));
+
   let changedFiles = Array.from(new Set(committedChanges).union(dirtyChanges));
 
   return changedFiles;