monorepo-next 12.1.1 → 12.2.1

package/README.md

@@ -115,33 +115,37 @@ next release
 release all packages as needed
 
 Options:
-  --help                          Show help                            [boolean]
-  --version                       Show version number                  [boolean]
-  --silent                        Don't print logs and errors
+  --help                            Show help                          [boolean]
+  --version                         Show version number                [boolean]
+  --silent                          Don't print logs and errors
                                                       [boolean] [default: false]
-  --dry-run                       log to console instead of modifying files
+  --dry-run                         log to console instead of modifying files
                                                       [boolean] [default: false]
-  --push                          git push + tags when done
+  --push                            git push + tags when done
                                                        [boolean] [default: true]
-  --publish                       npm publish when done[boolean] [default: true]
-  --dist-tag                      publish to a different NPM dist-tag
+  --publish                         npm publish when done
+                                                       [boolean] [default: true]
+  --dist-tag                        publish to a different NPM dist-tag
                                                     [string] [default: "latest"]
-  --bump-in-range-dependencies    If a dependency is still in range, and nothing
-                                  changed in my package, still bump my version
-                                  and the dependency version.
+  --bump-in-range-dependencies      If a dependency is still in range, and
+                                    nothing changed in my package, still bump my
+                                    version and the dependency version.
                                                        [boolean] [default: true]
-  --inherit-greater-release-type  If a dependency has a greater release type,
-                                  bump my package the with the same release
-                                  type.               [boolean] [default: false]
-  --exclude-dev-changes           If a change doesn't affect consumers, like a
-                                  monorepo dev dep change or manually bumping an
-                                  external dev dep, don't count it towards a
-                                  package change.     [boolean] [default: false]
-  --clean-up-after-failed-push    If there's already a new commit on the remote,
-                                  clean up the commit and tags that won't be
-                                  used                [boolean] [default: false]
-  --scripts                       Provide scripts to execute for lifecycle
-                                  events (prebump, precommit, etc.,)
+  --inherit-greater-release-type    If a dependency has a greater release type,
+                                    bump my package the with the same release
+                                    type.             [boolean] [default: false]
+  --exclude-dev-changes             If a change doesn't affect consumers, like a
+                                    monorepo dev dep change or manually bumping
+                                    an external dev dep, don't count it towards
+                                    a package change. [boolean] [default: false]
+  --validate-dependency-visibility  Prevent releasing public packages that
+                                    depend on private packages.
+                                                      [boolean] [default: false]
+  --clean-up-after-failed-push      If there's already a new commit on the
+                                    remote, clean up the commit and tags that
+                                    won't be used     [boolean] [default: false]
+  --scripts                         Provide scripts to execute for lifecycle
+                                    events (prebump, precommit, etc.,)
                                                                    [default: {}]
   --package-files
                 [array] [default: ["package.json","bower.json","manifest.json"]]

package/bin/commands/release.js

@@ -37,6 +37,11 @@ module.exports = {
       default: false,
     },
     'exclude-dev-changes': commonArgs['exclude-dev-changes'],
+    'validate-dependency-visibility': {
+      describe: 'Prevent releasing public packages that depend on private packages.',
+      type: 'boolean',
+      default: false,
+    },
     'clean-up-after-failed-push': {
       describe: 'If there\'s already a new commit on the remote, clean up the commit and tags that won\'t be used',
       type: 'boolean',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "monorepo-next",
-  "version": "12.1.1",
+  "version": "12.2.1",
   "description": "Detach monorepo packages from normal linking",
   "bin": {
     "next": "bin/next.js"
@@ -60,7 +60,7 @@
   },
   "dependencies": {
     "@npmcli/arborist": "^7.0.0",
-    "commit-and-tag-version": "12.4.1",
+    "commit-and-tag-version": "12.5.0",
     "conventional-changelog": "5.1.0",
     "conventional-recommended-bump": "9.0.0",
     "debug": "^4.3.1",

package/src/build-release-graph.js

@@ -133,6 +133,7 @@ async function secondPass({
   shouldBumpInRangeDependencies,
   shouldInheritGreaterReleaseType,
   shouldExcludeDevChanges,
+  shouldValidateDependencyVisibility,
 }) {
   function shouldInit({
     dag,
@@ -200,6 +201,15 @@ async function secondPass({
           continue;
         }
 
+        if (
+          shouldValidateDependencyVisibility &&
+          !dag.node.isPackage &&
+          group.node.isPackage &&
+          group.dependencyType === 'dependencies'
+        ) {
+          throw new Error(`Public package "${group.node.packageName}" has a dependency on the private package "${dag.node.packageName}".`);
+        }
+
         await crawlDag({
           dag: group,
           parent: releaseTrees[dag.node.packageName],
@@ -350,6 +360,7 @@ async function buildReleaseGraph({
   shouldBumpInRangeDependencies,
   shouldInheritGreaterReleaseType,
   shouldExcludeDevChanges,
+  shouldValidateDependencyVisibility,
 }) {
   let logSync = createSyncLogger(_debug);
   let logAsync = createAsyncLogger(_debug);
@@ -369,6 +380,7 @@ async function buildReleaseGraph({
     shouldBumpInRangeDependencies,
     shouldInheritGreaterReleaseType,
     shouldExcludeDevChanges,
+    shouldValidateDependencyVisibility,
   });
 
   // packages without changes, but need to be analyzed because of options

package/src/get-changelog.js

@@ -20,6 +20,7 @@ async function getChangelog({
   shouldBumpInRangeDependencies = builder['bump-in-range-dependencies'].default,
   shouldInheritGreaterReleaseType = builder['inherit-greater-release-type'].default,
   shouldExcludeDevChanges = builder['exclude-dev-changes'].default,
+  shouldValidateDependencyVisibility = builder['validate-dependency-visibility'].default,
   releaseCount = 1,
   fromCommit,
   cached,
@@ -48,6 +49,7 @@ async function getChangelog({
     shouldBumpInRangeDependencies,
     shouldInheritGreaterReleaseType,
     shouldExcludeDevChanges,
+    shouldValidateDependencyVisibility,
   });
 
   let releaseTree = releaseTrees.find(releaseTree => releaseTree.name === name);

package/src/get-new-versions.js

@@ -15,6 +15,7 @@ async function getNewVersions({
   shouldBumpInRangeDependencies = builder['bump-in-range-dependencies'].default,
   shouldInheritGreaterReleaseType = builder['inherit-greater-release-type'].default,
   shouldExcludeDevChanges = builder['exclude-dev-changes'].default,
+  shouldValidateDependencyVisibility = builder['validate-dependency-visibility'].default,
   fromCommit,
   sinceBranch,
   cached,
@@ -36,6 +37,7 @@ async function getNewVersions({
     shouldBumpInRangeDependencies,
     shouldInheritGreaterReleaseType,
     shouldExcludeDevChanges,
+    shouldValidateDependencyVisibility,
   });
 
   let newVersions = {};

package/src/release.js

@@ -30,6 +30,7 @@ async function release({
   shouldBumpInRangeDependencies = builder['bump-in-range-dependencies'].default,
   shouldInheritGreaterReleaseType = builder['inherit-greater-release-type'].default,
   shouldExcludeDevChanges = builder['exclude-dev-changes'].default,
+  shouldValidateDependencyVisibility = builder['validate-dependency-visibility'].default,
   shouldCleanUpAfterFailedPush = builder['clean-up-after-failed-push'].default,
   scripts = builder['scripts'].default,
   packageFiles = builder['package-files'].default,
@@ -77,6 +78,7 @@ async function release({
     shouldBumpInRangeDependencies,
     shouldInheritGreaterReleaseType,
     shouldExcludeDevChanges,
+    shouldValidateDependencyVisibility,
   });
 
   for (let releaseTree of releaseTrees) {