monocart-reporter 1.7.9 → 1.7.10

package/lib/visitor.js

@@ -506,12 +506,13 @@ class Visitor {
 
             if (item.body) {
                 if (!item.path) {
-                    this.saveAttachmentHandler(item, i, caseId);
+                    this.saveAttachmentBodyHandler(item, i, caseId);
                 }
-                delete item.body;
             }
 
+            // text attachment may no path
             if (!item.path) {
+                list.push(item);
                 return;
             }
 
@@ -584,12 +585,38 @@ class Visitor {
     }
 
     contentHandler(item) {
-        if (item.contentType && item.contentType.startsWith('text')) {
+        if (item.content) {
+            return;
+        }
+        if (Util.isTextType(item.contentType)) {
             item.content = Util.readFileSync(item.path);
         }
     }
 
-    saveAttachmentHandler(item, i, caseId) {
+    contentToString(content) {
+        if (typeof content === 'string') {
+            return content;
+        }
+
+        if (Buffer.isBuffer(content)) {
+            return content.toString('utf8');
+        }
+
+        return content.toString();
+    }
+
+    saveAttachmentBodyHandler(item, i, caseId) {
+
+        const content = item.body;
+        delete item.body;
+
+        // if text content no need save file, just show the content
+        const contentType = item.contentType;
+        if (Util.isTextType(contentType)) {
+            // body is buffer
+            item.content = this.contentToString(content);
+            return;
+        }
 
         const attachmentsPath = path.resolve(this.options.outputDir, caseId);
         if (!fs.existsSync(attachmentsPath)) {
@@ -598,21 +625,22 @@ class Visitor {
             });
         }
 
+        // https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
         const types = {
             'text/plain': 'txt',
-            'application/octet-stream': 'data'
+            'application/octet-stream': 'bin'
         };
 
         const filename = sanitize(`${item.name}-${i + 1}`);
 
-        let ext = 'data';
-        const contentType = item.contentType;
+        let ext = 'bin';
         if (contentType) {
             ext = types[contentType] || contentType.split('/').pop().slice(0, 4);
         }
         const filePath = path.resolve(attachmentsPath, `${filename}.${ext}`);
-        fs.writeFileSync(filePath, item.body);
+        fs.writeFileSync(filePath, content);
         item.path = filePath;
+
     }
 
     locationHandler(location) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "monocart-reporter",
-    "version": "1.7.9",
+    "version": "1.7.10",
     "description": "A playwright test reporter. Shows suites/cases/steps with tree style, markdown annotations, custom columns/formatters/data collection visitors, console logs, style tags, send email.",
     "main": "lib/index.js",
     "bin": {