monocart-coverage-reports 2.7.6 → 2.7.8

package/README.md

@@ -16,7 +16,7 @@
 * [Collecting V8 Coverage Data](#collecting-v8-coverage-data)
     - [Collecting V8 Coverage Data with Playwright](#collecting-v8-coverage-data-with-playwright)
     - [Collecting Raw V8 Coverage Data with Puppeteer](#collecting-raw-v8-coverage-data-with-puppeteer)
-    - [Node.js V8 Coverage Report for Server Side](#nodejs-v8-coverage-report-for-server-side)
+    - [Collecting V8 Coverage Data from Node.js](#collecting-v8-coverage-data-from-nodejs)
     - [Collecting V8 Coverage Data with `CDPClient` API](#collecting-v8-coverage-data-with-cdpclient-api)
     - [V8 Coverage Data API](#v8-coverage-data-api)
 * [Using `entryFilter` and `sourceFilter` to filter the results for V8 report](#using-entryfilter-and-sourcefilter-to-filter-the-results-for-v8-report)
@@ -42,6 +42,7 @@
     - [WebdriverIO](#webdriverio)
     - [Storybook Test Runner](#storybook-test-runner)
     - [TestCafe](#testcafe)
+    - [Selenium Webdriver](#selenium-webdriver)
     - [Mocha](#mocha)
     - [tsx](#tsx)
     - [ts-node](#ts-node)
@@ -49,34 +50,37 @@
     - [Codecov](#codecov)
     - [Coveralls](#coveralls)
     - [Sonar Cloud](#sonar-cloud)
+* [Contributing](#contributing)
+* [Changelog](CHANGELOG.md)
 * [Thanks](#thanks)
 
 ## Usage
 > It's recommended to use [Node.js 20+](https://nodejs.org/).
-- [API](#multiprocessing-support)
+- API
 ```js
 const MCR = require('monocart-coverage-reports');
-const coverageOptions = {
+const mcr = MCR({
     name: 'My Coverage Report - 2024-02-28',
     outputDir: './coverage-reports',
-    reports: ["v8", "console-details"]
-}
-const mcr = MCR(coverageOptions);
-mcr.cleanCache();
-
-await mcr.add(coverageData1);
-await mcr.add(coverageData2);
-
+    reports: ["v8", "console-details"],
+    cleanCache: true
+});
+await mcr.add(coverageData);
 await mcr.generate();
-
-// Or 
-// const { CoverageReport } = require('monocart-coverage-reports');
-// const mcr = new CoverageReport(coverageOptions);
 ```
-- [CLI](#command-line)
+Using `import` and load options from [config file](#config-file)
+```js
+import { CoverageReport } from 'monocart-coverage-reports';
+const mcr = new CoverageReport();
+await mcr.loadConfig();
+```
+For more information, see [Multiprocessing Support](#multiprocessing-support)
+
+- CLI
 ```sh
 mcr node my-app.js -r v8,console-details
 ```
+For more information, see [Command Line](#command-line)
 
 ## Options
 - Default Options: [lib/default/options.js](./lib/default/options.js)
@@ -109,7 +113,7 @@ mcr node my-app.js -r v8,console-details
 - `v8-json`
     - [V8 coverage-report.json](https://cenfun.github.io/monocart-coverage-reports/v8-and-istanbul/coverage-report.json)
 
-> Istanbul build-in reports (both V8 and istanbul data):
+> Istanbul build-in reports (both V8 and Istanbul data):
 
 - `clover`
 - `cobertura`
@@ -129,7 +133,7 @@ mcr node my-app.js -r v8,console-details
 - `text-lcov`
 - `text-summary`
 
-> Other build-in reports (both V8 and istanbul data):
+> Other build-in reports (both V8 and Istanbul data):
 
 - `codecov`
     - coverage data for [Codecov](https://docs.codecov.com/docs/codecov-custom-coverage-format), see [example](https://app.codecov.io/github/cenfun/monocart-coverage-reports) 
@@ -163,9 +167,9 @@ mcr node my-app.js -r v8,console-details
         ]
     }
     ```
-    - istanbul custom reporter
+    - Istanbul custom reporter
     > example: [./test/custom-istanbul-reporter.js](./test/custom-istanbul-reporter.js), see [istanbul built-in reporters' implementation](https://github.com/istanbuljs/istanbuljs/tree/master/packages/istanbul-reports/lib) for reference.
-    - v8 custom reporter
+    - V8 custom reporter
     > example: [./test/custom-v8-reporter.js](./test/custom-v8-reporter.js)
 
 ### Multiple Reports:
@@ -194,11 +198,9 @@ const coverageOptions = {
         }],
         // Specify reporter name with local path
         ['/absolute/path/to/custom-reporter.js']
-
     ]
 }
 const mcr = MCR(coverageOptions);
-mcr.cleanCache();
 ```
 
 ## Compare Reports
@@ -216,29 +218,35 @@ mcr.cleanCache();
 | Minified code | ❌ | ✅ | ❌ |
 
 ## Collecting Istanbul Coverage Data
-- Instrumenting source code
-    > Before collecting Istanbul coverage data, It requires your source code is instrumented with Istanbul
-    - webpack: [babel-plugin-istanbul](https://github.com/istanbuljs/babel-plugin-istanbul), example: [webpack.config-istanbul.js](./test/webpack.config-istanbul.js)
-    - rollup: [rollup-plugin-istanbul](https://github.com/artberri/rollup-plugin-istanbul)
+- Before coverage collection: Instrumenting source code with Istanbul
+    - webpack with babel loader: [babel-plugin-istanbul](https://github.com/istanbuljs/babel-plugin-istanbul), see example: [webpack.config-istanbul.js](./test/build/webpack.config-istanbul.js)
+    - CLI: [nyc instrument](https://github.com/istanbuljs/nyc/blob/master/docs/instrument.md) or API: [istanbul-lib-instrument](https://github.com/istanbuljs/istanbuljs/blob/main/packages/istanbul-lib-instrument/api.md)
     - vite: [vite-plugin-istanbul](https://github.com/ifaxity/vite-plugin-istanbul)
+    - rollup: [rollup-plugin-istanbul](https://github.com/artberri/rollup-plugin-istanbul)
+    - swc: [swc-plugin-coverage-instrument](https://github.com/kwonoj/swc-plugin-coverage-instrument)
+
 - Browser
     - Collecting coverage data from `window.__coverage__`, example: [test-istanbul.js](./test/test-istanbul.js)
+
 - Node.js
     - Collecting coverage data from `global.__coverage__`
 
+- CDP
+    - `getIstanbulCoverage()` see [`CDPClient` API](#collecting-v8-coverage-data-with-cdpclient-api)
+
 ## Collecting V8 Coverage Data
-- Sourcemap for source code: enable `sourcemap` and do not compress/minify:
-    - [webpack](https://webpack.js.org/configuration/): `devtool: source-map` and `mode: development`, example [webpack.config-v8.js](./test/webpack.config-v8.js)
-    - [rollup](https://rollupjs.org/configuration-options/): `sourcemap: true`
+- Before coverage collection: Enabling `sourcemap` for source code
+    - [webpack](https://webpack.js.org/configuration/): `devtool: source-map` and `mode: development`, example [webpack.config-v8.js](./test/build/webpack.config-v8.js)
+    - [rollup](https://rollupjs.org/configuration-options/): `sourcemap: true` and `treeshake: false`
+    - [esbuild](https://esbuild.github.io/api/): `sourcemap: true`, `treeShaking: false` and `minify: false`
     - [vite](https://vitejs.dev/config/build-options.html): `sourcemap: true` and `minify: false`
-    - [esbuild](https://esbuild.github.io/api/): `sourcemap: true` and `minify: false`
 
-- Browser (Chromium Only)
+- Browser (Chromium-based Only)
     - [Collecting V8 Coverage Data with Playwright](#collecting-v8-coverage-data-with-playwright)
     - [Collecting Raw V8 Coverage Data with Puppeteer](#collecting-raw-v8-coverage-data-with-puppeteer)
 
 - Node.js
-    - [Node.js V8 Coverage Report for Server Side](#nodejs-v8-coverage-report-for-server-side)
+    - [Collecting V8 Coverage Data from Node.js](#collecting-v8-coverage-data-from-nodejs)
 
 - CDP
     - [Collecting V8 Coverage Data with `CDPClient` API](#collecting-v8-coverage-data-with-cdpclient-api)
@@ -264,7 +272,7 @@ const [jsCoverage, cssCoverage] = await Promise.all([
 const coverageData = [... jsCoverage, ... cssCoverage];
 
 ```
-see [./test/test-v8.js](./test/test-v8.js), and [anonymous](./test/test-anonymous.js), [css](./test/test-css.js)
+For more examples, see [./test/test-v8.js](./test/test-v8.js), and [anonymous](./test/test-anonymous.js), [css](./test/test-css.js)
 
 ### Collecting Raw V8 Coverage Data with Puppeteer
 ```js
@@ -294,9 +302,9 @@ const coverageData = [... jsCoverage.map((it) => {
     };
 }), ... cssCoverage];
 ```
-see example: [./test/test-puppeteer.js](./test/test-puppeteer.js)
+Example: [./test/test-puppeteer.js](./test/test-puppeteer.js)
 
-### Node.js V8 Coverage Report for Server Side
+### Collecting V8 Coverage Data from Node.js
 Possible solutions:
 - [NODE_V8_COVERAGE](https://nodejs.org/docs/latest/api/cli.html#node_v8_coveragedir)=`dir`
     - Sets Node.js env `NODE_V8_COVERAGE`=`dir` before the program running, the coverage data will be saved to the `dir` after the program exits gracefully.
@@ -330,7 +338,27 @@ Possible solutions:
     - see [Command Line](#command-line)
 
 ### Collecting V8 Coverage Data with `CDPClient` API
-- Work with node debugger `--inspect=9229`
+- `CDPClient` available APIs
+```js
+startJSCoverage: () => Promise<void>;
+stopJSCoverage: () => Promise<V8CoverageEntry[]>;
+
+startCSSCoverage: () => Promise<void>;
+stopCSSCoverage: () => Promise<V8CoverageEntry[]>;
+
+/** start both js and css coverage */
+startCoverage: () => Promise<void>;
+/** stop and return both js and css coverage */
+stopCoverage: () => Promise<V8CoverageEntry[]>;
+
+/** write the coverage started by NODE_V8_COVERAGE to disk on demand, returns v8 coverage dir */
+writeCoverage: () => Promise<string>;
+
+/** get istanbul coverage data */
+getIstanbulCoverage: (coverageKey?: string) => Promise<any>;
+```
+
+- Work with node debugger port `--inspect=9229` or browser debugging port `--remote-debugging-port=9229`
 ```js
 const MCR = require('monocart-coverage-reports');
 const client = await MCR.CDPClient({
@@ -340,6 +368,7 @@ await client.startJSCoverage();
 // run your test here
 const coverageData = await client.stopJSCoverage();
 ```
+
 - Work with [Playwright CDPSession](https://playwright.dev/docs/api/class-cdpsession)
 ```js
 const { chromium } = require('playwright');
@@ -356,6 +385,7 @@ await client.startCoverage();
 await page.goto("your page url");
 const coverageData = await client.stopCoverage();
 ```
+
 - Work with [Puppeteer CDPSession](https://pptr.dev/api/puppeteer.cdpsession)
 ```js
 const puppeteer = require('puppeteer');
@@ -373,11 +403,23 @@ await page.goto("your page url");
 const coverageData = await client.stopCoverage();
 ```
 
+- Work with [Selenium Webdriver](https://www.selenium.dev/documentation/webdriver/) WebSocket (Chrome/Edge Browser)
+```js
+const { Builder, Browser } = require('selenium-webdriver');
+const MCR = require('monocart-coverage-reports');
+const driver = await new Builder().forBrowser(Browser.CHROME).build();
+const pageCdpConnection = await driver.createCDPConnection('page');
+const session = new MCR.WSSession(pageCdpConnection._wsConnection);
+const client = await MCR.CDPClient({
+    session
+})
+```
+
 ### V8 Coverage Data API
-- [V8 coverage report](https://v8.dev/blog/javascript-code-coverage) - Native support for JavaScript code coverage to V8. (Chromium only)
+- [JavaScript code coverage in V8](https://v8.dev/blog/javascript-code-coverage)
 - [Playwright Coverage Class](https://playwright.dev/docs/api/class-coverage)
-- [Puppeteer Coverage class](https://pptr.dev/api/puppeteer.coverage)
-- [DevTools Protocol for Coverage](https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#method-startPreciseCoverage) see devtools-protocol [ScriptCoverage](https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#type-ScriptCoverage) and [v8-coverage](https://github.com/bcoe/v8-coverage)
+- [Puppeteer Coverage Class](https://pptr.dev/api/puppeteer.coverage)
+- [DevTools Protocol for Coverage](https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#method-startPreciseCoverage) see [ScriptCoverage](https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#type-ScriptCoverage) and [v8-coverage](https://github.com/bcoe/v8-coverage)
 ```js
 // Coverage data for a source range.
 export interface CoverageRange {
@@ -388,7 +430,6 @@ export interface CoverageRange {
     // Collected execution count of the source range.
     count: integer;
 }
-
 // Coverage data for a JavaScript function.
 /**
  * @functionName can be an empty string.
@@ -405,7 +446,6 @@ export interface FunctionCoverage {
     // Whether coverage data for this function has block granularity.
     isBlockCoverage: boolean;
 }
-
 // Coverage data for a JavaScript script.
 export interface ScriptCoverage {
     // JavaScript script id.
@@ -415,32 +455,31 @@ export interface ScriptCoverage {
     // Functions contained in the script that has coverage data.
     functions: FunctionCoverage[];
 }
-
 export type V8CoverageData = ScriptCoverage[];
 ```
 
 ## Using `entryFilter` and `sourceFilter` to filter the results for V8 report
 When V8 coverage data collected, it actually contains the data of all entry files, for example:
-```
-dist/main.js
-dist/vendor.js
-dist/something-else.js
-```
+
+- *dist/main.js*
+- *dist/vendor.js*
+- *dist/something-else.js*
+
 We can use `entryFilter` to filter the entry files. For example, we should remove `vendor.js` and `something-else.js` if they are not in our coverage scope. 
-```
-dist/main.js
-```
+
+- *dist/main.js*
+
 When inline or linked sourcemap exists to the entry file, the source files will be extracted from the sourcemap for the entry file, and the entry file will be removed if `logging` is not `debug`.
-```
-> src/index.js
-> src/components/app.js
-> node_modules/dependency/dist/dependency.js
-```
+
+- *src/index.js*
+- *src/components/app.js*
+- *node_modules/dependency/dist/dependency.js*
+
 We can use `sourceFilter` to filter the source files. For example, we should remove `dependency.js` if it is not in our coverage scope.
-```
-> src/index.js
-> src/components/app.js
-```
+
+- *src/index.js*
+- *src/components/app.js*
+
 For example:
 ```js
 const coverageOptions = {
@@ -600,7 +639,6 @@ mcr.cleanCache();
 const MCR = require('monocart-coverage-reports');
 const coverageOptions = require('path-to/same-options.js');
 const mcr = MCR(coverageOptions);
-// do not clean cache in the stage
 await mcr.add(coverageData1);
 ```
 
@@ -609,7 +647,6 @@ await mcr.add(coverageData1);
 const MCR = require('monocart-coverage-reports');
 const coverageOptions = require('path-to/same-options.js');
 const mcr = MCR(coverageOptions);
-// do not clean cache in the stage
 await mcr.add(coverageData2);
 ```
 
@@ -619,7 +656,6 @@ await mcr.add(coverageData2);
 const MCR = require('monocart-coverage-reports');
 const coverageOptions = require('path-to/same-options.js');
 const mcr = MCR(coverageOptions);
-// do not clean cache before generating reports
 await mcr.generate();
 ```
 
@@ -629,13 +665,13 @@ await mcr.generate();
 - Installing globally
 ```sh
 npm i monocart-coverage-reports -g
-mcr node ./test/specs/node.test.js -r v8,console-summary --lcov
+mcr node ./test/specs/node.test.js -r v8,console-details --lcov
 ```
 
 - Locally in your project
 ```sh
 npm i monocart-coverage-reports
-npx mcr node ./test/specs/node.test.js -r v8,console-summary --lcov
+npx mcr node ./test/specs/node.test.js -r v8,console-details --lcov
 ```
 
 - CLI Options
@@ -671,6 +707,12 @@ Options:
 mcr -c mcr.config.js -- sub-cli -c sub-cli.config.js
 ```
 
+- Examples
+    - [Mocha](#mocha)
+    - [tsx](#tsx)
+    - [ts-node](#ts-node)
+    - [AVA](#ava)
+
 ## Config File
 Loading config file by priority:
 - Custom config file:
@@ -692,6 +734,7 @@ The following usage scenarios may require merging coverage reports:
 
 If the reports cannot be merged automatically, then here is how to manually merge the reports.
 First, using the `raw` report to export the original coverage data to the specified directory.
+For example, we have `raw` coverage data from unit tests:
 ```js
 const coverageOptions = {
     name: 'My Unit Test Coverage Report',
@@ -699,15 +742,18 @@ const coverageOptions = {
     reports: [
         ['raw', {
             // relative path will be "./coverage-reports/unit/raw"
+            // defaults to raw
             outputDir: "raw"
         }],
         ['v8'],
-        ['console-summary']
+        ['console-details']
     ]
 };
 ```
-Then, after all the tests are completed, generate a merged report with option `inputDir`:
+We also have `raw` coverage data from e2e tests, which is output to `./coverage-reports/e2e/raw`.
+After all the tests are completed, generate a merged report with option `inputDir`:
 ```js
+// merge-coverage.js
 const fs = require('fs');
 const { CoverageReport } = require('monocart-coverage-reports');
 const inputDir = [
@@ -731,6 +777,10 @@ const coverageOptions = {
     
     sourcePath: (filePath, info) => {
         // Unify the file path for the same files
+        // For example, the file index.js has different paths:
+        // unit: unit-dist/src/index.js
+        // e2e: e2e-dist/src/index.js
+        // return filePath.replace("unit-dist/", "").replace("e2e-dist/", "")
         return filePath;
     },
 
@@ -741,12 +791,12 @@ const coverageOptions = {
     
     onEnd: () => {
         // remove the raw files if it useless
-        inputDir.forEach((p) => {
-            fs.rmSync(p, {
-                recursive: true,
-                force: true
-            });
-        });
+        // inputDir.forEach((p) => {
+        //     fs.rmSync(p, {
+        //         recursive: true,
+        //         force: true
+        //     });
+        // });
     }
 };
 await new CoverageReport(coverageOptions).generate();
@@ -763,7 +813,7 @@ const a = tf ? 'true' : 'false';
 `m1` and `m2` are two consecutive mappings, `p` is the position we looking for. However, we can only get the position of the `m1` or `m2` if we don't fix it to `p`. Especially the generated code is different from the original code, such as the code was minified, compressed or converted, it is difficult to find the exact position. You can try [Debug for Coverage and Sourcemap](#debug-for-coverage-and-sourcemap)
 
 How `MCR` Works:
-- 1, Trying to fix the middle position if not found the exact mapping for the position. However, for non-JS code, such as Vue template, JSX, etc., it might be hard to find a perfect solution.
+- 1, Trying to fix the middle original position with string comparison and [`diff-sequences`](https://github.com/jestjs/jest/tree/main/packages/diff-sequences). However, for non-JS code, such as Vue template, JSX, etc., it might be hard to find a perfect solution.
 - 2, Finding all functions, statements and branches by parsing the source code [AST](https://github.com/acornjs/acorn). However, there's a small issue, which is the V8 cannot provide effective branch coverage information for `AssignmentPattern`.
 
 
@@ -795,7 +845,7 @@ const coverageOptions = {
     logging: 'debug',
     reports: [
         ['v8'],
-        ['console-summary']
+        ['console-details']
     ]
 };
 ```
@@ -818,6 +868,7 @@ When `logging` is `debug`, the raw report data will be preserved in `[outputDir]
 ## Integration Examples
 
 ### [Playwright](https://github.com/microsoft/playwright)
+- [playwright-coverage](https://github.com/cenfun/playwright-coverage) - A Example for Playwright Coverage Reports
 - [monocart-reporter](https://github.com/cenfun/monocart-reporter) - A Playwright custom reporter, supports generating [Code Coverage Report](https://github.com/cenfun/monocart-reporter?#code-coverage-report)
 - Coverage for component testing:
     - [playwright-ct-vue](https://github.com/cenfun/playwright-ct-vue)
@@ -829,6 +880,7 @@ When `logging` is `debug`, the raw report data will be preserved in `[outputDir]
 
 ### [Jest](https://github.com/jestjs/jest/)
 - [jest-monocart-coverage](https://github.com/cenfun/jest-monocart-coverage) - A Jest custom reporter for coverage reports
+- [jest-puppeteer-coverage](https://github.com/cenfun/jest-puppeteer-coverage) - A Jest Puppeteer Coverage Example
 - Example for Jest (unit) + Puppeteer (e2e) + Codecov: [maplibre-gl-js](https://github.com/maplibre/maplibre-gl-js)
 
 ### [Vitest](https://github.com/vitest-dev/vitest)
@@ -850,6 +902,9 @@ When `logging` is `debug`, the raw report data will be preserved in `[outputDir]
 ### [TestCafe](https://github.com/DevExpress/testcafe)
 - [testcafe-reporter-coverage](https://github.com/cenfun/testcafe-reporter-coverage) - A TestCafe custom reporter for coverage reports
 
+### [Selenium Webdriver](https://github.com/seleniumhq/selenium)
+- [selenium-webdriver-coverage](https://github.com/cenfun/selenium-webdriver-coverage) - Selenium Webdriver V8 Coverage Example
+
 ### [Mocha](https://github.com/mochajs/mocha)
 ```sh
 mcr mocha ./test/**/*.js
@@ -927,6 +982,18 @@ const coverageOptions = {
         -Dsonar.exclusions=dist/*,packages/*
 ```
 
+## Contributing
+```sh
+# Node.js 20+
+npm install starfall-cli -g
+npm install
+
+npm run build
+npm run test
+
+npm run dev
+```
+
 ### VSCode Extension
 - [Coverage Gutters](https://github.com/ryanluker/vscode-coverage-gutters) - Display test coverage generated by lcov or xml in VSCode editor.
 

package/lib/cli.js

@@ -21,25 +21,12 @@ const getRegisterPath = (filename) => {
     return `./${rel}`;
 };
 
-const isFeatureSupported = (nv) => {
-    // module register added in Node.js: v20.6.0
-    const [major, minor] = nv.split('.').map((s) => parseInt(s));
-    if (major < 20) {
-        return false;
-    }
-    if (major > 20) {
-        return true;
-    }
-    if (minor < 6) {
-        return false;
-    }
-    return true;
-};
-
 const initNodeOptions = async (cliOptions) => {
+
+    // module register added in Node.js: v20.6.0
     const nv = process.versions.node;
-    if (!isFeatureSupported(nv)) {
-        Util.logInfo(EC.yellow(`The current Node.js version "${nv}" does NOT support "module.register", it requires "20.6.0" or higher.`));
+    if (Util.cmpVersion(nv, '20.6.0') < 0) {
+        Util.logInfo(`The current Node.js version "${nv}" does NOT support "module.register", it requires "20.6.0" or higher.`);
         return;
     }
 

package/lib/client/cdp-client.js

@@ -12,10 +12,7 @@ const getDebuggerUrl = async (options) => {
     const protocol = options.secure ? 'https' : 'http';
 
     const url = `${protocol}://${options.host}:${options.port}/json/list`;
-    const [err, res] = await Util.request({
-        url,
-        timeout: options.timeout
-    });
+    const [err, res] = await Util.request(url);
     if (err) {
         return [err];
     }

package/lib/client/coverage-client.js

@@ -131,19 +131,22 @@ class CoverageClient {
         unbindEvents(this.session, this.jsEvents);
         this.jsEvents = null;
 
-        const jsCoverage = profileResponse.result;
-        // console.log('coverageList', coverageList);
+        const jsCoverage = [];
 
-        jsCoverage.forEach((entry) => {
-            // anonymous url
-            entry.url = entry.url || '';
-            // add source
-            const source = this.scriptSources.get(entry.scriptId);
-            if (!source) {
-                Util.logDebug(`Not found js source: ${entry.url}`);
-            }
-            entry.source = source || '';
-        });
+        // console.log('coverageList', coverageList);
+        if (profileResponse && profileResponse.result) {
+            profileResponse.result.forEach((entry) => {
+                // anonymous url
+                entry.url = entry.url || '';
+                // add source
+                const source = this.scriptSources.get(entry.scriptId);
+                if (!source) {
+                    Util.logDebug(`Not found js source: ${entry.url}`);
+                }
+                entry.source = source || '';
+                jsCoverage.push(entry);
+            });
+        }
 
         this.scriptSources.clear();
         this.enabledJS = false;
@@ -239,22 +242,39 @@ class CoverageClient {
     }
 
     async stopCoverage() {
+        if (!this.session) {
+            return;
+        }
         const [jsCoverage, cssCoverage] = await Promise.all([
             this.stopJSCoverage(),
             this.stopCSSCoverage()
         ]);
-        return [... jsCoverage, ... cssCoverage];
+        // could be undefined
+        let coverageList = [];
+        if (jsCoverage) {
+            coverageList = coverageList.concat(jsCoverage);
+        }
+        if (cssCoverage) {
+            coverageList = coverageList.concat(cssCoverage);
+        }
+        return coverageList;
     }
 
     // =================================================================================================
     // write the coverage started by NODE_V8_COVERAGE to disk on demand
     async writeCoverage() {
-        // // enable and start v8 coverage
+        if (!this.session) {
+            return;
+        }
+
         await this.session.send('Runtime.enable');
 
-        //  write the coverage started by NODE_V8_COVERAGE to disk on demand
+        // write the coverage started by NODE_V8_COVERAGE to disk on demand
         const res = await this.session.send('Runtime.evaluate', {
-            expression: 'new Promise(resolve=>{ require("v8").takeCoverage(); resolve(process.env.NODE_V8_COVERAGE); })',
+            expression: `new Promise((resolve) => { 
+                require("v8").takeCoverage();
+                resolve(process.env.NODE_V8_COVERAGE);
+            })`,
             includeCommandLineAPI: true,
             returnByValue: true,
             awaitPromise: true
@@ -262,7 +282,31 @@ class CoverageClient {
 
         await this.session.send('Runtime.disable');
 
-        return res.result.value;
+        return res && res.result && res.result.value;
+    }
+
+    // get istanbul coverage data
+    async getIstanbulCoverage(coverageKey = '__coverage__') {
+        if (!this.session) {
+            return;
+        }
+
+        await this.session.send('Runtime.enable');
+
+        // both browser and Node.js
+        const res = await this.session.send('Runtime.evaluate', {
+            expression: `new Promise((resolve) => { 
+                const globalTarget = typeof window !== 'undefined' ? window : global;
+                resolve(globalTarget['${coverageKey}']);
+            })`,
+            includeCommandLineAPI: true,
+            returnByValue: true,
+            awaitPromise: true
+        });
+
+        await this.session.send('Runtime.disable');
+
+        return res && res.result && res.result.value;
     }
 
     // =================================================================================================
@@ -270,10 +314,8 @@ class CoverageClient {
         if (!this.session) {
             return;
         }
-
         await this.session.detach();
         this.session = null;
-
     }
 }
 

package/lib/converter/collect-source-maps.js

@@ -19,9 +19,7 @@ const loadSourceMap = async (url = '') => {
         return JSON.parse(content);
     }
 
-    const [err, res] = await Util.request({
-        url
-    });
+    const [err, res] = await Util.request(url);
 
     if (err) {
         Util.logDebug(EC.red(`${err.message} ${url}`));