monocart-coverage-reports 2.6.2 → 2.6.4

package/README.md

@@ -33,6 +33,7 @@
     - [Using `v8-to-istanbul`](#using-v8-to-istanbul)
     - [How Monocart Works](#how-monocart-works)
 * [Debug for Coverage and Sourcemap](#debug-for-coverage-and-sourcemap)
+* [Common issues](#common-issues)
 * [Integration](#integration)
     - [Playwright](#playwright)
     - [Jest](#jest)
@@ -258,16 +259,19 @@ const coverageOptions = {
 
 ## `mcr` CLI
 > The CLI will run the program as a [child process](https://nodejs.org/docs/latest/api/child_process.html) with `NODE_V8_COVERAGE=dir` until it exits gracefully, and generate the coverage report with the coverage data from the `dir`.
+
 - Installing globally
 ```sh
 npm i monocart-coverage-reports -g
-mcr node ./test/test-node-env.js -r v8,console-summary --lcov
+mcr node ./test/specs/node.test.js -r v8,console-summary --lcov
 ```
+
 - Locally in your project
 ```sh
 npm i monocart-coverage-reports
-npx mcr node ./test/test-node-env.js -r v8,console-summary --lcov
+npx mcr node ./test/specs/node.test.js -r v8,console-summary --lcov
 ```
+
 - CLI Options
 ```sh
 Usage: mcr [options] <command>
@@ -279,10 +283,11 @@ Arguments:
 
 Options:
   -V, --version                output the version number
-  -c, --config <path>          custom config path
-  -o, --outputDir <dir>        output dir for reports
-  -r, --reports <name[,name]>  coverage reports to use
+  -c, --config <path>          custom config file path
+  --logging <logging>          off, error, info, debug
   -n, --name <name>            report name for title
+  -r, --reports <name[,name]>  coverage reports to use
+  -o, --outputDir <dir>        output dir for reports
   -i, --inputDir <dir>         input dir for merging raw files
   --entryFilter <pattern>      entry url filter
   --sourceFilter <pattern>     source path filter
@@ -290,19 +295,20 @@ Options:
   --inline                     inline html for v8 report
   --assetsPath <path>          assets path if not inline
   --lcov                       generate lcov.info file
-  --logging <logging>          off, error, info, debug
   -h, --help                   display help for command
 ```
-- Loading default configuration file
-    - `.mcrrc`
-    - `mcr.config.json`
-    - `mcr.config.mjs`
-    - `mcr.config.cjs`
+
+- Loading config file by priority:
+    - custom config file with `-c` or `--config`
     - `mcr.config.js`
-- Or loading custom configuration file with `-c` or `--config`
-```sh
-mcr node ./test.js -c path-to/my-custom-config.js
-```
+    - `mcr.config.cjs`
+    - `mcr.config.mjs`
+    - `mcr.config.json` - json format
+    - `.mcrrc.js`
+    - `.mcrrc` - json format
+    - `mcr.config.ts` - it requires `NODE_OPTIONS="--loader ts-node/esm"`
+
+- Working with `ts-node`, see [mcr-ts-node](https://github.com/cenfun/mcr-ts-node)
 
 ## Compare Reports
 | | Istanbul | V8 | V8 to Istanbul |
@@ -699,6 +705,28 @@ When `logging` is `debug`, the raw report data will be preserved in `[outputDir]
 
 ![](./assets/debug-sourcemap.png)
 
+## Common issues
+- `Unparsable source`
+
+It happens during the parsing of the source code into AST, if the source code is not in the standard ECMAScript. For example `ts`, `jsx` and so on. There is a option to fix it, which is to manually compile the source code for these files.
+```js
+import * as fs from "fs";
+import * as path from "path";
+import { fileURLToPath } from "url";
+import * as TsNode from 'ts-node';
+const coverageOptions = {
+    onEntry: async (entry) => {
+        const filePath = fileURLToPath(entry.url)
+        const originalSource = fs.readFileSync(filePath).toString("utf-8");
+        const fileName = path.basename(filePath);
+        const tn = TsNode.create({});
+        const source = tn.compile(originalSource, fileName);
+        entry.fake = false;
+        entry.source = source;
+    }
+}
+```
+
 ## Integration
 
 ### [Playwright](https://github.com/microsoft/playwright)

package/lib/cli.js

@@ -3,7 +3,7 @@
 const fs = require('fs');
 const path = require('path');
 const EC = require('eight-colors');
-const { fileURLToPath, pathToFileURL } = require('url');
+const { fileURLToPath } = require('url');
 
 const {
     foregroundChild,
@@ -12,93 +12,10 @@ const {
 
 const MCR = require('./index.js');
 const Util = require('./utils/util.js');
-const defaultOptions = require('./default/options.js');
 const { resolveSourceMap } = require('./converter/collect-source-maps.js');
 
 const version = require('../package.json').version;
 
-const cleanDir = (dir) => {
-    Util.rmSync(dir);
-};
-
-const resolveConfigPath = (customConfigPath) => {
-
-    const configList = [
-        '.mcrrc',
-        'mcr.config.json',
-        'mcr.config.mjs',
-        'mcr.config.cjs',
-        'mcr.config.js'
-    ];
-
-    if (customConfigPath) {
-        configList.push(customConfigPath);
-    }
-
-    const existsList = configList.filter((p) => fs.existsSync(p));
-    if (!existsList.length) {
-        return;
-    }
-
-    // last one
-    const configPath = existsList.pop();
-    Util.logInfo(`Config: ${EC.cyan(configPath)}`);
-
-    return configPath;
-};
-
-const resolveConfigOptions = async (configPath) => {
-
-    // json format
-    const ext = path.extname(configPath);
-    if (ext === '.json' || configPath.slice(-2) === 'rc') {
-        return JSON.parse(Util.readFileSync(configPath));
-    }
-
-    let configOptions;
-    let err;
-    try {
-        configOptions = await import(pathToFileURL(configPath));
-    } catch (ee) {
-        err = ee;
-    }
-
-    if (!configOptions) {
-        Util.logError(`ERROR: failed to import "${configPath}" ${err.message} `);
-        return;
-    }
-
-    configOptions = configOptions.default || configOptions;
-
-    return configOptions;
-};
-
-const initOptions = async (cliOptions) => {
-
-    const configPath = resolveConfigPath(cliOptions.config);
-    if (configPath) {
-        const configOptions = await resolveConfigOptions(configPath);
-        if (configOptions) {
-            cliOptions = {
-                ... configOptions,
-                ... cliOptions
-            };
-        }
-    }
-
-    // report options
-    const options = {
-        ... defaultOptions
-    };
-    Object.keys(cliOptions).forEach((k) => {
-        if (Util.hasOwn(options, k)) {
-            options[k] = cliOptions[k];
-        }
-    });
-
-    return options;
-};
-
 const resolveEntrySource = (entry, sourceMapCache = {}) => {
     let source;
     const filePath = fileURLToPath(entry.url);
@@ -107,7 +24,7 @@ const resolveEntrySource = (entry, sourceMapCache = {}) => {
         source = fs.readFileSync(filePath).toString('utf8');
     }
 
-    // not for typescript
+    // not for typescript, but it could be jsx even it is `.js`
     if (source && !['.ts', '.tsx'].includes(extname)) {
         entry.source = source;
         return;
@@ -118,7 +35,6 @@ const resolveEntrySource = (entry, sourceMapCache = {}) => {
 
     // for fake source file (can not parse to AST)
     if (lineLengths) {
-        // get runtime code with ts-node
         let fakeSource = '';
         sourcemapData.lineLengths.forEach((length) => {
             fakeSource += `${''.padEnd(length, '*')}\n`;
@@ -142,7 +58,7 @@ const resolveEntrySourceMap = (entry, sourceMapCache = {}) => {
     }
 };
 
-const collectCoverageData = (coverageList, entryFilterHandler, sourceMapCache = {}) => {
+const collectCoverageData = (coverageList, entryFilter, sourceMapCache = {}) => {
 
     if (!Util.isList(coverageList)) {
         return;
@@ -150,7 +66,7 @@ const collectCoverageData = (coverageList, entryFilterHandler, sourceMapCache =
 
     // filter node internal files
     coverageList = coverageList.filter((entry) => entry.url && entry.url.startsWith('file:'));
-    coverageList = coverageList.filter(entryFilterHandler);
+    coverageList = coverageList.filter(entryFilter);
 
     if (!Util.isList(coverageList)) {
         return;
@@ -164,57 +80,87 @@ const collectCoverageData = (coverageList, entryFilterHandler, sourceMapCache =
     return coverageList;
 };
 
-const executeCommand = async (command, cliOptions) => {
+const addCoverageData = async (coverageReport, nodeV8CoverageDir) => {
 
-    const options = await initOptions(cliOptions);
+    let added = false;
 
-    Util.logInfo(`Execute: ${EC.cyan(command)}`);
-    // console.log(options);
+    const files = fs.readdirSync(nodeV8CoverageDir);
+    if (!files.length) {
+        return added;
+    }
 
-    const nodeV8CoverageDir = path.resolve(options.outputDir, '.v8-coverage');
-    process.env.NODE_V8_COVERAGE = nodeV8CoverageDir;
+    // filter before adding
+    const entryFilter = coverageReport.getEntryFilter();
+    for (const filename of files) {
+        const filePath = path.resolve(nodeV8CoverageDir, filename);
+        const content = fs.readFileSync(filePath).toString('utf-8');
+        if (content) {
+            const json = JSON.parse(content);
+            const coverageList = json.result;
+            const sourceMapCache = json['source-map-cache'];
+            const coverageData = collectCoverageData(coverageList, entryFilter, sourceMapCache);
+            if (coverageData) {
+                await coverageReport.add(coverageData);
+                added = true;
+            }
+        }
+    }
 
-    cleanDir(nodeV8CoverageDir);
+    return added;
+};
 
-    // console.log('nodeV8CoverageDir', nodeV8CoverageDir);
+const executeCommand = async (command, cliOptions) => {
 
-    const coverageReport = MCR(options);
+    Util.logInfo(`Execute: ${EC.cyan(command)}`);
+
+    // console.log(options);
+    const coverageReport = MCR(cliOptions);
+    await coverageReport.loadConfig(cliOptions.config);
     coverageReport.cleanCache();
 
-    // on start hook
-    const onStart = cliOptions.onStart;
+    const coverageOptions = coverageReport.options;
+
+    // dir for node v8 coverage
+    const nodeV8CoverageDir = Util.relativePath(path.resolve(coverageOptions.outputDir, '.v8-coverage'));
+    process.env.NODE_V8_COVERAGE = nodeV8CoverageDir;
+    // clean v8 cache before running
+    Util.rmSync(nodeV8CoverageDir);
+    // Util.logInfo(`V8 coverage dir: ${EC.cyan(nodeV8CoverageDir)}`);
+
+    // =========================================
+    // onStart hook
+    const onStart = coverageOptions.onStart;
     if (typeof onStart === 'function') {
         await onStart(coverageReport);
     }
+    // =========================================
 
-    foregroundChild(command, {
+    const subprocess = foregroundChild(command, {
         shell: true
-    }, async () => {
+    }, async (code, signal) => {
+
+        // generate coverage even it is failed. code != 0
 
         if (!fs.existsSync(nodeV8CoverageDir)) {
-            EC.logRed(`Not found coverage data: ${Util.relativePath(nodeV8CoverageDir)}`);
+            EC.logRed(`Not found V8 coverage dir: ${Util.relativePath(nodeV8CoverageDir)}`);
             return 1;
         }
 
-        const entryFilterHandler = coverageReport.getEntryFilter();
-
-        const files = fs.readdirSync(nodeV8CoverageDir);
-        for (const filename of files) {
-            const content = fs.readFileSync(path.resolve(nodeV8CoverageDir, filename)).toString('utf-8');
-            const json = JSON.parse(content);
-            const coverageList = json.result;
-            const sourceMapCache = json['source-map-cache'];
-            const coverageData = await collectCoverageData(coverageList, entryFilterHandler, sourceMapCache);
-            if (coverageData) {
-                await coverageReport.add(coverageData);
-            }
+        // =========================================
+        // onReady hook before adding coverage data.
+        // Sometimes, the child process has not yet finished writing the coverage data, and it needs to wait here.
+        const onReady = coverageOptions.onReady;
+        if (typeof onReady === 'function') {
+            await onReady(coverageReport, nodeV8CoverageDir, subprocess);
         }
+        // =========================================
 
+        await addCoverageData(coverageReport, nodeV8CoverageDir);
         await coverageReport.generate();
 
         // remove nodeV8CoverageDir
-        if (options.logging !== 'debug') {
-            cleanDir(nodeV8CoverageDir);
+        if (!Util.isDebug()) {
+            Util.rmSync(nodeV8CoverageDir);
         }
 
         return process.exitCode;
@@ -222,16 +168,23 @@ const executeCommand = async (command, cliOptions) => {
 
 };
 
+process.on('uncaughtException', function(err) {
+    Util.logError(`ERROR: ${err.message || err}`);
+});
+
 program
     .name('mcr')
     .description('CLI to generate coverage reports')
     .version(version)
     .argument('<command>', 'command to execute')
     .allowUnknownOption()
-    .option('-c, --config <path>', 'custom config path')
-    .option('-o, --outputDir <dir>', 'output dir for reports')
-    .option('-r, --reports <name[,name]>', 'coverage reports to use')
+    .option('-c, --config <path>', 'custom config file path')
+    .option('--logging <logging>', 'off, error, info, debug')
+
     .option('-n, --name <name>', 'report name for title')
+    .option('-r, --reports <name[,name]>', 'coverage reports to use')
+
+    .option('-o, --outputDir <dir>', 'output dir for reports')
     .option('-i, --inputDir <dir>', 'input dir for merging raw files')
 
     .option('--entryFilter <pattern>', 'entry url filter')
@@ -243,8 +196,6 @@ program
 
     .option('--lcov', 'generate lcov.info file')
 
-    .option('--logging <logging>', 'off, error, info, debug')
-
     .action((_command, cliOptions) => {
         const command = program.args.join(' ');
         executeCommand(command, cliOptions);

package/lib/converter/ast.js

@@ -188,7 +188,9 @@ const getJsAstInfo = (item, coverageList) => {
         }
 
         // runtime code should be parsed successful
-        Util.logInfo(`failed to parse source file: ${item.sourcePath} ${err.message}`);
+        Util.logInfo(`Unparsable source: ${item.sourcePath} ${err.message}`);
+
+        // it could be jsx even it is `.js`
 
         // https://github.com/acornjs/acorn/tree/master/acorn-loose
         // It is recommended to always try a parse with the regular acorn parser first,

package/lib/converter/converter.js

@@ -369,7 +369,8 @@ const addJsBytesCoverage = (state, range) => {
     // add bytes range
     const byte = {
         start: startOffset,
-        end: endOffset,
+        // the end could be > source.length
+        end: Math.min(endOffset, state.maxContentLength),
         count
     };
     // for debug
@@ -982,6 +983,7 @@ const initOriginalList = (state, originalDecodedMap, options) => {
         }
 
         const locator = new Locator(sourceContent);
+        const maxContentLength = sourceContent.length;
 
         const decodedMappings = getOriginalDecodedMappings(originalDecodedMap, sourceIndex, locator);
 
@@ -997,6 +999,7 @@ const initOriginalList = (state, originalDecodedMap, options) => {
             source: sourceContent,
             sourcePath,
             locator,
+            maxContentLength,
             decodedMappings,
             // coverage info
             bytes: [],
@@ -1411,6 +1414,7 @@ const convertV8List = (v8list, options) => {
 
         // source mapping
         const locator = new Locator(source);
+        const maxContentLength = source.length;
 
         // ============================
         // move sourceMap
@@ -1453,6 +1457,7 @@ const convertV8List = (v8list, options) => {
             sourcePath,
             sourceMap,
             locator,
+            maxContentLength,
             decodedMappings: [],
             // coverage info
             bytes: [],

package/lib/default/options.js

@@ -3,11 +3,8 @@ module.exports = {
     // {string} logging levels: off, error, info, debug
     logging: 'info',
 
-    // {string} output dir
-    outputDir: './coverage-reports',
-
-    // {string|string[]} input raw dir(s)
-    inputDir: null,
+    // {string} Report name. Defaults to "Coverage Report".
+    name: 'Coverage Report',
 
     // {string} v8 or html for istanbul by default
     // {array} multiple reports with options
@@ -21,17 +18,11 @@ module.exports = {
     // ],
     reports: '',
 
-    // {string} Report name. Defaults to "Coverage Report".
-    name: 'Coverage Report',
-
-    // (V8 only) {string} Output [sub dir/]filename. Defaults to "index.html"
-    outputFile: 'index.html',
-
-    // (V8 only) {boolean} Inline all scripts to the single HTML file. Defaults to false.
-    inline: false,
+    // {string} output dir
+    outputDir: './coverage-reports',
 
-    // (V8 only) {string} Assets path if not inline. Defaults to "./assets"
-    assetsPath: './assets',
+    // {string|string[]} input raw dir(s)
+    inputDir: null,
 
     // (V8 only) {function} A filter function to execute for each element in the V8 list.
     // entryFilter: (entry) => {
@@ -46,6 +37,24 @@ module.exports = {
     // sourceFilter: (sourcePath) => sourcePath.search(/src\/.+/) !== -1,
     sourceFilter: null,
 
+    // {function} Source path handler.
+    // sourcePath: (filePath) => `wwwroot/${filePath}`,
+    sourcePath: null,
+
+    // (V8 only) {string} Output [sub dir/]filename. Defaults to "index.html"
+    outputFile: 'index.html',
+
+    // (V8 only) {boolean} Inline all scripts to the single HTML file. Defaults to false.
+    inline: false,
+
+    // (V8 only) {string} Assets path if not inline. Defaults to "./assets"
+    assetsPath: './assets',
+
+    // (Istanbul only) defaultSummarizer, sourceFinder
+
+    // {boolean} Generate lcov.info file, same as lcovonly report. Defaults to false.
+    lcov: false,
+
     // options for adding empty coverage for all files
     // all: {
     //     dir: ['src'],
@@ -56,15 +65,6 @@ module.exports = {
     // (V8 only) {boolean} Enable/Disable ignoring uncovered codes with the special comments: v8 ignore next/next N/start/stop
     v8Ignore: true,
 
-    // (Istanbul only) defaultSummarizer, sourceFinder
-
-    // {boolean} Generate lcov.info file, same as lcovonly report. Defaults to false.
-    lcov: false,
-
-    // {function} Source path handler.
-    // sourcePath: (filePath) => `wwwroot/${filePath}`,
-    sourcePath: null,
-
     // {string|function} Specify the report path, especially when there are multiple reports. Defaults to outputDir/index.html.
     reportPath: null,
 
@@ -78,6 +78,10 @@ module.exports = {
     // {boolean} Indicates whether to clean previous cache in output dir before generating report. Defaults to false.
     cleanCache: false,
 
+    // {function} onEntry hook
+    // onEntry: async (entry) => {}
+    onEntry: null,
+
     // {function} onEnd hook
     // onEnd: async (reportData) => {}
     onEnd: null

package/lib/generate.js

@@ -21,20 +21,16 @@ const { getGroupedRows } = require('./utils/snapshot.js');
 // maybe v8 or to istanbul reports
 const generateV8ListReports = async (v8list, coverageData, fileSources, options) => {
 
-    let istanbulCoverageResults;
+    let istanbulReportPath;
     // v8 to istanbul reports
     if (options.reportGroup.istanbul) {
-        istanbulCoverageResults = await saveIstanbulReports(coverageData, fileSources, options);
+        const istanbulCoverageResults = await saveIstanbulReports(coverageData, fileSources, options);
+        istanbulReportPath = istanbulCoverageResults.reportPath;
     }
 
     // v8 reports and v8 coverage results
     // could be no v8 or v8-json, but requires v8 coverage results
-    const v8CoverageResults = await saveV8Report(v8list, options);
-
-    // fix reportPath
-    if (!v8CoverageResults.reportPath && istanbulCoverageResults) {
-        v8CoverageResults.reportPath = istanbulCoverageResults.reportPath;
-    }
+    const v8CoverageResults = await saveV8Report(v8list, options, istanbulReportPath);
 
     return v8CoverageResults;
 };
@@ -292,12 +288,15 @@ const handleConsoleDetailsReport = (reportData, reportOptions, options) => {
     } = reportData;
 
     if (name) {
-        EC.logCyan(name);
+        Util.logInfo(EC.cyan(name));
     }
 
     const metrics = Util.getMetrics(cdOptions.metrics, type);
     const rows = getDetailsRows(files, metrics, cdOptions);
     const summaryRow = getRowData('Summary', summary, metrics);
+    if (summaryRow.nameStatus) {
+        summaryRow.name = Util.getColorStrByStatus(summaryRow.name, summaryRow.nameStatus);
+    }
     // no rows if skipped all by skipPercent
     if (rows.length) {
         rows.push({
@@ -343,7 +342,7 @@ const handleConsoleSummaryReport = (reportData, reportOptions, options) => {
     } = reportData;
 
     if (name) {
-        EC.logCyan(name);
+        Util.logInfo(EC.cyan(name));
     }
 
     const metrics = Util.getMetrics(csOptions.metrics, type);