mongoose 7.8.9 → 7.8.11

package/lib/document.js

@@ -60,6 +60,7 @@ let MongooseArray;
 let Embedded;
 
 const specialProperties = utils.specialProperties;
+const hasOwnProperty = utils.object.hasOwnProperty;
 
 const VERSION_INC = 2;
 
@@ -1880,7 +1881,9 @@ Document.prototype.get = function(path, type, options) {
 
   // Fast path if we know we're just accessing top-level path on the document:
   // just get the schema path, avoid `$__path()` because that does string manipulation
-  let schema = noDottedPath ? this.$__schema.paths[path] : this.$__path(path);
+  let schema = noDottedPath ?
+    hasOwnProperty(this.$__schema.paths, path) ? this.$__schema.paths[path] : undefined :
+    this.$__path(path);
   if (schema == null) {
     schema = this.$__schema.virtualpath(path);
 
@@ -1890,7 +1893,7 @@ Document.prototype.get = function(path, type, options) {
   }
 
   if (noDottedPath) {
-    let obj = this._doc[path];
+    let obj = hasOwnProperty(this._doc, path) ? this._doc[path] : undefined;
     if (adhoc) {
       obj = adhoc.cast(obj);
     }
@@ -1917,6 +1920,10 @@ Document.prototype.get = function(path, type, options) {
   }
 
   for (let i = 0, l = pieces.length; i < l; i++) {
+    if (specialProperties.has(pieces[i])) {
+      return undefined;
+    }
+
     if (obj && obj._doc) {
       obj = obj._doc;
     }
@@ -1938,7 +1945,7 @@ Document.prototype.get = function(path, type, options) {
 
   if (schema != null && options.getters !== false) {
     obj = schema.applyGetters(obj, this);
-  } else if (this.$__schema.nested[path] && options.virtuals) {
+  } else if (hasOwnProperty(this.$__schema.nested, path) && options.virtuals) {
     // Might need to apply virtuals if this is a nested path
     return applyVirtuals(this, clone(obj) || {}, { path: path });
   }

package/lib/schema/bigint.js

@@ -69,7 +69,7 @@ SchemaBigInt.setters = [];
  * #### Example:
  *
  *     // Convert bigints to numbers
- *     mongoose.Schema.BigInt.get(v => v == null ? v : Number(v));
+ *     mongoose.Schema.Types.BigInt.get(v => typeof v === 'bigint' ? Number(v) : v);
  *
  * @param {Function} getter
  * @return {this}

package/lib/schema/buffer.js

@@ -77,11 +77,11 @@ SchemaBuffer.setters = [];
  *
  * #### Example:
  *
- *     // Always convert to string when getting an ObjectId
- *     mongoose.Schema.Types.Buffer.get(v => v.toString('hex'));
+ *     // Always convert to string when getting a buffer
+ *     mongoose.Schema.Types.Buffer.get(v => Buffer.isBuffer(v) ? v.toString('hex') : v);
  *
- *     const Model = mongoose.model('Test', new Schema({ buf: Buffer } }));
- *     typeof (new Model({ buf: Buffer.fromString('hello') }).buf); // 'string'
+ *     const Model = mongoose.model('Test', new Schema({ buf: Buffer }));
+ *     typeof (new Model({ buf: Buffer.from('hello') }).buf); // 'string'
  *
  * @param {Function} getter
  * @return {this}

package/lib/schema/date.js

@@ -78,7 +78,7 @@ SchemaDate.setters = [];
  * #### Example:
  *
  *     // Always convert Dates to string
- *     mongoose.Date.get(v => v.toString());
+ *     mongoose.Date.get(v => v instanceof Date ? v.toString() : v);
  *
  *     const Model = mongoose.model('Test', new Schema({ date: { type: Date, default: () => new Date() } }));
  *     typeof (new Model({}).date); // 'string'

package/lib/schema/decimal128.js

@@ -73,7 +73,7 @@ Decimal128.setters = [];
  * #### Example:
  *
  *     // Automatically convert Decimal128s to Numbers
- *     mongoose.Schema.Decimal128.get(v => v == null ? v : Number(v));
+ *     mongoose.Schema.Types.Decimal128.get(v => v instanceof mongoose.Types.Decimal128 ? Number(v) : v);
  *
  * @param {Function} getter
  * @return {this}

package/lib/schema/number.js

@@ -32,7 +32,7 @@ function SchemaNumber(key, options) {
  * #### Example:
  *
  *     // Make all numbers round down
- *     mongoose.Number.get(function(v) { return Math.floor(v); });
+ *     mongoose.Number.get(function(v) { return typeof v === 'number' ? Math.floor(v) : v; });
  *
  *     const Model = mongoose.model('Test', new Schema({ test: Number }));
  *     new Model({ test: 3.14 }).test; // 3

package/lib/schema/objectid.js

@@ -58,8 +58,9 @@ ObjectId.prototype.OptionsConstructor = SchemaObjectIdOptions;
  *
  * #### Example:
  *
- *     // Always convert to string when getting an ObjectId
- *     mongoose.ObjectId.get(v => v.toString());
+ *     // Convert actual ObjectId values to strings when getting an ObjectId. Check for
+ *     // instanceof ObjectId first so null/undefined values and populated documents are left as-is.
+ *     mongoose.ObjectId.get(v => v instanceof mongoose.Types.ObjectId ? v.toString() : v);
  *
  *     const Model = mongoose.model('Test', new Schema({}));
  *     typeof (new Model({})._id); // 'string'

package/lib/schema/string.js

@@ -107,8 +107,9 @@ SchemaString._defaultCaster = v => {
  *
  * #### Example:
  *
- *     // Make all numbers round down
- *     mongoose.Schema.String.get(v => v.toLowerCase());
+ *     // Make all strings lowercase. Check for string type before calling `toLowerCase()`
+ *     // to account for null/undefined values as well as populated docs.
+ *     mongoose.Schema.Types.String.get(v => typeof v === 'string' ? v.toLowerCase() : v);
  *
  *     const Model = mongoose.model('Test', new Schema({ test: String }));
  *     new Model({ test: 'FOO' }).test; // 'foo'

package/lib/schema.js

@@ -996,7 +996,7 @@ reserved.collection = 1;
 
 Schema.prototype.path = function(path, obj) {
   if (obj === undefined) {
-    if (this.paths[path] != null) {
+    if (Object.prototype.hasOwnProperty.call(this.paths, path)) {
       return this.paths[path];
     }
     // Convert to '.$' to check subpaths re: gh-6405
@@ -1024,9 +1024,15 @@ Schema.prototype.path = function(path, obj) {
       : undefined;
   }
 
+  const subpaths = path.indexOf('.') === -1 ? [path] : path.split('.');
+  const last = subpaths.pop();
+  if (utils.specialProperties.has(last)) {
+    throw new Error('Cannot set special property `' + last + '` on a schema');
+  }
+
   // some path names conflict with document methods
-  const firstPieceOfPath = path.split('.')[0];
-  if (reserved[firstPieceOfPath] && !this.options.suppressReservedKeysWarning) {
+  const firstPieceOfPath = subpaths.length === 0 ? last : subpaths[0];
+  if (Object.prototype.hasOwnProperty.call(reserved, firstPieceOfPath) && !this.options.suppressReservedKeysWarning) {
     const errorMessage = `\`${firstPieceOfPath}\` is a reserved schema pathname and may break some functionality. ` +
       'You are allowed to use it, but use at your own risk. ' +
       'To disable this warning pass `suppressReservedKeysWarning` as a schema option.';
@@ -1039,8 +1045,6 @@ Schema.prototype.path = function(path, obj) {
   }
 
   // update the tree
-  const subpaths = path.split(/\./);
-  const last = subpaths.pop();
   let branch = this.tree;
   let fullPath = '';
 
@@ -2702,7 +2706,7 @@ Schema.prototype._getPathType = function(path) {
           };
         }
         return { schema: foundschema, pathType: 'real' };
-      } else if (p === parts.length && schema.nested[trypath]) {
+      } else if (p === parts.length && Object.prototype.hasOwnProperty.call(schema.nested, trypath)) {
         return { schema: schema, pathType: 'nested' };
       }
     }

package/lib/utils.js

@@ -274,8 +274,8 @@ exports.merge = function merge(to, from, options, path) {
         // base schema has a given path as a single nested but discriminator schema
         // has the path as a document array, or vice versa (gh-9534)
         if (options.isDiscriminatorSchemaMerge &&
-            (from[key].$isSingleNested && to[key].$isMongooseDocumentArray) ||
-            (from[key].$isMongooseDocumentArray && to[key].$isSingleNested)) {
+            ((from[key].$isSingleNested && to[key].$isMongooseDocumentArray) ||
+            (from[key].$isMongooseDocumentArray && to[key].$isSingleNested))) {
           continue;
         } else if (from[key].instanceOfSchema) {
           if (to[key].instanceOfSchema) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "mongoose",
   "description": "Mongoose MongoDB ODM",
-  "version": "7.8.9",
+  "version": "7.8.11",
   "author": "Guillermo Rauch <guillermo@learnboost.com>",
   "keywords": [
     "mongodb",

package/.claude/settings.local.json

@@ -1,7 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "mcp__acp__Bash"
-    ]
-  }
-}

package/startmdb.mjs

@@ -1,19 +0,0 @@
-import { MongoMemoryReplSet } from 'mongodb-memory-server';
-
-const replSet = await MongoMemoryReplSet.create({
-  binary: {
-    systemBinary: '/home/v/libs/mongodb-linux-x86_64-enterprise-ubuntu2404-8.2.0/bin/mongod'
-  },
-  instanceOpts: [
-    {
-      port: 27017
-    }
-  ],
-  replSet: {
-    storageEngine: 'inMemory',
-    count: 1
-  }
-});
-
-const uri = replSet.getUri();
-console.log(uri);